From: Jackie Liu liuyun01@kylinos.cn
When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit.
Fixes: f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB") Reported-by: k2ci kernel-bot@kylinos.cn Signed-off-by: Jackie Liu liuyun01@kylinos.cn --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 7ff89690a976..cd129d96e649 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - depends on FB + depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA
On Mon, 16 Aug 2021, Jackie Liu liu.yun@linux.dev wrote:
From: Jackie Liu liuyun01@kylinos.cn
When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit.
Fixes: f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB") Reported-by: k2ci kernel-bot@kylinos.cn Signed-off-by: Jackie Liu liuyun01@kylinos.cn
Why do you send this while the discussion is still ongoing?
Now this *requires* FB=y even if it *could* be FB=m when DRM_KMS_HELPER=m.
BR, Jani.
drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 7ff89690a976..cd129d96e649 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM
- depends on FB
- depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA
在 2021/8/16 下午4:58, Jani Nikula 写道:
On Mon, 16 Aug 2021, Jackie Liu liu.yun@linux.dev wrote:
From: Jackie Liu liuyun01@kylinos.cn
When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit.
Fixes: f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB") Reported-by: k2ci kernel-bot@kylinos.cn Signed-off-by: Jackie Liu liuyun01@kylinos.cn
Why do you send this while the discussion is still ongoing?
Now this *requires* FB=y even if it *could* be FB=m when DRM_KMS_HELPER=m.
Yes, You are right.
BR, Jackie
BR, Jani.
drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 7ff89690a976..cd129d96e649 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM
- depends on FB
- depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA
dri-devel@lists.freedesktop.org
-
Jackie Liu -
Jani Nikula