There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make the generated .config a bit ugly.
# ARM devices # # end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
# # Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
Signed-off-by: Qian Cai cai@lca.pw --- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 0919f1f159a4..3304b41f5611 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM_RCAR_DU
Hi Qian,
Thank you for the patch.
On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
s/DRM=n/DRM_RCAR_DU=n/ here.
the generated .config a bit ugly.
# ARM devices # # end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
# # Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
Signed-off-by: Qian Cai cai@lca.pw
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 0919f1f159a4..3304b41f5611 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64
- depends on DRM_RCAR_DU
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
s/DRM=n/DRM_RCAR_DU=n/ here.
the generated .config a bit ugly.
# ARM devices # # end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
# # Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
Signed-off-by: Qian Cai cai@lca.pw
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 0919f1f159a4..3304b41f5611 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64
- depends on DRM_RCAR_DU
On Jun 7, 2020, at 11:16 PM, Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
Yes, I am fine with those.
Hi Qian, Laurent,
On 08/06/2020 05:30, Qian Cai wrote:
On Jun 7, 2020, at 11:16 PM, Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
Yes, I am fine with those.
With the fixups,
Reviewed-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
-- Kieran
On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote:
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
Laurent, this patch is still not in the latest linux-next. Can you take a look?
On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
s/DRM=n/DRM_RCAR_DU=n/ here.
the generated .config a bit ugly.
# ARM devices # # end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
# # Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
Signed-off-by: Qian Cai cai@lca.pw
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 0919f1f159a4..3304b41f5611 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64
- depends on DRM_RCAR_DU
-- Regards,
Laurent Pinchart
Hi Qian,
On Fri, Aug 21, 2020 at 09:20:37PM -0400, Qian Cai wrote:
On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote:
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
Laurent, this patch is still not in the latest linux-next. Can you take a look?
Sorry for the delay. It will be included in the pull request I send this week.
On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
s/DRM=n/DRM_RCAR_DU=n/ here.
the generated .config a bit ugly.
# ARM devices # # end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
# # Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
Signed-off-by: Qian Cai cai@lca.pw
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index 0919f1f159a4..3304b41f5611 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64
- depends on DRM_RCAR_DU
dri-devel@lists.freedesktop.org
-
Kieran Bingham -
Laurent Pinchart -
Qian Cai