[ As I am not subscribed to both MLs and lazy to pick up all involved people ]
Hi Chris,
The original patch had also this part (see the revert in [1]): ... +#include <linux/security.h> ...
Your new patch in [2] is missing it or is it not required?
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=... [2] https://patchwork.kernel.org/patch/555501/
* Sedat Dilek (sedat.dilek@googlemail.com) wrote:
[ As I am not subscribed to both MLs and lazy to pick up all involved people ]
Hi Chris,
The original patch had also this part (see the revert in [1]): ... +#include <linux/security.h> ...
Your new patch in [2] is missing it or is it not required?
It was just a patch on top of the bad commit (47970b1b), the #include is required.
thanks, -chris
On Mon, Feb 14, 2011 at 5:20 PM, Chris Wright chrisw@sous-sol.org wrote:
- Sedat Dilek (sedat.dilek@googlemail.com) wrote:
[ As I am not subscribed to both MLs and lazy to pick up all involved people ]
Hi Chris,
The original patch had also this part (see the revert in [1]): ... +#include <linux/security.h> ...
Your new patch in [2] is missing it or is it not required?
It was just a patch on top of the bad commit (47970b1b), the #include is required.
thanks, -chris
OK, now I see. Might be good to push a v2 as the initial patch was reverted in the meantime? The explanations of the fixup patch were helpful (to me) and should be included.
- Sedat -
* Sedat Dilek (sedat.dilek@googlemail.com) wrote:
On Mon, Feb 14, 2011 at 5:20 PM, Chris Wright chrisw@sous-sol.org wrote:
- Sedat Dilek (sedat.dilek@googlemail.com) wrote:
[ As I am not subscribed to both MLs and lazy to pick up all involved people ]
Hi Chris,
The original patch had also this part (see the revert in [1]): ... +#include <linux/security.h> ...
Your new patch in [2] is missing it or is it not required?
It was just a patch on top of the bad commit (47970b1b), the #include is required.
thanks, -chris
OK, now I see. Might be good to push a v2 as the initial patch was reverted in the meantime? The explanations of the fixup patch were helpful (to me) and should be included.
Yeah, I'll send a new patch to James.
dri-devel@lists.freedesktop.org
-
Chris Wright -
Sedat Dilek