On 5/21/22 21:59, Tom Rix wrote:

cppcheck reports [drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.

The value parameter 'transp' is not used, so setting it can be removed.

Signed-off-by: Tom Rix trix@redhat.com

applied to the fbdev tree. Thanks! Helge

---

drivers/video/fbdev/xen-fbfront.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 3bed357a9870..4d2694d904aa 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, red = CNVT_TOHW(red, info->var.red.length); green = CNVT_TOHW(green, info->var.green.length); blue = CNVT_TOHW(blue, info->var.blue.length);

• transp = CNVT_TOHW(transp, info->var.transp.length);

#undef CNVT_TOHW

v = (red << info->var.red.offset) |