On 2021-07-08 05:28, Dmitry Baryshkov wrote:

We are preparing to support two independent DSI hosts in the DSI/DPU code. To remove possible confusion (as both configurations can be referenced as dual DSI) let's rename old "dual DSI" (two DSI hosts driving single device, with clocks being locked) to "bonded DSI".

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

Thanks for renaming this, Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org

---

drivers/gpu/drm/msm/dsi/dsi.h | 8 ++-- drivers/gpu/drm/msm/dsi/dsi_cfg.h | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 30 ++++++------ drivers/gpu/drm/msm/dsi/dsi_manager.c | 69 +++++++++++++-------------- 4 files changed, 54 insertions(+), 55 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h index 9b8e9b07eced..856a532850c0 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.h +++ b/drivers/gpu/drm/msm/dsi/dsi.h @@ -109,7 +109,7 @@ int msm_dsi_host_enable(struct mipi_dsi_host *host); int msm_dsi_host_disable(struct mipi_dsi_host *host); int msm_dsi_host_power_on(struct mipi_dsi_host *host, struct msm_dsi_phy_shared_timings *phy_shared_timings,

• 	bool is_dual_dsi);
  

• 	bool is_bonded_dsi);
  

int msm_dsi_host_power_off(struct mipi_dsi_host *host); int msm_dsi_host_set_display_mode(struct mipi_dsi_host *host, const struct drm_display_mode *mode); @@ -123,7 +123,7 @@ int msm_dsi_host_set_src_pll(struct mipi_dsi_host *host, void msm_dsi_host_reset_phy(struct mipi_dsi_host *host); void msm_dsi_host_get_phy_clk_req(struct mipi_dsi_host *host, struct msm_dsi_phy_clk_request *clk_req,

• bool is_dual_dsi);

• bool is_bonded_dsi);

void msm_dsi_host_destroy(struct mipi_dsi_host *host); int msm_dsi_host_modeset_init(struct mipi_dsi_host *host, struct drm_device *dev); @@ -145,8 +145,8 @@ int dsi_dma_base_get_6g(struct msm_dsi_host *msm_host, uint64_t *iova); int dsi_dma_base_get_v2(struct msm_dsi_host *msm_host, uint64_t *iova); int dsi_clk_init_v2(struct msm_dsi_host *msm_host); int dsi_clk_init_6g_v2(struct msm_dsi_host *msm_host); -int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_dual_dsi); -int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_dual_dsi); +int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_bonded_dsi); +int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_bonded_dsi); void msm_dsi_host_snapshot(struct msm_disp_state *disp_state, struct mipi_dsi_host *host); /* dsi phy */ struct msm_dsi_phy; diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h index ade9b609c7d9..2bce00d5a9fc 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h @@ -47,7 +47,7 @@ struct msm_dsi_host_cfg_ops { void* (*tx_buf_get)(struct msm_dsi_host *msm_host); void (*tx_buf_put)(struct msm_dsi_host *msm_host); int (*dma_base_get)(struct msm_dsi_host *msm_host, uint64_t *iova);

• int (*calc_clk_rate)(struct msm_dsi_host *msm_host, bool

is_dual_dsi);

• int (*calc_clk_rate)(struct msm_dsi_host *msm_host, bool

is_bonded_dsi); };

struct msm_dsi_cfg_handler { diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index ed504fe5074f..eb988faddbbf 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -679,7 +679,7 @@ void dsi_link_clk_disable_v2(struct msm_dsi_host *msm_host) clk_disable_unprepare(msm_host->byte_clk); }

-static u32 dsi_get_pclk_rate(struct msm_dsi_host *msm_host, bool is_dual_dsi) +static u32 dsi_get_pclk_rate(struct msm_dsi_host *msm_host, bool is_bonded_dsi) { struct drm_display_mode *mode = msm_host->mode; u32 pclk_rate; @@ -692,17 +692,17 @@ static u32 dsi_get_pclk_rate(struct msm_dsi_host *msm_host, bool is_dual_dsi) * the clock rates have to be split between the two dsi controllers. * Adjust the byte and pixel clock rates for each dsi host accordingly. */

• if (is_dual_dsi)

• if (is_bonded_dsi) pclk_rate /= 2;

  return pclk_rate;

}

-static void dsi_calc_pclk(struct msm_dsi_host *msm_host, bool is_dual_dsi) +static void dsi_calc_pclk(struct msm_dsi_host *msm_host, bool is_bonded_dsi) { u8 lanes = msm_host->lanes; u32 bpp = dsi_get_bpp(msm_host->format);

• u32 pclk_rate = dsi_get_pclk_rate(msm_host, is_dual_dsi);

• u32 pclk_rate = dsi_get_pclk_rate(msm_host, is_bonded_dsi); u64 pclk_bpp = (u64)pclk_rate * bpp;

  if (lanes == 0) {

@@ -720,28 +720,28 @@ static void dsi_calc_pclk(struct msm_dsi_host *msm_host, bool is_dual_dsi)

}

-int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_dual_dsi) +int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_bonded_dsi) { if (!msm_host->mode) { pr_err("%s: mode not set\n", __func__); return -EINVAL; }

• dsi_calc_pclk(msm_host, is_dual_dsi);

• dsi_calc_pclk(msm_host, is_bonded_dsi); msm_host->esc_clk_rate = clk_get_rate(msm_host->esc_clk); return 0;

}

-int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_dual_dsi) +int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_bonded_dsi) { u32 bpp = dsi_get_bpp(msm_host->format); u64 pclk_bpp; unsigned int esc_mhz, esc_div; unsigned long byte_mhz;

• dsi_calc_pclk(msm_host, is_dual_dsi);

• dsi_calc_pclk(msm_host, is_bonded_dsi);

• pclk_bpp = (u64)dsi_get_pclk_rate(msm_host, is_dual_dsi) * bpp;

• pclk_bpp = (u64)dsi_get_pclk_rate(msm_host, is_bonded_dsi) * bpp; do_div(pclk_bpp, 8); msm_host->src_clk_rate = pclk_bpp;

@@ -938,7 +938,7 @@ static void dsi_ctrl_config(struct msm_dsi_host *msm_host, bool enable, dsi_write(msm_host, REG_DSI_CTRL, data); }

-static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_dual_dsi) +static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) { struct drm_display_mode *mode = msm_host->mode; u32 hs_start = 0, vs_start = 0; /* take sync start as 0 */ @@ -962,7 +962,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_dual_dsi) * timings have to be split between the two dsi controllers. * Adjust the DSI host timing values accordingly. */

• if (is_dual_dsi) {

• if (is_bonded_dsi) { h_total /= 2; hs_end /= 2; ha_start /= 2;

@@ -2285,13 +2285,13 @@ void msm_dsi_host_reset_phy(struct mipi_dsi_host *host)

void msm_dsi_host_get_phy_clk_req(struct mipi_dsi_host *host, struct msm_dsi_phy_clk_request *clk_req,

• 	bool is_dual_dsi)
  

• 	bool is_bonded_dsi)
  

{ struct msm_dsi_host *msm_host = to_msm_dsi_host(host); const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd; int ret;

• ret = cfg_hnd->ops->calc_clk_rate(msm_host, is_dual_dsi);

• ret = cfg_hnd->ops->calc_clk_rate(msm_host, is_bonded_dsi); if (ret) { pr_err("%s: unable to calc clk rate, %d\n", __func__, ret); return;

@@ -2354,7 +2354,7 @@ static void msm_dsi_sfpb_config(struct msm_dsi_host *msm_host, bool enable)

int msm_dsi_host_power_on(struct mipi_dsi_host *host, struct msm_dsi_phy_shared_timings *phy_shared_timings,

• 	bool is_dual_dsi)
  

• 	bool is_bonded_dsi)
  

{ struct msm_dsi_host *msm_host = to_msm_dsi_host(host); const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd; @@ -2392,7 +2392,7 @@ int msm_dsi_host_power_on(struct mipi_dsi_host *host, goto fail_disable_clk; }

• dsi_timing_setup(msm_host, is_dual_dsi);

• dsi_timing_setup(msm_host, is_bonded_dsi); dsi_sw_reset(msm_host); dsi_ctrl_config(msm_host, true, phy_shared_timings);

diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 4ebfedc4a9ac..1173663c6d5d 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -21,14 +21,14 @@ struct msm_dsi_manager { struct msm_dsi *dsi[DSI_MAX];

• bool is_dual_dsi;

• bool is_bonded_dsi; bool is_sync_needed; int master_dsi_link_id;

};

static struct msm_dsi_manager msm_dsim_glb;

-#define IS_DUAL_DSI() (msm_dsim_glb.is_dual_dsi) +#define IS_BONDED_DSI() (msm_dsim_glb.is_bonded_dsi) #define IS_SYNC_NEEDED() (msm_dsim_glb.is_sync_needed) #define IS_MASTER_DSI_LINK(id) (msm_dsim_glb.master_dsi_link_id == id)

@@ -42,18 +42,17 @@ static inline struct msm_dsi *dsi_mgr_get_other_dsi(int id) return msm_dsim_glb.dsi[(id + 1) % DSI_MAX]; }

-static int dsi_mgr_parse_dual_dsi(struct device_node *np, int id) +static int dsi_mgr_parse_of(struct device_node *np, int id) { struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;

/* We assume 2 dsi nodes have the same information of dual-dsi and * sync-mode, and only one node specifies master in case of dual mode. */

• if (!msm_dsim->is_dual_dsi)

• msm_dsim->is_dual_dsi = of_property_read_bool(
  

• 				np, "qcom,dual-dsi-mode");
  

• if (!msm_dsim->is_bonded_dsi)

• msm_dsim->is_bonded_dsi = of_property_read_bool(np, 
  

"qcom,dual-dsi-mode");

• if (msm_dsim->is_dual_dsi) {

• if (msm_dsim->is_bonded_dsi) { if (of_property_read_bool(np, "qcom,master-dsi")) msm_dsim->master_dsi_link_id = id; if (!msm_dsim->is_sync_needed)

@@ -72,7 +71,7 @@ static int dsi_mgr_setup_components(int id) struct msm_dsi *clk_slave_dsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE); int ret;

• if (!IS_DUAL_DSI()) {

• if (!IS_BONDED_DSI()) { ret = msm_dsi_host_register(msm_dsi->host, true); if (ret) return ret;

@@ -119,9 +118,9 @@ static int enable_phy(struct msm_dsi *msm_dsi, { struct msm_dsi_phy_clk_request clk_req; int ret;

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI();

• msm_dsi_host_get_phy_clk_req(msm_dsi->host, &clk_req, is_dual_dsi);

• msm_dsi_host_get_phy_clk_req(msm_dsi->host, &clk_req, is_bonded_dsi);

  ret = msm_dsi_phy_enable(msm_dsi->phy, &clk_req); msm_dsi_phy_get_shared_timings(msm_dsi->phy, shared_timings);

@@ -143,7 +142,7 @@ dsi_mgr_phy_enable(int id, * will silently reset those PHY1 registers. Therefore we need to reset * and enable both PHYs before any PLL clock operation. */

• if (IS_DUAL_DSI() && mdsi && sdsi) {

• if (IS_BONDED_DSI() && mdsi && sdsi) { if (!mdsi->phy_enabled && !sdsi->phy_enabled) { msm_dsi_host_reset_phy(mdsi->host); msm_dsi_host_reset_phy(sdsi->host);

@@ -182,7 +181,7 @@ static void dsi_mgr_phy_disable(int id) * first controller only when the second controller is disabled. */ msm_dsi->phy_enabled = false;

• if (IS_DUAL_DSI() && mdsi && sdsi) {

• if (IS_BONDED_DSI() && mdsi && sdsi) { if (!mdsi->phy_enabled && !sdsi->phy_enabled) { msm_dsi_phy_disable(sdsi->phy); msm_dsi_phy_disable(mdsi->phy);

@@ -244,7 +243,7 @@ static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) struct msm_dsi *master_dsi, *slave_dsi; struct drm_panel *panel;

• if (IS_DUAL_DSI() && !IS_MASTER_DSI_LINK(id)) {

• if (IS_BONDED_DSI() && !IS_MASTER_DSI_LINK(id)) { master_dsi = other_dsi; slave_dsi = msm_dsi; } else {

@@ -264,7 +263,7 @@ static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) return PTR_ERR(panel); }

• if (!panel || !IS_DUAL_DSI())

• if (!panel || !IS_BONDED_DSI()) goto out;

  drm_object_attach_property(&conn->base,

@@ -366,7 +365,7 @@ static void dsi_mgr_bridge_pre_enable(struct drm_bridge *bridge) struct mipi_dsi_host *host = msm_dsi->host; struct drm_panel *panel = msm_dsi->panel; struct msm_dsi_phy_shared_timings phy_shared_timings[DSI_MAX];

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI(); int ret;

  DBG("id=%d", id);

@@ -374,22 +373,22 @@ static void dsi_mgr_bridge_pre_enable(struct drm_bridge *bridge) return;

/* Do nothing with the host if it is slave-DSI in case of dual DSI */

• if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))

• if (is_bonded_dsi && !IS_MASTER_DSI_LINK(id)) return;

  ret = dsi_mgr_phy_enable(id, phy_shared_timings); if (ret) goto phy_en_fail;

• ret = msm_dsi_host_power_on(host, &phy_shared_timings[id],

is_dual_dsi);

• ret = msm_dsi_host_power_on(host, &phy_shared_timings[id],

is_bonded_dsi); if (ret) { pr_err("%s: power on host %d failed, %d\n", __func__, id, ret); goto host_on_fail; }

• if (is_dual_dsi && msm_dsi1) {

• if (is_bonded_dsi && msm_dsi1) { ret = msm_dsi_host_power_on(msm_dsi1->host,

• 		&phy_shared_timings[DSI_1], is_dual_dsi);
  

• 		&phy_shared_timings[DSI_1], is_bonded_dsi);
  

  if (ret) { pr_err("%s: power on host1 failed, %d\n", __func__, ret);

@@ -415,7 +414,7 @@ static void dsi_mgr_bridge_pre_enable(struct drm_bridge *bridge) goto host_en_fail; }

• if (is_dual_dsi && msm_dsi1) {

• if (is_bonded_dsi && msm_dsi1) { ret = msm_dsi_host_enable(msm_dsi1->host); if (ret) { pr_err("%s: enable host1 failed, %d\n", __func__, ret);

@@ -431,7 +430,7 @@ static void dsi_mgr_bridge_pre_enable(struct drm_bridge *bridge) if (panel) drm_panel_unprepare(panel); panel_prep_fail:

• if (is_dual_dsi && msm_dsi1)

• if (is_bonded_dsi && msm_dsi1) msm_dsi_host_power_off(msm_dsi1->host);

host1_on_fail: msm_dsi_host_power_off(host); @@ -446,7 +445,7 @@ static void dsi_mgr_bridge_enable(struct drm_bridge *bridge) int id = dsi_mgr_bridge_get_id(bridge); struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); struct drm_panel *panel = msm_dsi->panel;

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI(); int ret;

  DBG("id=%d", id);

@@ -454,7 +453,7 @@ static void dsi_mgr_bridge_enable(struct drm_bridge *bridge) return;

/* Do nothing with the host if it is slave-DSI in case of dual DSI */

• if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))

• if (is_bonded_dsi && !IS_MASTER_DSI_LINK(id)) return;

  if (panel) {

@@ -471,7 +470,7 @@ static void dsi_mgr_bridge_disable(struct drm_bridge *bridge) int id = dsi_mgr_bridge_get_id(bridge); struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); struct drm_panel *panel = msm_dsi->panel;

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI(); int ret;

  DBG("id=%d", id);

@@ -479,7 +478,7 @@ static void dsi_mgr_bridge_disable(struct drm_bridge *bridge) return;

/* Do nothing with the host if it is slave-DSI in case of dual DSI */

• if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))

• if (is_bonded_dsi && !IS_MASTER_DSI_LINK(id)) return;

  if (panel) {

@@ -497,7 +496,7 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1); struct mipi_dsi_host *host = msm_dsi->host; struct drm_panel *panel = msm_dsi->panel;

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI(); int ret;

  DBG("id=%d", id);

@@ -510,14 +509,14 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) * It is safe to call dsi_mgr_phy_disable() here because a single PHY * won't be diabled until both PHYs request disable. */

• if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))

• if (is_bonded_dsi && !IS_MASTER_DSI_LINK(id)) goto disable_phy;

  ret = msm_dsi_host_disable(host); if (ret) pr_err("%s: host %d disable failed, %d\n", __func__, id, ret);

• if (is_dual_dsi && msm_dsi1) {

• if (is_bonded_dsi && msm_dsi1) { ret = msm_dsi_host_disable(msm_dsi1->host); if (ret) pr_err("%s: host1 disable failed, %d\n", __func__, ret);

@@ -537,7 +536,7 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) if (ret) pr_err("%s: host %d power off failed,%d\n", __func__, id, ret);

• if (is_dual_dsi && msm_dsi1) {

• if (is_bonded_dsi && msm_dsi1) { ret = msm_dsi_host_power_off(msm_dsi1->host); if (ret) pr_err("%s: host1 power off failed, %d\n",

@@ -556,15 +555,15 @@ static void dsi_mgr_bridge_mode_set(struct drm_bridge *bridge, struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id); struct mipi_dsi_host *host = msm_dsi->host;

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI();

  DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));

• if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))

• if (is_bonded_dsi && !IS_MASTER_DSI_LINK(id)) return;

  msm_dsi_host_set_display_mode(host, adjusted_mode);

• if (is_dual_dsi && other_dsi)

• if (is_bonded_dsi && other_dsi) msm_dsi_host_set_display_mode(other_dsi->host, adjusted_mode);

}

@@ -640,7 +639,7 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id)

bool msm_dsi_manager_validate_current_config(u8 id) {

• bool is_dual_dsi = IS_DUAL_DSI();

• bool is_bonded_dsi = IS_BONDED_DSI();

  /*

  • For dual DSI, we only have one drm panel. For this

@@ -648,7 +647,7 @@ bool msm_dsi_manager_validate_current_config(u8 id) * Skip bridge/connector initialisation if it is * slave-DSI for dual DSI configuration. */

• if (is_dual_dsi && !IS_MASTER_DSI_LINK(id)) {

• if (is_bonded_dsi && !IS_MASTER_DSI_LINK(id)) { DBG("Skip bridge registration for slave DSI->id: %d\n", id); return false; }

@@ -809,7 +808,7 @@ int msm_dsi_manager_register(struct msm_dsi *msm_dsi)

msm_dsim->dsi[id] = msm_dsi;

• ret = dsi_mgr_parse_dual_dsi(msm_dsi->pdev->dev.of_node, id);

• ret = dsi_mgr_parse_of(msm_dsi->pdev->dev.of_node, id); if (ret) { pr_err("%s: failed to parse dual DSI info\n", __func__); goto fail;

On 2021-07-08 05:28, Dmitry Baryshkov wrote:

Add two helper functions to be used by display drivers for setting up encoders.

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org

---

drivers/gpu/drm/msm/dsi/dsi.c | 7 +++++++ drivers/gpu/drm/msm/dsi/dsi_manager.c | 14 ++++++-------- drivers/gpu/drm/msm/msm_drv.h | 12 ++++++++++-- 3 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 75afc12a7b25..5201d7eb0490 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -13,6 +13,13 @@ struct drm_encoder *msm_dsi_get_encoder(struct msm_dsi *msm_dsi) return msm_dsi->encoder; }

+bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi) +{

• unsigned long host_flags =

msm_dsi_host_get_mode_flags(msm_dsi->host);

• return !(host_flags & MIPI_DSI_MODE_VIDEO);

+}

static int dsi_get_phy(struct msm_dsi *msm_dsi) { struct platform_device *pdev = msm_dsi->pdev; diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 1173663c6d5d..a81105633d3c 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -216,12 +216,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge) return dsi_bridge->id; }

-static bool dsi_mgr_is_cmd_mode(struct msm_dsi *msm_dsi) -{

• unsigned long host_flags =

msm_dsi_host_get_mode_flags(msm_dsi->host);

• return !(host_flags & MIPI_DSI_MODE_VIDEO);

-}

void msm_dsi_manager_setup_encoder(int id) { struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); @@ -231,7 +225,7 @@ void msm_dsi_manager_setup_encoder(int id)

if (encoder && kms->funcs->set_encoder_mode) kms->funcs->set_encoder_mode(kms, encoder,

• 			     dsi_mgr_is_cmd_mode(msm_dsi));
  

• 			     msm_dsi_is_cmd_mode(msm_dsi));
  

}

static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) @@ -276,7 +270,7 @@ static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) if (other_dsi && other_dsi->panel && kms->funcs->set_split_display) { kms->funcs->set_split_display(kms, master_dsi->encoder, slave_dsi->encoder,

• 			      dsi_mgr_is_cmd_mode(msm_dsi));
  

• 			      msm_dsi_is_cmd_mode(msm_dsi));
  

  }

out: @@ -839,3 +833,7 @@ void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi) msm_dsim->dsi[msm_dsi->id] = NULL; }

+bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi) +{

• return IS_BONDED_DSI();

+} diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 1a48a709ffb3..e0528dfd965e 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm/msm_drv.h @@ -350,7 +350,8 @@ void __exit msm_dsi_unregister(void); int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev, struct drm_encoder *encoder); void msm_dsi_snapshot(struct msm_disp_state *disp_state, struct msm_dsi *msm_dsi);

+bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi); +bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi); #else static inline void __init msm_dsi_register(void) { @@ -367,7 +368,14 @@ static inline int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, static inline void msm_dsi_snapshot(struct msm_disp_state *disp_state, struct msm_dsi *msm_dsi) { }

+static inline bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi) +{

• return false;

+} +static bool msm_dsi_is_bonded_dsi(struct msm_dsi *msm_dsi) +{

• return false;

+} #endif

#ifdef CONFIG_DRM_MSM_DP

On 2021-07-08 05:28, Dmitry Baryshkov wrote:

Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "bonded DSI" but also "two independent DSI" configurations. In future this would also help adding support for multiple DP connectors.

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 102 +++++++++++++----------- 1 file changed, 57 insertions(+), 45 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index 1d3a4f395e74..8459da36174e 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -471,30 +471,68 @@ static int _dpu_kms_initialize_dsi(struct drm_device *dev, struct dpu_kms *dpu_kms) { struct drm_encoder *encoder = NULL;

• struct msm_display_info info; int i, rc = 0;

  if (!(priv->dsi[0] || priv->dsi[1])) return rc;

• /*TODO: Support two independent DSI connectors */
• encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_DSI);
• if (IS_ERR(encoder)) {

• DPU_ERROR("encoder init failed for dsi display\n");
  

• return PTR_ERR(encoder);
  

• }
• priv->encoders[priv->num_encoders++] = encoder;

• /*

• * We support following confiurations:
  

• * - Single DSI host (dsi0 or dsi1)
  

• * - Two independent DSI hosts
  

• * - Bonded DSI0 and DSI1 hosts
  

• *
  

• *   TODO: Support swapping DSI0 and DSI1 in the bonded setup.
  

• */
  

  for (i = 0; i < ARRAY_SIZE(priv->dsi); i++) { if (!priv->dsi[i]) continue;

• if (!encoder) {
  

• 	encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_DSI);
  

• 	if (IS_ERR(encoder)) {
  

• 		DPU_ERROR("encoder init failed for dsi display\n");
  

• 		return PTR_ERR(encoder);
  

• 	}
  

• 	priv->encoders[priv->num_encoders++] = encoder;
  

• 	memset(&info, 0, sizeof(info));
  

• 	info.intf_type = encoder->encoder_type;
  

• 	info.capabilities = msm_dsi_is_cmd_mode(priv->dsi[i]) ?
  

• 		MSM_DISPLAY_CAP_CMD_MODE :
  

• 		MSM_DISPLAY_CAP_VID_MODE;
  

• }
  

• rc = msm_dsi_modeset_init(priv->dsi[i], dev, encoder); if (rc) { DPU_ERROR("modeset_init failed for dsi[%d], rc = %d\n", i, rc); break; }

• info.h_tile_instance[info.num_of_h_tiles++] = i;
  

• /* Register non-bonded encoder here. If the encoder is bonded,
  

•  * it will be registered later, when both DSI hosts are
  

•  * initialized.
  

•  */
  

• if (!msm_dsi_is_bonded_dsi(priv->dsi[i])) {
  

• 	rc = dpu_encoder_setup(dev, encoder, &info);
  

• 	if (rc)
  

• 		DPU_ERROR("failed to setup DPU encoder %d: rc:%d\n",
  

• 			  encoder->base.id, rc);
  

• 	encoder = NULL;
  

Seems like you are using encoder = NULL as a check to distinguish whether this is bonded mode or not.

• }
  

• }
• /* Register bonded encoder here, when both DSI hosts are initialized

*/

• if (encoder) {

Why cant we replace this with if (msm_dsi_is_bonded_dsi(priv->dsi[i]) and get rid of the encoder = NULL?

• rc = dpu_encoder_setup(dev, encoder, &info);
  

• if (rc)
  

• 	DPU_ERROR("failed to setup DPU encoder %d: rc:%d\n",
  

• 		  encoder->base.id, rc);
  

  }

  return rc;

@@ -505,6 +543,7 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev, struct dpu_kms *dpu_kms) { struct drm_encoder *encoder = NULL;

• struct msm_display_info info; int rc = 0;

  if (!priv->dp)

@@ -516,6 +555,7 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev, return PTR_ERR(encoder); }

• memset(&info, 0, sizeof(info)); rc = msm_dp_modeset_init(priv->dp, dev, encoder); if (rc) { DPU_ERROR("modeset_init failed for DP, rc = %d\n", rc);

@@ -524,6 +564,14 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev, }

priv->encoders[priv->num_encoders++] = encoder;

• info.num_of_h_tiles = 1;
• info.capabilities = MSM_DISPLAY_CAP_VID_MODE;
• info.intf_type = encoder->encoder_type;
• rc = dpu_encoder_setup(dev, encoder, &info);
• if (rc)

• DPU_ERROR("failed to setup DPU encoder %d: rc:%d\n",
  

• 	  encoder->base.id, rc);
  

  return rc;

}

@@ -726,41 +774,6 @@ static void dpu_kms_destroy(struct msm_kms *kms) msm_kms_destroy(&dpu_kms->base); }

-static void _dpu_kms_set_encoder_mode(struct msm_kms *kms,

• 		 struct drm_encoder *encoder,
  

• 		 bool cmd_mode)
  

-{

• struct msm_display_info info;
• struct msm_drm_private *priv = encoder->dev->dev_private;
• int i, rc = 0;
• memset(&info, 0, sizeof(info));
• info.intf_type = encoder->encoder_type;
• info.capabilities = cmd_mode ? MSM_DISPLAY_CAP_CMD_MODE :

• 	MSM_DISPLAY_CAP_VID_MODE;
  

• switch (info.intf_type) {
• case DRM_MODE_ENCODER_DSI:

• /* TODO: No support for DSI swap */
  

• for (i = 0; i < ARRAY_SIZE(priv->dsi); i++) {
  

• 	if (priv->dsi[i]) {
  

• 		info.h_tile_instance[info.num_of_h_tiles] = i;
  

• 		info.num_of_h_tiles++;
  

• 	}
  

• }
  

• break;
  

• case DRM_MODE_ENCODER_TMDS:

• info.num_of_h_tiles = 1;
  

• break;
  

• }
• rc = dpu_encoder_setup(encoder->dev, encoder, &info);
• if (rc)

• DPU_ERROR("failed to setup DPU encoder %d: rc:%d\n",
  

• 	encoder->base.id, rc);
  

-}

static irqreturn_t dpu_irq(struct msm_kms *kms) { struct dpu_kms *dpu_kms = to_dpu_kms(kms); @@ -863,7 +876,6 @@ static const struct msm_kms_funcs kms_funcs = { .get_format = dpu_get_msm_format, .round_pixclk = dpu_kms_round_pixclk, .destroy = dpu_kms_destroy,

• .set_encoder_mode = _dpu_kms_set_encoder_mode, .snapshot = dpu_kms_mdp_snapshot,

#ifdef CONFIG_DEBUG_FS .debugfs_init = dpu_kms_debugfs_init,

On 10/07/2021 01:16, abhinavk@codeaurora.org wrote:

On 2021-07-08 05:28, Dmitry Baryshkov wrote:

...

None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code.

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

The change looks fine, Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org

But has DP been re-verified with this change by Bjorn? If not, I can verify this on my board and give my Tested-by

Please test it on your setup.

...

---

drivers/gpu/drm/msm/dp/dp_display.c | 18 ------------------  1 file changed, 18 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 051c1be1de7e..70b319a8fe83 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -102,8 +102,6 @@ struct dp_display_private {      struct dp_display_mode dp_mode;      struct msm_dp dp_display;

-    bool encoder_mode_set;

/* wait for audio signaling */      struct completion audio_comp;

@@ -283,20 +281,6 @@ static void dp_display_send_hpd_event(struct msm_dp *dp_display)  }

-static void dp_display_set_encoder_mode(struct dp_display_private *dp) -{ -    struct msm_drm_private *priv = dp->dp_display.drm_dev->dev_private; -    struct msm_kms *kms = priv->kms;

-    if (!dp->encoder_mode_set && dp->dp_display.encoder && -                kms->funcs->set_encoder_mode) { -        kms->funcs->set_encoder_mode(kms, -                dp->dp_display.encoder, false);

-        dp->encoder_mode_set = true; -    } -}

static int dp_display_send_hpd_notification(struct dp_display_private *dp,                          bool hpd)  { @@ -369,8 +353,6 @@ static void dp_display_host_init(struct dp_display_private *dp, int reset)      if (dp->usbpd->orientation == ORIENTATION_CC2)          flip = true;

-    dp_display_set_encoder_mode(dp);

dp_power_init(dp->power, flip);      dp_ctrl_host_init(dp->ctrl, flip, reset);      dp_aux_init(dp->aux);

On 2021-07-08 05:28, Dmitry Baryshkov wrote:

None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code.

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org

---

drivers/gpu/drm/msm/dsi/dsi.c | 2 -- drivers/gpu/drm/msm/dsi/dsi.h | 1 - drivers/gpu/drm/msm/dsi/dsi_manager.c | 12 ------------ 3 files changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 5201d7eb0490..77c8dba297d8 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -251,8 +251,6 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev, goto fail; }

• msm_dsi_manager_setup_encoder(msm_dsi->id);
• priv->bridges[priv->num_bridges++] = msm_dsi->bridge; priv->connectors[priv->num_connectors++] = msm_dsi->connector;

diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h index 856a532850c0..e0c3c4409377 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.h +++ b/drivers/gpu/drm/msm/dsi/dsi.h @@ -80,7 +80,6 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id); struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id); int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg); bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len); -void msm_dsi_manager_setup_encoder(int id); int msm_dsi_manager_register(struct msm_dsi *msm_dsi); void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi); bool msm_dsi_manager_validate_current_config(u8 id); diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index a81105633d3c..e7f4e1d8978a 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -216,18 +216,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge) return dsi_bridge->id; }

-void msm_dsi_manager_setup_encoder(int id) -{

• struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
• struct msm_drm_private *priv = msm_dsi->dev->dev_private;
• struct msm_kms *kms = priv->kms;
• struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi);
• if (encoder && kms->funcs->set_encoder_mode)

• kms->funcs->set_encoder_mode(kms, encoder,
  

• 			     msm_dsi_is_cmd_mode(msm_dsi));
  

-}

static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) { struct msm_drm_private *priv = conn->dev->dev_private;

On 2021-07-08 05:28, Dmitry Baryshkov wrote:

set_encoder_mode callback is completely unused now. Drop it from msm_kms_func().

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

Reviewed-by: Abhinav Kumar abhinavk@codeaurora.org

---

drivers/gpu/drm/msm/msm_kms.h | 3 --- 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index 086a2d59b8c8..9484e8b62630 100644 --- a/drivers/gpu/drm/msm/msm_kms.h +++ b/drivers/gpu/drm/msm/msm_kms.h @@ -117,9 +117,6 @@ struct msm_kms_funcs { struct drm_encoder *encoder, struct drm_encoder *slave_encoder, bool is_cmd_mode);

• void (*set_encoder_mode)(struct msm_kms *kms,

• 		 struct drm_encoder *encoder,
  

• 		 bool cmd_mode);
  

  /* cleanup: */ void (*destroy)(struct msm_kms *kms);