https://bugs.freedesktop.org/show_bug.cgi?id=109375
Bug ID: 109375 Summary: Regression: dark notebook display (no backlight) after resume Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel@lists.freedesktop.org Reporter: zajec5@gmail.com
I use HP EliteBook 745 G5 with Ryzen 5 PRO 2500U.
Starting with the: commit 262485a50fd4532a8d71165190adc7a0a19bcc9e (refs/bisect/bad) Author: Anthony Koo Anthony.Koo@amd.com Date: Fri Oct 12 21:34:32 2018 -0400
drm/amd/display: Expand dc to use 16.16 bit backlight
[Why] We want to increase precision for backlight setting. But DC interface takes 8 bit backlight level value only.
[How] DMCU already takes 16 bit backlight level. Expand the DC interface to take 16.16 bit value. Max 32 bit backlight value (0xFFFF) will represent max backlight (100%)
Signed-off-by: Anthony Koo Anthony.Koo@amd.com Reviewed-by: Tony Cheng Tony.Cheng@amd.com Acked-by: Leo Li sunpeng.li@amd.com Signed-off-by: Alex Deucher alexander.deucher@amd.com
After resume from RAM my notebook display is all black.
Before suspend:
cat /sys/class/backlight/amdgpu_bl0/{actual_brightness,brightness}
65535 255
After resume:
cat /sys/class/backlight/amdgpu_bl0/{actual_brightness,brightness}
0 255
This can be workarounded by: echo 255 > /sys/class/backlight/amdgpu_bl0/brightness assuming one can execute that without a working display.
This problem still exists in the 5.0.0-rc2.
https://bugs.freedesktop.org/show_bug.cgi?id=109375
--- Comment #1 from Rafał Miłecki zajec5@gmail.com --- For a comparison: behavior with the commit 262485a50fd4~1 (before the regression):
Before suspend:
cat /sys/class/backlight/amdgpu_bl0/{actual_brightness,brightness}
255 255
After resume:
cat /sys/class/backlight/amdgpu_bl0/{actual_brightness,brightness}
250 255
Looks like a problem with amdgpu restoring backlight after resume.
https://bugs.freedesktop.org/show_bug.cgi?id=109375
--- Comment #2 from Leo Li sunpeng.li@amd.com --- Created attachment 143141 --> https://bugs.freedesktop.org/attachment.cgi?id=143141&action=edit drm/amd/display: Detach backlight from stream
Hi Rafał, Please give the attached patch a shot. It's in our staging branch, but not in 5.0-rc2 yet.
https://bugs.freedesktop.org/show_bug.cgi?id=109375
--- Comment #3 from Rafał Miłecki zajec5@gmail.com --- It didn't apply cleanly on top of 5.0.0-rc2 (a trivial conflict in the dc_link.c.rej). After fixing that, compiling & testing I can confirm is solves the problem for me! Thanks!
Before suspend:
cat /sys/class/backlight/amdgpu_bl0/{actual_brightness,brightness}
65535 255
After resume:
cat /sys/class/backlight/amdgpu_bl0/{actual_brightness,brightness}
64000 255
As it fixes a regression, can you submit it as a fix for the 5.0 release cycle, please?
https://bugs.freedesktop.org/show_bug.cgi?id=109375
--- Comment #4 from Alex Deucher alexdeucher@gmail.com --- Should be fixed with: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
https://bugs.freedesktop.org/show_bug.cgi?id=109375
Alex Deucher alexdeucher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.frank.uwb@googlem | |ail.com
--- Comment #5 from Alex Deucher alexdeucher@gmail.com --- *** Bug 109388 has been marked as a duplicate of this bug. ***
https://bugs.freedesktop.org/show_bug.cgi?id=109375
Rafał Miłecki zajec5@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #6 from Rafał Miłecki zajec5@gmail.com --- Fixed with the 5.0.0-rc3. Thanks!
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org