Hi, Jitao:

I agree with Neil, so please base on Boris' effort to negotiate with bridge.

Regards, Chun-Kuang Hu

Neil Armstrong narmstrong@baylibre.com 於 2020年3月11日 週三 下午9:53寫道：

Hi,

On 11/03/2020 08:18, Jitao Shi wrote:

...

Some chips's sample mode are rising, falling and dual edge (both falling and rising edge). Extern the pclk-sample property to support dual edge.

Acked-by: Rob Herring robh@kernel.org Reviewed-by: CK Hu ck.hu@mediatek.com Signed-off-by: Jitao Shi jitao.shi@mediatek.com

---

Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index f884ada0bffc..da9ad24935db 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -118,8 +118,8 @@ Optional endpoint properties

• data-enable-active: similar to HSYNC and VSYNC, specifies the data enable signal polarity.
• field-even-active: field signal level during the even field data transmission.

-- pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock

• signal.

+- pclk-sample: sample data on rising (1), falling (0) or both rising and

• falling (2) edge of the pixel clock signal.

• sync-on-green-active: active state of Sync-on-green (SoG) signal, 0/1 for LOW/HIGH respectively.
• data-lanes: an array of physical data lane indexes. Position of an entry

This changes the bus format, but we recently introduced a bus format negociation between bridges to avoid adding such properties into DT, and make bus format setup dynamic between an encoder and a bridge.

It would be great to use that instead.

Neil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Jitao Shi jitao.shi@mediatek.com 於 2020年3月11日 週三 下午3:18寫道：

Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set the dpi pins to gpio mode and output-low to avoid leakage current when dpi disabled.

Reviewed-by: Chun-Kuang Hu chunkuang.hu@kernel.org

Signed-off-by: Jitao Shi jitao.shi@mediatek.com

.../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 7 +++++++ 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt index 58914cf681b8..260ae75ac640 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt @@ -17,6 +17,10 @@ Required properties: Documentation/devicetree/bindings/graph.txt. This port should be connected to the input port of an attached HDMI or LVDS encoder chip.

+Optional properties: +- pinctrl-names: Contain "default" and "sleep".

• pinctrl-names see

Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt

Example:

dpi0: dpi@1401d000 { @@ -27,6 +31,9 @@ dpi0: dpi@1401d000 { <&mmsys CLK_MM_DPI_ENGINE>, <&apmixedsys CLK_APMIXED_TVDPLL>; clock-names = "pixel", "engine", "pll";

•   pinctrl-names = "default", "sleep";
  

•   pinctrl-0 = <&dpi_pin_func>;
  

•   pinctrl-1 = <&dpi_pin_idle>;
  
    port {
            dpi0_out: endpoint {
  

-- 2.21.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

On Wed, Mar 11, 2020 at 03:18:21PM +0800, Jitao Shi wrote:

Signed-off-by: Jitao Shi jitao.shi@mediatek.com

.../display/mediatek/mediatek,dpi.txt | 45 -------- .../display/mediatek/mediatek,dpi.yaml | 103 ++++++++++++++++++ 2 files changed, 103 insertions(+), 45 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt deleted file mode 100644 index 2dfb50a7321e..000000000000 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt +++ /dev/null @@ -1,45 +0,0 @@

-Mediatek DPI Device

-The Mediatek DPI function block is a sink of the display subsystem and -provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel -output bus.

-Required properties: -- compatible: "mediatek,<chip>-dpi"

• the supported chips are mt2701 , mt8173 and mt8183.

-- reg: Physical base address and length of the controller's registers -- interrupts: The interrupt signal from the function block. -- clocks: device clocks

• See Documentation/devicetree/bindings/clock/clock-bindings.txt for details.

-- clock-names: must contain "pixel", "engine", and "pll" -- port: Output port node with endpoint definitions as described in

• Documentation/devicetree/bindings/graph.txt. This port should be connected
• to the input port of an attached HDMI or LVDS encoder chip.

-Optional properties: -- pinctrl-names: Contain "default" and "sleep".

• pinctrl-names see Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt

-- pclk-sample: refer Documentation/devicetree/bindings/media/video-interfaces.txt.

-Example:

-dpi0: dpi@1401d000 {

• compatible = "mediatek,mt8173-dpi";
• reg = <0 0x1401d000 0 0x1000>;
• interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
• clocks = <&mmsys CLK_MM_DPI_PIXEL>,

•  <&mmsys CLK_MM_DPI_ENGINE>,
  

•  <&apmixedsys CLK_APMIXED_TVDPLL>;
  

• clock-names = "pixel", "engine", "pll";
• pinctrl-names = "default", "sleep";
• pinctrl-0 = <&dpi_pin_func>;
• pinctrl-1 = <&dpi_pin_idle>;
• port {

• dpi0_out: endpoint {
  

• 	pclk-sample = <0>;
  

• 	remote-endpoint = <&hdmi0_in>;
  

• };
  

• };

-}; diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml new file mode 100644 index 000000000000..d65543e3bf8c --- /dev/null +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -0,0 +1,103 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: mediatek DPI Controller Device Tree Bindings

+maintainers:

• • CK Hu ck.hu@mediatek.com
• • Jitao shi jitao.shi@mediatek.com

+description: |

• The Mediatek DPI function block is a sink of the display subsystem and
• provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel
• output bus.

+properties:

• compatible:
• enum:

•  - mediatek,mt2701-dpi
  

•  - mediatek,mt8173-dpi
  

•  - mediatek,mt8183-dpi
  

• reg:
• maxItems: 1
• interrupts:
• maxItems: 1
• clocks:
• items:

•  - description: Pixel Clock
  

•  - description: Engine Clock
  

•  - description: DPI PLL
  

• clock-names:
• items:

•  - const: pixel
  

•  - const: engine
  

•  - const: pll
  

• pinctrl-0: true
• pinctrl-1: true
• pinctrl-names:
• items:

•  - const: default
  

•  - const: sleep
  

• port@0:
• type: object
• description:

•  Output port node with endpoint definitions as described in
  

•  Documentation/devicetree/bindings/graph.txt. This port should be connected
  

•  to the input port of an attached HDMI or LVDS encoder chip.
  

• properties:

•  endpoint:
  

•    type: object
  

•    properties:
  

•      pclk-sample:
  

•        items:
  

•        - description: refer Documentation/devicetree/bindings/media/video-interfaces.txt.
  

This is not an array.

Just 'pclk-sample: true' if both values are allowed or 'const: 0|1' if only one value is allowed.

+required:

• • compatible
• • reg
• • interrupts
• • clocks
• • clock-names
• • port@0

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/interrupt-controller/arm-gic.h>
• #include <dt-bindings/clock/mt8173-clk.h>
• #include <dt-bindings/interrupt-controller/arm-gic.h>
• #include <dt-bindings/interrupt-controller/irq.h>
• dpi0: dpi@1401d000 {

•    compatible = "mediatek,mt8173-dpi";
  

•    reg = <0 0x1401d000 0 0x1000>;
  

•    interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
  

•    clocks = <&mmsys CLK_MM_DPI_PIXEL>,
  

•         <&mmsys CLK_MM_DPI_ENGINE>,
  

•         <&apmixedsys CLK_APMIXED_TVDPLL>;
  

•    clock-names = "pixel", "engine", "pll";
  

•    pinctrl-names = "default", "sleep";
  

•    pinctrl-0 = <&dpi_pin_func>;
  

•    pinctrl-1 = <&dpi_pin_idle>;
  

•    port@0 {
  

•        dpi0_out: endpoint {
  

•            pclk-sample = <0>;
  

•            remote-endpoint = <&hdmi0_in>;
  

•        };
  

•    };
  

• };

+...

2.21.0

Jitao Shi jitao.shi@mediatek.com 於 2020年3月11日 週三 下午3:19寫道：

Config dpi pins mode to output and pull low when dpi is disabled. Aovid leakage current from some dpi pins (Hsync Vsync DE ... ).

Reviewed-by: Chun-Kuang Hu chunkuang.hu@kernel.org

Signed-off-by: Jitao Shi jitao.shi@mediatek.com

drivers/gpu/drm/mediatek/mtk_dpi.c | 31 ++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 2871e68e7767..b6359e979588 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -10,7 +10,9 @@ #include <linux/kernel.h> #include <linux/of.h> #include <linux/of_device.h> +#include <linux/of_gpio.h> #include <linux/of_graph.h> +#include <linux/pinctrl/consumer.h> #include <linux/platform_device.h> #include <linux/types.h>

@@ -74,6 +76,9 @@ struct mtk_dpi { enum mtk_dpi_out_yc_map yc_map; enum mtk_dpi_out_bit_num bit_num; enum mtk_dpi_out_channel_swap channel_swap;

•   struct pinctrl *pinctrl;
  

•   struct pinctrl_state *pins_gpio;
  

•   struct pinctrl_state *pins_dpi;
    int refcount;
    u32 pclk_sample;
  

}; @@ -387,6 +392,9 @@ static void mtk_dpi_power_off(struct mtk_dpi *dpi) if (--dpi->refcount != 0) return;

•   if (dpi->pinctrl && dpi->pins_gpio)
  

•           pinctrl_select_state(dpi->pinctrl, dpi->pins_gpio);
  

•   mtk_dpi_disable(dpi);
    clk_disable_unprepare(dpi->pixel_clk);
    clk_disable_unprepare(dpi->engine_clk);
  

@@ -411,6 +419,9 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi) goto err_pixel; }

•   if (dpi->pinctrl && dpi->pins_dpi)
  

•           pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi);
  

•   mtk_dpi_enable(dpi);
    return 0;
  
  

@@ -728,6 +739,26 @@ static int mtk_dpi_probe(struct platform_device *pdev) of_property_read_u32(ep, "pclk-sample", &dpi->pclk_sample); of_node_put(ep);

•   dpi->pinctrl = devm_pinctrl_get(&pdev->dev);
  

•   if (IS_ERR(dpi->pinctrl)) {
  

•           dpi->pinctrl = NULL;
  

•           dev_dbg(&pdev->dev, "Cannot find pinctrl!\n");
  

•   }
  

•   if (dpi->pinctrl) {
  

•           dpi->pins_gpio = pinctrl_lookup_state(dpi->pinctrl,
  

"sleep");

•           if (IS_ERR(dpi->pins_gpio)) {
  

•                   dpi->pins_gpio = NULL;
  

•                   dev_dbg(&pdev->dev, "Cannot find pinctrl idle!\n");
  

•           }
  

•           if (dpi->pins_gpio)
  

•                   pinctrl_select_state(dpi->pinctrl, dpi->pins_gpio);
  

•           dpi->pins_dpi = pinctrl_lookup_state(dpi->pinctrl,
  

"default");

•           if (IS_ERR(dpi->pins_dpi)) {
  

•                   dpi->pins_dpi = NULL;
  

•                   dev_dbg(&pdev->dev, "Cannot find pinctrl
  

active!\n");

•           }
  

•   }
    mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    dpi->regs = devm_ioremap_resource(dev, mem);
    if (IS_ERR(dpi->regs)) {
  

-- 2.21.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel