From: Mark Yacoub markyacoub@google.com
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return; - plane->state = &state->base; }
+ __drm_atomic_helper_plane_reset(plane, &state->base); + state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565; }
Hi Mark:
Mark Yacoub markyacoub@chromium.org 於 2021年10月28日 週四 上午12:28寫道：
From: Mark Yacoub markyacoub@google.com
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
This patch looks good to me, but please fix this checkpatch warning:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Mark Yacoub markyacoub@google.com' != 'Signed-off-by: Mark Yacoub markyacoub@chromium.org'
total: 0 errors, 1 warnings, 11 lines checked
Regards, Chun-Kuang.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return;
plane->state = &state->base; }
__drm_atomic_helper_plane_reset(plane, &state->base);state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565;}
2.33.0.1079.g6e70778dc9-goog
On Wed, Dec 8, 2021 at 7:16 PM Chun-Kuang Hu chunkuang.hu@kernel.org wrote:
Hi Mark:
Mark Yacoub markyacoub@chromium.org 於 2021年10月28日 週四 上午12:28寫道：
From: Mark Yacoub markyacoub@google.com
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
This patch looks good to me, but please fix this checkpatch warning:
Uploaded a new revision. Thanks!
WARNING: From:/Signed-off-by: email address mismatch: 'From: Mark Yacoub markyacoub@google.com' != 'Signed-off-by: Mark Yacoub markyacoub@chromium.org'
total: 0 errors, 1 warnings, 11 lines checked
Regards, Chun-Kuang.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return;
plane->state = &state->base; }
__drm_atomic_helper_plane_reset(plane, &state->base);state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565;}
2.33.0.1079.g6e70778dc9-goog
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return; - plane->state = &state->base; }
+ __drm_atomic_helper_plane_reset(plane, &state->base); + state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565; }
Hi, Mark:
Mark Yacoub markyacoub@chromium.org 於 2021年12月14日 週二 上午12:08寫道：
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?...
Regards, Chun-Kuang.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return;
plane->state = &state->base; }
__drm_atomic_helper_plane_reset(plane, &state->base);state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565;}
2.34.1.173.g76aa8bc2d0-goog
Thank you so much!
On Mon, Dec 13, 2021 at 6:27 PM Chun-Kuang Hu chunkuang.hu@kernel.org wrote:
Hi, Mark:
Mark Yacoub markyacoub@chromium.org 於 2021年12月14日 週二 上午12:08寫道：
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?...
Regards, Chun-Kuang.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return;
plane->state = &state->base; }
__drm_atomic_helper_plane_reset(plane, &state->base);state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565;}
2.34.1.173.g76aa8bc2d0-goog
hey - uploaded v2 that takes care of the panel: https://patchwork.kernel.org/project/linux-mediatek/patch/20211229184420.793...
Thanks!
On Tue, Dec 14, 2021 at 10:26 AM Mark Yacoub markyacoub@chromium.org wrote:
Thank you so much!
On Mon, Dec 13, 2021 at 6:27 PM Chun-Kuang Hu chunkuang.hu@kernel.org wrote:
Hi, Mark:
Mark Yacoub markyacoub@chromium.org 於 2021年12月14日 週二 上午12:08寫道：
At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1.
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?...
Regards, Chun-Kuang.
Tested on Jacuzzi (MTK). Resolves IGT@kms_properties@plane-properties-{legacy,atomic}
Signed-off-by: Mark Yacoub markyacoub@chromium.org
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return;
plane->state = &state->base; }
__drm_atomic_helper_plane_reset(plane, &state->base);state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565;}
2.34.1.173.g76aa8bc2d0-goog
dri-devel@lists.freedesktop.org
-
Chun-Kuang Hu -
Mark Yacoub