Hi

Am 31.12.19 um 07:50 schrieb Tian Tao:

since we can get the BO from drm_fb rather than hibmc_fb,do not need the hibmc_fb.so we delete the local variable hibmc_fb.

Signed-off-by: Tian Tao tiantao6@hisilicon.com Signed-off-by: Gong junjie gongjunjie2@huawei.com

---

drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c index 6bf4334..12b38ac 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c @@ -105,14 +105,12 @@ static void hibmc_plane_atomic_update(struct drm_plane *plane, s64 gpu_addr = 0; unsigned int line_l; struct hibmc_drm_private *priv = plane->dev->dev_private;

• struct hibmc_framebuffer *hibmc_fb; struct drm_gem_vram_object *gbo;

  if (!state->fb) return;

• hibmc_fb = to_hibmc_framebuffer(state->fb);

• gbo = drm_gem_vram_of_gem(hibmc_fb->obj);

• gbo = drm_gem_vram_of_gem(state->fb->obj[0]);

  gpu_addr = drm_gem_vram_offset(gbo); if (WARN_ON_ONCE(gpu_addr < 0))

Thanks for the patch. This has meanwhile been fixed as part of

commit 3e10d2ffd245f996c36f87b0a8027a719e6135c3 Author: Thomas Zimmermann tzimmermann@suse.de Date: Tue Dec 3 09:38:16 2019 +0100

drm/hisilicon/hibmc: Replace struct hibmc_framebuffer with generic code

Best regards Thomas