...

From: Markus Elfring elfring@users.sourceforge.net Date: Wed, 4 Feb 2015 21:54:45 +0100

The functions phy_power_on() and vunmap() perform also input parameter validation. Thus the test around their calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring elfring@users.sourceforge.net

drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++---- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index 34d46aa..306cf1d 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display,

static void exynos_dp_phy_init(struct exynos_dp_device *dp) {

• if (dp->phy)

• phy_power_on(dp->phy);
  

• phy_power_on(dp->phy);

}

static void exynos_dp_phy_exit(struct exynos_dp_device *dp) {

• if (dp->phy)

• phy_power_off(dp->phy);
  

• phy_power_off(dp->phy);

}

static void exynos_dp_poweron(struct exynos_drm_display *display) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index e12ea90..0dd448a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev, struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd->exynos_gem_obj; struct drm_framebuffer *fb;

• if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr)

• if (is_drm_iommu_supported(dev)) vunmap(exynos_gem_obj->buffer->kvaddr);

  /* release drm framebuffer and real buffer */

Acked-by: Joonyoung Shim jy0922.shim@samsung.com

Do the chances increase to integrate this update suggestion into another source code repository?

Regards, Markus

On Thu, Jul 21, 2016 at 1:42 PM, SF Markus Elfring elfring@users.sourceforge.net wrote:

From: Markus Elfring elfring@users.sourceforge.net Date: Thu, 21 Jul 2016 19:23:25 +0200

The vunmap() function performs also input parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring elfring@users.sourceforge.net

Applied to drm-misc

---

drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index dd09117..4cfb39d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -269,8 +269,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev, struct exynos_drm_gem *exynos_gem = exynos_fbd->exynos_gem; struct drm_framebuffer *fb;

•   if (exynos_gem->kvaddr)
  

•           vunmap(exynos_gem->kvaddr);
  

•   vunmap(exynos_gem->kvaddr);
  
    /* release drm framebuffer and real buffer */
    if (fb_helper->fb && fb_helper->fb->funcs) {
  

-- 2.9.2

---

dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel