Uwe Kleine-König u.kleine-koenig@pengutronix.de writes:
$ git name-rev --refs=refs/tags/v2.6* 69a07f0b117a40fcc1a479358d8e1f41793617f2 69a07f0b117a40fcc1a479358d8e1f41793617f2 tags/v2.6.39-rc2~3^2~43^2~4
so it was introduced just before -rc2.
$ git tag --contains 69a07f0b117a40fcc1a479358d8e1f41793617f2 v2.6.39-rc1 v2.6.39-rc2
Andreas.
On Wed, Apr 13, 2011 at 10:59:14AM +0200, Andreas Schwab wrote:
Uwe Kleine-König u.kleine-koenig@pengutronix.de writes:
$ git name-rev --refs=refs/tags/v2.6* 69a07f0b117a40fcc1a479358d8e1f41793617f2 69a07f0b117a40fcc1a479358d8e1f41793617f2 tags/v2.6.39-rc2~3^2~43^2~4
so it was introduced just before -rc2.
$ git tag --contains 69a07f0b117a40fcc1a479358d8e1f41793617f2 v2.6.39-rc1 v2.6.39-rc2
So who is right? I think it was before rc1.
Anyway I'm aware that there are other git commands, although for the option details I often have to have a look at the man page.
However in this case the main reason to fire gitk was to have a quick look at the patch and its context, and simply reported the "Precedes" line in the display, which is 2.6.39-rc1. It also follow v2.6.37-rc2, which means that it has been quite a long time outside the main tree.
Gabriel
Hello Gabriel On Wed, Apr 13, 2011 at 12:31:44PM +0200, Gabriel Paubert wrote:
On Wed, Apr 13, 2011 at 10:59:14AM +0200, Andreas Schwab wrote:
Uwe Kleine-König u.kleine-koenig@pengutronix.de writes:
$ git name-rev --refs=refs/tags/v2.6* 69a07f0b117a40fcc1a479358d8e1f41793617f2 69a07f0b117a40fcc1a479358d8e1f41793617f2 tags/v2.6.39-rc2~3^2~43^2~4
so it was introduced just before -rc2.
$ git tag --contains 69a07f0b117a40fcc1a479358d8e1f41793617f2 v2.6.39-rc1 v2.6.39-rc2
So who is right? I think it was before rc1.
Yep, correct. I interpreted the output of git name-rev to mean it's not included in a tag earlier than v2.6.39-rc2, but actually that's wrong. It's just that it's easier (for some definition of easy) to reach the commit in question from v2.6.39-rc2 than from v2.6.39-rc1.
However in this case the main reason to fire gitk was to have a quick look at the patch and its context, and simply reported the "Precedes" line in the display, which is 2.6.39-rc1. It also follow v2.6.37-rc2, which means that it has been quite a long time outside the main tree.
I think this conclusion isn't valid in general. (E.g. in git itself a bug-fix is often done on top of the commit that introduced it and than merged into master. Still the bugfix might be new.) But looking at the AuthorDate of 69a07f0b117a seems to support your statement.
Best regards Uwe
dri-devel@lists.freedesktop.org
-
Andreas Schwab -
Gabriel Paubert -
Uwe Kleine-König