edid should be freed once it's finished being used.
Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") Cc: Rob Herring robh@kernel.org Cc: Sean Paul seanpaul@chromium.org Cc: Maxime Ripard maxime.ripard@free-electrons.com Cc: Archit Taneja architt@codeaurora.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Laurent Pinchart Laurent.pinchart@ideasonboard.com Cc: stable@vger.kernel.org # v4.9+ Signed-off-by: Sean Paul seanpaul@chromium.org --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 498d5948d1a8..9837c8d69e69 100644 --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c @@ -56,7 +56,9 @@ static int dumb_vga_get_modes(struct drm_connector *connector) }
drm_mode_connector_update_edid_property(connector, edid); - return drm_add_edid_modes(connector, edid); + ret = drm_add_edid_modes(connector, edid); + kfree(edid); + return ret;
fallback: /*
Hi Sean,
Thank you for the patch.
On Friday, 20 April 2018 21:59:59 EEST Sean Paul wrote:
edid should be freed once it's finished being used.
Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") Cc: Rob Herring robh@kernel.org Cc: Sean Paul seanpaul@chromium.org Cc: Maxime Ripard maxime.ripard@free-electrons.com Cc: Archit Taneja architt@codeaurora.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Laurent Pinchart Laurent.pinchart@ideasonboard.com Cc: stable@vger.kernel.org # v4.9+ Signed-off-by: Sean Paul seanpaul@chromium.org
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
drivers/gpu/drm/bridge/dumb-vga-dac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 498d5948d1a8..9837c8d69e69 100644 --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c @@ -56,7 +56,9 @@ static int dumb_vga_get_modes(struct drm_connector *connector) }
drm_mode_connector_update_edid_property(connector, edid);
- return drm_add_edid_modes(connector, edid);
- ret = drm_add_edid_modes(connector, edid);
- kfree(edid);
- return ret;
fallback: /*
On Fri, Apr 20, 2018 at 02:59:59PM -0400, Sean Paul wrote:
edid should be freed once it's finished being used.
Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") Cc: Rob Herring robh@kernel.org Cc: Sean Paul seanpaul@chromium.org Cc: Maxime Ripard maxime.ripard@free-electrons.com Cc: Archit Taneja architt@codeaurora.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Laurent Pinchart Laurent.pinchart@ideasonboard.com Cc: stable@vger.kernel.org # v4.9+ Signed-off-by: Sean Paul seanpaul@chromium.org
Reviewed-by: Maxime Ripard maxime.ripard@bootlin.com
Maxime
On Fri, Apr 20, 2018 at 02:59:59PM -0400, Sean Paul wrote:
edid should be freed once it's finished being used.
Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") Cc: Rob Herring robh@kernel.org Cc: Sean Paul seanpaul@chromium.org Cc: Maxime Ripard maxime.ripard@free-electrons.com Cc: Archit Taneja architt@codeaurora.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Laurent Pinchart Laurent.pinchart@ideasonboard.com Cc: stable@vger.kernel.org # v4.9+ Signed-off-by: Sean Paul seanpaul@chromium.org
Applied to -misc-fixes with review tags.
Sean
drivers/gpu/drm/bridge/dumb-vga-dac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 498d5948d1a8..9837c8d69e69 100644 --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c @@ -56,7 +56,9 @@ static int dumb_vga_get_modes(struct drm_connector *connector) }
drm_mode_connector_update_edid_property(connector, edid);
- return drm_add_edid_modes(connector, edid);
- ret = drm_add_edid_modes(connector, edid);
- kfree(edid);
- return ret;
fallback: /* -- Sean Paul, Software Engineer, Google / Chromium OS
dri-devel@lists.freedesktop.org
-
Laurent Pinchart -
Maxime Ripard -
Sean Paul