The top level drm Kconfig is a bit messy at the moment. Most of the drm drivers have their own Kconfig files, but a few have their Kconfig files in the top level Kconfig option itself.
Create new Kconfig files for drivers that don't have one. This cleans up the Kconfig quite a bit
Archit Taneja (10): drm/tdfx: clean up: create a separate Kconfig file drm/r128: clean up: create a separate Kconfig file drm/radeon: clean up: move config option to driver's own Kconfig file drm/amdgpu: clean up: move config option to driver's own Kconfig file drm/i810: clean up: create a separate Kconfig file drm/mga: clean up: create a separate Kconfig file drm/sis: clean up: create a separate Kconfig file drm/via: clean up: create a separate Kconfig file drm/savage: clean up: create a separate Kconfig file drm/misc: clean up: group device specific Kconfigs
drivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++ 10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig
Remove the DRM_TDFX from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 7 +------ drivers/gpu/drm/tdfx/Kconfig | 6 ++++++ 2 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 drivers/gpu/drm/tdfx/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index c46ca31..3f3328b 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -81,12 +81,7 @@ source "drivers/gpu/drm/i2c/Kconfig"
source "drivers/gpu/drm/bridge/Kconfig"
-config DRM_TDFX - tristate "3dfx Banshee/Voodoo3+" - depends on DRM && PCI - help - Choose this option if you have a 3dfx Banshee or Voodoo3 (or later), - graphics card. If M is selected, the module will be called tdfx. +source "drivers/gpu/drm/tdfx/Kconfig"
config DRM_R128 tristate "ATI Rage 128" diff --git a/drivers/gpu/drm/tdfx/Kconfig b/drivers/gpu/drm/tdfx/Kconfig new file mode 100644 index 0000000..a9e26ad --- /dev/null +++ b/drivers/gpu/drm/tdfx/Kconfig @@ -0,0 +1,6 @@ +config DRM_TDFX + tristate "3dfx Banshee/Voodoo3+" + depends on DRM && PCI + help + Choose this option if you have a 3dfx Banshee or Voodoo3 (or later), + graphics card. If M is selected, the module will be called tdfx.
Remove the DRM_R128 config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/r128/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/r128/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3f3328b..fc9d65d 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -83,14 +83,7 @@ source "drivers/gpu/drm/bridge/Kconfig"
source "drivers/gpu/drm/tdfx/Kconfig"
-config DRM_R128 - tristate "ATI Rage 128" - depends on DRM && PCI - select FW_LOADER - help - Choose this option if you have an ATI Rage 128 graphics card. If M - is selected, the module will be called r128. AGP support for - this card is strongly suggested (unless you have a PCI version). +source "drivers/gpu/drm/r128/Kconfig"
config DRM_RADEON tristate "ATI Radeon" diff --git a/drivers/gpu/drm/r128/Kconfig b/drivers/gpu/drm/r128/Kconfig new file mode 100644 index 0000000..3c1ae88 --- /dev/null +++ b/drivers/gpu/drm/r128/Kconfig @@ -0,0 +1,8 @@ +config DRM_R128 + tristate "ATI Rage 128" + depends on DRM && PCI + select FW_LOADER + help + Choose this option if you have an ATI Rage 128 graphics card. If M + is selected, the module will be called r128. AGP support for + this card is strongly suggested (unless you have a PCI version).
Remove the DRM_RADEON config option from the top level drm Kconfig file and move it to the Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 21 --------------------- drivers/gpu/drm/radeon/Kconfig | 21 +++++++++++++++++++++ 2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index fc9d65d..f19d894 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -85,27 +85,6 @@ source "drivers/gpu/drm/tdfx/Kconfig"
source "drivers/gpu/drm/r128/Kconfig"
-config DRM_RADEON - tristate "ATI Radeon" - depends on DRM && PCI - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT - select FW_LOADER - select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select DRM_TTM - select POWER_SUPPLY - select HWMON - select BACKLIGHT_CLASS_DEVICE - select INTERVAL_TREE - help - Choose this option if you have an ATI Radeon graphics card. There - are both PCI and AGP versions. You don't need to choose this to - run the Radeon in plain VGA mode. - - If M is selected, the module will be called radeon. - source "drivers/gpu/drm/radeon/Kconfig"
config DRM_AMDGPU diff --git a/drivers/gpu/drm/radeon/Kconfig b/drivers/gpu/drm/radeon/Kconfig index 421ae13..82c623b 100644 --- a/drivers/gpu/drm/radeon/Kconfig +++ b/drivers/gpu/drm/radeon/Kconfig @@ -1,3 +1,24 @@ +config DRM_RADEON + tristate "ATI Radeon" + depends on DRM && PCI + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + select FW_LOADER + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_TTM + select POWER_SUPPLY + select HWMON + select BACKLIGHT_CLASS_DEVICE + select INTERVAL_TREE + help + Choose this option if you have an ATI Radeon graphics card. There + are both PCI and AGP versions. You don't need to choose this to + run the Radeon in plain VGA mode. + + If M is selected, the module will be called radeon. + config DRM_RADEON_USERPTR bool "Always enable userptr support" depends on DRM_RADEON
On Mon, Jul 13, 2015 at 12:06:26PM +0530, Archit Taneja wrote: [...]
diff --git a/drivers/gpu/drm/radeon/Kconfig b/drivers/gpu/drm/radeon/Kconfig index 421ae13..82c623b 100644 --- a/drivers/gpu/drm/radeon/Kconfig +++ b/drivers/gpu/drm/radeon/Kconfig @@ -1,3 +1,24 @@ +config DRM_RADEON
- tristate "ATI Radeon"
- depends on DRM && PCI
- select FB_CFB_FILLRECT
- select FB_CFB_COPYAREA
- select FB_CFB_IMAGEBLIT
- select FW_LOADER
select DRM_KMS_HELPER- select DRM_KMS_FB_HELPER
select DRM_TTM
There's a mix of tabs vs. spaces here, which you might want to clean up as part of this clean up series.
Thierry
Remove the DRM_AMDGPU config option from the top level drm Kconfig file and move to Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 19 ------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index f19d894..5641a9a 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -87,25 +87,6 @@ source "drivers/gpu/drm/r128/Kconfig"
source "drivers/gpu/drm/radeon/Kconfig"
-config DRM_AMDGPU - tristate "AMD GPU" - depends on DRM && PCI - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT - select FW_LOADER - select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select DRM_TTM - select POWER_SUPPLY - select HWMON - select BACKLIGHT_CLASS_DEVICE - select INTERVAL_TREE - help - Choose this option if you have a recent AMD Radeon graphics card. - - If M is selected, the module will be called amdgpu. - source "drivers/gpu/drm/amd/amdgpu/Kconfig"
source "drivers/gpu/drm/nouveau/Kconfig" diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index b30fcfa..da7dcbf 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -1,3 +1,22 @@ +config DRM_AMDGPU + tristate "AMD GPU" + depends on DRM && PCI + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + select FW_LOADER + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_TTM + select POWER_SUPPLY + select HWMON + select BACKLIGHT_CLASS_DEVICE + select INTERVAL_TREE + help + Choose this option if you have a recent AMD Radeon graphics card. + + If M is selected, the module will be called amdgpu. + config DRM_AMDGPU_CIK bool "Enable amdgpu support for CIK parts" depends on DRM_AMDGPU
On Mon, Jul 13, 2015 at 12:06:27PM +0530, Archit Taneja wrote: [...]
diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index b30fcfa..da7dcbf 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -1,3 +1,22 @@ +config DRM_AMDGPU
- tristate "AMD GPU"
- depends on DRM && PCI
- select FB_CFB_FILLRECT
- select FB_CFB_COPYAREA
- select FB_CFB_IMAGEBLIT
- select FW_LOADER
select DRM_KMS_HELPER- select DRM_KMS_FB_HELPER
select DRM_TTM
Same here.
Thierry
Remove the DRM_I810 config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/i810/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 5641a9a..b7e694c 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -91,14 +91,7 @@ source "drivers/gpu/drm/amd/amdgpu/Kconfig"
source "drivers/gpu/drm/nouveau/Kconfig"
-config DRM_I810 - tristate "Intel I810" - # !PREEMPT because of missing ioctl locking - depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN) - help - Choose this option if you have an Intel I810 graphics card. If M is - selected, the module will be called i810. AGP support is required - for this driver to work. +source "drivers/gpu/drm/i810/Kconfig"
source "drivers/gpu/drm/i915/Kconfig"
diff --git a/drivers/gpu/drm/i810/Kconfig b/drivers/gpu/drm/i810/Kconfig new file mode 100644 index 0000000..71ba73a --- /dev/null +++ b/drivers/gpu/drm/i810/Kconfig @@ -0,0 +1,8 @@ +config DRM_I810 + tristate "Intel I810" + # !PREEMPT because of missing ioctl locking + depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN) + help + Choose this option if you have an Intel I810 graphics card. If M is + selected, the module will be called i810. AGP support is required + for this driver to work.
Remove the DRM_MGA config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/mga/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/mga/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index b7e694c..198cb75 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -95,14 +95,7 @@ source "drivers/gpu/drm/i810/Kconfig"
source "drivers/gpu/drm/i915/Kconfig"
-config DRM_MGA - tristate "Matrox g200/g400" - depends on DRM && PCI - select FW_LOADER - help - Choose this option if you have a Matrox G200, G400 or G450 graphics - card. If M is selected, the module will be called mga. AGP - support is required for this driver to work. +source "drivers/gpu/drm/mga/Kconfig"
config DRM_SIS tristate "SiS video cards" diff --git a/drivers/gpu/drm/mga/Kconfig b/drivers/gpu/drm/mga/Kconfig new file mode 100644 index 0000000..b8d143b --- /dev/null +++ b/drivers/gpu/drm/mga/Kconfig @@ -0,0 +1,8 @@ +config DRM_MGA + tristate "Matrox g200/g400" + depends on DRM && PCI + select FW_LOADER + help + Choose this option if you have a Matrox G200, G400 or G450 graphics + card. If M is selected, the module will be called mga. AGP + support is required for this driver to work.
Remove the DRM_SIS config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/sis/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/sis/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 198cb75..4b178a3 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -97,14 +97,7 @@ source "drivers/gpu/drm/i915/Kconfig"
source "drivers/gpu/drm/mga/Kconfig"
-config DRM_SIS - tristate "SiS video cards" - depends on DRM && AGP - depends on FB_SIS || FB_SIS=n - help - Choose this option if you have a SiS 630 or compatible video - chipset. If M is selected the module will be called sis. AGP - support is required for this driver to work. +source "drivers/gpu/drm/sis/Kconfig"
config DRM_VIA tristate "Via unichrome video cards" diff --git a/drivers/gpu/drm/sis/Kconfig b/drivers/gpu/drm/sis/Kconfig new file mode 100644 index 0000000..8ad0276 --- /dev/null +++ b/drivers/gpu/drm/sis/Kconfig @@ -0,0 +1,8 @@ +config DRM_SIS + tristate "SiS video cards" + depends on DRM && AGP + depends on FB_SIS || FB_SIS=n + help + Choose this option if you have a SiS 630 or compatible video + chipset. If M is selected the module will be called sis. AGP + support is required for this driver to work.
Remove the DRM_VIA config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 7 +------ drivers/gpu/drm/via/Kconfig | 6 ++++++ 2 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 drivers/gpu/drm/via/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 4b178a3..de11dc2 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -99,12 +99,7 @@ source "drivers/gpu/drm/mga/Kconfig"
source "drivers/gpu/drm/sis/Kconfig"
-config DRM_VIA - tristate "Via unichrome video cards" - depends on DRM && PCI - help - Choose this option if you have a Via unichrome or compatible video - chipset. If M is selected the module will be called via. +source "drivers/gpu/drm/via/Kconfig"
config DRM_SAVAGE tristate "Savage video cards" diff --git a/drivers/gpu/drm/via/Kconfig b/drivers/gpu/drm/via/Kconfig new file mode 100644 index 0000000..3206167 --- /dev/null +++ b/drivers/gpu/drm/via/Kconfig @@ -0,0 +1,6 @@ +config DRM_VIA + tristate "Via unichrome video cards" + depends on DRM && PCI + help + Choose this option if you have a Via unichrome or compatible video + chipset. If M is selected the module will be called via.
Remove the DRM_SAVAGE config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 8 +------- drivers/gpu/drm/savage/Kconfig | 7 +++++++ 2 files changed, 8 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/savage/Kconfig
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index de11dc2..f026ed8 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -101,13 +101,6 @@ source "drivers/gpu/drm/sis/Kconfig"
source "drivers/gpu/drm/via/Kconfig"
-config DRM_SAVAGE - tristate "Savage video cards" - depends on DRM && PCI - help - Choose this option if you have a Savage3D/4/SuperSavage/Pro/Twister - chipset. If M is selected the module will be called savage. - config DRM_VGEM tristate "Virtual GEM provider" depends on DRM @@ -116,6 +109,7 @@ config DRM_VGEM as used by Mesa's software renderer for enhanced performance. If M is selected the module will be called vgem.
+source "drivers/gpu/drm/savage/Kconfig"
source "drivers/gpu/drm/exynos/Kconfig"
diff --git a/drivers/gpu/drm/savage/Kconfig b/drivers/gpu/drm/savage/Kconfig new file mode 100644 index 0000000..7e19b9a --- /dev/null +++ b/drivers/gpu/drm/savage/Kconfig @@ -0,0 +1,7 @@ +config DRM_SAVAGE + tristate "Savage video cards" + depends on DRM && PCI + help + Choose this option if you have a Savage3D/4/SuperSavage/Pro/Twister + chipset. If M is selected the module will be called savage. +
Move the VGEM Kconfig option along with other DRM Kconfig options. Add a comment saying that the device specific Kconfig options start from here.
Signed-off-by: Archit Taneja architt@codeaurora.org --- drivers/gpu/drm/Kconfig | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index f026ed8..a66ac44 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -77,6 +77,16 @@ config DRM_KMS_CMA_HELPER help Choose this if you need the KMS CMA helper functions
+config DRM_VGEM + tristate "Virtual GEM provider" + depends on DRM + help + Choose this option to get a virtual graphics memory manager, + as used by Mesa's software renderer for enhanced performance. + If M is selected the module will be called vgem. + +#device specific Kconfigs + source "drivers/gpu/drm/i2c/Kconfig"
source "drivers/gpu/drm/bridge/Kconfig" @@ -101,14 +111,6 @@ source "drivers/gpu/drm/sis/Kconfig"
source "drivers/gpu/drm/via/Kconfig"
-config DRM_VGEM - tristate "Virtual GEM provider" - depends on DRM - help - Choose this option to get a virtual graphics memory manager, - as used by Mesa's software renderer for enhanced performance. - If M is selected the module will be called vgem. - source "drivers/gpu/drm/savage/Kconfig"
source "drivers/gpu/drm/exynos/Kconfig"
On Mon, Jul 13, 2015 at 2:36 AM, Archit Taneja architt@codeaurora.org wrote:
The top level drm Kconfig is a bit messy at the moment. Most of the drm drivers have their own Kconfig files, but a few have their Kconfig files in the top level Kconfig option itself.
Create new Kconfig files for drivers that don't have one. This cleans up the Kconfig quite a bit
Series is : Acked-by: Alex Deucher alexander.deucher@amd.com
Archit Taneja (10): drm/tdfx: clean up: create a separate Kconfig file drm/r128: clean up: create a separate Kconfig file drm/radeon: clean up: move config option to driver's own Kconfig file drm/amdgpu: clean up: move config option to driver's own Kconfig file drm/i810: clean up: create a separate Kconfig file drm/mga: clean up: create a separate Kconfig file drm/sis: clean up: create a separate Kconfig file drm/via: clean up: create a separate Kconfig file drm/savage: clean up: create a separate Kconfig file drm/misc: clean up: group device specific Kconfigs
drivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++ 10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Jul 13, 2015 at 12:06:23PM +0530, Archit Taneja wrote:
The top level drm Kconfig is a bit messy at the moment. Most of the drm drivers have their own Kconfig files, but a few have their Kconfig files in the top level Kconfig option itself.
Create new Kconfig files for drivers that don't have one. This cleans up the Kconfig quite a bit
Archit Taneja (10): drm/tdfx: clean up: create a separate Kconfig file drm/r128: clean up: create a separate Kconfig file drm/radeon: clean up: move config option to driver's own Kconfig file drm/amdgpu: clean up: move config option to driver's own Kconfig file drm/i810: clean up: create a separate Kconfig file drm/mga: clean up: create a separate Kconfig file drm/sis: clean up: create a separate Kconfig file drm/via: clean up: create a separate Kconfig file drm/savage: clean up: create a separate Kconfig file drm/misc: clean up: group device specific Kconfigs
drivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++ 10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig
Looking at the current state of the top-level Kconfig file, I think it'd be a good idea to sort it in some way once this series has been merged. There are a bunch of options that are interleaved in completely non- intuitive ways.
I'm not sure what the best ordering would be, but I'd suggest to at least order them alphabetically. I think it'd also make sense to separate out panel and bridge drivers so that they are listed at the very bottom.
Perhaps also splitting legacy drivers and modesetting drivers might be useful, though perhaps a little discriminatory...
Thierry
On Tue, Jul 14, 2015 at 11:18:02AM +0200, Thierry Reding wrote:
On Mon, Jul 13, 2015 at 12:06:23PM +0530, Archit Taneja wrote:
The top level drm Kconfig is a bit messy at the moment. Most of the drm drivers have their own Kconfig files, but a few have their Kconfig files in the top level Kconfig option itself.
Create new Kconfig files for drivers that don't have one. This cleans up the Kconfig quite a bit
Archit Taneja (10): drm/tdfx: clean up: create a separate Kconfig file drm/r128: clean up: create a separate Kconfig file drm/radeon: clean up: move config option to driver's own Kconfig file drm/amdgpu: clean up: move config option to driver's own Kconfig file drm/i810: clean up: create a separate Kconfig file drm/mga: clean up: create a separate Kconfig file drm/sis: clean up: create a separate Kconfig file drm/via: clean up: create a separate Kconfig file drm/savage: clean up: create a separate Kconfig file drm/misc: clean up: group device specific Kconfigs
drivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++ 10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig
Looking at the current state of the top-level Kconfig file, I think it'd be a good idea to sort it in some way once this series has been merged. There are a bunch of options that are interleaved in completely non- intuitive ways.
I'm not sure what the best ordering would be, but I'd suggest to at least order them alphabetically. I think it'd also make sense to separate out panel and bridge drivers so that they are listed at the very bottom.
Perhaps also splitting legacy drivers and modesetting drivers might be useful, though perhaps a little discriminatory...
I ended up patching things while writing this, so I'll just wait until these patches have landed, rebase on top of them and send out a proposal.
Thierry
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Archit Taneja -
Thierry Reding