Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 61d3361381b73..835574e2d5bf7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, };
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { + .width = 1200, + .height = 1920, + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, +}; + static const struct dmi_system_id orientation_data[] = { { /* Acer One 10 (S1003) */ .matches = { @@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), }, .driver_data = &itworks_tw891, + }, { /* Lenovo Ideapad D330 */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), + }, + .driver_data = &lcd1200x1920_rightside_up, }, { /* * Lenovo Ideapad Miix 310 laptop, only some production batches * have a portrait screen, the resolution checks makes the quirk
On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamaría Rogado wrote:
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
Is something obfuscating your email address here?
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 61d3361381b73..835574e2d5bf7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, };
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
- .width = 1200,
- .height = 1920,
- .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
Looks like that something may be messing up the whitespace in your patch as well.
Thierry
static const struct dmi_system_id orientation_data[] = { { /* Acer One 10 (S1003) */ .matches = { @@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), }, .driver_data = &itworks_tw891,
- }, { /* Lenovo Ideapad D330 */
- .matches = {
- DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
- DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
- DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
- },
- .driver_data = &lcd1200x1920_rightside_up, }, { /*
- Lenovo Ideapad Miix 310 laptop, only some production batches
- have a portrait screen, the resolution checks makes the quirk
I was about to forget the signed off like the void removal patch, so I mistake adding it just with @ as at. I can resend it with mail corrected.
I can't see the white spaces issue, The whitespaces issue I send it like the mails before as text without format. Anyways I can resend this entire patch if needed.
Thanks for your attention.
El mié., 13 feb. 2019 a las 13:43, Thierry Reding (thierry.reding@gmail.com) escribió:
On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamaría Rogado wrote:
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
Is something obfuscating your email address here?
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 61d3361381b73..835574e2d5bf7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, };
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
- .width = 1200,
- .height = 1920,
- .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
Looks like that something may be messing up the whitespace in your patch as well.
Thierry
static const struct dmi_system_id orientation_data[] = { { /* Acer One 10 (S1003) */ .matches = { @@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), }, .driver_data = &itworks_tw891,
- }, { /* Lenovo Ideapad D330 */
- .matches = {
- DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
- DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
- DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
- },
- .driver_data = &lcd1200x1920_rightside_up, }, { /*
- Lenovo Ideapad Miix 310 laptop, only some production batches
- have a portrait screen, the resolution checks makes the quirk
On Wed, Feb 13, 2019 at 06:18:26PM +0100, David Santamaría Rogado wrote:
I was about to forget the signed off like the void removal patch, so I mistake adding it just with @ as at. I can resend it with mail corrected.
I can't see the white spaces issue, The whitespaces issue I send it like the mails before as text without format. Anyways I can resend this entire patch if needed.
Resending is probably not going to help if we don't figure out first what's messing with the whitespace.
Thanks for your attention.
El mié., 13 feb. 2019 a las 13:43, Thierry Reding (thierry.reding@gmail.com) escribió:
On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamaría Rogado wrote:
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
Is something obfuscating your email address here?
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 61d3361381b73..835574e2d5bf7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, };
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
- .width = 1200,
- .height = 1920,
- .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
Looks like that something may be messing up the whitespace in your patch as well.
If you look at what arrived in my inbox, there is a single space after the + for the lines in the patch. There should be a tab if you've correctly followed the existing indentation in the file. Given that a single space is also present for existing lines (those without a +), I think you must've either generated the patch in a non-standard way, or your email client or server are getting in the way.
Are you using gmail to send this patch? Also, are you using git send-email?
Thierry
dri-devel@lists.freedesktop.org
-
David Santamaría Rogado -
Thierry Reding