Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2 can work on panels without y cordinate support.
v2: (Rodrigo) - Move the check to intel_psr_match_conditions
v3: (Rodrigo) - add return false
Cc: Rodrigo Vivi rodrigo.vivi@intel.com Cc: Jim Bride jim.bride@linux.intel.com Signed-off-by: Vathsala Nagaraju vathsala.nagaraju@intel.com Signed-off-by: Patil Deepti deepti.patil@intel.com --- drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 05efd4e..fc32b04 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp) return false; }
+ /* + * FIXME:enable psr2 only for y-cordinate psr2 panels + * After gtc implementation , remove this restriction. + */ + if (!dev_priv->psr.y_cord_support && dev_priv->psr.psr2_support) { + DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n"); + return false; + } + dev_priv->psr.source_ok = true; return true; }
I was going to write the rv-b, but something came to my mind...
In this case where y_cord_support but we don't have gtc yet, couldn't we enable PSR1 instead? in this case instead of return false we would do dev_priv->psr.psr2_support = false;
what do you think/advise?
On Fri, 2017-01-06 at 23:01 +0530, vathsala nagaraju wrote:
Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2 can work on panels without y cordinate support.
v2: (Rodrigo)
- Move the check to intel_psr_match_conditions
v3: (Rodrigo)
- add return false
Cc: Rodrigo Vivi rodrigo.vivi@intel.com Cc: Jim Bride jim.bride@linux.intel.com Signed-off-by: Vathsala Nagaraju vathsala.nagaraju@intel.com Signed-off-by: Patil Deepti deepti.patil@intel.com
drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 05efd4e..fc32b04 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp) return false; }
- /*
* FIXME:enable psr2 only for y-cordinate psr2 panels* After gtc implementation , remove this restriction.*/- if (!dev_priv->psr.y_cord_support && dev_priv->psr.psr2_support) {
DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");return false;- }
- dev_priv->psr.source_ok = true; return true;
}
1) I am still not able to get psr1 working on y-cordinate panels. Only psr2 works. 2) I haven't got a GTC panel to test this scenario. Once we test psr1 on psr2 GTC panel, we could add dev_priv->psr.psr2_support = false; till GTC is implemented.
-----Original Message----- From: Vivi, Rodrigo Sent: Friday, January 6, 2017 11:08 PM To: Nagaraju, Vathsala vathsala.nagaraju@intel.com Cc: dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; jim.bride@linux.intel.com; Patil, Deepti deepti.patil@intel.com Subject: Re: [PATCH 08/10] drm/i915/psr: enable psr2 for y cordinate panels
I was going to write the rv-b, but something came to my mind...
In this case where y_cord_support but we don't have gtc yet, couldn't we enable PSR1 instead? in this case instead of return false we would do dev_priv->psr.psr2_support = false;
what do you think/advise?
On Fri, 2017-01-06 at 23:01 +0530, vathsala nagaraju wrote:
Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2 can work on panels without y cordinate support.
v2: (Rodrigo)
- Move the check to intel_psr_match_conditions
v3: (Rodrigo)
- add return false
Cc: Rodrigo Vivi rodrigo.vivi@intel.com Cc: Jim Bride jim.bride@linux.intel.com Signed-off-by: Vathsala Nagaraju vathsala.nagaraju@intel.com Signed-off-by: Patil Deepti deepti.patil@intel.com
drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 05efd4e..fc32b04 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp) return false; }
- /*
* FIXME:enable psr2 only for y-cordinate psr2 panels* After gtc implementation , remove this restriction.*/- if (!dev_priv->psr.y_cord_support && dev_priv->psr.psr2_support) {
DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");return false;- }
- dev_priv->psr.source_ok = true; return true;
}
On Fri, 2017-01-06 at 17:55 +0000, Nagaraju, Vathsala wrote:
- I am still not able to get psr1 working on y-cordinate panels. Only psr2 works.
- I haven't got a GTC panel to test this scenario. Once we test psr1 on psr2 GTC panel, we could add dev_priv->psr.psr2_support = false; till GTC is implemented.
Agree!
Reviewed-by: Rodrigo Vivi rodrigo.vivi@intel.com
-----Original Message----- From: Vivi, Rodrigo Sent: Friday, January 6, 2017 11:08 PM To: Nagaraju, Vathsala vathsala.nagaraju@intel.com Cc: dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; jim.bride@linux.intel.com; Patil, Deepti deepti.patil@intel.com Subject: Re: [PATCH 08/10] drm/i915/psr: enable psr2 for y cordinate panels
I was going to write the rv-b, but something came to my mind...
In this case where y_cord_support but we don't have gtc yet, couldn't we enable PSR1 instead? in this case instead of return false we would do dev_priv->psr.psr2_support = false;
what do you think/advise?
On Fri, 2017-01-06 at 23:01 +0530, vathsala nagaraju wrote:
Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2 can work on panels without y cordinate support.
v2: (Rodrigo)
- Move the check to intel_psr_match_conditions
v3: (Rodrigo)
- add return false
Cc: Rodrigo Vivi rodrigo.vivi@intel.com Cc: Jim Bride jim.bride@linux.intel.com Signed-off-by: Vathsala Nagaraju vathsala.nagaraju@intel.com Signed-off-by: Patil Deepti deepti.patil@intel.com
drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 05efd4e..fc32b04 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp) return false; }
- /*
* FIXME:enable psr2 only for y-cordinate psr2 panels* After gtc implementation , remove this restriction.*/- if (!dev_priv->psr.y_cord_support && dev_priv->psr.psr2_support) {
DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");return false;- }
- dev_priv->psr.source_ok = true; return true;
}
dri-devel@lists.freedesktop.org
-
Nagaraju, Vathsala -
vathsala nagaraju
-
Vivi, Rodrigo