On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote:

On 13/06/2017 14:47, Colin King wrote:

...

From: Colin Ian King colin.king@canonical.com

The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global scope, so make it static.

Cleans up sparse warning: "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it be static?"

Signed-off-by: Colin Ian King colin.king@canonical.com

drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c index 8e669b6254ae..2f7b0e64f628 100644 --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, return true; }

-bool cnl_ddi_dp_set_dpll_hw_state(int clock,

• 		  struct intel_dpll_hw_state *dpll_hw_state)
  

+static bool +cnl_ddi_dp_set_dpll_hw_state(int clock,

• 	     struct intel_dpll_hw_state *dpll_hw_state)
  

  { uint32_t cfgcr0;

Reviewed-by: Tvrtko Ursulin tvrtko.ursulin@intel.com

Thanks for the patch and review. Pushed to dinq.