The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab mchehab+huawei@kernel.org --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a82f37d44258..631125b46e04 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd) /** * drm_display_mode_from_cea_vic() - return a mode for CEA VIC * @dev: DRM device - * @vic: CEA VIC of the mode + * @video_code: CEA VIC of the mode * * Creates a new mode matching the specified CEA VIC. *
Reviewed-by: Lyude Paul lyude@redhat.com
Thanks for the fixes! I will go ahead and push 11 and 12 to drm-misc-next.
On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote:
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab mchehab+huawei@kernel.org
drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a82f37d44258..631125b46e04 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd) /**
- drm_display_mode_from_cea_vic() - return a mode for CEA VIC
- @dev: DRM device
- @vic: CEA VIC of the mode
- @video_code: CEA VIC of the mode
- Creates a new mode matching the specified CEA VIC.
wait, I think there's some confusion here. these patches have already been pushed
On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote:
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab mchehab+huawei@kernel.org
drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a82f37d44258..631125b46e04 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd) /**
- drm_display_mode_from_cea_vic() - return a mode for CEA VIC
- @dev: DRM device
- @vic: CEA VIC of the mode
- @video_code: CEA VIC of the mode
- Creates a new mode matching the specified CEA VIC.
Hi Lyude,
Em Tue, 13 Oct 2020 15:49:11 -0400 Lyude Paul lyude@redhat.com escreveu:
wait, I think there's some confusion here. these patches have already been pushed
As the patch adding the warning was merged upstream at the 5.10 merge window, the fixup one should also be added there, instead of waiting until 5.11 ;-)
So, if OK for you, I'll send this upstream via my tree by the end of the merge window, as our goal is that 5.10 won't have doc warnings.
Regards, Mauro
On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote:
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab mchehab+huawei@kernel.org
drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a82f37d44258..631125b46e04 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd) /**
- drm_display_mode_from_cea_vic() - return a mode for CEA VIC
- @dev: DRM device
- @vic: CEA VIC of the mode
- @video_code: CEA VIC of the mode
- Creates a new mode matching the specified CEA VIC.
Thanks, Mauro
Ah, good point. It looks like you've already added the drm-misc-next and drm maintainers to here so as long as they're aware that should be fine
On Wed, 2020-10-21 at 12:11 +0200, Mauro Carvalho Chehab wrote:
Hi Lyude,
Em Tue, 13 Oct 2020 15:49:11 -0400 Lyude Paul lyude@redhat.com escreveu:
wait, I think there's some confusion here. these patches have already been pushed
As the patch adding the warning was merged upstream at the 5.10 merge window, the fixup one should also be added there, instead of waiting until 5.11 ;-)
So, if OK for you, I'll send this upstream via my tree by the end of the merge window, as our goal is that 5.10 won't have doc warnings.
Regards, Mauro
On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote:
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab mchehab+huawei@kernel.org
drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index a82f37d44258..631125b46e04 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd) /**
- drm_display_mode_from_cea_vic() - return a mode for CEA VIC
- @dev: DRM device
- @vic: CEA VIC of the mode
- @video_code: CEA VIC of the mode
- Creates a new mode matching the specified CEA VIC.
Thanks, Mauro
dri-devel@lists.freedesktop.org