Hi,

On 12/11/21 15:49, Miaoqian Lin wrote:

The devm_gen_pool_create() function does not return NULL. It returns error pointers.

Signed-off-by: Miaoqian Lin linmq006@gmail.com

This is already fixed in linux-next, see:

https://cgit.freedesktop.org/drm-misc/commit/drivers/gpu/drm/vboxvideo/vbox_...

Regards,

Hans

---

drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c index f28779715ccd..c9e8b3a63c62 100644 --- a/drivers/gpu/drm/vboxvideo/vbox_main.c +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c @@ -127,8 +127,8 @@ int vbox_hw_init(struct vbox_private *vbox) /* Create guest-heap mem-pool use 2^4 = 16 byte chunks */ vbox->guest_pool = devm_gen_pool_create(vbox->ddev.dev, 4, -1, "vboxvideo-accel");

• if (!vbox->guest_pool)

• return -ENOMEM;
  

• if (IS_ERR(vbox->guest_pool))

• return PTR_ERR(vbox->guest_pool);
  
  

  ret = gen_pool_add_virt(vbox->guest_pool, (unsigned long)vbox->guest_heap,