4k requires two dsi pipes, so don't report MODE_OK when only a single pipe is configured. But rather report MODE_PANEL to signal that requirements of the panel are not being met.
Reported-by: Peter Collingbourne pcc@google.com Suggested-by: Peter Collingbourne pcc@google.com Signed-off-by: Robert Foss robert.foss@linaro.org Tested-by: John Stultz john.stultz@linaro.org --- drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index d734d9402c35..e8eb8deb444b 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge, const struct drm_display_mode *mode) { struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode); + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
- return lt9611_mode ? MODE_OK : MODE_BAD; + if (!lt9611_mode) + return MODE_BAD; + else if (lt9611_mode->intfs > 1 && !lt9611->dsi1) + return MODE_PANEL; + else + return MODE_OK; }
static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
I just tested on non 4k display. Looks good to me.
On Mon, 23 Nov 2020 at 04:46, Robert Foss robert.foss@linaro.org wrote:
Tested-by: Anibal Limon anibal.limon@linaro.org
Thanks. Confirmed that this fixes display output for me on a 4K monitor.
On Mon, Nov 23, 2020 at 2:46 AM Robert Foss robert.foss@linaro.org wrote:
Tested-by: Peter Collingbourne pcc@google.com
On Mon 23 Nov 04:46 CST 2020, Robert Foss wrote:
This looks very similar to what I had in the early revisions of the driver.
Reviewed-by: Bjorn Andersson bjorn.andersson@linaro.org
Regards, Bjorn
dri-devel@lists.freedesktop.org
-
Anibal Limon -
Bjorn Andersson -
Peter Collingbourne -
Robert Foss -
Vinod Koul