Reviewed-by: Lyude Paul lyude@redhat.com

On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote:

As warned by kernel-doc:

./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or member 'type' not described in 'drm_dp_downstream_is_type' ./drivers/gpu/drm/drm_dp_helper.c:886: warning: Function parameter or member 'dev' not described in 'drm_dp_downstream_mode'

Some function parameters weren't documented.

Fixes: 38784f6f8805 ("drm/dp: Add helpers to identify downstream facing port types") Signed-off-by: Mauro Carvalho Chehab mchehab+huawei@kernel.org

---

drivers/gpu/drm/drm_dp_helper.c | 5 +++++ 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index b1c71af88579..deeed73f4ed6 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -374,6 +374,10 @@ static bool is_edid_digital_input_dp(const struct edid *edid)

• drm_dp_downstream_is_type() - is the downstream facing port of certain

type?

• @dpcd: DisplayPort configuration data
• @port_cap: port capabilities

• • @type: port type to be checked. Can be:

• •  %DP_DS_PORT_TYPE_DP, %DP_DS_PORT_TYPE_VGA, %DP_DS_PORT_TYPE_DVI,
    

• •  %DP_DS_PORT_TYPE_HDMI, %DP_DS_PORT_TYPE_NON_EDID,
    

• •  %DP_DS_PORT_TYPE_DP_DUALMODE or %DP_DS_PORT_TYPE_WIRELESS.
    

  • Caveat: Only works with DPCD 1.1+ port caps.

@@ -870,6 +874,7 @@ EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion);

/**

• drm_dp_downstream_mode() - return a mode for downstream facing port

• • @dev: DRM device
  • @dpcd: DisplayPort configuration data
  • @port_cap: port capabilities