In the drm_vblank_init() error handling case, platform device unregister is missing. This patch fix it.
Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers") Signed-off-by: Wei Yongjun weiyongjun1@huawei.com --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 6e728b8..5ad09d4 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -110,7 +110,7 @@ static int __init vkms_init(void) ret = drm_vblank_init(&vkms_device->drm, 1); if (ret) { DRM_ERROR("Failed to vblank\n"); - goto out_fini; + goto out_unregister; }
ret = vkms_modeset_init(vkms_device);
On 08/02, Wei Yongjun wrote:
In the drm_vblank_init() error handling case, platform device unregister is missing. This patch fix it.
Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers") Signed-off-by: Wei Yongjun weiyongjun1@huawei.com
drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 6e728b8..5ad09d4 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -110,7 +110,7 @@ static int __init vkms_init(void) ret = drm_vblank_init(&vkms_device->drm, 1); if (ret) { DRM_ERROR("Failed to vblank\n");
goto out_fini;
goto out_unregister;
}
ret = vkms_modeset_init(vkms_device);
Hi,
Thanks for the patch! Everything is fine for me.
Reviewed-by: Rodrigo Siqueira rodrigosiqueiramelo@gmail.com
dri-devel@lists.freedesktop.org