Like the Asus T100HA the Asus T101HA also uses a panel which has been mounted 90 degrees rotated, add a quirk for this.
Signed-off-by: Hans de Goede hdegoede@redhat.com --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index ffd95bfeaa94..d11d83703931 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -121,6 +121,12 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"), }, .driver_data = (void *)&asus_t100ha, + }, { /* Asus T101HA */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T101HA"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* GPD MicroPC (generic strings, also match on bios date) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
The Acer S1003 has proper DMI strings for sys-vendor and product-name, so we do not need to match by BIOS-date.
This means that the Acer S1003 can use the generic lcd800x1280_rightside_up drm_dmi_panel_orientation_data struct which is also used by other quirks.
Signed-off-by: Hans de Goede hdegoede@redhat.com --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index d11d83703931..d00ea384dcbf 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -30,12 +30,6 @@ struct drm_dmi_panel_orientation_data { int orientation; };
-static const struct drm_dmi_panel_orientation_data acer_s1003 = { - .width = 800, - .height = 1280, - .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, -}; - static const struct drm_dmi_panel_orientation_data asus_t100ha = { .width = 800, .height = 1280, @@ -114,7 +108,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"), }, - .driver_data = (void *)&acer_s1003, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* Asus T100HA */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
On Sun, 31 May 2020 at 10:30, Hans de Goede hdegoede@redhat.com wrote:
Like the Asus T100HA the Asus T101HA also uses a panel which has been mounted 90 degrees rotated, add a quirk for this.
Reading the commit message, made me wonder: If it's similar why it doesn't use the same quirk? Something like the following helps:
... 90 degrees rotated, albeit in the opposite direction. Add a quirk for this.
With that the series is: Reviewed-by: Emil Velikov emil.l.velikov@gmail.com
-Emil
Hi,
On 5/31/20 7:25 PM, Emil Velikov wrote:
On Sun, 31 May 2020 at 10:30, Hans de Goede hdegoede@redhat.com wrote:
Like the Asus T100HA the Asus T101HA also uses a panel which has been mounted 90 degrees rotated, add a quirk for this.
Reading the commit message, made me wonder: If it's similar why it doesn't use the same quirk? Something like the following helps:
... 90 degrees rotated, albeit in the opposite direction. Add a quirk for this.
With that the series is: Reviewed-by: Emil Velikov emil.l.velikov@gmail.com
Thank you, I've ammended the commit msg with your suggestion and pushed the 2 patches to drm-misc-fixes.
Regards,
Hans
dri-devel@lists.freedesktop.org
-
Emil Velikov -
Hans de Goede