Hi, Dave.
I am very sorry for html type used before so I am re-sending this e-mail. I wonder where are we on this. I had sent DRM Driver patch v5 for Samsung SoC Exynos4210 a week ago but we have not received any comments from you.
You can refer to these patches I sent from links below. v1: < https://lwn.net/Articles/454380/ > v2: < http://www.spinics.net/lists/kernel/msg1224275.html > v3: < http://www.spinics.net/lists/dri-devel/msg13755.html > v4: < http://permalink.gmane.org/gmane.comp.video.dri.devel/60439 > v5: < http://comments.gmane.org/gmane.comp.video.dri.devel/60802 >
and also you can refer to our working repository below. < http://git.infradead.org/users/kmpark/linux-2.6-samsung > Branch name : dev/samsung-drm
If there are any problems regarding our driver then please give me your comments or advices so that we could prepare next patch; otherwise we wish our driver be applied to mainline.
Thanks, Inki Dae.
You can refer to these patches I sent from links below. v1: < https://lwn.net/Articles/454380/ > v2: < http://www.spinics.net/lists/kernel/msg1224275.html > v3: < http://www.spinics.net/lists/dri-devel/msg13755.html > v4: < http://permalink.gmane.org/gmane.comp.video.dri.devel/60439 > v5: < http://comments.gmane.org/gmane.comp.video.dri.devel/60802 >
and also you can refer to our working repository below. < http://git.infradead.org/users/kmpark/linux-2.6-samsung > Branch name : dev/samsung-drm
If there are any problems regarding our driver then please give me your comments or advices so that we could prepare next patch; otherwise we wish our driver be applied to mainline.
I'll probably give it one more review early next week, but I might merge it to -next, if I don't find anything seriously wrong.
I still dislike the samsung_drm_ everywhere, just because no other driver does this, but if it helps with backtraces in the future maybe its okay.
Dave.
Hi, Dave.
-----Original Message----- From: Dave Airlie [mailto:airlied@gmail.com] Sent: Saturday, October 01, 2011 3:07 PM To: Inki Dae Cc: airlied@linux.ie; dri-devel@lists.freedesktop.org; kyungmin.park@samsung.com Subject: Re: [RESEND] An inquiry about DRM Driver for Samsung SoC Exynos4.
You can refer to these patches I sent from links below. v1: < https://lwn.net/Articles/454380/ > v2: < http://www.spinics.net/lists/kernel/msg1224275.html > v3: < http://www.spinics.net/lists/dri-devel/msg13755.html > v4: < http://permalink.gmane.org/gmane.comp.video.dri.devel/60439 > v5: < http://comments.gmane.org/gmane.comp.video.dri.devel/60802 >
and also you can refer to our working repository below. < http://git.infradead.org/users/kmpark/linux-2.6-samsung > Branch name
:
dev/samsung-drm
If there are any problems regarding our driver then please give me your comments or advices so that we could prepare next patch; otherwise we
wish
our driver be applied to mainline.
I'll probably give it one more review early next week, but I might merge it to -next, if I don't find anything seriously wrong.
We would look forward to your comments. thank you.
I still dislike the samsung_drm_ everywhere, just because no other driver does this, but if it helps with backtraces in the future maybe its okay.
Ok, get it. we would consider using 'exynos' instead of 'samsung' seriously if you dont want 'samsung' prefix and then with your comments, the change would be done on PATCH v6.
Dave.
Thanks, Inki Dae.
We would look forward to your comments. thank you.
I think the only thing I can see wanting changing at this point is to add padding to the offset ioctl.
struct drm_samsung_gem_map_off { unsigned int handle; uint64_t offset; };
just add an unsigned int pad; between the two members so the 64-bit fields get natively aligned.
I still dislike the samsung_drm_ everywhere, just because no other driver does this, but if it helps with backtraces in the future maybe its okay.
Ok, get it. we would consider using 'exynos' instead of 'samsung' seriously if you don’t want 'samsung' prefix and then with your comments, the change would be done on PATCH v6.
Yeah I think it would be a good idea to just go with exynos, and then I'll merge V6 into -next.
Dave.
Hi, Dave.
-----Original Message----- From: Dave Airlie [mailto:airlied@gmail.com] Sent: Monday, October 03, 2011 7:17 PM To: Inki Dae Cc: airlied@linux.ie; dri-devel@lists.freedesktop.org; kyungmin.park@samsung.com Subject: Re: [RESEND] An inquiry about DRM Driver for Samsung SoC Exynos4.
We would look forward to your comments. thank you.
I think the only thing I can see wanting changing at this point is to add padding to the offset ioctl.
struct drm_samsung_gem_map_off { unsigned int handle; uint64_t offset; };
just add an unsigned int pad; between the two members so the 64-bit fields get natively aligned.
Ok, get it. I will add the padding. thank you.
I still dislike the samsung_drm_ everywhere, just because no other driver does this, but if it helps with backtraces in the future maybe its okay.
Ok, get it. we would consider using 'exynos' instead of 'samsung'
seriously
if you don't want 'samsung' prefix and then with your comments, the
change
would be done on PATCH v6.
Yeah I think it would be a good idea to just go with exynos, and then I'll merge V6 into -next.
Dave.
Ok, get it. I will send patch V6 soon. thank you for your review.
dri-devel@lists.freedesktop.org
-
Dave Airlie -
Inki Dae