From: Gao Chao gaochao49@huawei.com
If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m, bulding fails:
drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe': panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to `drm_panel_dp_aux_backlight' make: *** [vmlinux] Error 1
Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to fix this error.
Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel") Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Gao Chao gaochao49@huawei.com Reviewed-by: Douglas Anderson dianders@chromium.org --- v1->v2: fix Signed-off-by name --- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 38799effd00a..4f1f004b3c54 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20 depends on OF depends on BACKLIGHT_CLASS_DEVICE depends on PM + select DRM_DISPLAY_DP_HELPER + select DRM_DISPLAY_HELPER select DRM_DP_AUX_BUS help DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't -- 2.17.1
Hi,
On Mon, May 23, 2022 at 7:46 PM gaochao gaochao49@huawei.com wrote:
From: Gao Chao gaochao49@huawei.com
If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m, bulding fails:
drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe': panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to `drm_panel_dp_aux_backlight' make: *** [vmlinux] Error 1
Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and CONFIG_DRM_DISPLAY_HELPER to fix this error.
Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel") Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Gao Chao gaochao49@huawei.com Reviewed-by: Douglas Anderson dianders@chromium.org
v1->v2: fix Signed-off-by name
drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
The patch this is "fixing" is in mainline so theoretically this should land in drm-misc-fixes, but it gets messy because it would need to be adapted because commit 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module") isn't in mainline. Since this doesn't feel urgent, I'm landing this in drm-misc/drm-misc-next.
a67664860f78 drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
-Doug
dri-devel@lists.freedesktop.org