Hi,
Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.
As soon as the intel driver is loaded, the monitor shuts off (standby mode). Inspecting /sys/class/drm/card0-HDMI-A-1/status reports "disconnected". When it is working, this attribute says "connected".
There is nothing unusual printed to dmesg.
Bisection pinpoints the following:
237ed86c693d8a8e4db476976aeb30df4deac74b is the first bad commit commit 237ed86c693d8a8e4db476976aeb30df4deac74b Author: Sonika Jindal sonika.jindal@intel.com Date: Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid [...] Signed-off-by: Shashank Sharma shashank.sharma@intel.com Signed-off-by: Sonika Jindal sonika.jindal@intel.com Reviewed-by: Rodrigo Vivi rodrigo.vivi@intel.com Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch
The commit does not revert cleanly, but this patch resolves the issue:
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index e6c035b0fc1c..8cefb9105f26 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1393,7 +1393,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
intel_hdmi_unset_edid(connector);
- if (intel_hdmi_set_edid(connector, live_status)) { + if (intel_hdmi_set_edid(connector, true)) { struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
hdmi_to_dig_port(intel_hdmi)->base.type = INTEL_OUTPUT_HDMI;
Let me know if you need any more info.
Thanks, Nick
Can you please check if you have following patch: "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d Author: Gary Wang gary.c.wang@intel.com Date: Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking"
For some monitors, 30ms delay is not good enough to report the live status correctly.
Does the same system works with any other monitor?
Daniel,
Can this be related to the live status bits on g45? "commit 0ce99f749b3834edeb500e17d6ad17e86b60ff83 Author: Daniel Vetter daniel.vetter@ffwll.ch Date: Fri Jul 26 11:27:49 2013 +0200
drm/i915: fix gen4 digital port hotplug definitions"
Regards, Sonika
On 1/20/2016 3:56 AM, Nick Bowler wrote:
Hi,
Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.
As soon as the intel driver is loaded, the monitor shuts off (standby mode). Inspecting /sys/class/drm/card0-HDMI-A-1/status reports "disconnected". When it is working, this attribute says "connected".
There is nothing unusual printed to dmesg.
Bisection pinpoints the following:
237ed86c693d8a8e4db476976aeb30df4deac74b is the first bad commit commit 237ed86c693d8a8e4db476976aeb30df4deac74b Author: Sonika Jindal sonika.jindal@intel.com Date: Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid [...] Signed-off-by: Shashank Sharma <shashank.sharma@intel.com> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>The commit does not revert cleanly, but this patch resolves the issue:
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index e6c035b0fc1c..8cefb9105f26 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1393,7 +1393,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
intel_hdmi_unset_edid(connector);
if (intel_hdmi_set_edid(connector, live_status)) {
if (intel_hdmi_set_edid(connector, true)) { struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); hdmi_to_dig_port(intel_hdmi)->base.type = INTEL_OUTPUT_HDMI;Let me know if you need any more info.
Thanks, Nick
Hi,
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
Can you please check if you have following patch: "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d Author: Gary Wang gary.c.wang@intel.com Date: Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking"
Yes, that patch seems to be present in 4.4.
Does the same system works with any other monitor?
I'll see if I can find another to try.
Thanks, Nick
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote:
Hi,
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
Can you please check if you have following patch: "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d Author: Gary Wang gary.c.wang@intel.com Date: Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking"
Yes, that patch seems to be present in 4.4.
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
On 1/21/2016 8:59 AM, Nick Bowler wrote:
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote:
Hi,
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
Can you please check if you have following patch: "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d Author: Gary Wang gary.c.wang@intel.com Date: Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking"
Yes, that patch seems to be present in 4.4.
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors? Do you have any other system other than G45?
Shashank, Do you suggest anything else which Nick can try?
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote:
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V - Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Thanks, Nick
On 2016-01-21, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote:
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Cheers, Nick
On 1/28/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote:
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers, Nick
Hi Nick,
Sonika is OOO for this week. AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.
As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
Regards Shashank -----Original Message----- From: Nick Bowler [mailto:nbowler@draconx.ca] Sent: Tuesday, February 09, 2016 10:03 PM To: Jindal, Sonika Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Daniel Vetter; Sharma, Shashank Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
On 1/28/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote:
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers, Nick
On Tue, Feb 09, 2016 at 04:39:21PM +0000, Sharma, Shashank wrote:
Hi Nick,
Sonika is OOO for this week. AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.
As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 188ad5de020f..80c08016e522 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -3302,9 +3302,9 @@ enum skl_disp_power_wells { * Please check the detailed lore in the commit message for for experimental * evidence. */ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) /* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
On Tue, Feb 09, 2016 at 07:03:51PM +0200, Ville Syrjälä wrote:
On Tue, Feb 09, 2016 at 04:39:21PM +0000, Sharma, Shashank wrote:
Hi Nick,
Sonika is OOO for this week. AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.
As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 188ad5de020f..80c08016e522 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {
- Please check the detailed lore in the commit message for for experimental
- evidence.
*/ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) /* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Just retested the g4x machine here, and port B is definitely on bit 29, port C on bit 28. No port D on ELK, so can't check that. So either someone made a fumble when they tested this originally, or some boards are just wired incorrectly, or CTG is where it was tested and that actually disagrees with the spec for some reason.
-- 2.4.10
Regards Shashank -----Original Message----- From: Nick Bowler [mailto:nbowler@draconx.ca] Sent: Tuesday, February 09, 2016 10:03 PM To: Jindal, Sonika Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Daniel Vetter; Sharma, Shashank Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
On 1/28/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote:
On 1/20/16, Nick Bowler nbowler@draconx.ca wrote: > On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
>> Does the same system works with any other monitor? > I'll see if I can find another to try. I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers, Nick _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, Feb 09, 2016 at 07:36:41PM +0200, Ville Syrjälä wrote:
On Tue, Feb 09, 2016 at 07:03:51PM +0200, Ville Syrjälä wrote:
On Tue, Feb 09, 2016 at 04:39:21PM +0000, Sharma, Shashank wrote:
Hi Nick,
Sonika is OOO for this week. AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.
As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 188ad5de020f..80c08016e522 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {
- Please check the detailed lore in the commit message for for experimental
- evidence.
*/ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) /* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Just retested the g4x machine here, and port B is definitely on bit 29, port C on bit 28. No port D on ELK, so can't check that. So either someone made a fumble when they tested this originally, or some boards are just wired incorrectly, or CTG is where it was tested and that actually disagrees with the spec for some reason.
I just tried to trawl the w/a database for anything interesting, and the only thing I ran across was WaDPHDMISupriousHpd (without any description of course) for both elk and ctg. Nothing else really relevant looking.
So I think we should get someone to double check this on ctg, and then we can decide whether we change the bits just for elk or for ctg as well.
-- 2.4.10
Regards Shashank -----Original Message----- From: Nick Bowler [mailto:nbowler@draconx.ca] Sent: Tuesday, February 09, 2016 10:03 PM To: Jindal, Sonika Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Daniel Vetter; Sharma, Shashank Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
On 1/28/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote: > On 1/20/16, Nick Bowler nbowler@draconx.ca wrote: >> On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
>>> Does the same system works with any other monitor? >> I'll see if I can find another to try. > I tried another monitor, and the same problem occurs. Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers, Nick _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
I checked locally in BDC, Seems we don't have these boards available with us (in working state).
Regards Shashank -----Original Message----- From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com] Sent: Tuesday, February 09, 2016 11:53 PM To: Sharma, Shashank Cc: Nick Bowler; Daniel Vetter; linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
On Tue, Feb 09, 2016 at 07:36:41PM +0200, Ville Syrjälä wrote:
On Tue, Feb 09, 2016 at 07:03:51PM +0200, Ville Syrjälä wrote:
On Tue, Feb 09, 2016 at 04:39:21PM +0000, Sharma, Shashank wrote:
Hi Nick,
Sonika is OOO for this week. AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.
As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 188ad5de020f..80c08016e522 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {
- Please check the detailed lore in the commit message for for experimental
- evidence.
*/ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) /* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Just retested the g4x machine here, and port B is definitely on bit 29, port C on bit 28. No port D on ELK, so can't check that. So either someone made a fumble when they tested this originally, or some boards are just wired incorrectly, or CTG is where it was tested and that actually disagrees with the spec for some reason.
I just tried to trawl the w/a database for anything interesting, and the only thing I ran across was WaDPHDMISupriousHpd (without any description of course) for both elk and ctg. Nothing else really relevant looking.
So I think we should get someone to double check this on ctg, and then we can decide whether we change the bits just for elk or for ctg as well.
-- 2.4.10
Regards Shashank -----Original Message----- From: Nick Bowler [mailto:nbowler@draconx.ca] Sent: Tuesday, February 09, 2016 10:03 PM To: Jindal, Sonika Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Daniel Vetter; Sharma, Shashank Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
On 1/28/16, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Nick Bowler nbowler@draconx.ca wrote:
On 2016-01-21, Jindal, Sonika sonika.jindal@intel.com wrote:
On 1/21/2016 8:59 AM, Nick Bowler wrote: > On 1/20/16, Nick Bowler nbowler@draconx.ca wrote: >> On 2016-01-20, Jindal, Sonika sonika.jindal@intel.com wrote:
[...]
>>> Does the same system works with any other monitor? >> I'll see if I can find another to try. > I tried another monitor, and the same problem occurs. Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers, Nick _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Ville Syrjälä Intel OTC
On 2/9/16, Ville Syrjälä ville.syrjala@linux.intel.com wrote:
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 188ad5de020f..80c08016e522 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {
- Please check the detailed lore in the commit message for for
experimental
- evidence.
*/ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) /* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Well, I applied this on 4.5-rc3 and it seems to fix things.
Thanks, Nick
On Tue, 09 Feb 2016, Nick Bowler nbowler@draconx.ca wrote:
On 2/9/16, Ville Syrjälä ville.syrjala@linux.intel.com wrote:
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 188ad5de020f..80c08016e522 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {
- Please check the detailed lore in the commit message for for
experimental
- evidence.
*/ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29) /* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27) #define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Well, I applied this on 4.5-rc3 and it seems to fix things.
Ville, please do a proper patch, using your best judgement on elk vs. ctg difference.
BR, Jani.
Thanks, Nick _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Jani Nikula -
Jindal, Sonika -
Nick Bowler -
Sharma, Shashank -
Ville Syrjälä