Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked up as a whole to have that case finally closed. Greg? Are you interested in picking it up?
Wolfram
Tushar Behera (2): DRM: Armada: Use devm_ioremap_resource lib: devres: Remove deprecated devm_request_and_ioremap
Wolfram Sang (1): bus: brcmstb_gisb: Use devm_ioremap_resource
Documentation/driver-model/devres.txt | 1 - drivers/bus/brcmstb_gisb.c | 6 +++--- drivers/gpu/drm/armada/armada_crtc.c | 8 +++----- include/linux/device.h | 2 -- lib/devres.c | 28 ---------------------------- 5 files changed, 6 insertions(+), 39 deletions(-)
From: Tushar Behera tushar.behera@linaro.org
While at it, propagate the error code.
Signed-off-by: Tushar Behera tushar.behera@linaro.org Signed-off-by: Wolfram Sang wsa@the-dreams.de --- drivers/gpu/drm/armada/armada_crtc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c index 81c34f949dfc..3aedf9e993e6 100644 --- a/drivers/gpu/drm/armada/armada_crtc.c +++ b/drivers/gpu/drm/armada/armada_crtc.c @@ -1039,11 +1039,9 @@ int armada_drm_crtc_create(struct drm_device *dev, unsigned num, if (ret) return ret;
- base = devm_request_and_ioremap(dev->dev, res); - if (!base) { - DRM_ERROR("failed to ioremap register\n"); - return -ENOMEM; - } + base = devm_ioremap_resource(dev->dev, res); + if (IS_ERR(base)) + return PTR_ERR(base);
dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL); if (!dcrtc) {
On Thu, Jun 19, 2014 at 08:48:58PM +0200, Wolfram Sang wrote:
Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked up as a whole to have that case finally closed. Greg? Are you interested in picking it up?
Note to self: Add Greg to CC list when asking him...
On Friday, June 20, 2014 3:49 AM, Wolfram Sang wrote:
Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked up as a whole to have that case finally closed. Greg? Are you interested in picking it up?
(+cc Greg Kroah-Hartman)
I already sent the same patch as one single patch to Greg Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. [2] Thank you.
[1] https://lkml.org/lkml/2014/6/11/26 [2] https://lkml.org/lkml/2014/6/11/649
Best regards, Jingoo Han
Wolfram
Tushar Behera (2): DRM: Armada: Use devm_ioremap_resource lib: devres: Remove deprecated devm_request_and_ioremap
Wolfram Sang (1): bus: brcmstb_gisb: Use devm_ioremap_resource
Documentation/driver-model/devres.txt | 1 - drivers/bus/brcmstb_gisb.c | 6 +++--- drivers/gpu/drm/armada/armada_crtc.c | 8 +++----- include/linux/device.h | 2 -- lib/devres.c | 28 ---------------------------- 5 files changed, 6 insertions(+), 39 deletions(-)
-- 2.0.0
On Fri, Jun 20, 2014 at 11:36:03AM +0900, Jingoo Han wrote:
On Friday, June 20, 2014 3:49 AM, Wolfram Sang wrote:
Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked up as a whole to have that case finally closed. Greg? Are you interested in picking it up?
(+cc Greg Kroah-Hartman)
I already sent the same patch as one single patch to Greg Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. [2] Thank you.
[1] https://lkml.org/lkml/2014/6/11/26 [2] https://lkml.org/lkml/2014/6/11/649
Yeah, I'll go apply that right now while I'm remembering it :)
thanks,
greg k-h
I already sent the same patch as one single patch to Greg Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. [2] Thank you.
[1] https://lkml.org/lkml/2014/6/11/26 [2] https://lkml.org/lkml/2014/6/11/649
Yeah, I'll go apply that right now while I'm remembering it :)
Yay, great! Thank you both!
On Thu, Jun 19, 2014 at 07:59:57PM -0700, 'Greg Kroah-Hartman' wrote:
On Fri, Jun 20, 2014 at 11:36:03AM +0900, Jingoo Han wrote:
On Friday, June 20, 2014 3:49 AM, Wolfram Sang wrote:
Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked up as a whole to have that case finally closed. Greg? Are you interested in picking it up?
(+cc Greg Kroah-Hartman)
I already sent the same patch as one single patch to Greg Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. [2] Thank you.
[1] https://lkml.org/lkml/2014/6/11/26 [2] https://lkml.org/lkml/2014/6/11/649
Yeah, I'll go apply that right now while I'm remembering it :)
For the patch above:
Reviewed-by: Wolfram Sang wsa@the-dreams.de
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 06/20/2014 02:15 PM, Wolfram Sang wrote:
On Thu, Jun 19, 2014 at 07:59:57PM -0700, 'Greg Kroah-Hartman' wrote:
On Fri, Jun 20, 2014 at 11:36:03AM +0900, Jingoo Han wrote:
On Friday, June 20, 2014 3:49 AM, Wolfram Sang wrote:
Pretty much a year ago, Tushar cleaned up a lot of deprecated uses of devm_request_and_ioremap, yet some remains are still left. Remove the last two users, and let the function rest in peace. I'd suggest that this series is picked up as a whole to have that case finally closed. Greg? Are you interested in picking it up?
(+cc Greg Kroah-Hartman)
I already sent the same patch as one single patch to Greg Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. [2] Thank you.
[1] https://lkml.org/lkml/2014/6/11/26 [2] https://lkml.org/lkml/2014/6/11/649
Yeah, I'll go apply that right now while I'm remembering it :)
For the patch above:
Reviewed-by: Wolfram Sang wsa@the-dreams.de
If it is still not late,
Acked-by: Tushar Behera trblinux@gmail.com
- -- Tushar Behera
dri-devel@lists.freedesktop.org
-
'Greg Kroah-Hartman' -
Jingoo Han -
Tushar Behera -
Wolfram Sang