From: Matthias Brugger matthias.bgg@gmail.com
The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data. As all this is done later already, just delete the call to of_device_get_match_data.
Signed-off-by: Matthias Brugger matthias.bgg@gmail.com --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index e2bb0d19ef99..63ec92ba0e92 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev) if (!private) return -ENOMEM;
- private->data = of_device_get_match_data(dev); private->mmsys_dev = dev->parent; if (!private->mmsys_dev) { dev_err(dev, "Failed to get MMSYS device\n");
Hi, Matthias:
matthias.bgg@kernel.org 於 2020年5月18日 週一 下午7:23寫道：
From: Matthias Brugger matthias.bgg@gmail.com
The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data. As all this is done later already, just delete the call to of_device_get_match_data.
Reviewed-by: Chun-Kuang Hu chunkuang.hu@kernel.org
Signed-off-by: Matthias Brugger matthias.bgg@gmail.com
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index e2bb0d19ef99..63ec92ba0e92 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev) if (!private) return -ENOMEM;
private->data = of_device_get_match_data(dev); private->mmsys_dev = dev->parent; if (!private->mmsys_dev) { dev_err(dev, "Failed to get MMSYS device\n");-- 2.26.2
Hi Matthias,
On 18/5/20 13:22, matthias.bgg@kernel.org wrote:
From: Matthias Brugger matthias.bgg@gmail.com
The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data. As all this is done later already, just delete the call to of_device_get_match_data.
Signed-off-by: Matthias Brugger matthias.bgg@gmail.com
Reviewed-by: Enric Balletbo i Serra enric.balletbo@collabora.com
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index e2bb0d19ef99..63ec92ba0e92 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev) if (!private) return -ENOMEM;
- private->data = of_device_get_match_data(dev); private->mmsys_dev = dev->parent; if (!private->mmsys_dev) { dev_err(dev, "Failed to get MMSYS device\n");
Hi, Matthias:
matthias.bgg@kernel.org 於 2020年5月18日 週一 下午7:23寫道：
From: Matthias Brugger matthias.bgg@gmail.com
The driver will be loaded by via a platform device. So we will need to get the device_node from the parent device. Depending on this we will set the driver data. As all this is done later already, just delete the call to of_device_get_match_data.
Applied to mediatek-drm-fixes [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?...
Regards, Chun-Kuang.
Signed-off-by: Matthias Brugger matthias.bgg@gmail.com
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index e2bb0d19ef99..63ec92ba0e92 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev) if (!private) return -ENOMEM;
private->data = of_device_get_match_data(dev); private->mmsys_dev = dev->parent; if (!private->mmsys_dev) { dev_err(dev, "Failed to get MMSYS device\n");-- 2.26.2
dri-devel@lists.freedesktop.org
-
Chun-Kuang Hu -
Enric Balletbo i Serra -
matthias.bgg＠kernel.org