Hi Colin,

On Sat, 2018-01-06 at 17:28 +0000, Colin King wrote:

From: Colin Ian King colin.king@canonical.com

Don't populate the const read-only array 'int_reg' on the stack but instead make it static. Makes the object code smaller by over 80 bytes:

Before: text data bss dec hex filename 28024 8936 192 37152 9120 drivers/gpu/ipu-v3/ipu-common.o

After: text data bss dec hex filename 27794 9080 192 37066 90ca drivers/gpu/ipu-v3/ipu-common.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King colin.king@canonical.com

Thank you for the patch.

---

drivers/gpu/ipu-v3/ipu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 658fa2d3e40c..babf1aee7ca5 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1089,7 +1089,7 @@ static void ipu_irq_handler(struct irq_desc *desc) { struct ipu_soc *ipu = irq_desc_get_handler_data(desc); struct irq_chip *chip = irq_desc_get_chip(desc);

• const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14};

• static const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14};

  chained_irq_enter(chip, desc);

There's the same issue in ipu_irq_err_handler right below:

----------8<---------- diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index babf1aee7ca58..48685cddbad1b 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1102,7 +1102,7 @@ static void ipu_err_irq_handler(struct irq_desc *desc)  {         struct ipu_soc *ipu = irq_desc_get_handler_data(desc);         struct irq_chip *chip = irq_desc_get_chip(desc); -       const int int_reg[] = { 4, 5, 8, 9}; +       static const int int_reg[] = { 4, 5, 8, 9};           chained_irq_enter(chip, desc);   ---------->8----------

If you don't mind, I'll amend this change.

regards Philipp