dri-devel October 2010

dri-devel@lists.freedesktop.org

76 participants
345 discussions

[Bug 25544] KMS/R200: No texture bound to unit 1
by bugzilla-daemon＠freedesktop.org 27 Oct '10

27 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 --- Comment #14 from Daniel Richard G. <skunk(a)iskunk.org> 2010-10-26 22:36:23 PDT --- Confirmed here too! gltron now runs perfectly, as does OpenArena. Thank you, Alex, for pouncing on this one. There's now a GPU-lockup problem (that existed before this fix) that I've reported as bug #31150. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 25544] KMS/R200: No texture bound to unit 1
by bugzilla-daemon＠freedesktop.org 27 Oct '10

27 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #13 from Alex Deucher <agd5f(a)yahoo.com> 2010-10-26 22:03:19 PDT --- I've sent the patch to Dave for upstream inclusion. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[PATCH] drm/radeon/kms: fix handling of tex lookup disable in cs checker on r2xx
by Alex Deucher 27 Oct '10

27 Oct '10

There are cases when multiple texture units have to be enabled, but not actually used to sample. This patch checks to see if the lookup_disable bit is set and if so, skips the texture check. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=25544 Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> Cc: stable(a)kernel.org --- drivers/gpu/drm/radeon/r100.c | 3 +++ drivers/gpu/drm/radeon/r100_track.h | 1 + drivers/gpu/drm/radeon/r200.c | 2 ++ drivers/gpu/drm/radeon/radeon_reg.h | 1 + 4 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index cde67d1..91cdd3a 100644 --- a/drivers/gpu/drm/radeon/r100.c +++ b/drivers/gpu/drm/radeon/r100.c @@ -3268,6 +3268,8 @@ static int r100_cs_track_texture_check(struct radeon_device *rdev, for (u = 0; u < track->num_texture; u++) { if (!track->textures[u].enabled) continue; + if (track->textures[u].lookup_disable) + continue; robj = track->textures[u].robj; if (robj == NULL) { DRM_ERROR("No texture bound to unit %u\n", u); @@ -3502,6 +3504,7 @@ void r100_cs_track_clear(struct radeon_device *rdev, struct r100_cs_track *track track->textures[i].robj = NULL; /* CS IB emission code makes sure texture unit are disabled */ track->textures[i].enabled = false; + track->textures[i].lookup_disable = false; track->textures[i].roundup_w = true; track->textures[i].roundup_h = true; if (track->separate_cube) diff --git a/drivers/gpu/drm/radeon/r100_track.h b/drivers/gpu/drm/radeon/r100_track.h index f47cdca..af65600 100644 --- a/drivers/gpu/drm/radeon/r100_track.h +++ b/drivers/gpu/drm/radeon/r100_track.h @@ -46,6 +46,7 @@ struct r100_cs_track_texture { unsigned height_11; bool use_pitch; bool enabled; + bool lookup_disable; bool roundup_w; bool roundup_h; unsigned compress_format; diff --git a/drivers/gpu/drm/radeon/r200.c b/drivers/gpu/drm/radeon/r200.c index 0266d72..d2408c3 100644 --- a/drivers/gpu/drm/radeon/r200.c +++ b/drivers/gpu/drm/radeon/r200.c @@ -447,6 +447,8 @@ int r200_packet0_check(struct radeon_cs_parser *p, track->textures[i].width = 1 << ((idx_value >> RADEON_TXFORMAT_WIDTH_SHIFT) & RADEON_TXFORMAT_WIDTH_MASK); track->textures[i].height = 1 << ((idx_value >> RADEON_TXFORMAT_HEIGHT_SHIFT) & RADEON_TXFORMAT_HEIGHT_MASK); } + if (idx_value & R200_TXFORMAT_LOOKUP_DISABLE) + track->textures[i].lookup_disable = true; switch ((idx_value & RADEON_TXFORMAT_FORMAT_MASK)) { case R200_TXFORMAT_I8: case R200_TXFORMAT_RGB332: diff --git a/drivers/gpu/drm/radeon/radeon_reg.h b/drivers/gpu/drm/radeon/radeon_reg.h index c332f46..6492881 100644 --- a/drivers/gpu/drm/radeon/radeon_reg.h +++ b/drivers/gpu/drm/radeon/radeon_reg.h @@ -2836,6 +2836,7 @@ # define R200_TXFORMAT_ST_ROUTE_STQ5 (5 << 24) # define R200_TXFORMAT_ST_ROUTE_MASK (7 << 24) # define R200_TXFORMAT_ST_ROUTE_SHIFT 24 +# define R200_TXFORMAT_LOOKUP_DISABLE (1 << 27) # define R200_TXFORMAT_ALPHA_MASK_ENABLE (1 << 28) # define R200_TXFORMAT_CHROMA_KEY_ENABLE (1 << 29) # define R200_TXFORMAT_CUBIC_MAP_ENABLE (1 << 30) -- 1.7.1.1

1 0

[Bug 25544] KMS/R200: No texture bound to unit 1
by bugzilla-daemon＠freedesktop.org 27 Oct '10

27 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 --- Comment #12 from Nicholas Miell <nmiell(a)gmail.com> 2010-10-26 18:31:21 PDT --- I've tested the patch and it works. Thanks. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[PATCH] drm/radeon/kms: fix r6xx/7xx 1D tiling CS checker
by Alex Deucher 27 Oct '10

27 Oct '10

broken by: drm/radeon/r600: fix tiling issues in CS checker. Signed-off-by: Alex Deucher <alexdeucher(a)gmail.com> --- drivers/gpu/drm/radeon/r600_cs.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 7e44b5a..aec0944 100644 --- a/drivers/gpu/drm/radeon/r600_cs.c +++ b/drivers/gpu/drm/radeon/r600_cs.c @@ -190,6 +190,8 @@ static inline int r600_cs_track_validate_cb(struct radeon_cs_parser *p, int i) height = slice_tile_max / (pitch * 8); if (height > 8192) height = 8192; + if (height > 7) + height &= ~0x7; array_mode = G_0280A0_ARRAY_MODE(track->cb_color_info[i]); switch (array_mode) { case V_0280A0_ARRAY_LINEAR_GENERAL: -- 1.7.1.1

1 1

[Bug 25544] KMS/R200: No texture bound to unit 1
by bugzilla-daemon＠freedesktop.org 26 Oct '10

26 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33643|0 |1 is obsolete| | --- Comment #11 from Alex Deucher <agd5f(a)yahoo.com> 2010-10-26 14:21:18 PDT --- Created an attachment (id=39799) View: https://bugs.freedesktop.org/attachment.cgi?id=39799 Review: https://bugs.freedesktop.org/review?bug=25544&attachment=39799 fix the drm CS checker This patch should fix the issue. Please test and I'll get it upstream and into stable. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 25544] KMS/R200: No texture bound to unit 1
by bugzilla-daemon＠freedesktop.org 26 Oct '10

26 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 --- Comment #10 from Daniel Richard G. <skunk(a)iskunk.org> 2010-10-26 13:46:12 PDT --- I'm looking at r100_cs_track_texture_check() in linux-2.6.36/drivers/gpu/drm/radeon/r100.c (starting at line 3217). What if instead of an unconditional return, you were to do e.g. /* XXX: Disable texture check until R200 fake texture enable supported */ if (rdev->family == CHIP_R200) return 0; ? Other parts of that function are already conditionalized based on chipset. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 25544] KMS/R200: No texture bound to unit 1
by bugzilla-daemon＠freedesktop.org 26 Oct '10

26 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 Alan Swanson <swanson(a)ukfsn.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|KMS/R200: CS section size |KMS/R200: No texture bound |missmatch start at |to unit 1 |(r200_state_init.c,tex_emit | |_mm,703) 5 vs 9 | --- Comment #9 from Alan Swanson <swanson(a)ukfsn.org> 2010-10-26 13:04:11 PDT --- Not as far as I'm aware unfortunately. Texture checking came in with the KMS rewrite IIRC. (Updated bug summary to match problem.) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 25544] KMS/R200: CS section size missmatch start at (r200_state_init.c,tex_emit_mm,703) 5 vs 9
by bugzilla-daemon＠freedesktop.org 26 Oct '10

26 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25544 --- Comment #8 from Daniel Richard G. <skunk(a)iskunk.org> 2010-10-26 12:41:59 PDT --- Alan, can texture checking be disabled for R200 in production code? Building a patched kernel module isn't a feasible option for most users, and the effect of this bug is to make the 3D hardware basically unusable. Was this same checking even done in the past? Before all the KMS upheaval, the R200 driver was rock-solid. (R200 was, I believe, the last Radeon release to have full 3D specs before the long dry spell that only recently ended.) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[PATCH 0/3] radeon: add pageflip support
by Alex Deucher 26 Oct '10

26 Oct '10

This set of patches adds pageflipping support for radeon. There are two drm patches and one ddx patch required. The drm patches are against Dave's drm-next branch and the ddx patch is against git master. So far it's been lightly tested with openarena on a variety of radeons. Feedback appreciated. Alex

1 5

← Newer
1
...
16
17
18
19
20
21
22
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2010