dri-devel October 2010

dri-devel@lists.freedesktop.org

76 participants
345 discussions

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34
by bugzilla-daemon＠freedesktop.org 21 Oct '10

21 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=28402 --- Comment #83 from Martin Steigerwald <Martin(a)Lichtvoll.de> 2010-10-21 10:26:12 PDT --- Now testing 2.6.36 + your v2 patch. Three reboots all is well so far - I do not expect any surprises, since mem mapping seems to be the same: martin@shambhala:~> dmesg | grep "radeon" | egrep -i "(gtt|vram)" radeon 0000:01:00.0: GTT: 256M 0xD0000000 - 0xDFFFFFFF radeon 0000:01:00.0: VRAM: 64M 0x00000000 - 0x03FFFFFF (64M used) [drm] radeon: … [View More]

1 0

[PATCH] drm/radeon/r600: fix tiling issues in CS checker.
by Dave Airlie 21 Oct '10

21 Oct '10

From: Dave Airlie <airlied(a)redhat.com> The CS checker had some incorrect alignment requirements for 2D surfaces, this made rendering to mipmap levels that were 2D broken. Also the CB height was being worked out from the BO size, this doesn't work at all when rendering mipmap levels, instead we work out what height userspace wanted from slice max and use that to check it fits inside the BO, however the DDX send the wrong slice max for an unaligned buffer so we have to workaround for … [View More]that even though its a userspace bug. Signed-off-by: Dave Airlie <airlied(a)redhat.com> --- drivers/gpu/drm/radeon/r600_cs.c | 29 ++++++++++++++++++++--------- drivers/gpu/drm/radeon/radeon_drv.c | 3 ++- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 820c121..8c82e43 100644 --- a/drivers/gpu/drm/radeon/r600_cs.c +++ b/drivers/gpu/drm/radeon/r600_cs.c @@ -170,6 +170,7 @@ static inline int r600_cs_track_validate_cb(struct radeon_cs_parser *p, int i) struct r600_cs_track *track = p->track; u32 bpe = 0, pitch, slice_tile_max, size, tmp, height, pitch_align; volatile u32 *ib = p->ib->ptr; + unsigned array_mode; if (G_0280A0_TILE_MODE(track->cb_color_info[i])) { dev_warn(p->dev, "FMASK or CMASK buffer are not supported by this kernel\n"); @@ -185,12 +186,12 @@ static inline int r600_cs_track_validate_cb(struct radeon_cs_parser *p, int i) /* pitch is the number of 8x8 tiles per row */ pitch = G_028060_PITCH_TILE_MAX(track->cb_color_size[i]) + 1; slice_tile_max = G_028060_SLICE_TILE_MAX(track->cb_color_size[i]) + 1; - height = size / (pitch * 8 * bpe); + slice_tile_max *= 64; + height = slice_tile_max / (pitch * 8); if (height > 8192) height = 8192; - if (height > 7) - height &= ~0x7; - switch (G_0280A0_ARRAY_MODE(track->cb_color_info[i])) { + array_mode = G_0280A0_ARRAY_MODE(track->cb_color_info[i]); + switch (array_mode) { case V_0280A0_ARRAY_LINEAR_GENERAL: /* technically height & 0x7 */ break; @@ -222,7 +223,7 @@ static inline int r600_cs_track_validate_cb(struct radeon_cs_parser *p, int i) break; case V_0280A0_ARRAY_2D_TILED_THIN1: pitch_align = max((u32)track->nbanks, - (u32)(((track->group_size / 8) / (bpe * track->nsamples)) * track->nbanks)); + (u32)(((track->group_size / 8) / (bpe * track->nsamples)) * track->nbanks)) / 8; if (!IS_ALIGNED(pitch, pitch_align)) { dev_warn(p->dev, "%s:%d cb pitch (%d) invalid\n", __func__, __LINE__, pitch); @@ -243,8 +244,18 @@ static inline int r600_cs_track_validate_cb(struct radeon_cs_parser *p, int i) /* check offset */ tmp = height * pitch * 8 * bpe; if ((tmp + track->cb_color_bo_offset[i]) > radeon_bo_size(track->cb_color_bo[i])) { - dev_warn(p->dev, "%s offset[%d] %d too big\n", __func__, i, track->cb_color_bo_offset[i]); - return -EINVAL; + if (array_mode == V_0280A0_ARRAY_LINEAR_GENERAL) { + /* the initial DDX does bad things with the CB size occasionally */ + /* it rounds up height too far for slice tile max but the BO is smaller */ + tmp = (height - 7) * 8 * bpe; + if ((tmp + track->cb_color_bo_offset[i]) > radeon_bo_size(track->cb_color_bo[i])) { + dev_warn(p->dev, "%s offset[%d] %d %d %d too big\n", __func__, i, track->cb_color_bo_offset[i], tmp, radeon_bo_size(track->cb_color_bo[i])); + return -EINVAL; + } + } else { + dev_warn(p->dev, "%s offset[%d] %d %d %d too big\n", __func__, i, track->cb_color_bo_offset[i], tmp, radeon_bo_size(track->cb_color_bo[i])); + return -EINVAL; + } } if (!IS_ALIGNED(track->cb_color_bo_offset[i], track->group_size)) { dev_warn(p->dev, "%s offset[%d] %d not aligned\n", __func__, i, track->cb_color_bo_offset[i]); @@ -361,7 +372,7 @@ static int r600_cs_track_check(struct radeon_cs_parser *p) break; case V_028010_ARRAY_2D_TILED_THIN1: pitch_align = max((u32)track->nbanks, - (u32)(((track->group_size / 8) / bpe) * track->nbanks)); + (u32)(((track->group_size / 8) / bpe) * track->nbanks)) / 8; if (!IS_ALIGNED(pitch, pitch_align)) { dev_warn(p->dev, "%s:%d db pitch (%d) invalid\n", __func__, __LINE__, pitch); @@ -1139,7 +1150,7 @@ static inline int r600_check_texture_resource(struct radeon_cs_parser *p, u32 i break; case V_038000_ARRAY_2D_TILED_THIN1: pitch_align = max((u32)track->nbanks, - (u32)(((track->group_size / 8) / bpe) * track->nbanks)); + (u32)(((track->group_size / 8) / bpe) * track->nbanks)) / 8; if (!IS_ALIGNED(pitch, pitch_align)) { dev_warn(p->dev, "%s:%d tex pitch (%d) invalid\n", __func__, __LINE__, pitch); diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index f29a269..f9e2286 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -47,9 +47,10 @@ * - 2.4.0 - add crtc id query * - 2.5.0 - add get accel 2 to work around ddx breakage for evergreen * - 2.6.0 - add tiling config query (r6xx+), add initial HiZ support (r300->r500) + * 2.7.0 - fixups for r600 2D tiling support. (no external ABI change) */ #define KMS_DRIVER_MAJOR 2 -#define KMS_DRIVER_MINOR 6 +#define KMS_DRIVER_MINOR 7 #define KMS_DRIVER_PATCHLEVEL 0 int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags); int radeon_driver_unload_kms(struct drm_device *dev); -- 1.7.2.3 [View Less]

2 1

[patch 1/1] drivers/gpu/drm/radeon/atom.c: fix warning
by akpm＠linux-foundation.org 20 Oct '10

20 Oct '10

From: Andrew Morton <akpm(a)linux-foundation.org> drivers/gpu/drm/radeon/atom.c: In function 'atom_op_delay': drivers/gpu/drm/radeon/atom.c:653: warning: comparison is always false due to limited range of data type Cc: David Airlie <airlied(a)linux.ie> Cc: Alex Deucher <alexdeucher(a)gmail.com> Cc: Matt Turner <mattst88(a)gmail.com> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- drivers/gpu/drm/radeon/atom.c | 2 +- 1 file changed, 1 … [View More]

1 0

[Bug 28402] random radeon/kms/drm related freezes with kernel 2.6.34
by bugzilla-daemon＠freedesktop.org 20 Oct '10

20 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=28402 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39455|0 |1 is obsolete| | --- Comment #82 from Alex Deucher <agd5f(a)yahoo.com> 2010-10-20 13:31:53 PDT --- Created an attachment (id=39595) View: https://bugs.freedesktop.org/… [View More]

1 0

Detecting if display is powered on or not
by Pasi Kärkkäinen 20 Oct '10

20 Oct '10

Hello, While I was discussing the laptop lid/dock issues with Fedora people this issue was brought up. How do you determine if a display is actually powered on or not? Scenario: - Laptop in a docking station, lid open, so internal LVDS enabled. - External DVI display connected, but powered off. So in this case the external display shouldn't be used, since it's off. What happens is this: # cat /sys/class/drm/card0-DVI-D-1/status connected # cat /sys/class/drm/card0-DVI-D-1/enabled … [View More]

2 3

[Bug 30648] New: Video playback not smooth and exhibits stuttering at 720p while running Youtube HD stream
by bugzilla-daemon＠freedesktop.org 20 Oct '10

20 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=30648 Summary: Video playback not smooth and exhibits stuttering at 720p while running Youtube HD stream Product: Mesa Version: unspecified Platform: x86-64 (AMD64) OS/Version: All Status: NEW Severity: major Priority: high Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: hysvats(a)gmail.… [View More]

1 8

[Bug 22576] [KMS] mesa demo spectex broken on rv280
by bugzilla-daemon＠freedesktop.org 20 Oct '10

20 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=22576 --- Comment #16 from Andrew Randrianasulu <randrik(a)mail.ru> 2010-10-19 22:43:28 PDT --- Created an attachment (id=39559) --> (https://bugs.freedesktop.org/attachment.cgi?id=39559) screenshot of corruption -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

[Bug 22576] [KMS] mesa demo spectex broken on rv280
by bugzilla-daemon＠freedesktop.org 20 Oct '10

20 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=22576 --- Comment #15 from Andrew Randrianasulu <randrik(a)mail.ru> 2010-10-19 22:42:16 PDT --- (In reply to comment #14) > This could be fixed in mesa master and 7.9 branch: > http://lists.freedesktop.org/archives/mesa-dev/2010-October/003492.html It still broken, but in slightly different way: sphere has few horizontal black stripes now. I'll add screenshot. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email… [View More]

1 0

[Bug 29367] New: [KMS] Assertion `boi->space_accounted' failed. on rv280
by bugzilla-daemon＠freedesktop.org 20 Oct '10

20 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=29367 Summary: [KMS] Assertion `boi->space_accounted' failed. on rv280 Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r200 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: randrik(a)mail.ru With latest mesa (commit … [View More]

1 7

[Bug 25005] radeon RV250: xorg locks up when running glxgears
by bugzilla-daemon＠freedesktop.org 20 Oct '10

20 Oct '10

https://bugs.freedesktop.org/show_bug.cgi?id=25005 --- Comment #8 from Jose <braket(a)hotmail.com> 2010-10-19 19:53:47 PDT --- I won't have access to the machine with the ATI card for a while. It may be a couple of weeks before I have a chance to test it. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2010