dri-devel October 2012

dri-devel@lists.freedesktop.org

139 participants
712 discussions

[git pull] drm fixes
by Dave Airlie 23 Oct '12

23 Oct '12

Hi Linus, fixes for intel and nouveau mainly. intel: disable HSW by default, sdvo fixes, link train regression fix nouveau: acpi rom loading regression fix, with a few other fixes from the rework core: just other minor fixes and race fixes for ttm. Dave. The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556: Linux 3.7-rc2 (2012-10-20 12:11:32 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes Ben Skeggs (4): drm/nouveau/bios: fetch full 4KiB block to determine ACPI ROM image size drm/nv41/vm: don't init hw pciegart on boards with agp bridge drm/nouveau/fb: fix reporting of memory type on GF8+ IGPs drm/nouveau/clock: fix missing pll type/addr when matching default entry Chris Wilson (2): drm/i915: Add no-lvds quirk for Supermicro X7SPA-H drm/i915: Initialize obj->pages before use by i915_gem_object_do_bit17_swizzle() Daniel Vetter (2): Revert "drm/i915: Try harder to complete DP training pattern 1" drm/i915: shut up spurious WARN in the gtt fault handler Dave Airlie (2): Merge branch 'drm-intel-fixes' of git://people.freedesktop.org/~danvet/drm-intel into drm-fixes Merge branch 'drm-nouveau-fixes' of git://git.freedesktop.org/git/nouveau/linux-2.6 into drm-fixes Egbert Eich (4): DRM/i915: Don't delete DPLL Multiplier during DAC init. DRM/i915: Add QUIRK_INVERT_BRIGHTNESS for NCR machines. DRM/i915: Don't clone SDVO LVDS with analog. DRM/i915: Restore sdvo_flags after dtd->mode->dtd Roundrtrip. Marcin Slusarz (5): drm/nouveau: handle same-fb page flips drm/nouveau: fix nouveau_mm/nouveau_mm_node leak drm/nouveau: warn when trying to free mm which is still in use drm/nouveau: validate vbios size drm/debugfs: remove redundant info from gem_names Martin Peres (1): drm/nouveau/bios: improve error handling when reading the vbios from ACPI Rodrigo Vivi (1): drm/i915: Insert i915_preliminary_hw_support variable. Thierry Reding (3): drm: fb: cma: Fix typo in debug message drm: fb: cma: Fail gracefully on allocation failure drm: platform: Don't initialize driver-private data Thomas Hellstrom (2): drm/ttm: Fix a theoretical race drm/ttm: Fix a theoretical race in ttm_bo_cleanup_refs() drivers/gpu/drm/drm_fb_cma_helper.c | 4 +- drivers/gpu/drm/drm_info.c | 2 - drivers/gpu/drm/drm_platform.c | 1 - drivers/gpu/drm/i915/i915_drv.c | 13 +++++++++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 7 +++- drivers/gpu/drm/i915/intel_crt.c | 15 +---------- drivers/gpu/drm/i915/intel_display.c | 32 +++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dp.c | 15 +++++++--- drivers/gpu/drm/i915/intel_lvds.c | 8 +++++ drivers/gpu/drm/i915/intel_sdvo.c | 14 +++++++--- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 5 +++ drivers/gpu/drm/nouveau/core/core/mm.c | 2 +- drivers/gpu/drm/nouveau/core/subdev/bios/base.c | 30 ++++++++++++++++----- drivers/gpu/drm/nouveau/core/subdev/bios/pll.c | 10 +++---- drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c | 1 + drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c | 3 +- drivers/gpu/drm/nouveau/core/subdev/vm/nv44.c | 3 +- drivers/gpu/drm/nouveau/nouveau_display.c | 14 ++++++--- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 12 +++----- drivers/gpu/drm/ttm/ttm_bo.c | 24 ++++++++++------- 21 files changed, 148 insertions(+), 68 deletions(-)

1 0

[PATCH 00/10] extract dp helper functions
by Daniel Vetter 22 Oct '12

22 Oct '12

Hi all, I've frustrated myself the last few days yelling at our link training code. Comparing the i915 code to radeon and nouveau I've noticed the lack of a nice set of dp helper functions. So I've started to extract a few. There's lots more that we can do I think (link configuration selection, the i2c over aux retry stuff which diverges already between i915 and radeon, maybe more higher level parts of the training sequence). But there the drivers diverge quite a bit (e.g. the link configuration is driver by different things in each driver: coded link bw from the dp spec, link clock or required bw vs avialable bw), so that's more work and probably best done when reworking these functions for other reasons. I've also tried to put the new helpers a bit to use in nouveau, but due to lack of hw that part is untested. Comments and testing highly welcome. Yours, Daniel Daniel Vetter (10): drm: rename drm_dp_i2c_helper.c to drm_dp_helper.c drm: dp helper: extract drm_dp_channel_eq_ok drm: dp helper: extract drm_dp_clock_recovery_ok drm/nouveau: use the cr_ok/chanel_eq_ok helpers drm: extract helpers to compute new training values from sink request drm/nouveau: use dp link train request helper drm: extract dp link train delay functions from radeon drm/i915: use the new dp train delay helpers drm: extract dp link bw helpers drm: extract drm_dp_max_lane_count helper drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_dp_helper.c | 328 +++++++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_dp_i2c_helper.c | 208 ---------------------- drivers/gpu/drm/i915/intel_dp.c | 98 ++--------- drivers/gpu/drm/nouveau/nouveau_dp.c | 35 +--- drivers/gpu/drm/radeon/atombios_dp.c | 147 ++-------------- drivers/gpu/drm/radeon/radeon_mode.h | 2 +- include/drm/drm_dp_helper.h | 31 ++++ 8 files changed, 400 insertions(+), 451 deletions(-) create mode 100644 drivers/gpu/drm/drm_dp_helper.c delete mode 100644 drivers/gpu/drm/drm_dp_i2c_helper.c -- 1.7.11.4

3 16

[Bug 56042] New: [865G] BadAlloc (insufficient resources for operation)
by bugzilla-daemon＠freedesktop.org 22 Oct '12

22 Oct '12

https://bugs.freedesktop.org/show_bug.cgi?id=56042 Priority: medium Bug ID: 56042 Assignee: dri-devel(a)lists.freedesktop.org Summary: [865G] BadAlloc (insufficient resources for operation) Severity: normal Classification: Unclassified OS: Linux (All) Reporter: goetzchrist(a)yahoo.es Hardware: x86 (IA32) Status: NEW Version: 9.0 Component: Drivers/DRI/i830 Product: Mesa Created attachment 68637 --> https://bugs.freedesktop.org/attachment.cgi?id=68637&action=edit dmesg When I run glxinfo, or any 3D application, the app doesn't start, and I only get this error. With Mesa 8.0.4 there was no problem. $ glxinfo name of display: :0 X Error of failed request: BadAlloc (insufficient resources for operation) Major opcode of failed request: 153 (GLX) Minor opcode of failed request: 3 (X_GLXCreateContext) Serial number of failed request: 22 Current serial number in output stream: 25 ----------- Linux 3.6.2 X Server 1.13.0 libdrm 2.4.39 xf86-video-intel 2.20.10 00:02.0 VGA compatible controller: Intel Corporation 82865G Integrated Graphics Controller (rev 02) (prog-if 00 [VGA controller]) Subsystem: ASRock Incorporation Device 2572 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx+ Latency: 0 Interrupt: pin A routed to IRQ 16 Region 0: Memory at f0000000 (32-bit, prefetchable) [size=128M] Region 1: Memory at ff280000 (32-bit, non-prefetchable) [size=512K] Region 2: I/O ports at ec00 [size=8] Expansion ROM at <unassigned> [disabled] Capabilities: [d0] Power Management version 1 Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: i915 I don't know what information should I provide. -- You are receiving this mail because: You are the assignee for the bug.

1 2

radeon: RFC speed cap detection on ppc64
by Lucas Kannebley Tavares 22 Oct '12

22 Oct '12

The radeon driver does speed cap detection on the root PCI device for the maximum speed with which the adapter can communicate. On ppc64 systems, however, the root device belongs to the Hypervisor, so the current code would case a null pointer dereference. I propose to look for the outmost bus with a parent node and get speed caps from it, though I suppose the cleaner way would be to inspect all devices along the way and choose the smallest speed cap. Does anyone have suggestions for this? Thanks -- --- /home/lucaskt/work/devdrivers/kernel/linux/drivers/gpu/drm/drm_pci.c 2012-09-26 10:06:00.280549928 -0300 +++ drm_pci.c 2012-09-26 15:38:51.121786353 -0300 @@ -466,6 +466,19 @@ } EXPORT_SYMBOL(drm_pci_exit); +static struct pci_dev *drm_get_pcie_root_dev(struct pci_dev *dev) +{ + // Go up through all possible busses to get the info for the outmost bus + while (!pci_is_root_bus(dev->bus)) + dev = dev->bus->parent->self; + + // In POWER architectures there's no PCI root device, so it should just read + // the caps from the device itself + if (dev->bus->self != NULL) + return dev->bus->self; + else + return dev; +} + int drm_pcie_get_speed_cap_mask(struct drm_device *dev, u32 *mask) { struct pci_dev *root; @@ -479,7 +492,7 @@ if (!pci_is_pcie(dev->pdev)) return -EINVAL; - root = dev->pdev->bus->self; + root = drm_get_pcie_root_dev(dev->pdev); pos = pci_pcie_cap(root); if (!pos) -- Lucas Kannebley Tavares Software Engineer IBM Linux Technology Center

4 3

[PATCH 1/5] drm/radeon: fix PFP sync in vm_flush
by Christian König 22 Oct '12

22 Oct '12

Otherwise the next IB might start reading commands with the page table still invalid. Signed-off-by: Christian König <deathsimple(a)vodafone.de> --- drivers/gpu/drm/radeon/ni.c | 4 ++++ drivers/gpu/drm/radeon/nid.h | 1 + drivers/gpu/drm/radeon/si.c | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c index 8c74c72..19b7fe1 100644 --- a/drivers/gpu/drm/radeon/ni.c +++ b/drivers/gpu/drm/radeon/ni.c @@ -1586,4 +1586,8 @@ void cayman_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm) /* bits 0-7 are the VM contexts0-7 */ radeon_ring_write(ring, PACKET0(VM_INVALIDATE_REQUEST, 0)); radeon_ring_write(ring, 1 << vm->id); + + /* sync PFP to ME, otherwise we might get invalid PFP reads */ + radeon_ring_write(ring, PACKET3(PACKET3_PFP_SYNC_ME, 0)); + radeon_ring_write(ring, 0x0); } diff --git a/drivers/gpu/drm/radeon/nid.h b/drivers/gpu/drm/radeon/nid.h index 2423d1b..cbef681 100644 --- a/drivers/gpu/drm/radeon/nid.h +++ b/drivers/gpu/drm/radeon/nid.h @@ -502,6 +502,7 @@ #define PACKET3_MPEG_INDEX 0x3A #define PACKET3_WAIT_REG_MEM 0x3C #define PACKET3_MEM_WRITE 0x3D +#define PACKET3_PFP_SYNC_ME 0x42 #define PACKET3_SURFACE_SYNC 0x43 # define PACKET3_CB0_DEST_BASE_ENA (1 << 6) # define PACKET3_CB1_DEST_BASE_ENA (1 << 7) diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index df8dd77..da184de 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c @@ -2868,6 +2868,10 @@ void si_vm_flush(struct radeon_device *rdev, int ridx, struct radeon_vm *vm) radeon_ring_write(ring, VM_INVALIDATE_REQUEST >> 2); radeon_ring_write(ring, 0); radeon_ring_write(ring, 1 << vm->id); + + /* sync PFP to ME, otherwise we might get invalid PFP reads */ + radeon_ring_write(ring, PACKET3(PACKET3_PFP_SYNC_ME, 0)); + radeon_ring_write(ring, 0x0); } /* -- 1.7.9.5

1 4

[PATCH 1/5] drm/radeon: fix PFP sync in vm_flush
by Christian König 22 Oct '12

22 Oct '12

2 7

[PATCH 1/1] intel: corrected the header include path for recent Valgrind versions.
by Oliver McFadden 22 Oct '12

22 Oct '12

intel_bufmgr_gem.c:67:22: fatal error: valgrind.h: No such file or directory Signed-off-by: Oliver McFadden <oliver.mcfadden(a)linux.intel.com> --- intel/intel_bufmgr_gem.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c index 8d45839..f5a468c 100644 --- a/intel/intel_bufmgr_gem.c +++ b/intel/intel_bufmgr_gem.c @@ -64,8 +64,8 @@ #include "i915_drm.h" #ifdef HAVE_VALGRIND -#include <valgrind.h> -#include <memcheck.h> +#include <valgrind/valgrind.h> +#include <valgrind/memcheck.h> #define VG(x) x #else #define VG(x) -- 1.7.8.6

2 1

[PATCH 0/2 v6] of: add display helper
by Steffen Trumtrar 22 Oct '12

22 Oct '12

Hi! In accordance with Stepehn Warren, I downsized the binding. Now, just the display-timing is described, as I think, it is way easier to agree on those and have a complete binding. Regards, Steffen Steffen Trumtrar (2): of: add helper to parse display timings of: add generic videomode description .../devicetree/bindings/video/display-timings.txt | 222 ++++++++++++++++++++ drivers/of/Kconfig | 10 + drivers/of/Makefile | 2 + drivers/of/of_display_timings.c | 183 ++++++++++++++++ drivers/of/of_videomode.c | 212 +++++++++++++++++++ include/linux/of_display_timings.h | 85 ++++++++ include/linux/of_videomode.h | 41 ++++ 7 files changed, 755 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/display-timings.txt create mode 100644 drivers/of/of_display_timings.c create mode 100644 drivers/of/of_videomode.c create mode 100644 include/linux/of_display_timings.h create mode 100644 include/linux/of_videomode.h -- 1.7.10.4

9 45

[Bug 36522] Caught 16-bit read from uninitialized memory in drm_fb_helper_setcmap
by bugzilla-daemon＠bugzilla.kernel.org 21 Oct '12

21 Oct '12

https://bugzilla.kernel.org/show_bug.cgi?id=36522 --- Comment #10 from Christian Casteyde <casteyde.christian(a)free.fr> 2012-10-21 21:49:34 --- Update: Still present in 3.7-rc2 on Slackware 64 + xf86-video-ati-6.14.6 + libdrm-2.4.39-x86_64 -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 0

[PATCH 1/2] drm: fb: cma: Fix typo in debug message
by Thierry Reding 21 Oct '12

21 Oct '12

The debug message showing the resolution of a framebuffer to be allocated is missing a closing parenthesis. Signed-off-by: Thierry Reding <thierry.reding(a)avionic-design.de> --- drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index 09e11a5..d6c80a3 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -206,7 +206,7 @@ static int drm_fbdev_cma_create(struct drm_fb_helper *helper, size_t size; int ret; - DRM_DEBUG_KMS("surface width(%d), height(%d) and bpp(%d\n", + DRM_DEBUG_KMS("surface width(%d), height(%d) and bpp(%d)\n", sizes->surface_width, sizes->surface_height, sizes->surface_bpp); -- 1.7.12.4

2 2

← Newer
1
...
51
52
53
54
55
56
57
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2012