dri-devel October 2012

dri-devel@lists.freedesktop.org

139 participants
712 discussions

[PATCH 1/3] drm/nouveau: add reservation to nouveau_gem_ioctl_cpu_prep
by Maarten Lankhorst 18 Oct '12

18 Oct '12

Apart from some code inside ttm itself and nouveau_bo_vma_del, this is the only place where ttm_bo_wait is used without a reservation. Fix this so we can remove the fence_lock later on. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)canonical.com> --- drivers/gpu/drm/nouveau/nouveau_gem.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 5e2f521..18342b0 … [View More]

2 1

[Bug 56111] New: EDID not read, results in flickering monitor
by bugzilla-daemon＠freedesktop.org 18 Oct '12

18 Oct '12

https://bugs.freedesktop.org/show_bug.cgi?id=56111 Priority: medium Bug ID: 56111 Assignee: dri-devel(a)lists.freedesktop.org Summary: EDID not read, results in flickering monitor Severity: normal Classification: Unclassified OS: All Reporter: darxus(a)chaosreigns.com Hardware: Other Status: NEW Version: unspecified Component: General Product: DRI Created … [View More]attachment 68741 --> https://bugs.freedesktop.org/attachment.cgi?id=68741&action=edit Ubuntu Oneric dmesg output, not having this problem Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690794 Ubuntu bug, possibly the same, fixed, but I don't know how: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/958439 Installed Debian Wheezy, then installed package linux-image-3.5-trunk-amd64 from Experimental, which I guess is an unmodified mainline kernel: $ uname -a Linux dancer 3.5-trunk-amd64 #1 SMP Debian 3.5.5-1~experimental.1 x86_64 GNU/Linux EDID is not read properly, resulting in (CRT) monitor flickering (looks like 60hz). gnome-control-center says the display is "Unknown". xrandr --verbose does not mention the EDID. I previously had these problems on Ubuntu, reported in the above Ubuntu bug. It persisted when I changed video cards from Nvidia to AMD Radeon. It went away with a kernel upgrade. Not sure what the change was. "xrandr --verbose" output: ------------------------------------------------------------------------- xrandr: Failed to get size of gamma for output default Screen 0: minimum 640 x 400, current 1600 x 1200, maximum 1920 x 1440 default connected 1600x1200+0+0 (0x13b) normal (normal) 0mm x 0mm Identifier: 0x137 Timestamp: 40607 Subpixel: no subpixels Clones: CRTC: 0 CRTCs: 0 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: 1920x1440 (0x138) 0.0MHz h: width 1920 start 0 end 0 total 1920 skew 0 clock 0.0KHz v: height 1440 start 0 end 0 total 1440 clock 0.0Hz 1856x1392 (0x139) 0.0MHz h: width 1856 start 0 end 0 total 1856 skew 0 clock 0.0KHz v: height 1392 start 0 end 0 total 1392 clock 0.0Hz 1792x1344 (0x13a) 0.0MHz h: width 1792 start 0 end 0 total 1792 skew 0 clock 0.0KHz v: height 1344 start 0 end 0 total 1344 clock 0.0Hz 1600x1200 (0x13b) 0.0MHz *current h: width 1600 start 0 end 0 total 1600 skew 0 clock 0.0KHz v: height 1200 start 0 end 0 total 1200 clock 0.0Hz 1280x1024 (0x13c) 0.0MHz h: width 1280 start 0 end 0 total 1280 skew 0 clock 0.0KHz v: height 1024 start 0 end 0 total 1024 clock 0.0Hz 1152x864 (0x13d) 0.0MHz h: width 1152 start 0 end 0 total 1152 skew 0 clock 0.0KHz v: height 864 start 0 end 0 total 864 clock 0.0Hz 1024x768 (0x13e) 0.0MHz h: width 1024 start 0 end 0 total 1024 skew 0 clock 0.0KHz v: height 768 start 0 end 0 total 768 clock 0.0Hz 800x600 (0x13f) 0.0MHz h: width 800 start 0 end 0 total 800 skew 0 clock 0.0KHz v: height 600 start 0 end 0 total 600 clock 0.0Hz 640x480 (0x140) 0.0MHz h: width 640 start 0 end 0 total 640 skew 0 clock 0.0KHz v: height 480 start 0 end 0 total 480 clock 0.0Hz 720x400 (0x141) 0.0MHz h: width 720 start 0 end 0 total 720 skew 0 clock 0.0KHz v: height 400 start 0 end 0 total 400 clock 0.0Hz ------------------------------------------------------------------------- "get-edid 2>&1 | parse-edid > get-parse-edid.txt 2>&1" output: ------------------------------------------------------------------------- parse-edid: parse-edid version 2.0.0 parse-edid: EDID checksum failed - data is corrupt. Continuing anyway. parse-edid: first bytes don't match EDID version 1 header parse-edid: do not trust output (if any). # EDID version 32 revision 118 Section "Monitor" Identifier "NQ@:6765" VendorName "NQ@" ModelName "NQ@:6765" # DPMS capabilities: Active off:yes Suspend:yes Standby:no Mode "1110x1568" # vfreq 17.559Hz, hfreq 33.766kHz DotClock 82.930000 HTimings 1110 1218 1326 2456 VTimings 1568 1600 1626 1923 EndMode Mode "884x888" # vfreq 335.422Hz, hfreq 314.290kHz DotClock 287.890000 HTimings 884 916 1029 916 VTimings 888 943 967 937 EndMode Mode "888x632" # vfreq 389.264Hz, hfreq 264.700kHz DotClock 251.200000 HTimings 888 987 1107 949 VTimings 632 635 648 680 EndMode Mode "1652x1902" # vfreq 16.831Hz, hfreq 45.478kHz DotClock 254.540000 HTimings 1652 1769 1881 5597 VTimings 1902 1957 2005 2702 EndMode EndSection ------------------------------------------------------------------------- Output of "xrandr --verbose" on Ubuntu Oneric, which does not have this problem: ------------------------------------------------------------------------- Screen 0: minimum 320 x 200, current 1600 x 1200, maximum 16384 x 16384 DisplayPort-0 disconnected (normal left inverted right x axis y axis) Identifier: 0x55 Timestamp: 32750 Subpixel: horizontal rgb Clones: CRTCs: 0 1 2 3 4 5 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: underscan vborder: 0 (0x00000000) range: (0,128) underscan hborder: 0 (0x00000000) range: (0,128) underscan: off supported: off on auto coherent: 1 (0x00000001) range: (0,1) DisplayPort-1 disconnected (normal left inverted right x axis y axis) Identifier: 0x56 Timestamp: 32750 Subpixel: horizontal rgb Clones: CRTCs: 0 1 2 3 4 5 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: underscan vborder: 0 (0x00000000) range: (0,128) underscan hborder: 0 (0x00000000) range: (0,128) underscan: off supported: off on auto coherent: 1 (0x00000001) range: (0,1) HDMI-0 disconnected (normal left inverted right x axis y axis) Identifier: 0x57 Timestamp: 32750 Subpixel: horizontal rgb Clones: CRTCs: 0 1 2 3 4 5 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: underscan vborder: 0 (0x00000000) range: (0,128) underscan hborder: 0 (0x00000000) range: (0,128) underscan: off supported: off on auto coherent: 1 (0x00000001) range: (0,1) DVI-0 disconnected (normal left inverted right x axis y axis) Identifier: 0x58 Timestamp: 32750 Subpixel: horizontal rgb Clones: CRTCs: 0 1 2 3 4 5 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: underscan vborder: 0 (0x00000000) range: (0,128) underscan hborder: 0 (0x00000000) range: (0,128) underscan: off supported: off on auto coherent: 1 (0x00000001) range: (0,1) DVI-1 connected 1600x1200+0+0 (0x5a) normal (normal left inverted right x axis y axis) 390mm x 290mm Identifier: 0x59 Timestamp: 32750 Subpixel: horizontal rgb Gamma: 1.0:1.0:1.0 Brightness: 1.0 Clones: CRTC: 0 CRTCs: 0 1 2 3 4 5 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: EDID: 00ffffffffffff005a6309e801010101 260d01031d281ec0eacc58a054479925 0f484cffff80a94f81996159714fc14f c940d140e140a659403062b0324040c0 130086221100001e000000ff0034324b 3033333830303333350a000000fd0032 b41e6e1a000a202020202020000000fc 004732323066620a20202020202000df load detection: 1 (0x00000001) range: (0,1) underscan vborder: 0 (0x00000000) range: (0,128) underscan hborder: 0 (0x00000000) range: (0,128) underscan: off supported: off on auto coherent: 1 (0x00000001) range: (0,1) 1600x1200 (0x5a) 229.5MHz +HSync +VSync *current +preferred h: width 1600 start 1664 end 1856 total 2160 skew 0 clock 106.2KHz v: height 1200 start 1201 end 1204 total 1250 clock 85.0Hz 2048x1536 (0x5b) 267.0MHz -HSync +VSync h: width 2048 start 2200 end 2424 total 2800 skew 0 clock 95.4KHz v: height 1536 start 1537 end 1540 total 1589 clock 60.0Hz 1920x1440 (0x5c) 234.0MHz -HSync +VSync h: width 1920 start 2048 end 2256 total 2600 skew 0 clock 90.0KHz v: height 1440 start 1441 end 1444 total 1500 clock 60.0Hz 1856x1392 (0x5d) 218.2MHz -HSync +VSync h: width 1856 start 1952 end 2176 total 2528 skew 0 clock 86.3KHz v: height 1392 start 1393 end 1396 total 1439 clock 60.0Hz 1792x1344 (0x5e) 261.0MHz -HSync +VSync h: width 1792 start 1888 end 2104 total 2456 skew 0 clock 106.3KHz v: height 1344 start 1345 end 1348 total 1417 clock 75.0Hz 1600x1200 (0x5f) 202.5MHz +HSync +VSync h: width 1600 start 1664 end 1856 total 2160 skew 0 clock 93.8KHz v: height 1200 start 1201 end 1204 total 1250 clock 75.0Hz 1280x1024 (0x60) 157.5MHz +HSync +VSync h: width 1280 start 1344 end 1504 total 1728 skew 0 clock 91.1KHz v: height 1024 start 1025 end 1028 total 1072 clock 85.0Hz 1280x1024 (0x61) 135.0MHz +HSync +VSync h: width 1280 start 1296 end 1440 total 1688 skew 0 clock 80.0KHz v: height 1024 start 1025 end 1028 total 1066 clock 75.0Hz 1152x864 (0x62) 108.0MHz +HSync +VSync h: width 1152 start 1216 end 1344 total 1600 skew 0 clock 67.5KHz v: height 864 start 865 end 868 total 900 clock 75.0Hz 1024x768 (0x63) 94.5MHz +HSync +VSync h: width 1024 start 1072 end 1168 total 1376 skew 0 clock 68.7KHz v: height 768 start 769 end 772 total 808 clock 85.0Hz 1024x768 (0x64) 78.8MHz +HSync +VSync h: width 1024 start 1040 end 1136 total 1312 skew 0 clock 60.1KHz v: height 768 start 769 end 772 total 800 clock 75.1Hz 1024x768 (0x65) 75.0MHz -HSync -VSync h: width 1024 start 1048 end 1184 total 1328 skew 0 clock 56.5KHz v: height 768 start 771 end 777 total 806 clock 70.1Hz 1024x768 (0x66) 65.0MHz -HSync -VSync h: width 1024 start 1048 end 1184 total 1344 skew 0 clock 48.4KHz v: height 768 start 771 end 777 total 806 clock 60.0Hz 1024x768 (0x67) 44.9MHz +HSync +VSync Interlace h: width 1024 start 1032 end 1208 total 1264 skew 0 clock 35.5KHz v: height 768 start 768 end 776 total 817 clock 43.5Hz 832x624 (0x68) 57.3MHz -HSync -VSync h: width 832 start 864 end 928 total 1152 skew 0 clock 49.7KHz v: height 624 start 625 end 628 total 667 clock 74.6Hz 800x600 (0x69) 50.0MHz +HSync +VSync h: width 800 start 856 end 976 total 1040 skew 0 clock 48.1KHz v: height 600 start 637 end 643 total 666 clock 72.2Hz 800x600 (0x6a) 49.5MHz +HSync +VSync h: width 800 start 816 end 896 total 1056 skew 0 clock 46.9KHz v: height 600 start 601 end 604 total 625 clock 75.0Hz 800x600 (0x6b) 40.0MHz +HSync +VSync h: width 800 start 840 end 968 total 1056 skew 0 clock 37.9KHz v: height 600 start 601 end 605 total 628 clock 60.3Hz 800x600 (0x6c) 36.0MHz +HSync +VSync h: width 800 start 824 end 896 total 1024 skew 0 clock 35.2KHz v: height 600 start 601 end 603 total 625 clock 56.2Hz 640x480 (0x6d) 31.5MHz -HSync -VSync h: width 640 start 664 end 704 total 832 skew 0 clock 37.9KHz v: height 480 start 489 end 491 total 520 clock 72.8Hz 640x480 (0x6e) 31.5MHz -HSync -VSync h: width 640 start 656 end 720 total 840 skew 0 clock 37.5KHz v: height 480 start 481 end 484 total 500 clock 75.0Hz 640x480 (0x6f) 30.2MHz -HSync -VSync h: width 640 start 704 end 768 total 864 skew 0 clock 35.0KHz v: height 480 start 483 end 486 total 525 clock 66.7Hz 640x480 (0x70) 25.2MHz -HSync -VSync h: width 640 start 656 end 752 total 800 skew 0 clock 31.5KHz v: height 480 start 490 end 492 total 525 clock 60.0Hz 720x400 (0x71) 35.5MHz -HSync -VSync h: width 720 start 738 end 846 total 900 skew 0 clock 39.4KHz v: height 400 start 421 end 423 total 449 clock 87.8Hz 720x400 (0x72) 28.3MHz -HSync +VSync h: width 720 start 738 end 846 total 900 skew 0 clock 31.5KHz v: height 400 start 412 end 414 total 449 clock 70.1Hz ------------------------------------------------------------------------- Output of "get-edid 2>&1 | parse-edid > get-parse-edid.txt 2>&1" on Ubuntu Oneric: ------------------------------------------------------------------------- parse-edid: parse-edid version 2.0.0 parse-edid: EDID checksum failed - data is corrupt. Continuing anyway. parse-edid: first bytes don't match EDID version 1 header parse-edid: do not trust output (if any). # EDID version 32 revision 118 Section "Monitor" Identifier "NQ@:6765" VendorName "NQ@" ModelName "NQ@:6765" # DPMS capabilities: Active off:yes Suspend:yes Standby:no Mode "623x1902" # vfreq 121.269Hz, hfreq 368.295kHz DotClock 269.960000 HTimings 623 671 783 733 VTimings 1902 1908 1945 3037 EndMode Mode "613x1637" # vfreq 16.090Hz, hfreq 65.018kHz DotClock 263.780000 HTimings 613 729 787 4057 VTimings 1637 1655 1671 4041 EndMode Mode "1652x1900" # vfreq 48.351Hz, hfreq 134.078kHz DotClock 269.900000 HTimings 1652 1757 1867 2013 VTimings 1900 1906 1913 2773 EndMode Mode "1568x1908" # vfreq 19.585Hz, hfreq 49.374kHz DotClock 259.560000 HTimings 1568 1686 1783 5257 VTimings 1908 1930 1949 2521 EndMode EndSection ------------------------------------------------------------------------- Oneric kernel is: $ uname -a Linux dancer 3.0.0-26-generic #43-Ubuntu SMP Tue Sep 25 17:19:22 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux -- You are receiving this mail because: You are the assignee for the bug. [View Less]

1 3

[REGRESSION?] Blanking screen does not blank it on Radeon HD3200 (Thinkpad Edge 13, model 0197)
by Yaroslav Fedevych 18 Oct '12

18 Oct '12

In text mode, instead of blanking the screen and shutting it down, it is instead painted white, backlight going full steam. I have bisected the code and git tells me the first bad commit is f3728734ba78310525bf4a361c7787c7c6fa5d40. Apparently my laptop, despite having atom tables, still needs legacy backlight controls. Or whatever. ---------------------------------------------------------- drm/radeon: add backlight control for atom devices (v2) On systems that use the build in GPU backlight … [View More]

1 0

[PATCH] drm/exynos: fix display on issue
by Inki Dae 18 Oct '12

18 Oct '12

When crtc_funcs->dpms callback is called, exynos_crtc->dpms and exynos_encoder->dpms are changed to new mode. But if user requests dpms mode operation, OFF -> ON, when crtc's dpms callback is called, exynos_encoder->dpms is also changed to ON. This makes encoder's dpms callback call be ignored so display power couldn't become on again. This patch removes exynos_encoder->dpms changing and adds 'updated' variable to exynos_drm_encoder structure to avoid duplicated overlay … [View More]updating. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 1 + drivers/gpu/drm/exynos/exynos_drm_encoder.c | 33 +++++++++++++------------ 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c index 18c2718..0f68a28 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c @@ -374,6 +374,7 @@ struct drm_connector *exynos_drm_connector_create(struct drm_device *dev, exynos_connector->encoder_id = encoder->base.id; exynos_connector->manager = manager; exynos_connector->dpms = DRM_MODE_DPMS_OFF; + connector->dpms = DRM_MODE_DPMS_OFF; connector->encoder = encoder; err = drm_mode_connector_attach_encoder(connector, encoder); diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index e51503f..241ad1e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -43,12 +43,14 @@ * @manager: specific encoder has its own manager to control a hardware * appropriately and we can access a hardware drawing on this manager. * @dpms: store the encoder dpms value. + * @updated: indicate whether overlay data updating is needed or not. */ struct exynos_drm_encoder { struct drm_crtc *old_crtc; struct drm_encoder drm_encoder; struct exynos_drm_manager *manager; - int dpms; + int dpms; + bool updated; }; static void exynos_drm_connector_power(struct drm_encoder *encoder, int mode) @@ -85,7 +87,9 @@ static void exynos_drm_encoder_dpms(struct drm_encoder *encoder, int mode) switch (mode) { case DRM_MODE_DPMS_ON: if (manager_ops && manager_ops->apply) - manager_ops->apply(manager->dev); + if (!exynos_encoder->updated) + manager_ops->apply(manager->dev); + exynos_drm_connector_power(encoder, mode); exynos_encoder->dpms = mode; break; @@ -94,6 +98,7 @@ static void exynos_drm_encoder_dpms(struct drm_encoder *encoder, int mode) case DRM_MODE_DPMS_OFF: exynos_drm_connector_power(encoder, mode); exynos_encoder->dpms = mode; + exynos_encoder->updated = false; break; default: DRM_ERROR("unspecified mode %d\n", mode); @@ -205,13 +210,22 @@ static void exynos_drm_encoder_prepare(struct drm_encoder *encoder) static void exynos_drm_encoder_commit(struct drm_encoder *encoder) { - struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder); + struct exynos_drm_encoder *exynos_encoder = to_exynos_encoder(encoder); + struct exynos_drm_manager *manager = exynos_encoder->manager; struct exynos_drm_manager_ops *manager_ops = manager->ops; DRM_DEBUG_KMS("%s\n", __FILE__); if (manager_ops && manager_ops->commit) manager_ops->commit(manager->dev); + + /* + * this will avoid one issue that overlay data is updated to + * real hardware two times. + * And this variable will be used to check if the data was + * already updated or not by exynos_drm_encoder_dpms function. + */ + exynos_encoder->updated = true; } static void exynos_drm_encoder_disable(struct drm_encoder *encoder) @@ -401,19 +415,6 @@ void exynos_drm_encoder_crtc_dpms(struct drm_encoder *encoder, void *data) manager_ops->dpms(manager->dev, mode); /* - * set current mode to new one so that data aren't updated into - * registers by drm_helper_connector_dpms two times. - * - * in case that drm_crtc_helper_set_mode() is called, - * overlay_ops->commit() and manager_ops->commit() callbacks - * can be called two times, first at drm_crtc_helper_set_mode() - * and second at drm_helper_connector_dpms(). - * so with this setting, when drm_helper_connector_dpms() is called - * encoder->funcs->dpms() will be ignored. - */ - exynos_encoder->dpms = mode; - - /* * if this condition is ok then it means that the crtc is already * detached from encoder and last function for detaching is properly * done, so clear pipe from manager to prevent repeated call. -- 1.7.4.1 [View Less]

1 0

[PATCH 0/4] add ipp subsystem and each ipp drivers
by Eunchul Kim 18 Oct '12

18 Oct '12

Hi All. I am responsible for a display part from Samsung Electronics Telecommunication Division. and I am going to add post-processing features in exynos drm. If you have some opinion of this patch, please give some comments about my patch. IPP is stands for Image Post Processing and supports image scaler/rotator and input/output DMA operations using IPP drivers(FIMC, Rotator, GSC, SC, so on.) IPP is integration device driver of same attibute hardware. IPP drivers supports Memory to Memory … [View More]operations with various converting. and some drivers supports Writeback and Display output operations using local path. User can make converted image using this driver. and also supports streaming concept for multimedia data processing. And supports various operations 1. Scale operation generates various sizes of image. 2. CSC(Color Space Conversion) operation supports format converting. 3. Crop operation supports cutting the image. 4. Rotate operation supports to 90, 180, 270 degree. 5. Flip operation supports to vertical, horizontal, and both. 6. Writeback operation genertates cloned image from display controller(FIMD). 7. Display output operation support various format display to display controller(FIMD). 8. Input DMA reads image data from the memory. 9. Output DMA writes image data to memory. 10. Supports image effect functions. Descriptions) User should make property informations and set this property to registers. and IPP subsystem manages property id using command node and make queue list using memory node. IPP subsystem supports register function of IPP drivers. IPP driver manages input/output DMA with various operations. and some driver supports optional operations(writeback, output). IPP driver needs various informations, so User set property information to IPP driver. and also IPP driver needs memory base address of image for various operations. User doesn't know its address, so fills the gem handle of that memory than address of image base. and than IPP driver start operation. We adds four ioctls and one event for IPP subsystem. Basic control flow is same as below Open -> Get properties -> User choose IPP driver and set property information -> Set Property -> Create gem handle -> Queue buffer(Enqueue) of source/destination -> Command control(Play) -> Event occured to User -> User handle converted image -> (Queue buffer(Enqueue) of source/destination -> Event occured to User)*N -> Queue buffer(Dequeue) of source/destination -> Command control(Stop) -> Free gem handle -> Close - ioctls DRM_EXYNOS_IPP_GET_PROPERTY : get ipp driver capabilitis and id. DRM_EXYNOS_IPP_SET_PROPERTY : set format, position, rotation, flip about source/destination. DRM_EXYNOS_IPP_QUEUE_BUF : enqueue/dequeue buffer and make event list. DRM_EXYNOS_IPP_CMD_CTRL : play/stop/pause/resume control. - event DRM_EXYNOS_IPP_EVENT : event to give notification completion of buffer DMA with buffer list Eunchul Kim (4): drm/exynos: add ipp subsystem drm/exynos: add fimc ipp driver drm/exynos: add rotator ipp driver drm/exynos: add gsc ipp driver drivers/gpu/drm/exynos/Kconfig | 24 + drivers/gpu/drm/exynos/Makefile | 4 + drivers/gpu/drm/exynos/exynos_drm_drv.c | 69 + drivers/gpu/drm/exynos/exynos_drm_drv.h | 10 + drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2041 +++++++++++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_fimc.h | 35 + drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1476 +++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_gsc.h | 35 + drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1937 +++++++++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_ipp.h | 268 ++++ drivers/gpu/drm/exynos/exynos_drm_rotator.c | 801 +++++++++++ drivers/gpu/drm/exynos/exynos_drm_rotator.h | 13 + drivers/gpu/drm/exynos/regs-fimc.h | 669 +++++++++ drivers/gpu/drm/exynos/regs-gsc.h | 295 ++++ drivers/gpu/drm/exynos/regs-rotator.h | 73 + include/drm/exynos_drm.h | 33 + include/uapi/drm/exynos_drm.h | 189 +++ 17 files changed, 7972 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/exynos/exynos_drm_fimc.c create mode 100644 drivers/gpu/drm/exynos/exynos_drm_fimc.h create mode 100644 drivers/gpu/drm/exynos/exynos_drm_gsc.c create mode 100644 drivers/gpu/drm/exynos/exynos_drm_gsc.h create mode 100644 drivers/gpu/drm/exynos/exynos_drm_ipp.c create mode 100644 drivers/gpu/drm/exynos/exynos_drm_ipp.h create mode 100644 drivers/gpu/drm/exynos/exynos_drm_rotator.c create mode 100644 drivers/gpu/drm/exynos/exynos_drm_rotator.h create mode 100644 drivers/gpu/drm/exynos/regs-fimc.h create mode 100644 drivers/gpu/drm/exynos/regs-gsc.h create mode 100644 drivers/gpu/drm/exynos/regs-rotator.h [View Less]

1 4

[PATCH] drm/radeon: give each backlight a unique id
by alexdeucher＠gmail.com 17 Oct '12

17 Oct '12

From: Alex Deucher <alexander.deucher(a)amd.com> In cases where we have multiple radeons with backlight controls. Should fix: https://bugzilla.kernel.org/show_bug.cgi?id=48941 Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- drivers/gpu/drm/radeon/atombios_encoders.c | 5 ++++- drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/… [View More]drm/radeon/atombios_encoders.c index 806cbcc..a9a059c 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -184,6 +184,7 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder, struct radeon_backlight_privdata *pdata; struct radeon_encoder_atom_dig *dig; u8 backlight_level; + char bl_name[16]; if (!radeon_encoder->enc_priv) return; @@ -203,7 +204,9 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder, memset(&props, 0, sizeof(props)); props.max_brightness = RADEON_MAX_BL_LEVEL; props.type = BACKLIGHT_RAW; - bd = backlight_device_register("radeon_bl", &drm_connector->kdev, + snprintf(bl_name, sizeof(bl_name), + "radeon_bl%d", dev->primary->index); + bd = backlight_device_register(bl_name, &drm_connector->kdev, pdata, &radeon_atom_backlight_ops, &props); if (IS_ERR(bd)) { DRM_ERROR("Backlight registration failed\n"); diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c index 8ad9c5f..687b07c 100644 --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c @@ -370,6 +370,7 @@ void radeon_legacy_backlight_init(struct radeon_encoder *radeon_encoder, struct backlight_properties props; struct radeon_backlight_privdata *pdata; uint8_t backlight_level; + char bl_name[16]; if (!radeon_encoder->enc_priv) return; @@ -389,7 +390,9 @@ void radeon_legacy_backlight_init(struct radeon_encoder *radeon_encoder, memset(&props, 0, sizeof(props)); props.max_brightness = RADEON_MAX_BL_LEVEL; props.type = BACKLIGHT_RAW; - bd = backlight_device_register("radeon_bl", &drm_connector->kdev, + snprintf(bl_name, sizeof(bl_name), + "radeon_bl%d", dev->primary->index); + bd = backlight_device_register(bl_name, &drm_connector->kdev, pdata, &radeon_backlight_ops, &props); if (IS_ERR(bd)) { DRM_ERROR("Backlight registration failed\n"); -- 1.7.7.5 [View Less]

1 0

[Bug 26294] [Regression] Resolution for external TV/monitor Philips 32PFL5404H not set correctly
by bugzilla-daemon＠freedesktop.org 17 Oct '12

17 Oct '12

https://bugs.freedesktop.org/show_bug.cgi?id=26294 --- Comment #26 from Paul Menzel <paulepanter(a)users.sourceforge.net> --- (In reply to comment #0) […] > connecting a Philips 32PFL5404H [1] to the ASUS EeePC 701 4G worked with > version 2.8 and maybe even 2.9.0 of the Intel driver. With 2.9.1 it does not > work anymore and I get a similar picture as in [2] (different monitor). In #intel-gfx on irc.freenode.net ajax suggested, to test it with VESA. Unfortunately I could not … [View More]

1 0

[PATCH] drm/omap: Remove cpu_is_omapXXXX usage in DMM
by Andy Gross 17 Oct '12

17 Oct '12

Removed usage of the cpu_is_omapXXXX in the DMM driver. This is no longer necessary as we can key off of the omap_dmm pointer that is only non-NULL if the device has been probed successfully. Signed-off-by: Andy Gross <andy.gross(a)ti.com> --- drivers/staging/omapdrm/omap_dmm_tiler.c | 2 +- drivers/staging/omapdrm/omap_dmm_tiler.h | 7 +------ drivers/staging/omapdrm/omap_gem.c | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/… [View More]

1 0

[PATCH 0/2] uapi: two minor changes
by Luis R. Rodriguez 16 Oct '12

16 Oct '12

From: "Luis R. Rodriguez" <mcgrof(a)do-not-panic.com> Here are a few minor updates to the UAPI changes [0]. The first one is to help with the backport effort [1], the second one is simply space cosmetic change to address my eyes bleeding while reviewing the changes on next-20121012 with git. If the changes on the first patch make sense perhaps similar changes can be done for the other subsystem in similar cases. In those cases the now kernel API header file no longer exists so even if … [View More]

3 7

[PATCH 01/11] drm: add drm_send_vblank_event() helper (v5)
by Rob Clark 16 Oct '12

16 Oct '12

From: Rob Clark <rob(a)ti.com> A helper that drivers can use to send vblank event after a pageflip. If the driver doesn't support proper vblank irq based time/seqn then just pass -1 for the pipe # to get do_gettimestamp() behavior (since there are a lot of drivers that don't use drm_vblank_count_and_time()) Also an internal send_vblank_event() helper for the various other code paths within drm_irq that also need to send vblank events. v1: original v2: add back 'vblwait->reply.… [View More]sequence = seq' which should not have been deleted v3: add WARN_ON() in case lock is not held and comments v4: use WARN_ON_SMP() instead to fix issue with !SMP && !DEBUG_SPINLOCK as pointed out by Marcin Slusarz v5: update docbook Signed-off-by: Rob Clark <rob(a)ti.com> --- Documentation/DocBook/drm.tmpl | 20 +++-------- drivers/gpu/drm/drm_irq.c | 74 ++++++++++++++++++++++++++++------------ include/drm/drmP.h | 2 ++ 3 files changed, 59 insertions(+), 37 deletions(-) diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index b030052..c9cbb3f 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl @@ -1141,23 +1141,13 @@ int max_width, max_height;</synopsis> the <methodname>page_flip</methodname> operation will be called with a non-NULL <parameter>event</parameter> argument pointing to a <structname>drm_pending_vblank_event</structname> instance. Upon page - flip completion the driver must fill the - <parameter>event</parameter>::<structfield>event</structfield> - <structfield>sequence</structfield>, <structfield>tv_sec</structfield> - and <structfield>tv_usec</structfield> fields with the associated - vertical blanking count and timestamp, add the event to the - <parameter>drm_file</parameter> list of events to be signaled, and wake - up any waiting process. This can be performed with + flip completion the driver must call <methodname>drm_send_vblank_event</methodname> + to fill in the event and send to wake up any waiting processes. + This can be performed with <programlisting><![CDATA[ - struct timeval now; - - event->event.sequence = drm_vblank_count_and_time(..., &now); - event->event.tv_sec = now.tv_sec; - event->event.tv_usec = now.tv_usec; - spin_lock_irqsave(&dev->event_lock, flags); - list_add_tail(&event->base.link, &event->base.file_priv->event_list); - wake_up_interruptible(&event->base.file_priv->event_wait); + ... + drm_send_vblank_event(dev, pipe, event); spin_unlock_irqrestore(&dev->event_lock, flags); ]]></programlisting> </para> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 076c4a8..9bdcfd5 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -802,6 +802,46 @@ u32 drm_vblank_count_and_time(struct drm_device *dev, int crtc, } EXPORT_SYMBOL(drm_vblank_count_and_time); +static void send_vblank_event(struct drm_device *dev, + struct drm_pending_vblank_event *e, + unsigned long seq, struct timeval *now) +{ + WARN_ON_SMP(!spin_is_locked(&dev->event_lock)); + e->event.sequence = seq; + e->event.tv_sec = now->tv_sec; + e->event.tv_usec = now->tv_usec; + + list_add_tail(&e->base.link, + &e->base.file_priv->event_list); + wake_up_interruptible(&e->base.file_priv->event_wait); + trace_drm_vblank_event_delivered(e->base.pid, e->pipe, + e->event.sequence); +} + +/** + * drm_send_vblank_event - helper to send vblank event after pageflip + * @dev: DRM device + * @crtc: CRTC in question + * @e: the event to send + * + * Updates sequence # and timestamp on event, and sends it to userspace. + * Caller must hold event lock. + */ +void drm_send_vblank_event(struct drm_device *dev, int crtc, + struct drm_pending_vblank_event *e) +{ + struct timeval now; + unsigned int seq; + if (crtc >= 0) { + seq = drm_vblank_count_and_time(dev, crtc, &now); + } else { + seq = 0; + do_gettimeofday(&now); + } + send_vblank_event(dev, e, seq, &now); +} +EXPORT_SYMBOL(drm_send_vblank_event); + /** * drm_update_vblank_count - update the master vblank counter * @dev: DRM device @@ -936,6 +976,13 @@ void drm_vblank_put(struct drm_device *dev, int crtc) } EXPORT_SYMBOL(drm_vblank_put); +/** + * drm_vblank_off - disable vblank events on a CRTC + * @dev: DRM device + * @crtc: CRTC in question + * + * Caller must hold event lock. + */ void drm_vblank_off(struct drm_device *dev, int crtc) { struct drm_pending_vblank_event *e, *t; @@ -955,15 +1002,9 @@ void drm_vblank_off(struct drm_device *dev, int crtc) DRM_DEBUG("Sending premature vblank event on disable: \ wanted %d, current %d\n", e->event.sequence, seq); - - e->event.sequence = seq; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; + list_del(&e->base.link); drm_vblank_put(dev, e->pipe); - list_move_tail(&e->base.link, &e->base.file_priv->event_list); - wake_up_interruptible(&e->base.file_priv->event_wait); - trace_drm_vblank_event_delivered(e->base.pid, e->pipe, - e->event.sequence); + send_vblank_event(dev, e, seq, &now); } spin_unlock_irqrestore(&dev->vbl_lock, irqflags); @@ -1107,15 +1148,9 @@ static int drm_queue_vblank_event(struct drm_device *dev, int pipe, e->event.sequence = vblwait->request.sequence; if ((seq - vblwait->request.sequence) <= (1 << 23)) { - e->event.sequence = seq; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; drm_vblank_put(dev, pipe); - list_add_tail(&e->base.link, &e->base.file_priv->event_list); - wake_up_interruptible(&e->base.file_priv->event_wait); + send_vblank_event(dev, e, seq, &now); vblwait->reply.sequence = seq; - trace_drm_vblank_event_delivered(current->pid, pipe, - vblwait->request.sequence); } else { /* drm_handle_vblank_events will call drm_vblank_put */ list_add_tail(&e->base.link, &dev->vblank_event_list); @@ -1256,14 +1291,9 @@ static void drm_handle_vblank_events(struct drm_device *dev, int crtc) DRM_DEBUG("vblank event on %d, current %d\n", e->event.sequence, seq); - e->event.sequence = seq; - e->event.tv_sec = now.tv_sec; - e->event.tv_usec = now.tv_usec; + list_del(&e->base.link); drm_vblank_put(dev, e->pipe); - list_move_tail(&e->base.link, &e->base.file_priv->event_list); - wake_up_interruptible(&e->base.file_priv->event_wait); - trace_drm_vblank_event_delivered(e->base.pid, e->pipe, - e->event.sequence); + send_vblank_event(dev, e, seq, &now); } spin_unlock_irqrestore(&dev->event_lock, flags); diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 05af0e7..ee8f927 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -1437,6 +1437,8 @@ extern int drm_vblank_wait(struct drm_device *dev, unsigned int *vbl_seq); extern u32 drm_vblank_count(struct drm_device *dev, int crtc); extern u32 drm_vblank_count_and_time(struct drm_device *dev, int crtc, struct timeval *vblanktime); +extern void drm_send_vblank_event(struct drm_device *dev, int crtc, + struct drm_pending_vblank_event *e); extern bool drm_handle_vblank(struct drm_device *dev, int crtc); extern int drm_vblank_get(struct drm_device *dev, int crtc); extern void drm_vblank_put(struct drm_device *dev, int crtc); -- 1.7.9.5 [View Less]

1 0

← Newer
1
...
53
54
55
56
57
58
59
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2012