dri-devel February 2013

dri-devel@lists.freedesktop.org

130 participants
696 discussions

[PATCH] drm/radeon: copy userspace cmd to local copy before processing it v3
by j.glisse＠gmail.com 08 Feb '13

08 Feb '13

From: Jerome Glisse <jglisse(a)redhat.com> In some rare case were packet is big enough to go over page boundary we might not have copied yet the userspace data into the local copy resulting in kernel reading garbage data. Without this patch kernel might submit unprocessed/unrelocated cmd to the GPU which might lead to GPU lockup. v2: Make sure we do copy all the page and don't forget some when the packet count dw is bigger than 1 page v3: Rebase patch against Linus master Signed-… [View More]off-by: Jerome Glisse <jglisse(a)redhat.com> --- drivers/gpu/drm/radeon/evergreen_cs.c | 35 ++++++++++++++++++++++++++++++++++- drivers/gpu/drm/radeon/r600_cs.c | 19 ++++++++++++++++++- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c index 7a44566..51ad74a 100644 --- a/drivers/gpu/drm/radeon/evergreen_cs.c +++ b/drivers/gpu/drm/radeon/evergreen_cs.c @@ -1021,7 +1021,7 @@ static int evergreen_cs_packet_parse(struct radeon_cs_parser *p, unsigned idx) { struct radeon_cs_chunk *ib_chunk = &p->chunks[p->chunk_ib_idx]; - uint32_t header; + uint32_t header, i, npages; if (idx >= ib_chunk->length_dw) { DRM_ERROR("Can not parse packet at %d after CS end %d !\n", @@ -1052,6 +1052,11 @@ static int evergreen_cs_packet_parse(struct radeon_cs_parser *p, pkt->idx, pkt->type, pkt->count, ib_chunk->length_dw); return -EINVAL; } + /* make sure we copied packet fully from userspace */ + npages = ((idx + pkt->count + 1) >> 10) - (idx >> 10); + for (i = 1; i <= npages; i++) { + radeon_get_ib_value(p, (idx & 0xfffffc00) + i * 0x400); + } return 0; } @@ -2909,12 +2914,16 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) return -EINVAL; } if (tiled) { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 6); dst_offset = ib[idx+1]; dst_offset <<= 8; ib[idx+1] += (u32)(dst_reloc->lobj.gpu_offset >> 8); p->idx += count + 7; } else { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 2); dst_offset = ib[idx+1]; dst_offset |= ((u64)(ib[idx+2] & 0xff)) << 32; @@ -2945,6 +2954,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) switch (misc) { case 0: /* L2T, frame to fields */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 9); if (idx_value & (1 << 31)) { DRM_ERROR("bad L2T, frame to fields DMA_PACKET_COPY\n"); return -EINVAL; @@ -2983,6 +2994,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 1: /* L2T, T2L partial */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 11); if (p->family < CHIP_CAYMAN) { DRM_ERROR("L2T, T2L Partial is cayman only !\n"); return -EINVAL; @@ -3005,6 +3018,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 3: /* L2T, broadcast */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 9); if (idx_value & (1 << 31)) { DRM_ERROR("bad L2T, broadcast DMA_PACKET_COPY\n"); return -EINVAL; @@ -3043,6 +3058,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 4: /* L2T, T2L */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 8); /* detile bit */ if (idx_value & (1 << 31)) { /* tiled src, linear dst */ @@ -3079,6 +3096,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 5: /* T2T partial */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 12); if (p->family < CHIP_CAYMAN) { DRM_ERROR("L2T, T2L Partial is cayman only !\n"); return -EINVAL; @@ -3089,6 +3108,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 7: /* L2T, broadcast */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 9); if (idx_value & (1 << 31)) { DRM_ERROR("bad L2T, broadcast DMA_PACKET_COPY\n"); return -EINVAL; @@ -3132,6 +3153,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) } else { switch (misc) { case 0: + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 8); /* detile bit */ if (idx_value & (1 << 31)) { /* tiled src, linear dst */ @@ -3176,6 +3199,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) switch (misc) { case 0: /* L2L, byte */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 4); src_offset = ib[idx+2]; src_offset |= ((u64)(ib[idx+4] & 0xff)) << 32; dst_offset = ib[idx+1]; @@ -3198,6 +3223,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 1: /* L2L, partial */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 8); if (p->family < CHIP_CAYMAN) { DRM_ERROR("L2L Partial is cayman only !\n"); return -EINVAL; @@ -3211,6 +3238,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) break; case 4: /* L2L, dw, broadcast */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 6); r = r600_dma_cs_next_reloc(p, &dst2_reloc); if (r) { DRM_ERROR("bad L2L, dw, broadcast DMA_PACKET_COPY\n"); @@ -3251,6 +3280,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) } } else { /* L2L, dw */ + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 4); src_offset = ib[idx+2]; src_offset |= ((u64)(ib[idx+4] & 0xff)) << 32; dst_offset = ib[idx+1]; @@ -3274,6 +3305,8 @@ int evergreen_dma_cs_parse(struct radeon_cs_parser *p) } break; case DMA_PACKET_CONSTANT_FILL: + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 3); r = r600_dma_cs_next_reloc(p, &dst_reloc); if (r) { DRM_ERROR("bad DMA_PACKET_CONSTANT_FILL\n"); diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 69ec24a..d36f9e6 100644 --- a/drivers/gpu/drm/radeon/r600_cs.c +++ b/drivers/gpu/drm/radeon/r600_cs.c @@ -796,7 +796,7 @@ static int r600_cs_packet_parse(struct radeon_cs_parser *p, unsigned idx) { struct radeon_cs_chunk *ib_chunk = &p->chunks[p->chunk_ib_idx]; - uint32_t header; + uint32_t header, i, npages; if (idx >= ib_chunk->length_dw) { DRM_ERROR("Can not parse packet at %d after CS end %d !\n", @@ -827,6 +827,11 @@ static int r600_cs_packet_parse(struct radeon_cs_parser *p, pkt->idx, pkt->type, pkt->count, ib_chunk->length_dw); return -EINVAL; } + /* make sure we copied packet fully from userspace */ + npages = ((idx + pkt->count + 1) >> 10) - (idx >> 10); + for (i = 1; i <= npages; i++) { + radeon_get_ib_value(p, (idx & 0xfffffc00) + i * 0x400); + } return 0; } @@ -2623,12 +2628,16 @@ int r600_dma_cs_parse(struct radeon_cs_parser *p) return -EINVAL; } if (tiled) { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 4); dst_offset = ib[idx+1]; dst_offset <<= 8; ib[idx+1] += (u32)(dst_reloc->lobj.gpu_offset >> 8); p->idx += count + 5; } else { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 2); dst_offset = ib[idx+1]; dst_offset |= ((u64)(ib[idx+2] & 0xff)) << 32; @@ -2654,6 +2663,8 @@ int r600_dma_cs_parse(struct radeon_cs_parser *p) return -EINVAL; } if (tiled) { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 6); idx_value = radeon_get_ib_value(p, idx + 2); /* detile bit */ if (idx_value & (1 << 31)) { @@ -2680,6 +2691,8 @@ int r600_dma_cs_parse(struct radeon_cs_parser *p) p->idx += 7; } else { if (p->family >= CHIP_RV770) { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 4); src_offset = ib[idx+2]; src_offset |= ((u64)(ib[idx+4] & 0xff)) << 32; dst_offset = ib[idx+1]; @@ -2691,6 +2704,8 @@ int r600_dma_cs_parse(struct radeon_cs_parser *p) ib[idx+4] += upper_32_bits(src_reloc->lobj.gpu_offset) & 0xff; p->idx += 5; } else { + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 3); src_offset = ib[idx+2]; src_offset |= ((u64)(ib[idx+3] & 0xff)) << 32; dst_offset = ib[idx+1]; @@ -2715,6 +2730,8 @@ int r600_dma_cs_parse(struct radeon_cs_parser *p) } break; case DMA_PACKET_CONSTANT_FILL: + /* make sure we copied packet fully from userspace */ + radeon_get_ib_value(p, idx + 3); if (p->family < CHIP_RV770) { DRM_ERROR("Constant Fill is 7xx only !\n"); return -EINVAL; -- 1.7.11.7 [View Less]

2 1

Re: [RFC v2 0/5] Common Display Framework
by Vikas Sajjan 08 Feb '13

08 Feb '13

Hi Laurent, Thanks for the reply. On 17 December 2012 20:55, Laurent Pinchart < laurent.pinchart(a)ideasonboard.com> wrote: > Hi Vikas, > > Sorry for the late reply. I now have more time to work on CDF, so delays > should be much shorter. > > On Thursday 06 December 2012 10:51:15 Vikas Sajjan wrote: > > Hi Laurent, > > > > I was thinking of porting CDF to samsung EXYNOS 5250 platform, what I > found > > is that, the exynos display controller … [View More]

6 16

[Bug 46006] New: [r300g, bisected] piglit glsl-max-varyings fails
by bugzilla-daemon＠freedesktop.org 08 Feb '13

08 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=46006 Bug #: 46006 Summary: [r300g, bisected] piglit glsl-max-varyings fails Classification: Unclassified Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Keywords: regression Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel(a)lists.freedesktop.org … [View More]

1 1

Re: radeon causing sleeping function called from invalid context
by Sergey Senozhatsky 08 Feb '13

08 Feb '13

On (01/12/13 20:27), Dave Jones wrote: > BUG: sleeping function called from invalid context at mm/slub.c:925 > in_atomic(): 1, irqs_disabled(): 0, pid: 566, name: Xorg > INFO: lockdep is turned off. > Pid: 566, comm: Xorg Not tainted 3.8.0-rc3+ #49 > Call Trace: > [<ffffffff81087ad1>] __might_sleep+0x141/0x200 > [<ffffffff8119eddb>] kmem_cache_alloc_trace+0x4b/0x2a0 > [<ffffffffa0083fb3>] ttm_bo_move_accel_cleanup+0x1d3/0x330 [ttm] > [<… [View More]ffffffffa00c5418>] radeon_move_blit.isra.4+0xf8/0x160 [radeon] > [<ffffffffa00c5db0>] radeon_bo_move+0xb0/0x1f0 [radeon] > [<ffffffffa00820ed>] ttm_bo_handle_move_mem+0x27d/0x5d0 [ttm] > [<ffffffff8108dd51>] ? get_parent_ip+0x11/0x50 > [<ffffffffa0083307>] ttm_bo_move_buffer+0x127/0x140 [ttm] > [<ffffffffa008717d>] ? ttm_eu_list_ref_sub+0x3d/0x60 [ttm] > [<ffffffffa00833c2>] ttm_bo_validate+0xa2/0x120 [ttm] > [<ffffffffa00c6f45>] radeon_bo_list_validate+0x75/0x90 [radeon] > [<ffffffffa00dca22>] radeon_cs_ioctl+0x582/0x950 [radeon] > [<ffffffffa002e573>] drm_ioctl+0x4d3/0x580 [drm] > [<ffffffffa00dc4a0>] ? radeon_cs_finish_pages+0xf0/0xf0 [radeon] > [<ffffffff811c49f9>] do_vfs_ioctl+0x99/0x5a0 > [<ffffffff812cd3d7>] ? file_has_perm+0x97/0xb0 > [<ffffffff81103715>] ? rcu_eqs_exit+0x65/0xb0 > [<ffffffff811c4f91>] sys_ioctl+0x91/0xb0 > [<ffffffff81695ad4>] tracesys+0xdd/0xe2 > I see lots of these [mostly from page fault], the following one (quick and dirty) works for me. ---- Forbid ttm_buffer_object_transfer() sleeping in ISR context, do not pass __GFP_WAIT flag to kzalloc(): BUG: sleeping function called from invalid context at mm/slub.c:925 in_atomic(): 1, irqs_disabled(): 0, pid: 2179, name: X 3 locks held by X/2179: #0: (&mm->mmap_sem){++++++}, at: [<ffffffff815fac53>] __do_page_fault+0xf3/0x590 #1: (&rdev->pm.mclk_lock){++++.+}, at: [<ffffffff81428e40>] radeon_ttm_fault+0x40/0x70 #2: (&(&bdev->fence_lock)->rlock){+.+.+.}, at: [<ffffffff813f3227>] ttm_bo_move_accel_cleanup+0x57/0x330 Pid: 2179, comm: X Not tainted 3.8.0-rc3-dbg-01259-gbdac2d4-dirty #1500 Call Trace: [<ffffffff8107adea>] __might_sleep+0x14a/0x200 [<ffffffff811649c3>] kmem_cache_alloc_trace+0x153/0x240 [<ffffffff813f33a3>] ttm_bo_move_accel_cleanup+0x1d3/0x330 [<ffffffff814292e8>] radeon_move_blit.isra.6+0xf8/0x160 [<ffffffff81429a90>] radeon_bo_move+0xb0/0x1f0 [<ffffffff813f14b5>] ttm_bo_handle_move_mem+0x275/0x5c0 [<ffffffff813f26f7>] ttm_bo_move_buffer+0x127/0x140 [<ffffffff813f27b2>] ttm_bo_validate+0xa2/0x130 [<ffffffff8142b0ed>] radeon_bo_fault_reserve_notify+0xad/0xe0 [<ffffffff813f4600>] ttm_bo_vm_fault+0x60/0x370 [<ffffffff81428e51>] radeon_ttm_fault+0x51/0x70 [<ffffffff8114150a>] __do_fault+0x6a/0x540 [<ffffffff81144771>] handle_pte_fault+0x91/0x810 [<ffffffff815fac53>] ? __do_page_fault+0xf3/0x590 [<ffffffff811464c1>] handle_mm_fault+0x231/0x330 [<ffffffff815facbc>] __do_page_fault+0x15c/0x590 [<ffffffff81184cd9>] ? do_vfs_ioctl+0x99/0x580 [<ffffffff815ff7c9>] ? sysret_check+0x22/0x5d [<ffffffff815fb11b>] do_page_fault+0x2b/0x50 [<ffffffff815f79a8>] page_fault+0x28/0x30 Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> --- drivers/gpu/drm/ttm/ttm_bo_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index d73d6e3..92e0dea 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_util.c +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c @@ -422,7 +422,7 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo, struct ttm_bo_device *bdev = bo->bdev; struct ttm_bo_driver *driver = bdev->driver; - fbo = kzalloc(sizeof(*fbo), GFP_KERNEL); + fbo = kzalloc(sizeof(*fbo), __GFP_IO | __GFP_FS); if (!fbo) return -ENOMEM; [View Less]

3 3

[git pull] drm regression fix
by Dave Airlie 08 Feb '13

08 Feb '13

Hi Linus, this one fixes a sleep while locked regression that was introduced earlier in 3.8. Dave. The following changes since commit 6bacaa9ddacb71c691d32c678d37bc59ffc71fac: Merge tag 'sound-3.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound (2013-02-07 08:43:30 +1100) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes for you to fetch changes up to ff7c60c580d9722f820d85c9c58ca55ecc1ee7c4: drm/ttm: fix fence locking in … [View More]

1 0

[Bug 60347] New: Reproducible GPU lockup CP stall in Amnesia game
by bugzilla-daemon＠freedesktop.org 08 Feb '13

08 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=60347 Priority: medium Bug ID: 60347 Assignee: dri-devel(a)lists.freedesktop.org Summary: Reproducible GPU lockup CP stall in Amnesia game Severity: normal Classification: Unclassified OS: Linux (All) Reporter: anonymous(a)dodgeit.com Hardware: x86-64 (AMD64) Status: NEW Version: git Component: Drivers/Gallium/r600 … [View More]Product: Mesa There is/are a reproducible GPU lockup in Amnesia: Dark Descent video game on Linux x86-64. Often it occurs when looking at certain doors in the levels. I find that using VT-switch helps to recover the GPU in a reasonable timeframe to a somewhat usable state. I do experience some jerkiness though after the stall recovery. Radeon 6750M 3.8.0-rc5 Everything else taken from xorg-edgers ppa I'm happy to investigate this issue further. [ 9902.661056] radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec [ 9902.661059] radeon 0000:01:00.0: GPU lockup (waiting for 0x0000000000049060) [ 9902.661062] radeon 0000:01:00.0: failed to get a new IB (-35) [ 9902.661063] [drm:radeon_cs_ib_chunk] *ERROR* Failed to get ib ! [ 9902.662124] radeon 0000:01:00.0: Saved 10007 dwords of commands on ring 0. [ 9902.662127] radeon 0000:01:00.0: GPU softreset: 0x00000003 [ 9902.673782] radeon 0000:01:00.0: GRBM_STATUS = 0xA7732CA4 [ 9902.673784] radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0x7C000005 [ 9902.673786] radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0x00000007 [ 9902.673787] radeon 0000:01:00.0: SRBM_STATUS = 0x200000C0 [ 9902.673789] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x04000000 [ 9902.673791] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x000C0000 [ 9902.673793] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00048402 [ 9902.673794] radeon 0000:01:00.0: R_008680_CP_STAT = 0x80860243 [ 9902.673796] radeon 0000:01:00.0: GRBM_SOFT_RESET=0x00007F6B [ 9902.673848] radeon 0000:01:00.0: GRBM_STATUS = 0x00003828 [ 9902.673850] radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0x00000007 [ 9902.673851] radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0x00000007 [ 9902.673853] radeon 0000:01:00.0: SRBM_STATUS = 0x200000C0 [ 9902.673855] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [ 9902.673857] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00000000 [ 9902.673858] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00000000 [ 9902.673860] radeon 0000:01:00.0: R_008680_CP_STAT = 0x00000000 [ 9902.691442] radeon 0000:01:00.0: GPU reset succeeded, trying to resume [ 9902.709761] [drm] probing gen 2 caps for device 8086:101 = 2/0 [ 9902.709765] [drm] PCIE gen 2 link speeds already enabled [ 9902.711799] [drm] PCIE GART of 512M enabled (table at 0x0000000000040000). [ 9902.711901] radeon 0000:01:00.0: WB enabled [ 9902.711904] radeon 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000040000c00 and cpu addr 0xffff880451db8c00 [ 9902.711905] radeon 0000:01:00.0: fence driver on ring 3 use gpu addr 0x0000000040000c0c and cpu addr 0xffff880451db8c0c [ 9902.728078] [drm] ring test on 0 succeeded in 3 usecs [ 9902.728142] [drm] ring test on 3 succeeded in 1 usecs [ 9902.777649] [drm] ib test on ring 0 succeeded in 0 usecs [ 9902.777738] [drm] ib test on ring 3 succeeded in 1 usecs [ 9914.739076] [drm] Forcing lvds to dual link mode on Apple MacBook Pro (Core i5/i7 Series) -- You are receiving this mail because: You are the assignee for the bug. [View Less]

1 7

[pull] radeon drm-next-3.9
by alexdeucher＠gmail.com 08 Feb '13

08 Feb '13

From: Alex Deucher <alexander.deucher(a)amd.com> Hi Dave, This is the first drm-next pull for 3.9 for radeon. Highlights: - CS ioctl cleanup and unification. Unification of a lot of functionality that was duplicated across multiple generates of hardware. - Add support for Oland GPUs - Deprecate UMS support. Mesa and the ddx dropped support for UMS and apparently very few people still use it since the UMS CS ioctl was broken for several kernels and no one reported it. It was fixed … [View More]in 3.8/stable. - Rework GPU reset. Use the status registers to determine what blocks to reset. This better matches the recommended reset programming model. This also allows us to properly reset blocks besides GFX and DMA. - Switch the VM set page code to use an IB rather than the ring. This fixes overflow issues when doing large page table updates using a small ring like DMA. - Several small cleanups and bug fixes. The following changes since commit 3646e4209f2bd0d09022ed792e594fb4f559b86c: drm/radeon: switch back to the CP ring for VM PT updates (2013-01-31 16:19:19 -0500) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-3.9 Alex Deucher (24): drm/radeon: add additional reset flags drm/radeon: add a bios scratch asic hung helper drm/radeon: rework GPU reset on r6xx/r7xx drm/radeon: rework GPU reset on evergreen drm/radeon: rework GPU reset on cayman/TN drm/radeon: rework GPU reset on cayman/TN drm/radeon: use status regs to determine what to reset (6xx/7xx) drm/radeon: use status regs to determine what to reset (evergreen) drm/radeon: use status regs to determine what to reset (cayman) drm/radeon: use status regs to determine what to reset (si) drm/radeon: halt engines before disabling MC (6xx/7xx) drm/radeon: halt engines before disabling MC (evergreen) drm/radeon: halt engines before disabling MC (cayman/TN) drm/radeon: halt engines before disabling MC (si) drm/radeon: use the reset mask to determine if rings are hung drm/radeon: don't reset the MC on IGPs/APUs drm/radeon: use IBs for VM page table updates v2 drm/radeon: switch back to using the DMA ring for VM PT updates drm/radeon: add Oland chip family drm/radeon: fill in gpu init for Oland drm/radeon: add ucode loading support for Oland drm/radeon: radeon-asic updates for Oland drm/radeon: add Oland pci ids drm/radeon/dce6: fix display powergating Christian König (1): drm/radeon: Deprecate UMS support v2 Ilija Hadzic (12): drm/radeon: remove unecessary assignment drm/radeon: remove unused prototype from radeon_cs drm/radeon: fix formatting drm/radeon: implement common cs packet parse function drm/radeon: use common cs packet parse function drm/radeon: factor out cs_next_is_pkt3_nop function drm/radeon: refactor vline packet parsing function drm/radeon: add a check to wait_reg_mem command drm/radeon: rename r100_cs_dump_packet to radeon_cs_dump_packet drm/radeon: pull out common next_reloc function drm/radeon: use common next_reloc function drm/radeon: consolidate redundant macros and constants Jerome Glisse (1): radeon/kms: cleanup async dma packet checking drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/radeon/Kconfig | 33 +- drivers/gpu/drm/radeon/Makefile | 10 +- drivers/gpu/drm/radeon/atombios_crtc.c | 6 +- drivers/gpu/drm/radeon/evergreen.c | 353 +++++++--- drivers/gpu/drm/radeon/evergreen_cs.c | 1149 +++++++++++++------------------- drivers/gpu/drm/radeon/evergreen_reg.h | 1 + drivers/gpu/drm/radeon/evergreend.h | 54 +- drivers/gpu/drm/radeon/ni.c | 339 ++++++---- drivers/gpu/drm/radeon/nid.h | 27 +- drivers/gpu/drm/radeon/r100.c | 224 ++----- drivers/gpu/drm/radeon/r100_track.h | 4 - drivers/gpu/drm/radeon/r100d.h | 11 - drivers/gpu/drm/radeon/r200.c | 26 +- drivers/gpu/drm/radeon/r300.c | 42 +- drivers/gpu/drm/radeon/r300_cmdbuf.c | 2 + drivers/gpu/drm/radeon/r300d.h | 11 - drivers/gpu/drm/radeon/r500_reg.h | 1 + drivers/gpu/drm/radeon/r600.c | 384 +++++++---- drivers/gpu/drm/radeon/r600_blit.c | 33 +- drivers/gpu/drm/radeon/r600_blit_kms.c | 31 + drivers/gpu/drm/radeon/r600_cp.c | 2 + drivers/gpu/drm/radeon/r600_cs.c | 332 +++------- drivers/gpu/drm/radeon/r600d.h | 17 +- drivers/gpu/drm/radeon/radeon.h | 31 +- drivers/gpu/drm/radeon/radeon_asic.c | 52 +- drivers/gpu/drm/radeon/radeon_asic.h | 17 +- drivers/gpu/drm/radeon/radeon_cp.c | 2 + drivers/gpu/drm/radeon/radeon_cs.c | 176 +++++- drivers/gpu/drm/radeon/radeon_device.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 70 +- drivers/gpu/drm/radeon/radeon_drv.h | 16 +- drivers/gpu/drm/radeon/radeon_family.h | 1 + drivers/gpu/drm/radeon/radeon_gart.c | 60 +- drivers/gpu/drm/radeon/radeon_irq.c | 2 + drivers/gpu/drm/radeon/radeon_mem.c | 2 + drivers/gpu/drm/radeon/radeon_reg.h | 15 + drivers/gpu/drm/radeon/radeon_ring.c | 19 + drivers/gpu/drm/radeon/radeon_state.c | 2 + drivers/gpu/drm/radeon/rv515d.h | 11 - drivers/gpu/drm/radeon/si.c | 478 ++++++++++---- drivers/gpu/drm/radeon/sid.h | 25 +- include/drm/drm_pciids.h | 13 + 43 files changed, 2199 insertions(+), 1887 deletions(-) [View Less]

1 0

[Bug 26891] Radeon KMS fails with inaccessible AtomBIOS on systems with (U)EFI boot
by bugzilla-daemon＠freedesktop.org 08 Feb '13

08 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=26891 --- Comment #54 from Austin Lund <austin.lund(a)gmail.com> --- This does seem to be fixed in 3.8 series kernels. I just tested 3.8-rc6 and booted fine into radeondrmfb. I could get the vgaswitcheroo to move between the integrated and discrete, but I couldn't get the intel console to work (will have to check my config). -- You are receiving this mail because: You are the assignee for the bug.

1 0

3.8-rc6: nouveau lockdep recursive lock acquisition
by Daniel J Blueman 07 Feb '13

07 Feb '13

>From recent additional locking in nouveau, it looks like we see recursive lock acquisition in 3.8-rc6: nouveau [ DEVICE][0000:01:00.0] BOOT0 : 0x0e7150a2 nouveau [ DEVICE][0000:01:00.0] Chipset: GK107 (NVE7) nouveau [ DEVICE][0000:01:00.0] Family : NVE0 nouveau [ VBIOS][0000:01:00.0] checking PRAMIN for image... nouveau [ VBIOS][0000:01:00.0] ... appears to be valid nouveau [ VBIOS][0000:01:00.0] using image from PRAMIN nouveau [ VBIOS][0000:01:00.0] BIT signature found nouveau [ … [View More]VBIOS][0000:01:00.0] version 80.07.26.04.01 nouveau [ PFB][0000:01:00.0] RAM type: GDDR5 nouveau [ PFB][0000:01:00.0] RAM size: 1024 MiB nouveau [ PFB][0000:01:00.0] ZCOMP: 0 tags init: gdm main process (960) killed by TERM signal vga_switcheroo: enabled [TTM] Zone kernel: Available graphics memory: 4038258 kiB [TTM] Zone dma32: Available graphics memory: 2097152 kiB [TTM] Initializing pool allocator [TTM] Initializing DMA pool allocator nouveau [ DRM] VRAM: 1024 MiB nouveau [ DRM] GART: 512 MiB nouveau [ DRM] BIT BIOS found nouveau [ DRM] Bios version 80.07.26.04 nouveau [ DRM] TMDS table version 2.0 nouveau [ DRM] DCB version 4.0 nouveau [ DRM] DCB outp 00: 048101b6 0f230010 nouveau [ DRM] DCB outp 01: 018212d6 0f220020 nouveau [ DRM] DCB outp 02: 01021212 00020020 nouveau [ DRM] DCB outp 03: 088324c6 0f220010 nouveau [ DRM] DCB outp 04: 08032402 00020010 nouveau [ DRM] DCB outp 05: 02843862 00020010 nouveau [ DRM] DCB conn 00: 00020047 nouveau [ DRM] DCB conn 01: 02208146 nouveau [ DRM] DCB conn 02: 01104246 nouveau [ DRM] DCB conn 03: 00410361 ============================================= [ INFO: possible recursive locking detected ] 3.8.0-rc6-ninja+ #1 Not tainted --------------------------------------------- modprobe/585 is trying to acquire lock: (&subdev->mutex){+.+.+.}, at: [<ffffffffa016c323>] nouveau_instobj_create_+0x43/0x90 [nouveau] but task is already holding lock: (&subdev->mutex){+.+.+.}, at: [<ffffffffa017672d>] nv50_disp_data_ctor+0x5d/0xd0 [nouveau] other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&subdev->mutex); lock(&subdev->mutex); *** DEADLOCK *** May be due to missing lock nesting notation 4 locks held by modprobe/585: #0: (&__lockdep_no_validate__){......}, at: [<ffffffff813075f3>] __driver_attach+0x53/0xb0 #1: (&__lockdep_no_validate__){......}, at: [<ffffffff81307601>] __driver_attach+0x61/0xb0 #2: (drm_global_mutex){+.+.+.}, at: [<ffffffff812ee59c>] drm_get_pci_dev+0xbc/0x2b0 #3: (&subdev->mutex){+.+.+.}, at: [<ffffffffa017672d>] nv50_disp_data_ctor+0x5d/0xd0 [nouveau] stack backtrace: Pid: 585, comm: modprobe Not tainted 3.8.0-rc6-expert+ #1 Call Trace: [<ffffffff8108fde2>] validate_chain.isra.33+0xd72/0x10d0 [<ffffffff8105fa08>] ? __kernel_text_address+0x58/0x80 [<ffffffff8100575d>] ? print_context_stack+0x5d/0xd0 [<ffffffff81090bc1>] __lock_acquire+0x3a1/0xb60 [<ffffffff8108d504>] ? __lock_is_held+0x54/0x80 [<ffffffff8109184a>] lock_acquire+0x5a/0x70 [<ffffffffa016c323>] ? nouveau_instobj_create_+0x43/0x90 [nouveau] [<ffffffff81558739>] mutex_lock_nested+0x69/0x340 [<ffffffffa016c323>] ? nouveau_instobj_create_+0x43/0x90 [nouveau] [<ffffffffa0152370>] ? nouveau_object_create_+0x60/0xa0 [nouveau] [<ffffffffa016c323>] nouveau_instobj_create_+0x43/0x90 [nouveau] [<ffffffffa016cf8c>] nv50_instobj_ctor+0x4c/0xf0 [nouveau] [<ffffffffa0152163>] nouveau_object_ctor+0x33/0xc0 [nouveau] [<ffffffffa016cd51>] nv50_instmem_alloc+0x21/0x30 [nouveau] [<ffffffffa0150917>] nouveau_gpuobj_create_+0x247/0x2f0 [nouveau] [<ffffffff8155b35a>] ? _raw_spin_unlock_irqrestore+0x3a/0x70 [<ffffffff810921fd>] ? trace_hardirqs_on_caller+0x10d/0x1a0 [<ffffffffa014f4bc>] nouveau_engctx_create_+0x25c/0x2a0 [nouveau] [<ffffffffa0176791>] nv50_disp_data_ctor+0xc1/0xd0 [nouveau] [<ffffffffa0153722>] ? nouveau_subdev_reset+0x52/0x60 [nouveau] [<ffffffffa0152163>] nouveau_object_ctor+0x33/0xc0 [nouveau] [<ffffffffa0152a42>] nouveau_object_new+0x112/0x240 [nouveau] [<ffffffffa01f4b1d>] nv50_display_create+0x18d/0x860 [nouveau] [<ffffffff8105cb5d>] ? __cancel_work_timer+0x6d/0xc0 [<ffffffffa01db8eb>] nouveau_display_create+0x3cb/0x670 [nouveau] [<ffffffffa01cb1bf>] nouveau_drm_load+0x26f/0x590 [nouveau] [<ffffffff81304c99>] ? device_register+0x19/0x20 [<ffffffff812efe91>] ? drm_sysfs_device_add+0x81/0xb0 [<ffffffff812ee65e>] drm_get_pci_dev+0x17e/0x2b0 [<ffffffff81245e56>] ? __pci_set_master+0x26/0x80 [<ffffffffa01cab2a>] nouveau_drm_probe+0x25a/0x2a0 [nouveau] [<ffffffff8124a386>] local_pci_probe+0x46/0x80 [<ffffffff8124ac11>] pci_device_probe+0x101/0x110 [<ffffffff813073d6>] driver_probe_device+0x76/0x240 [<ffffffff81307643>] __driver_attach+0xa3/0xb0 [<ffffffff813075a0>] ? driver_probe_device+0x240/0x240 [<ffffffff8130564d>] bus_for_each_dev+0x4d/0x90 [<ffffffff81306f39>] driver_attach+0x19/0x20 [<ffffffff81306af0>] bus_add_driver+0x1a0/0x270 [<ffffffffa023d000>] ? 0xffffffffa023cfff [<ffffffff81307cd2>] driver_register+0x72/0x170 [<ffffffffa023d000>] ? 0xffffffffa023cfff [<ffffffff8124ad0f>] __pci_register_driver+0x5f/0x70 [<ffffffff812ee8a5>] drm_pci_init+0x115/0x130 [<ffffffffa023d000>] ? 0xffffffffa023cfff [<ffffffffa023d000>] ? 0xffffffffa023cfff [<ffffffffa023d04d>] nouveau_drm_init+0x4d/0x1000 [nouveau] [<ffffffff810002da>] do_one_initcall+0x11a/0x170 [<ffffffff8109d044>] load_module+0xe84/0x1470 [<ffffffff81098c30>] ? in_lock_functions+0x20/0x20 [<ffffffff8122c22e>] ? trace_hardirqs_on_thunk+0x3a/0x3f [<ffffffff8109d6e7>] sys_init_module+0xb7/0xe0 [<ffffffff8155c156>] system_call_fastpath+0x1a/0x1f [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [drm] No driver support for vblank timestamp query. nouveau W[ DRM] voltage table 0x50 unknown nouveau [ DRM] 4 available performance level(s) nouveau [ DRM] 1: core 209MHz shader 419MHz memory 405MHz voltage 520mV nouveau [ DRM] 2: core 390MHz shader 780MHz memory 1080MHz voltage 610mV nouveau [ DRM] 3: core 1000MHz shader 2000MHz memory 1080MHz voltage 630mV nouveau [ DRM] 4: core 1254MHz shader 2508MHz memory 1080MHz voltage 630mV nouveau [ DRM] c: nouveau [ DRM] MM: using COPY for buffer copies nouveau 0000:01:00.0: No connectors reported connected with modes [drm] Cannot find any crtc or sizes - going 1024x768 nouveau [ DRM] allocated 1024x768 fb: 0x80000, bo ffff88025b966800 nouveau 0000:01:00.0: fb1: nouveaufb frame buffer device [drm] Initialized nouveau 1.1.0 20120801 for 0000:01:00.0 on minor 1 snd_hda_intel 0000:01:00.1: enabling device (0000 -> 0002) hda-intel 0000:01:00.1: Handle VGA-switcheroo audio client snd_hda_intel 0000:01:00.1: irq 49 for MSI/MSI-X input: HDA NVidia HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input11 input: HDA NVidia HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input12 input: HDA NVidia HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input13 hda-intel 0000:01:00.1: Disabling via VGA-switcheroo VGA switcheroo: switched nouveau off nouveau [ DRM] suspending fbcon... nouveau [ DRM] suspending display... nouveau [ DRM] unpinning framebuffer(s)... nouveau [ DRM] evicting buffers... nouveau [ DRM] suspending client object trees... nouveau E[ I2C][0000:01:00.0] AUXCH(3): begin idle timeout 0xffffffff nouveau E[ I2C][0000:01:00.0] AUXCH(2): begin idle timeout 0xffffffff nouveau E[ I2C][0000:01:00.0] AUXCH(1): begin idle timeout 0xffffffff applesmc: light sensor data length set to 10 nouveau E[ I2C][0000:01:00.0] AUXCH(1): begin idle timeout 0xffffffff nouveau E[ I2C][0000:01:00.0] AUXCH(3): begin idle timeout 0xffffffff nouveau E[ I2C][0000:01:00.0] AUXCH(2): begin idle timeout 0xffffffff -- Daniel J Blueman [View Less]

5 5

[Bug 60034] New: rv790 etqw regression since r600g: add async for staging buffer upload v2
by bugzilla-daemon＠freedesktop.org 07 Feb '13

07 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=60034 Priority: medium Bug ID: 60034 Assignee: dri-devel(a)lists.freedesktop.org Summary: rv790 etqw regression since r600g: add async for staging buffer upload v2 Severity: normal Classification: Unclassified OS: Linux (All) Reporter: lists(a)andyfurniss.entadsl.com Hardware: x86 (IA32) Status: NEW Version: git … [View More]

1 17

← Newer
1
...
60
61
62
63
64
65
66
...
70
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2013