dri-devel May 2013

dri-devel@lists.freedesktop.org

116 participants
705 discussions

[PATCH 1/1] drm/exynos: Remove redundant use of of_match_ptr macro
by Sachin Kamat 22 May '13

22 May '13

'mixer_match_types' is always compiled in. Hence of_match_ptr is not necessary. Signed-off-by: Sachin Kamat <sachin.kamat(a)linaro.org> --- drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index ec3e376..ec45064 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -1186,7 +1186,7 @@ static int mixer_probe(struct platform_device *pdev) if (dev->of_node) { const struct of_device_id *match; - match = of_match_node(of_match_ptr(mixer_match_types), + match = of_match_node(mixer_match_types, pdev->dev.of_node); drv = (struct mixer_drv_data *)match->data; } else { -- 1.7.9.5

1 0

[PATCH] drm/exynos: wait for the completion of pending page flip
by Inki Dae 22 May '13

22 May '13

This patch fixes the issue that drm_vblank_get() is failed. The issus occurs when next page flip request is tried if previous page flip event wasn't completed yet and then dpms became off. So this patch make sure that page flip event is completed before dpms goes to off. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index e8894bc..69a77e9 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -48,6 +48,8 @@ struct exynos_drm_crtc { unsigned int pipe; unsigned int dpms; enum exynos_crtc_mode mode; + wait_queue_head_t pending_flip_queue; + atomic_t pending_flip; }; static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) @@ -61,6 +63,13 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) return; } + if (mode > DRM_MODE_DPMS_ON) { + /* wait for the completion of page flip. */ + wait_event(exynos_crtc->pending_flip_queue, + atomic_read(&exynos_crtc->pending_flip) == 0); + drm_vblank_off(crtc->dev, exynos_crtc->pipe); + } + exynos_drm_fn_encoder(crtc, &mode, exynos_drm_encoder_crtc_dpms); exynos_crtc->dpms = mode; } @@ -225,6 +234,7 @@ static int exynos_drm_crtc_page_flip(struct drm_crtc *crtc, spin_lock_irq(&dev->event_lock); list_add_tail(&event->base.link, &dev_priv->pageflip_event_list); + atomic_set(&exynos_crtc->pending_flip, 1); spin_unlock_irq(&dev->event_lock); crtc->fb = fb; @@ -344,6 +354,8 @@ int exynos_drm_crtc_create(struct drm_device *dev, unsigned int nr) exynos_crtc->pipe = nr; exynos_crtc->dpms = DRM_MODE_DPMS_OFF; + init_waitqueue_head(&exynos_crtc->pending_flip_queue); + atomic_set(&exynos_crtc->pending_flip, 0); exynos_crtc->plane = exynos_plane_init(dev, 1 << nr, true); if (!exynos_crtc->plane) { kfree(exynos_crtc); @@ -398,6 +410,8 @@ void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc) { struct exynos_drm_private *dev_priv = dev->dev_private; struct drm_pending_vblank_event *e, *t; + struct drm_crtc *drm_crtc = dev_priv->crtc[crtc]; + struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(drm_crtc); struct timeval now; unsigned long flags; @@ -419,6 +433,8 @@ void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc) list_move_tail(&e->base.link, &e->base.file_priv->event_list); wake_up_interruptible(&e->base.file_priv->event_wait); drm_vblank_put(dev, crtc); + atomic_set(&exynos_crtc->pending_flip, 0); + wake_up(&exynos_crtc->pending_flip_queue); } spin_unlock_irqrestore(&dev->event_lock, flags); -- 1.7.5.4

4 9

[PATCH 00/11] page-flip cleanups and fixes
by Rob Clark 22 May '13

22 May '13

From: Rob Clark <rob(a)ti.com> Add a helper fxn to send vblank event after pageflip, plus a handful of fixes for other issues that I noticed in the process. Other than OMAP, the changes are just compile tested, so would be good to get a quick look from the maintainers of various drivers. Rob Clark (11): drm: add drm_send_vblank_event() helper drm/i915: use drm_send_vblank_event() helper drm/nouveau: use drm_send_vblank_event() helper drm/radeon: use drm_send_vblank_event() helper drm/exynos: use drm_send_vblank_event() helper drm/exynos: page flip fixes drm/shmob: use drm_send_vblank_event() helper drm/imx: use drm_send_vblank_event() helper drm/imx: page flip fixes drm/omap: use drm_send_vblank_event() helper drm/omap: page-flip fixes drivers/gpu/drm/drm_irq.c | 65 +++++++++++++++++++---------- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 1 - drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10 +---- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 10 +---- drivers/gpu/drm/exynos/exynos_mixer.c | 9 +--- drivers/gpu/drm/i915/intel_display.c | 15 +------ drivers/gpu/drm/nouveau/nouveau_display.c | 13 +----- drivers/gpu/drm/radeon/radeon_display.c | 13 ++---- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 19 ++------- drivers/staging/imx-drm/ipuv3-crtc.c | 32 ++++---------- drivers/staging/omapdrm/omap_crtc.c | 37 ++++------------ include/drm/drmP.h | 2 + 12 files changed, 78 insertions(+), 148 deletions(-) -- 1.7.9.5

12 37

linux-next: build warning after merge of the final tree (drm-intel tree related)
by Stephen Rothwell 22 May '13

22 May '13

Hi , After merging the final tree, today's linux-next build (i386 defconfig) produced this warning: drivers/gpu/drm/i915/i915_gem.c:2978:3: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' [-Wformat] Introduced by commit e4341d0356bc ("drm/i915: Be more informative when reporting "too large for aperture" error") from the drm-intel tree. -- Cheers, Stephen Rothwell sfr(a)canb.auug.org.au http://www.canb.auug.org.au/~sfr/

1 0

[Bug 63236] New: kwin crashes when some desktop effects are used
by bugzilla-daemon＠freedesktop.org 21 May '13

21 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=63236 Priority: medium Bug ID: 63236 Assignee: dri-devel(a)lists.freedesktop.org Summary: kwin crashes when some desktop effects are used Severity: normal Classification: Unclassified OS: All Reporter: omegatype(a)gmail.com Hardware: Other Status: NEW Version: 9.1 Component: Drivers/Gallium/radeonsi Product: Mesa Created attachment 77558 --> https://bugs.freedesktop.org/attachment.cgi?id=77558&action=edit kwin command output (stdout and stderr) Kwin crashes when using 'Desktop Grid' or 'Taskbar Thumnails'. Sowtware: Arch Linux 3.8.5-1-ARCH x86_64 KDE 4.10.2 OpenGL and Raster set in KDE System Settings. Some version accorging to log: OpenGL vendor string: X.Org OpenGL renderer string: Gallium 0.4 on AMD PITCAIRN OpenGL version string: 2.1 Mesa 9.1.1 OpenGL shading language version string: 1.20 Driver: Unknown GPU class: Unknown OpenGL version: 2.1 GLSL version: 1.20 Mesa version: 9.1.1 X server version: 1.14 Linux kernel version: 3.8.5 Direct rendering: yes Requires strict binding: yes GLSL shaders: yes Texture NPOT support: yes Virtual Machine: no Hardware: ATI Radeon HD7870 detected as: 01:00.0 VGA compatible controller: Advanced Micro Devices [AMD] nee ATI Pitcairn [Radeon HD 7800] -- You are receiving this mail because: You are the assignee for the bug.

1 4

[PATCH] drm/radeon: fix typo in cu_per_sh on verde
by alexdeucher＠gmail.com 21 May '13

21 May '13

From: Alex Deucher <alexander.deucher(a)amd.com> Should be 5 rather than 2. Noticed by sroland and glisse on IRC. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/radeon/si.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index 113ed9f..34d431e 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c @@ -2435,7 +2435,7 @@ static void si_gpu_init(struct radeon_device *rdev) default: rdev->config.si.max_shader_engines = 1; rdev->config.si.max_tile_pipes = 4; - rdev->config.si.max_cu_per_sh = 2; + rdev->config.si.max_cu_per_sh = 5; rdev->config.si.max_sh_per_se = 2; rdev->config.si.max_backends_per_se = 4; rdev->config.si.max_texture_channel_caches = 4; -- 1.7.7.5

1 0

[PATCH] drm/radeon: UVD block on SUMO2 is the same as on SUMO
by Christian König 21 May '13

21 May '13

From: Christian König <christian.koenig(a)amd.com> The chip id for SUMO2 isn't used. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/radeon/rv770.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv770.c b/drivers/gpu/drm/radeon/rv770.c index 83f612a..3fc2985 100644 --- a/drivers/gpu/drm/radeon/rv770.c +++ b/drivers/gpu/drm/radeon/rv770.c @@ -862,10 +862,8 @@ int rv770_uvd_resume(struct radeon_device *rdev) chip_id = 0x0100000b; break; case CHIP_SUMO: - chip_id = 0x0100000c; - break; case CHIP_SUMO2: - chip_id = 0x0100000d; + chip_id = 0x0100000c; break; case CHIP_PALM: chip_id = 0x0100000e; -- 1.7.9.5

2 1

Re: Genereal question regarding kernel development
by Daniel Vetter 21 May '13

21 May '13

On Tue, May 21, 2013 at 4:30 PM, Jan Niggemann <jn(a)hz6.de> wrote: > Hi Daniel, > > you misunderstood my mail, I just wanted to know: > > Are patches in patchwork that correct kernel bugs in any way linked to > bugzilla issues and if so, how? > In other words: What bugzilla bug corresponds to > https://patchwork.kernel.org/patch/2402211/ ? There's no bug rebort for this issue in kernel bugzilla afaik. And please don't drop cc's. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

1 0

Re: Genereal question regarding kernel development
by Daniel Vetter 21 May '13

21 May '13

Hi Jan, First things first, please _always_ cc relevant mailing lists. Second: I've submitted a proper patch to revert this behaviour change, but it has been nacked. I've poked Dave Airlie about it again on irc. See https://patchwork.kernel.org/patch/2402211/ Thanks, Daniel On Tue, May 21, 2013 at 3:28 PM, Jan Niggemann <jn(a)hz6.de> wrote: > Hi Daniel, > > sorry for bothering you directly, but being a kernel dev you can probably > answer my question: > I read what "patchwork" is and what it's used for; I also understand that > bugs are tracked in bugzilla and that both are separate systems. > My question is: > I'm affected by this: https://patchwork.kernel.org/patch/2400621/ > I expected this patch to be somehow linked to a bugzilla entry I could > subscribe to (in order to get updates on issue)... > But I'm unable to find a bug in bugzilla regarding "kworker irq storm" or > similar... > > Are patches in patchwork that correct kernel bugs in any way linked to > bugzilla issues and if so, how? > Thank you for your time! > > Regards > Jan -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

1 0

[Bug 64193] New: LLVM RV670 regression since R600: Packetize instructions
by bugzilla-daemon＠freedesktop.org 21 May '13

21 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=64193 Priority: medium Bug ID: 64193 CC: vljn(a)ovi.com Assignee: dri-devel(a)lists.freedesktop.org Summary: LLVM RV670 regression since R600: Packetize instructions Severity: normal Classification: Unclassified OS: Linux (All) Reporter: adf.lists(a)gmail.com Hardware: x86 (IA32) Status: NEW Version: git Component: Drivers/Gallium/r600 Product: Mesa My AGP rv670 box has been in pieces for a while so no testing until today. It seems that it suffers from the same regression as my 790 - https://bugs.freedesktop.org/show_bug.cgi?id=64096 but the fixes for that do not help. With llvm set on - commit 25f259cde28860ea76c2f5628010968945a28edb Author: Vincent Lejeune <vljn(a)ovi.com> Date: Tue Apr 30 00:14:27 2013 +0000 R600: Packetize instructions git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@180760 91177308-0d34-0410-b5e6-96231b3b80d8 the issue is there, the commit before and rendering is OK. -- You are receiving this mail because: You are the assignee for the bug.

1 26

← Newer
1
...
54
55
56
57
58
59
60
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2013