dri-devel May 2013

dri-devel@lists.freedesktop.org

116 participants
705 discussions

[Bug 64801] Seeing repeatable DRM relocation error messages with RV710 board
by bugzilla-daemon＠freedesktop.org 20 May '13

20 May '13

1 0

[Bug 32006] KMS/R100 - [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!
by bugzilla-daemon＠freedesktop.org 20 May '13

20 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=32006 --- Comment #16 from Philip Prindeville <philipp(a)redfish-solutions.com> --- (In reply to comment #15) > Please file a different bug. The original report was for R1xx asics. You > have an R7xx asic. Also, in the future, please attach files. The link you > provided doesn't work. I tried to attach a screenshot but it was 12MB and the limit is 3MB. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 32006] KMS/R100 - [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!
by bugzilla-daemon＠freedesktop.org 20 May '13

20 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=32006 --- Comment #15 from Alex Deucher <agd5f(a)yahoo.com> --- Please file a different bug. The original report was for R1xx asics. You have an R7xx asic. Also, in the future, please attach files. The link you provided doesn't work. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 32006] KMS/R100 - [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!
by bugzilla-daemon＠freedesktop.org 20 May '13

20 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=32006 --- Comment #14 from Philip Prindeville <philipp(a)redfish-solutions.com> --- Here's a screenshot showing RGB 'snow' as the background and random bits of backing store buffer at the bottom of both screens. Note that both screens (HDMI-0 on the left and DVI-0 on the right) are on the Radeon 4350 card. ftp://ftp.redfish-solutions.com/pub/Screenshot from 2013-05-20 14:42:55.png -- You are receiving this mail because: You are the assignee for the bug.

1 0

[pull] radeon drm-fixes-3.10-sun
by alexdeucher＠gmail.com 20 May '13

20 May '13

From: Alex Deucher <alexander.deucher(a)amd.com> Hi Dave, This is the pull request for AMD Sun/Hainan support. I've split it out separately from my regular fixes stream. Hainan is a new SI asic with no UVD or DCE hardware. The patches are minimally invasive; basically just pci ids and skipping UVD and DCE init for this family. Most of the changes to si.c are just the golden register tables for the family. The following changes since commit 731da21b7b205efb388481f7a9731c4c1ca3b48c: drm/radeon/dce2: use 10khz units for audio dto calculation (2013-05-20 10:44:58 -0400) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-3.10-sun Alex Deucher (9): drm/radeon: add chip family for Hainan drm/radeon: fill in GPU init for Hainan (v2) drm/radeon: don't touch DCE or VGA regs on Hainan (v3) drm/radeon: fill in ucode loading support for Hainan drm/radeon: radeon-asic updates for Hainan drm/radeon: track which asics have UVD drm/radeon: sun/hainan chips do not have UVD (v2) drm/radeon: add golden register settings for Hainan (v2) drm/radeon: add Hainan pci ids drivers/gpu/drm/radeon/evergreen.c | 27 ++- drivers/gpu/drm/radeon/radeon.h | 2 + drivers/gpu/drm/radeon/radeon_asic.c | 22 ++- drivers/gpu/drm/radeon/radeon_bios.c | 28 ++- drivers/gpu/drm/radeon/radeon_device.c | 1 + drivers/gpu/drm/radeon/radeon_family.h | 1 + drivers/gpu/drm/radeon/si.c | 366 ++++++++++++++++++++++++++------ drivers/gpu/drm/radeon/sid.h | 1 + include/drm/drm_pciids.h | 6 + 9 files changed, 362 insertions(+), 92 deletions(-)

1 0

[pull] radeon drm-fixes-3.10
by alexdeucher＠gmail.com 20 May '13

20 May '13

From: Alex Deucher <alexander.deucher(a)amd.com> Hi Dave, Just some minor bug fixes. The following changes since commit b7cb1c50c828adaee95e8ada0e55918686245992: Merge branch 'drm-nouveau-fixes-3.10' of git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-05-20 13:31:36 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-3.10 Alex Deucher (1): drm/radeon/dce2: use 10khz units for audio dto calculation Niels Ole Salscheider (2): drm/radeon: Remove superfluous variable drm/radeon: Fix VRAM size calculation for VRAM >= 4GB drivers/gpu/drm/radeon/atombios_crtc.c | 6 ------ drivers/gpu/drm/radeon/evergreen.c | 4 ++-- drivers/gpu/drm/radeon/evergreen_hdmi.c | 7 +++---- drivers/gpu/drm/radeon/r600_hdmi.c | 9 ++++----- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 4 ---- drivers/gpu/drm/radeon/radeon_mode.h | 1 - drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- drivers/gpu/drm/radeon/si.c | 4 ++-- 8 files changed, 12 insertions(+), 25 deletions(-)

1 0

[Bug 58521] New: Radeon ATOM BIOS have wrong value in controller->ucType for RV635
by bugzilla-daemon＠bugzilla.kernel.org 20 May '13

20 May '13

https://bugzilla.kernel.org/show_bug.cgi?id=58521 Summary: Radeon ATOM BIOS have wrong value in controller->ucType for RV635 Product: Drivers Version: 2.5 Kernel Version: 3.5.0 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) AssignedTo: drivers_video-dri(a)kernel-bugs.osdl.org ReportedBy: guram.savinov(a)gmail.com Regression: No I have Asus M50Sa laptop with ATI Radeon Mobility HD3650(RV635 chip) graphics. RV635 chip have internal thermal sensor, but for my graphics it's no hwmon entry in /sys/class/hwmon. I found that in radeon_atombios.c it's checking for thermal sensor from ATOM BIOS structure: ################################## static void radeon_atombios_add_pplib_thermal_controller(struct radeon_device *rdev, ATOM_PPLIB_THERMALCONTROLLER *controller) { struct radeon_i2c_bus_rec i2c_bus; /* add the i2c bus for thermal/fan chip */ if (controller->ucType > 0) { if (controller->ucType == ATOM_PP_THERMALCONTROLLER_RV6xx) { DRM_INFO("Internal thermal controller %s fan control\n", (controller->ucFanParameters & ATOM_PP_FANPARAMETERS_NOFAN) ? "without" : "with"); rdev->pm.int_thermal_type = THERMAL_TYPE_RV6XX; } else if (controller->ucType == ATOM_PP_THERMALCONTROLLER_RV770) { ... ################################### But for my graphics controller->ucType have 0, that mean ATOM_PP_THERMALCONTROLLER_NONE. I try to set THERMAL_TYPE_RV6XX to controller->ucType, hwmon was added and I have thermal sensor for my RV635 chip, all works great. May be it's Asus M50Sa ATOM BIOS bug, but why you check thermal sensor for RV635? Is it possible to have RV635 chip without internal thermal sensor? It'll be great to not check thermal sensor type for RV635 chip, because AMD say that it shipped with internal thermal sensor. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 12

[Bug 61747] New: [r600g] GPU lockup when playing WoW with 3.8.1 kernel.
by bugzilla-daemon＠freedesktop.org 20 May '13

20 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=61747 Priority: medium Bug ID: 61747 Assignee: dri-devel(a)lists.freedesktop.org Summary: [r600g] GPU lockup when playing WoW with 3.8.1 kernel. Severity: major Classification: Unclassified OS: Linux (All) Reporter: rankincj(a)googlemail.com Hardware: x86-64 (AMD64) Status: NEW Version: git Component: Drivers/Gallium/r600 Product: Mesa Created attachment 75852 --> https://bugs.freedesktop.org/attachment.cgi?id=75852&action=edit dmesg output, showing lockup and failed reset. Playing WoW on Fedora's kernel-3.8.1-201.fc18.x86_64, and the GPU locked up moments later. A GPU reset did not succeed in restoring anything, and I was forced to "kill -HUP" the Xorg process from a virtual console. Mesa's git HEAD is: commit 0b6e72f8d75a31ef233ad5be0c9f59497880657f Author: Brian Paul <brianp(a)vmware.com> Date: Fri Mar 1 17:36:34 2013 -0700 st/mesa: add switch case for ir_txf_ms to silence warning -- You are receiving this mail because: You are the assignee for the bug.

1 16

[RFC] drm: i2c: add irq handler for tda998x slave encoder
by Sebastian Hesselbarth 20 May '13

20 May '13

This adds an irq handler for HPD to the tda998x slave encoder driver to trigger HPD change instead of polling. The gpio connected to int pin of tda998x is passed through platform_data of the i2c client. As HPD will ultimately cause EDID read and that will raise an EDID_READ_DONE interrupt, the irq handling is done threaded with a workqueue to notify drm backend of HPD events. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth(a)gmail.com> --- Cc: David Airlie <airlied(a)linux.ie> Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> Cc: Rob Clark <robdclark(a)gmail.com> Cc: Daniel Vetter Cc: dri-devel(a)lists.freedesktop.org Cc: linux-kernel(a)vger.kernel.org This patch currently is based on top of Russell King's Dove DRM driver. I only have DT (plus the patches to get the above running) I post it as an RFC first. To rebase it on top of v3.10-rc1, I would just have to create include/drm/i2c/tda998x.h without rmk's initial include. @Russell: TDA19988 int line on Cubox is on mpp27. Sebastian --- drivers/gpu/drm/i2c/tda998x_drv.c | 134 +++++++++++++++++++++++++++++++++---- include/drm/i2c/tda998x.h | 4 ++ 2 files changed, 125 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 8ffb844..d71b9d8 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -16,8 +16,10 @@ */ - +#include <linux/gpio.h> #include <linux/module.h> +#include <linux/wait.h> +#include <linux/workqueue.h> #include <drm/drmP.h> #include <drm/drm_crtc_helper.h> @@ -29,6 +31,7 @@ struct tda998x_priv { struct i2c_client *cec; + struct drm_encoder *encoder; uint16_t rev; uint8_t current_page; int dpms; @@ -37,6 +40,10 @@ struct tda998x_priv { u8 vip_cntrl_1; u8 vip_cntrl_2; struct tda998x_encoder_params params; + wait_queue_head_t wq_edid; + bool wq_edid_done; + struct work_struct work; + int irq; }; #define to_tda998x_priv(x) ((struct tda998x_priv *)to_encoder_slave(x)->slave_priv) @@ -285,14 +292,19 @@ struct tda998x_priv { /* CEC registers: (not paged) */ +#define REG_CEC_INTSTATUS 0xee /* read */ +# define CEC_INTSTATUS_HDMI (1 << 1) +# define CEC_INTSTATUS_CEC (1 << 0) #define REG_CEC_FRO_IM_CLK_CTRL 0xfb /* read/write */ # define CEC_FRO_IM_CLK_CTRL_GHOST_DIS (1 << 7) # define CEC_FRO_IM_CLK_CTRL_ENA_OTP (1 << 6) # define CEC_FRO_IM_CLK_CTRL_IMCLK_SEL (1 << 1) # define CEC_FRO_IM_CLK_CTRL_FRO_DIV (1 << 0) +#define REG_CEC_RXSHPDINTENA 0xfc /* read/write */ +#define REG_CEC_RXSHPDINT 0xfd /* read */ #define REG_CEC_RXSHPDLEV 0xfe /* read */ -# define CEC_RXSHPDLEV_RXSENS (1 << 0) -# define CEC_RXSHPDLEV_HPD (1 << 1) +# define CEC_RXSHPD_RXSENS (1 << 0) +# define CEC_RXSHPD_HPD (1 << 1) #define REG_CEC_ENAMODS 0xff /* read/write */ # define CEC_ENAMODS_DIS_FRO (1 << 6) @@ -666,6 +678,54 @@ tda998x_encoder_set_config(struct drm_encoder *encoder, void *params) tda998x_configure_audio(encoder, p); } +static irqreturn_t tda998x_irq_thread(int irq, void *data) +{ + struct drm_encoder *encoder = data; + struct tda998x_priv *priv; + uint8_t sta, cec, hdmi, lev; + + if (!encoder) + return IRQ_HANDLED; + + priv = to_tda998x_priv(encoder); + if (!priv) + return IRQ_HANDLED; + + sta = cec_read(encoder, REG_CEC_INTSTATUS); + cec = cec_read(encoder, REG_CEC_RXSHPDINT); + lev = cec_read(encoder, REG_CEC_RXSHPDLEV); + hdmi = reg_read(encoder, REG_INT_FLAGS_2); + + /* clear all interrupts */ + cec_write(encoder, REG_CEC_RXSHPDINTENA, 0x00); + + if (sta & CEC_INTSTATUS_HDMI) { + /* schedule EDID read on active HPD */ + if ((cec & CEC_RXSHPD_HPD) && (lev & CEC_RXSHPD_HPD)) + schedule_work(&priv->work); + + /* wake up thread waiting on EDID read done */ + if (hdmi & INT_FLAGS_2_EDID_BLK_RD) { + priv->wq_edid_done = true; + wake_up(&priv->wq_edid); + } + }; + + /* re-enable HPD interrupts */ + cec_write(encoder, REG_CEC_RXSHPDINTENA, CEC_RXSHPD_HPD); + + return IRQ_HANDLED; +} + +static void tda998x_hpd_worker(struct work_struct *work) +{ + struct tda998x_priv *priv = + container_of(work, struct tda998x_priv, work); + + if (priv->encoder && priv->encoder->dev) + drm_helper_hpd_irq_event(priv->encoder->dev); +} + static void tda998x_encoder_dpms(struct drm_encoder *encoder, int mode) { @@ -878,19 +938,17 @@ tda998x_encoder_detect(struct drm_encoder *encoder, struct drm_connector *connector) { uint8_t val = cec_read(encoder, REG_CEC_RXSHPDLEV); - return (val & CEC_RXSHPDLEV_HPD) ? connector_status_connected : + return (val & CEC_RXSHPD_HPD) ? connector_status_connected : connector_status_disconnected; } static int read_edid_block(struct drm_encoder *encoder, uint8_t *buf, int blk) { + struct tda998x_priv *priv = to_tda998x_priv(encoder); uint8_t offset, segptr; int ret, i; - /* enable EDID read irq: */ - reg_set(encoder, REG_INT_FLAGS_2, INT_FLAGS_2_EDID_BLK_RD); - offset = (blk & 1) ? 128 : 0; segptr = blk / 2; @@ -900,17 +958,24 @@ read_edid_block(struct drm_encoder *encoder, uint8_t *buf, int blk) reg_write(encoder, REG_DDC_SEGM, segptr); /* enable reading EDID: */ + priv->wq_edid_done = false; + reg_set(encoder, REG_INT_FLAGS_2, INT_FLAGS_2_EDID_BLK_RD); reg_write(encoder, REG_EDID_CTRL, 0x1); /* flag must be cleared by sw: */ reg_write(encoder, REG_EDID_CTRL, 0x0); /* wait for block read to complete: */ - for (i = 100; i > 0; i--) { - uint8_t val = reg_read(encoder, REG_INT_FLAGS_2); - if (val & INT_FLAGS_2_EDID_BLK_RD) - break; - msleep(1); + if (priv->irq < 0) { + for (i = 100; i > 0; i--) { + uint8_t val = reg_read(encoder, REG_INT_FLAGS_2); + if (val & INT_FLAGS_2_EDID_BLK_RD) + break; + msleep(1); + } + } else { + i = wait_event_timeout(priv->wq_edid, priv->wq_edid_done, + msecs_to_jiffies(100)); } if (i == 0) @@ -1014,7 +1079,15 @@ static int tda998x_encoder_create_resources(struct drm_encoder *encoder, struct drm_connector *connector) { - DBG(""); + struct tda998x_priv *priv = to_tda998x_priv(encoder); + + /* announce polling if no irq is available */ + if (priv->irq < 0) + connector->polled = DRM_CONNECTOR_POLL_CONNECT | + DRM_CONNECTOR_POLL_DISCONNECT; + else + connector->polled = DRM_CONNECTOR_POLL_HPD; + return 0; } @@ -1105,7 +1178,9 @@ tda998x_encoder_init(struct i2c_client *client, struct drm_encoder_slave *encoder_slave) { struct drm_encoder *encoder = &encoder_slave->base; + struct tda998x_platform_data *pdata = client->dev.platform_data; struct tda998x_priv *priv; + int ret; /* debug */ device_create_file(&client->dev, &dev_attr_i2c_read); device_create_file(&client->dev, &dev_attr_i2c_write); @@ -1122,7 +1197,9 @@ tda998x_encoder_init(struct i2c_client *client, priv->current_page = 0; priv->cec = i2c_new_dummy(client->adapter, 0x34); + priv->irq = -EINVAL; priv->dpms = DRM_MODE_DPMS_OFF; + priv->encoder = encoder; encoder_slave->slave_priv = priv; encoder_slave->slave_funcs = &tda998x_encoder_funcs; @@ -1163,6 +1240,37 @@ tda998x_encoder_init(struct i2c_client *client, cec_write(encoder, REG_CEC_FRO_IM_CLK_CTRL, CEC_FRO_IM_CLK_CTRL_GHOST_DIS | CEC_FRO_IM_CLK_CTRL_IMCLK_SEL); + /* allow no platform_data */ + if (!pdata) + goto no_pdata; + + if (gpio_is_valid(pdata->int_gpio)) { + ret = devm_gpio_request_one(&client->dev, pdata->int_gpio, + GPIOF_DIR_IN, "HDMI HPD"); + if (ret) + goto fail; + + priv->irq = gpio_to_irq(pdata->int_gpio); + /* init work and waitqueue */ + INIT_WORK(&priv->work, tda998x_hpd_worker); + init_waitqueue_head(&priv->wq_edid); + /* clear pending interrupts */ + reg_read(encoder, REG_INT_FLAGS_0); + reg_read(encoder, REG_INT_FLAGS_1); + reg_read(encoder, REG_INT_FLAGS_2); + + ret = devm_request_threaded_irq(&client->dev, priv->irq, NULL, + tda998x_irq_thread, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "tda998x-int", encoder); + if (ret) + goto fail; + + /* enable HPD irq */ + cec_write(encoder, REG_CEC_RXSHPDINTENA, CEC_RXSHPD_HPD); + } + +no_pdata: return 0; fail: diff --git a/include/drm/i2c/tda998x.h b/include/drm/i2c/tda998x.h index 41f799f..1838703 100644 --- a/include/drm/i2c/tda998x.h +++ b/include/drm/i2c/tda998x.h @@ -20,4 +20,8 @@ struct tda998x_encoder_params { int swap_f, mirr_f; }; +struct tda998x_platform_data { + int int_gpio; +}; + #endif -- 1.7.10.4

3 3

[PATCH] drm/radeon: Fix VRAM size calculation for VRAM >= 4GB
by Niels Ole Salscheider 20 May '13

20 May '13

Add ULL prefix to avoid overflow. Signed-off-by: Niels Ole Salscheider <niels_ole(a)salscheider-online.de> --- drivers/gpu/drm/radeon/evergreen.c | 4 ++-- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- drivers/gpu/drm/radeon/si.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 105bafb..06c261b 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c @@ -3405,8 +3405,8 @@ int evergreen_mc_init(struct radeon_device *rdev) rdev->mc.real_vram_size = RREG32(CONFIG_MEMSIZE); } else { /* size in MB on evergreen/cayman/tn */ - rdev->mc.mc_vram_size = RREG32(CONFIG_MEMSIZE) * 1024 * 1024; - rdev->mc.real_vram_size = RREG32(CONFIG_MEMSIZE) * 1024 * 1024; + rdev->mc.mc_vram_size = RREG32(CONFIG_MEMSIZE) * 1024ULL * 1024ULL; + rdev->mc.real_vram_size = RREG32(CONFIG_MEMSIZE) * 1024ULL * 1024ULL; } rdev->mc.visible_vram_size = rdev->mc.aper_size; r700_vram_gtt_location(rdev, &rdev->mc); diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 93f760e..6c0ce89 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -726,7 +726,7 @@ int radeon_ttm_init(struct radeon_device *rdev) return r; } DRM_INFO("radeon: %uM of VRAM memory ready\n", - (unsigned)rdev->mc.real_vram_size / (1024 * 1024)); + (unsigned) (rdev->mc.real_vram_size / (1024 * 1024))); r = ttm_bo_init_mm(&rdev->mman.bdev, TTM_PL_TT, rdev->mc.gtt_size >> PAGE_SHIFT); if (r) { diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index f0b6c2f..113ed9f 100644 --- a/drivers/gpu/drm/radeon/si.c +++ b/drivers/gpu/drm/radeon/si.c @@ -3397,8 +3397,8 @@ static int si_mc_init(struct radeon_device *rdev) rdev->mc.aper_base = pci_resource_start(rdev->pdev, 0); rdev->mc.aper_size = pci_resource_len(rdev->pdev, 0); /* size in MB on si */ - rdev->mc.mc_vram_size = RREG32(CONFIG_MEMSIZE) * 1024 * 1024; - rdev->mc.real_vram_size = RREG32(CONFIG_MEMSIZE) * 1024 * 1024; + rdev->mc.mc_vram_size = RREG32(CONFIG_MEMSIZE) * 1024ULL * 1024ULL; + rdev->mc.real_vram_size = RREG32(CONFIG_MEMSIZE) * 1024ULL * 1024ULL; rdev->mc.visible_vram_size = rdev->mc.aper_size; si_vram_gtt_location(rdev, &rdev->mc); radeon_update_bandwidth_info(rdev); -- 1.8.2.3

2 1

← Newer
1
...
56
57
58
59
60
61
62
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2013