dri-devel June 2013

dri-devel@lists.freedesktop.org

132 participants
727 discussions

i915 mapping large (3MB) scatter list, hitting limits on certain IOMMUs that can only map contingous regions up to 2MB.
by Konrad Rzeszutek Wilk 25 Jun '13

25 Jun '13

Hey, I am using an ThinkPad X230 with an Intel HD 4000. With a stock Fedora 18 (3.9.6) I can get it to boot and work just fine with Xen. If I use v3.10-rc6 I found that i915 would halt with a [drm:intel_pipe_set_base] *ERROR* pin & fence failed [drm:intel_crtc_set_config] *ERROR* failed to set mode on [CRTC:3], err = -28 after a bit of debugging (see patch below) I traced it down to the fact that the scatter list that is provided at the end has a huge (3MB) page. I am wondering if … [View More]anybody knows what patch might have introduced it to grab such a large memory segment? The other thing I am wondering is if there are some fallbacks when the underlaying IOMMU can't deal with a request for contingous regions that are more than 2MB? Thanks. >From a681a4adb4738c32cb1acdf6f5161bf877816b01 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> Date: Fri, 21 Jun 2013 11:17:55 -0400 Subject: [PATCH] dbug: print scatterlist. ------------[ cut here ]------------ WARNING: at drivers/gpu/drm/i915/i915_gem_gtt.c:418 i915_gem_gtt_prepare_object+0x180/0x200() 10 but got 0 Modules linked in: crc32_pclmul sdhci_pci crc32c_intel sdhci mmc_core ghash_clmulni_intel CPU: 0 PID: 216 Comm: plymouthd Not tainted 3.10.0-rc6+ #16 Hardware name: LENOVO 2325DV4/2325DV4, BIOS G2ET86WW (2.06 ) 11/13/2012 0000000000000009 ffff8801fa42d958 ffffffff816e6d89 ffff8801fa42d998 ffffffff8105d2b0 ffff8801fa42d988 0000000000000000 ffff8801fb0f4d80 ffffffff81c172e0 ffff8801fa76f000 000000000000000a ffff8801fa42d9f8 Call Trace: [<ffffffff816e6d89>] dump_stack+0x19/0x1b [<ffffffff8105d2b0>] warn_slowpath_common+0x70/0xa0 [<ffffffff8105d396>] warn_slowpath_fmt+0x46/0x50 [<ffffffff8142a740>] i915_gem_gtt_prepare_object+0x180/0x200 [<ffffffff81423581>] i915_gem_object_pin+0x321/0x670 [<ffffffff81423951>] i915_gem_object_pin_to_display_plane+0x81/0x190 [<ffffffff814381b5>] intel_pin_and_fence_fb_obj+0x85/0x1a0 [<ffffffff8143999c>] intel_pipe_set_base+0x7c/0x220 [<ffffffff814409be>] intel_crtc_set_config+0x89e/0x990 [<ffffffff813ffdae>] drm_mode_set_config_internal+0x2e/0x60 [<ffffffff814023ab>] drm_mode_setcrtc+0xfb/0x620 [<ffffffff811850f9>] ? kmem_cache_alloc_trace+0x39/0x1f0 [<ffffffff813f9767>] ? drm_vm_open_locked+0x57/0x90 [<ffffffff813f2e39>] drm_ioctl+0x549/0x680 [<ffffffff814022b0>] ? drm_mode_setplane+0x3b0/0x3b0 [<ffffffff811aef77>] do_vfs_ioctl+0x97/0x580 [<ffffffff81295dca>] ? inode_has_perm.isra.32.constprop.62+0x2a/0x30 [<ffffffff81297397>] ? file_has_perm+0x97/0xb0 [<ffffffff811af4f1>] SyS_ioctl+0x91/0xb0 [<ffffffff816f63e7>] tracesys+0xdd/0xe2 ---[ end trace 7b6adc5450d9a9e1 ]--- i915 0000:00:02.0: i915_gem_gtt_prepare_object: Mapping 10 pages, mapped: 0 [0] virT:ffff8801fd37c000 dma: 1fd37c000, size:4096 [1] virT:ffff8801fd37b000 dma: 1fd37b000, size:4096 [2] virT:ffff8801fd37a000 dma: 1fd37a000, size:4096 [3] virT:ffff8801fd378000 dma: 1fd378000, size:4096 [4] virT:ffff8801fd131000 dma: 1fd131000, size:4096 [5] virT:ffff880200c36000 dma: 200c36000, size:4096 [6] virT:ffff8801fd1a4000 dma: 1fd1a4000, size:69632 [7] virT:ffff8801fd3bb000 dma: 1fd3bb000, size:4096 [8] virT:ffff8801fd3c0000 dma: 1fd3c0000, size:262144 [9] virT:ffff8801f9400000 dma: 1f9400000, size:3866624 [drm] 3011: ret:-28 [drm] 3540: ret:-28 [drm] 3364: ret:-28 [drm:intel_pin_and_fence_fb_obj] *ERROR* i915_gem_object_pin_to_display_plane failed: -28 [drm:intel_pipe_set_base] *ERROR* pin & fence failed [drm:intel_crtc_set_config] *ERROR* failed to set mode on [CRTC:3], err = -28 Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> --- drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ drivers/gpu/drm/i915/i915_gem_gtt.c | 28 +++++++++++++++++++++++++--- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 8411942..141c6fb 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -133,6 +133,12 @@ module_param_named(coherent, use_coherent, int, 0600); MODULE_PARM_DESC(use_coherent, "Use coherent DMA API calls (default: false)"); +int i915_sgl __read_mostly = 0; +module_param_named(sgl, i915_sgl, int, 0600); +MODULE_PARM_DESC(sgl, + "Print scatterlist SG's when DMA mapping them (default: false)"); + + static struct drm_driver driver; extern int intel_agp_enabled; diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index acb3b3f..292179c 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -28,6 +28,7 @@ #include "i915_trace.h" #include "intel_drv.h" +extern int use_coherent; typedef uint32_t gen6_gtt_pte_t; /* PPGTT stuff */ @@ -403,15 +404,36 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) i915_gem_chipset_flush(dev); } - +extern int i915_sgl; int i915_gem_gtt_prepare_object(struct drm_i915_gem_object *obj) { + int elem; if (obj->has_dma_mapping) return 0; - if (!dma_map_sg(&obj->base.dev->pdev->dev, + elem = dma_map_sg(&obj->base.dev->pdev->dev, obj->pages->sgl, obj->pages->nents, - PCI_DMA_BIDIRECTIONAL)) + PCI_DMA_BIDIRECTIONAL); + + WARN(elem == 0, "%d but got %d", obj->pages->nents, elem); + + if (i915_sgl && obj->pages && obj->pages->sgl) { + int i; + struct scatterlist *s; + + if (obj->base.dev) { + dev_info(&obj->base.dev->pdev->dev, "%s: Mapping %d pages, mapped: %d\n", + __func__,obj->pages->nents, elem); + } else + printk(KERN_INFO "%s: no dev, %d pages, mapped: %d\n",__func__, + obj->pages->nents, elem); + + for_each_sg(obj->pages->sgl, s, obj->pages->nents, i) { + printk(KERN_INFO "[%d] virT:%lx dma: %lx, size:%d\n", i, + (unsigned long)sg_virt(s), (unsigned long)sg_phys(s), s->length); + } + } + if (!elem) return -ENOSPC; return 0; -- 1.8.1.4 [View Less]

3 5

[PATCH 0/6] fb refcount and crtc helper patches
by Daniel Vetter 25 Jun '13

25 Jun '13

Hi all, Russell found a refcount bug in my fb refcounting conversion, but to also fix i915.ko I've opted for a slightly different approach. While at it I've thought it would be good to backport some of the semantic changes we've implented in i915's ->set_config callback since we've forked our own modeset infrastructure. The intel code receive lots more refactorings and cleanups (most of them right after the code fork) which would be simple to backport, but I'm kinda swamped (hint, hint, ..… [View More]

2 10

[PATCH] drm: Added SDP and VSC structures for handling PSR for eDP
by Rodrigo Vivi 25 Jun '13

25 Jun '13

From: Shobhit Kumar <shobhit.kumar(a)intel.com> SDP header and SDP VSC header as per eDP 1.3 spec, section 3.5, chapter "PSR Secondary Data Package Support". v2: Modified and corrected the structures to be more in line for kernel coding guidelines and rebased the code on Paulo's DP patchset v3: removing unecessary identation at DP_RECEIVER_CAP_SIZE v4: moving them to include/drm/drm_dp_helper.h and also already icluding EDP_PSR_RECEIVER_CAP_SIZE to add everything needed for PSR … [View More]at once at drm_dp_helper.h v5: Fix SDP VSC header and identation by (Paulo Zanoni) and remove i915 from title (Daniel Vetter) v6: Fix spec version and move comments from code to commit message since numbers might change in the future (by Paulo Zanoni). CC: Paulo Zanoni <paulo.r.zanoni(a)intel.com> Reviewed-by: Paulo Zanoni <paulo.r.zanoni(a)intel.com> Signed-off-by: Sateesh Kavuri <sateesh.kavuri(a)intel.com> Signed-off-by: Shobhit Kumar <shobhit.kumar(a)intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi(a)gmail.com> --- include/drm/drm_dp_helper.h | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index e8e1417..ae8dbfb 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -342,13 +342,42 @@ u8 drm_dp_get_adjust_request_voltage(u8 link_status[DP_LINK_STATUS_SIZE], u8 drm_dp_get_adjust_request_pre_emphasis(u8 link_status[DP_LINK_STATUS_SIZE], int lane); -#define DP_RECEIVER_CAP_SIZE 0xf +#define DP_RECEIVER_CAP_SIZE 0xf +#define EDP_PSR_RECEIVER_CAP_SIZE 2 + void drm_dp_link_train_clock_recovery_delay(u8 dpcd[DP_RECEIVER_CAP_SIZE]); void drm_dp_link_train_channel_eq_delay(u8 dpcd[DP_RECEIVER_CAP_SIZE]); u8 drm_dp_link_rate_to_bw_code(int link_rate); int drm_dp_bw_code_to_link_rate(u8 link_bw); +struct edp_sdp_header { + u8 HB0; /* Secondary Data Packet ID */ + u8 HB1; /* Secondary Data Packet Type */ + u8 HB2; /* 7:5 reserved, 4:0 revision number */ + u8 HB3; /* 7:5 reserved, 4:0 number of valid data bytes */ +} __packed; + +#define EDP_SDP_HEADER_REVISION_MASK 0x1F +#define EDP_SDP_HEADER_VALID_PAYLOAD_BYTES 0x1F + +struct edp_vsc_psr { + struct edp_sdp_header sdp_header; + u8 DB0; /* Stereo Interface */ + u8 DB1; /* 0 - PSR State; 1 - Update RFB; 2 - CRC Valid */ + u8 DB2; /* CRC value bits 7:0 of the R or Cr component */ + u8 DB3; /* CRC value bits 15:8 of the R or Cr component */ + u8 DB4; /* CRC value bits 7:0 of the G or Y component */ + u8 DB5; /* CRC value bits 15:8 of the G or Y component */ + u8 DB6; /* CRC value bits 7:0 of the B or Cb component */ + u8 DB7; /* CRC value bits 15:8 of the B or Cb component */ + u8 DB8_31[24]; /* Reserved */ +} __packed; + +#define EDP_VSC_PSR_STATE_ACTIVE (1<<0) +#define EDP_VSC_PSR_UPDATE_RFB (1<<1) +#define EDP_VSC_PSR_CRC_VALUES_VALID (1<<2) + static inline int drm_dp_max_link_rate(u8 dpcd[DP_RECEIVER_CAP_SIZE]) { -- 1.8.1.4 [View Less]

1 0

[PATCH 1/2] power: add new interface to return pm_transition state
by Shuah Khan 24 Jun '13

24 Jun '13

Add a new interface get_pm_transition() to return pm_transition state. This interface is intended to be used from dev_pm_ops class and type suspend interfaces that call legacy pm ops driver suspend interfaces. Legacy suspend pm_ops take pm_message_t as a parameter. e.g: drm_class_suspend() calls into driver suspend routines via drm_dev->driver->suspend(drm_dev, state). Once drm_class_suspend() is converted to dev_pm_ops, it will no longer have access to pm_transition which it has to … [View More]

2 3

[PATCH 0/4] IPU DMFC bandwidth allocation fix and cleanups
by Philipp Zabel 24 Jun '13

24 Jun '13

Hi, the following patches remove some unused variables, replace some hard-coded channel numbers with existing descriptive defines, fix the DMFC bandwidth (or rather: FIFO space) allocation, and update ipu_page_flip() to immediately set crtc->fb. regards Philipp --- drivers/staging/imx-drm/imx-drm-core.c | 3 --- drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 22 ++++++++++++++++------ drivers/staging/imx-drm/ipuv3-crtc.c | 7 +------ 3 files changed, 17 insertions(+), 15 deletions(-)

2 5

Re: [PATCH 0/5] clk/exynos5420: add clocks for hdmi subsystem
by Rahul Sharma 24 Jun '13

24 Jun '13

+ mike On Tue, Jun 18, 2013 at 8:03 PM, Rahul Sharma <rahul.sharma(a)samsung.com> wrote: > Add clock changes for hdmi subsystem for exynos5250 SoC. These > include addition of new clocks like mout_hdmi and smmu_tv, associating > ID to clk_hdmiphy and some essential corrections. > > This set is based on kukjin's for-next branch at > http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git. > > This set dependents on the following patches which add … [View More]

3 6

[Bug 66064] New: ATI Mobility FireGL V5250 hardware incorrectly matched with RV530 dri settings in r_300.dri
by bugzilla-daemon＠freedesktop.org 24 Jun '13

24 Jun '13

https://bugs.freedesktop.org/show_bug.cgi?id=66064 Priority: medium Bug ID: 66064 Assignee: dri-devel(a)lists.freedesktop.org Summary: ATI Mobility FireGL V5250 hardware incorrectly matched with RV530 dri settings in r_300.dri Severity: normal Classification: Unclassified OS: Linux (All) Reporter: belfrancis2001(a)yahoo.ca Hardware: x86 (IA32) Status: NEW … [View More]

1 4

[PATCH 0/2] IPU generic irq chip
by Philipp Zabel 24 Jun '13

24 Jun '13

Hi, with linear domain support in the generic irq chip framework, we can drop the custom irq_chip / irq_domain_ops altogether and use the generic irq chip implementation instead. The following two patches depend on "genirq: Generic chip: Add linear irq domain support" and "genirq: irqchip: Add mask to block out invalid irqs": https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?id=e8bd834f73… regards Philipp --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 101 ++++++++++----------… [View More]

2 3

[PULL] drm-intel-fixes
by Daniel Vetter 24 Jun '13

24 Jun '13

Hi Dave, One remaining regression fix for i915. I've left it in -fixes for more than a week since it's in tricky code, and it took us a few kernel releases to notice the regression at all. The fence leak is especially annoying on gen2/3 and will kill userspace there quickly. For extra paranoia we've added a WARN in -next to catch this, things seem to be solid now. Cheers, Daniel The following changes since commit 7d132055814ef17a6c7b69f342244c410a5e000f: Linux 3.10-rc6 (2013-06-15 11:51:… [View More]

1 0

PROBLEM: WARNING, plane B assertion failure
by brian porter 24 Jun '13

24 Jun '13

BIOS Information Vendor: Hewlett-Packard Version: 361A0 Ver. F.11 System Information Manufacturer: Hewlett-Packard Product Name: HP Mini Version: F.11 Wake-up Type: Power Switch SKU Number: FW376UA#ABA Family: 103C_5335KV 00:02.0 VGA compatible controller: Intel Corporation Mobile 945GSE Express Integrated Graphics Controller (rev 03) (prog-if 0 0 [VGA controller]) Subsystem: Hewlett-Packard Company Device 361a … [View More]Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin A routed to IRQ 16 Region 0: Memory at fe980000 (32-bit, non-prefetchable) [size=512K] Region 1: I/O ports at dc80 [size=8] Region 2: Memory at d0000000 (32-bit, prefetchable) [size=256M] Region 3: Memory at fe940000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at <unassigned> [disabled] Capabilities: [90] MSI: Enable- Count=1/1 Maskable- 64bit- Address: 00000000 Data: 0000 Capabilities: [d0] Power Management version 2 Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: i915 Kernel modules: i915 [ 3.243456] ------------[ cut here ]------------ [ 3.243541] WARNING: at drivers/gpu/drm/i915/intel_display.c:1274 intel_disable_pipe+0x146/0x150 [i915]() [ 3.243548] Hardware name: HP Mini [ 3.243554] plane B assertion failure, should be off on pipe B but is still active [ 3.243559] Modules linked in: cfg80211 hp_wmi(+) sparse_keymap iTCO_wdt iTCO_vendor_support rfkill uvcvideo coretemp videobuf2_vmalloc videobuf2_memops videobuf2_core microcode videodev usb_storage media snd_hda_intel(+) i915(+) evdev psmouse serio_raw pcspkr snd_hda_codec lpc_ich i2c_i801 of_i2c snd_hwdep drm_kms_helper wmi snd_pcm ssb snd_page_alloc mmc_core snd_timer drm snd pcmcia soundcore battery pcmcia_core acpi_cpufreq mperf sky2 video thermal ac intel_agp intel_gtt agpgart i2c_algo_bit i2c_core button processor ext4 crc16 mbcache jbd2 sd_mod ata_generic pata_acpi ata_piix libata ehci_pci uhci_hcd ehci_hcd scsi_mod usbcore usb_common [ 3.243695] Pid: 117, comm: systemd-udevd Not tainted 3.9.7-1-ARCH #1 [ 3.243701] Call Trace: [ 3.243721] [<c103bcec>] warn_slowpath_common+0x6c/0xa0 [ 3.243788] [<f873a766>] ? intel_disable_pipe+0x146/0x150 [i915] [ 3.243854] [<f873a766>] ? intel_disable_pipe+0x146/0x150 [i915] [ 3.243867] [<c103bd53>] warn_slowpath_fmt+0x33/0x40 [ 3.243933] [<f873a766>] intel_disable_pipe+0x146/0x150 [i915] [ 3.244000] [<f873adac>] i9xx_crtc_disable+0xec/0x1c0 [i915] [ 3.244233] [<f873c40e>] intel_crtc_disable+0x2e/0x110 [i915] [ 3.244299] [<f873c732>] __intel_set_mode+0x242/0x880 [i915] [ 3.244316] [<c140a7ad>] ? mutex_unlock+0xd/0x10 [ 3.244347] [<f835d4d0>] ? drm_framebuffer_init+0x80/0x90 [drm] [ 3.244417] [<f87431a3>] intel_set_mode+0x23/0x40 [i915] [ 3.244647] [<f87441e0>] intel_get_load_detect_pipe+0x230/0x3a0 [i915] [ 3.244724] [<f87458d4>] intel_modeset_setup_hw_state+0x714/0x8b0 [i915] [ 3.244796] [<f8745a90>] intel_modeset_gem_init+0x20/0x30 [i915] [ 3.244852] [<f8719a16>] i915_driver_load+0xa86/0xcb0 [i915] [ 3.245039] [<f8716de0>] ? i915_switcheroo_set_state+0xa0/0xa0 [i915] [ 3.245091] [<f835a16b>] drm_get_pci_dev+0x13b/0x260 [drm] [ 3.245152] [<f871553a>] i915_pci_probe+0x3a/0x90 [i915] [ 3.245168] [<c122e6ef>] pci_device_probe+0x6f/0xb0 [ 3.245184] [<c12ca389>] driver_probe_device+0x79/0x360 [ 3.245199] [<c12ca721>] __driver_attach+0x71/0x80 [ 3.245211] [<c12ca6b0>] ? __device_attach+0x40/0x40 [ 3.245223] [<c12c87b7>] bus_for_each_dev+0x47/0x80 [ 3.245236] [<c12c9e9e>] driver_attach+0x1e/0x20 [ 3.245247] [<c12ca6b0>] ? __device_attach+0x40/0x40 [ 3.245258] [<c12c9acf>] bus_add_driver+0x1df/0x2a0 [ 3.245402] [<c122e730>] ? pci_device_probe+0xb0/0xb0 [ 3.245417] [<c122e730>] ? pci_device_probe+0xb0/0xb0 [ 3.245429] [<c12cacfa>] driver_register+0x6a/0x130 [ 3.245444] [<c122e582>] __pci_register_driver+0x32/0x40 [ 3.245473] [<f835a385>] drm_pci_init+0xf5/0x100 [drm] [ 3.245504] [<f880a000>] ? 0xf8809fff [ 3.245568] [<f880a05e>] i915_init+0x5e/0x60 [i915] [ 3.245581] [<c10011fa>] do_one_initcall+0x10a/0x150 [ 3.245594] [<c10607c4>] ? __blocking_notifier_call_chain+0x44/0x60 [ 3.245609] [<c109b636>] load_module+0x19a6/0x2340 [ 3.245627] [<c109c055>] sys_init_module+0x85/0xe0 [ 3.245641] [<c141318d>] sysenter_do_call+0x12/0x28 [ 3.245785] ---[ end trace 62583c49c20e738c ]--- [View Less]

2 2

← Newer
1
...
53
54
55
56
57
58
59
...
73
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2013