dri-devel June 2013

dri-devel@lists.freedesktop.org

132 participants
727 discussions

[PATCH v2 0/4] gpu: host1x: add runtime pm support
by Mayuresh Kulkarni 14 Jun '13

14 Jun '13

This patch-set series adds runtime pm support for host1x, gr2d & dc. It retains the current behaviour if CONFIG_PM_RUNTIME is not enabled. For host1x & gr2d, the clocks are now enabled in .probe and disabled on its exit. This is needed for correct init of hardware. Additionally for gr2d, the clocks are also enabled when a new work is submitted and disabled when the work is done. Due to parent->child relations between host1x->gr2d, this scheme also ends up in enabling & … [View More]

3 9

[PATCH] drm: shmobile: Use devm_* managed functions
by Laurent Pinchart 14 Jun '13

14 Jun '13

This simplifies cleanup paths and fixes a probe time crash in the error path when trying to cleanup mode setting before it was initialized. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com> --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 28 +++++++++------------------- drivers/gpu/drm/shmobile/shmob_drm_plane.c | 7 +------ 2 files changed, 10 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/… [View More]shmob_drm_drv.c index f6e0b53..29d15e3 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c @@ -90,7 +90,7 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev, return -EINVAL; } - clk = clk_get(sdev->dev, clkname); + clk = devm_clk_get(sdev->dev, clkname); if (IS_ERR(clk)) { dev_err(sdev->dev, "cannot get dot clock %s\n", clkname); return PTR_ERR(clk); @@ -106,21 +106,12 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev, static int shmob_drm_unload(struct drm_device *dev) { - struct shmob_drm_device *sdev = dev->dev_private; - drm_kms_helper_poll_fini(dev); drm_mode_config_cleanup(dev); drm_vblank_cleanup(dev); drm_irq_uninstall(dev); - if (sdev->clock) - clk_put(sdev->clock); - - if (sdev->mmio) - iounmap(sdev->mmio); - dev->dev_private = NULL; - kfree(sdev); return 0; } @@ -139,7 +130,7 @@ static int shmob_drm_load(struct drm_device *dev, unsigned long flags) return -EINVAL; } - sdev = kzalloc(sizeof(*sdev), GFP_KERNEL); + sdev = devm_kzalloc(&pdev->dev, sizeof(*sdev), GFP_KERNEL); if (sdev == NULL) { dev_err(dev->dev, "failed to allocate private data\n"); return -ENOMEM; @@ -156,29 +147,28 @@ static int shmob_drm_load(struct drm_device *dev, unsigned long flags) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (res == NULL) { dev_err(&pdev->dev, "failed to get memory resource\n"); - ret = -EINVAL; - goto done; + return -EINVAL; } - sdev->mmio = ioremap_nocache(res->start, resource_size(res)); + sdev->mmio = devm_ioremap_nocache(&pdev->dev, res->start, + resource_size(res)); if (sdev->mmio == NULL) { dev_err(&pdev->dev, "failed to remap memory resource\n"); - ret = -ENOMEM; - goto done; + return -ENOMEM; } ret = shmob_drm_setup_clocks(sdev, pdata->clk_source); if (ret < 0) - goto done; + return ret; ret = shmob_drm_init_interface(sdev); if (ret < 0) - goto done; + return ret; ret = shmob_drm_modeset_init(sdev); if (ret < 0) { dev_err(&pdev->dev, "failed to initialize mode setting\n"); - goto done; + return ret; } for (i = 0; i < 4; ++i) { diff --git a/drivers/gpu/drm/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/shmobile/shmob_drm_plane.c index e1eb899..6898f6f 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_plane.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_plane.c @@ -221,11 +221,8 @@ static int shmob_drm_plane_disable(struct drm_plane *plane) static void shmob_drm_plane_destroy(struct drm_plane *plane) { - struct shmob_drm_plane *splane = to_shmob_plane(plane); - shmob_drm_plane_disable(plane); drm_plane_cleanup(plane); - kfree(splane); } static const struct drm_plane_funcs shmob_drm_plane_funcs = { @@ -251,7 +248,7 @@ int shmob_drm_plane_create(struct shmob_drm_device *sdev, unsigned int index) struct shmob_drm_plane *splane; int ret; - splane = kzalloc(sizeof(*splane), GFP_KERNEL); + splane = devm_kzalloc(sdev->dev, sizeof(*splane), GFP_KERNEL); if (splane == NULL) return -ENOMEM; @@ -261,8 +258,6 @@ int shmob_drm_plane_create(struct shmob_drm_device *sdev, unsigned int index) ret = drm_plane_init(sdev->ddev, &splane->plane, 1, &shmob_drm_plane_funcs, formats, ARRAY_SIZE(formats), false); - if (ret < 0) - kfree(splane); return ret; } -- Regards, Laurent Pinchart [View Less]

2 1

[PATCH] drm/exynos: make sure to handle an error case to vm_mmap call
by Inki Dae 14 Jun '13

14 Jun '13

vm_mmap function returns unsigned long so addr type should be unsigned long. a pointer or address variable is required to use unsigned long or uint64_t type for 64bits address support. So this patch makes sure that addr has unsigned long type and also exynos_drm_gem_mmap_ioctl returns correct error type. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 6 +++--- 1 files … [View More]

1 0

[PATCH] drm/edid: Don't print messages regarding stereo or csync by default
by Egbert Eich 13 Jun '13

13 Jun '13

drm_mode_detailed() is called quite often, therefore when a monitor that has a detailed timing mode marked DRM_EDID_PT_STEREO or requiring composite sync, warning messages will clutter up the kernel log. Like we already do for incorrect hsync/vsync pluse widths, print these messages only when KMS debugging is enabled. Signed-off-by: Egbert Eich <eich(a)suse.com> --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/… [View More]

2 1

[Bug 65714] Champions of Regnum dont show characters!
by bugzilla-daemon＠freedesktop.org 13 Jun '13

13 Jun '13

https://bugs.freedesktop.org/show_bug.cgi?id=65714 --- Comment #2 from Fabio Pedretti <fabio.ped(a)libero.it> --- (In reply to comment #1) > Does the ppa enable LLVM? If so does setting env var R600_LLVM=0 help? The PPA is compiling with LLVM but *without* --enable-r600-llvm-compiler . -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 65714] Champions of Regnum dont show characters!
by bugzilla-daemon＠freedesktop.org 13 Jun '13

13 Jun '13

1 0

[PATCH 1/1] dRM/exynos: exynos_drm_ipp: Remove redundant break statement
by Sachin Kamat 13 Jun '13

13 Jun '13

'break' after goto statement is redundant. Silences the following message: drivers/gpu/drm/exynos/exynos_drm_ipp.c:1067 exynos_drm_ipp_check_valid() info: ignoring unreachable code. Signed-off-by: Sachin Kamat <sachin.kamat(a)linaro.org> --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index 01cb9a0..b1ef8e7 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.… [View More]

2 1

[PATCH 0/4] exynos5250/hdmi: modify driver and arch data towards CCF migration
by Rahul Sharma 13 Jun '13

13 Jun '13

After switching to CCF, driver and device tree nodes are required to be update with clock information. This set includes those changes. After these patches, the only missing portion is hdmiphy power control which is posted independently. Together, basic hdmi is working for exynos5250. Rahul Sharma (2): drm/exynos: add mout_hdmi clock in hdmi driver to change parent ARM/dts: add clocks to hdmi dt node for exynos5250 Sean Paul (2): drm/exynos: Prepare/Unprepare HDMI subsystem clocks … [View More]

2 8

[PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails
by Christopher Harvey 12 Jun '13

12 Jun '13

Running mgag200_driver_unload when the driver init fails early on causes functions like drm_mode_config_cleanup to be called. The problem is, drm_mode_config_cleanup crashes because the corresponding init hasn't happend yet. There really isn't anything to cleanup after mgag200_device_init, so we can just pass the error code upwards. Acked-by: Julia Lemire <jlemire(a)matrox.com> Signed-off-by: Christopher Harvey <charvey(a)matrox.com> --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 +… [View More]

2 2

[PATCH 0/1] drm/mgag200: Added resolution and bandwidth limits for various G200e products.
by Julia Lemire 12 Jun '13

12 Jun '13

At the larger resolutions, the g200e series sometimes struggles with maintaining a proper output. Problems like flickering or black bands appearing on screen can occur. In order to avoid this, limitations regarding resolutions and bandwidth have been added for the different variations of the g200e series. Julia Lemire (1): drm/mgag200: Added resolution and bandwidth limits for various G200e products. drivers/gpu/drm/mgag200/mgag200_drv.h | 41 ++++++++++++------------ drivers/gpu/… [View More]

1 1

← Newer
1
...
62
63
64
65
66
67
68
...
73
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2013