dri-devel July 2013

dri-devel@lists.freedesktop.org

142 participants
850 discussions

[pull] radeon drm-next-3.11
by alexdeucher＠gmail.com 03 Jul '13

03 Jul '13

From: Alex Deucher <alexander.deucher(a)amd.com> Hi Dave, A few more DPM fixes. The following changes since commit 7982128c3d447df27db963af67bc6b8dc7efb1de: drm/radeon/dpm: add debugfs support for SI (2013-07-01 16:09:06 -0400) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-3.11 Alex Deucher (6): drm/radeon/dpm: clarify debugfs warning drm/radeon: fix endian bug in radeon_atom_get_mclk_range_table() drm/radeon/aruba: disable additional rlc features drm/radeon/sumo: disable PG when changing UVD clocks drm/radeon/tn: disable PG when changing UVD clocks drm/radeon/sumo: implement support for disable_gfx_power_gating_in_uvd flag Mike Lothian (1): drm/radeon/dpm: fix compilation with certain versions of gcc drivers/gpu/drm/radeon/evergreen.c | 2 -- drivers/gpu/drm/radeon/ni_dpm.c | 1 + drivers/gpu/drm/radeon/radeon_atombios.c | 2 +- drivers/gpu/drm/radeon/radeon_pm.c | 2 +- drivers/gpu/drm/radeon/rv6xx_dpm.c | 1 + drivers/gpu/drm/radeon/rv770_dpm.c | 1 + drivers/gpu/drm/radeon/si_dpm.c | 1 + drivers/gpu/drm/radeon/sumo_dpm.c | 24 ++++++++++++++++++++++-- drivers/gpu/drm/radeon/trinity_dpm.c | 9 +++++++++ 9 files changed, 37 insertions(+), 6 deletions(-)

1 0

[Bug 66519] New: 3.10 kernel: [drm:evergreen_startup] *ERROR* radeon: error initializing UVD (-1).
by bugzilla-daemon＠freedesktop.org 03 Jul '13

03 Jul '13

https://bugs.freedesktop.org/show_bug.cgi?id=66519 Priority: medium Bug ID: 66519 Assignee: dri-devel(a)lists.freedesktop.org Summary: 3.10 kernel: [drm:evergreen_startup] *ERROR* radeon: error initializing UVD (-1). Severity: normal Classification: Unclassified OS: All Reporter: jpiszcz(a)lucidpixels.com Hardware: Other Status: NEW Version: XOrg CVS Component: DRM/Radeon Product: DRI Created attachment 81905 --> https://bugs.freedesktop.org/attachment.cgi?id=81905&action=edit Xorg.0.log Per: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg462393.html Please open a bug (product: DRI, component: DRM/Radeon): https://bugs.freedesktop.org and attach your dmesg output and xorg log. Attaching.. Distribution: Debian Testing Xorg Version: 7.7+3 1. full-dmesg.txt 2. Xorg.0.log 3. Xorg.0.log.old -- You are receiving this mail because: You are the assignee for the bug.

1 12

[pull] radeon drm-next-3.11
by alexdeucher＠gmail.com 03 Jul '13

03 Jul '13

From: Alex Deucher <alexander.deucher(a)amd.com> Hi Dave, A few more patches for 3.11: - add debugfs interface to check current DPM state - Fix a bug that caused problems with DPM on BTC+ asics. The following changes since commit f7d452f4fd5d86f764807a1234a407deb5b105ef: Merge branch 'drm-nouveau-next' of git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-next (2013-07-01 14:10:20 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-3.11 Alex Deucher (12): drm/radeon: remove sumo dpm/uvd bringup leftovers drm/radeon/atom: fix endian bug in radeon_atom_init_mc_reg_table() drm/radeon: fix typo in radeon_atom_init_mc_reg_table() drm/radeon/dpm: re-enable state transitions for BTC drm/radeon/dpm: re-enable state transitions for Cayman drm/radeon/dpm: add infrastructure to support debugfs info drm/radeon/dpm: add debugfs support for rv6xx drm/radeon/dpm: add debugfs support for 7xx/evergreen/btc drm/radeon/dpm: add debugfs support for ON/LN drm/radeon/dpm: add debugfs support for TN drm/radeon/dpm: add debugfs support for cayman drm/radeon/dpm: add debugfs support for SI drivers/gpu/drm/radeon/btc_dpm.c | 3 -- drivers/gpu/drm/radeon/ni_dpm.c | 25 +++++++++++++--- drivers/gpu/drm/radeon/nid.h | 4 ++ drivers/gpu/drm/radeon/radeon.h | 2 + drivers/gpu/drm/radeon/radeon_asic.c | 8 +++++ drivers/gpu/drm/radeon/radeon_asic.h | 12 ++++++++ drivers/gpu/drm/radeon/radeon_atombios.c | 3 +- drivers/gpu/drm/radeon/radeon_pm.c | 40 ++++++++++++++++++-------- drivers/gpu/drm/radeon/rv6xx_dpm.c | 25 ++++++++++++++++ drivers/gpu/drm/radeon/rv770_dpm.c | 30 ++++++++++++++++++++ drivers/gpu/drm/radeon/rv770d.h | 4 ++ drivers/gpu/drm/radeon/si_dpm.c | 19 ++++++++++++ drivers/gpu/drm/radeon/sid.h | 4 ++ drivers/gpu/drm/radeon/sumo_dpm.c | 45 ++++++++++++++++++----------- drivers/gpu/drm/radeon/trinity_dpm.c | 21 ++++++++++++++ 15 files changed, 206 insertions(+), 39 deletions(-)

5 4

RE: 3.10 kernel: [drm:evergreen_startup] *ERROR* radeon: error initializing UVD (-1). [SOLVED]
by Justin Piszcz 03 Jul '13

03 Jul '13

-----Original Message----- From: Alex Deucher [mailto:alexdeucher@gmail.com] Sent: Tuesday, July 02, 2013 3:41 PM To: Justin Piszcz Cc: linux-kernel(a)vger.kernel.org; dri-devel(a)lists.freedesktop.org Subject: Re: 3.10 kernel: [drm:evergreen_startup] *ERROR* radeon: error initializing UVD (-1). Please open a bug (product: DRI, component: DRM/Radeon): https://bugs.freedesktop.org and attach your dmesg output and xorg log. Alex Per: https://bugs.freedesktop.org/show_bug.cgi?id=66519 Grabbed firmware, removed distribution firmware package, re-built kernel and all is working now, thanks! Justin.

1 0

MacBook Pro 10,1 + i915
by Marek Vasut 03 Jul '13

03 Jul '13

Hi guys, I recently got the rMBP 10,1 model, it has two graphic cards: 00:02.0 VGA compatible controller: Intel Corporation 3rd Gen Core processor Graphics Controller (rev 09) 01:00.0 VGA compatible controller: NVIDIA Corporation GK107M [GeForce GT 650M Mac Edition] (rev a1) I'm running linux 3.10-rc7 . The nvidia works with nouveau, but I'd prefer to switch the nvidia off altogether and use the intel GPU. So far I arrived at the point where I disabled X11, mounted debugfs and tried the vgaswitcheroo. With the nvidia still in operation, I see the console. Unfortunatelly, I end up with a black screen after I run the following command to switch to the intel GPU: echo IGD > /sys/kernel/debug/vgaswitcheroo/switch If I try to switch back to the nvidia card (using echo DIS > ...), the screen remains black. This state persists until reboot. I suspect [1] is the same bug, none of the hints there helped. Can you please give me any hint/patch/idea/... how to continue? Thank you! [1] https://bugs.freedesktop.org/show_bug.cgi?id=61115 Best regards, Marek Vasut

2 4

"radeon: error initializing UVD" in kernel 3.10 on hybrid laptop with CEDAR / R600
by Jörg-Volker Peetz 03 Jul '13

03 Jul '13

With self-compiled linux 3.10 on a HP Pavilion dv7 with hybrid graphics (ATI RS880M [Mobility Radeon HD 4200 Series] / ATI Manhattan [Mobility Radeon HD 5400 Series]) uvd seems to be broken. The new firware files are installed in /lib/firmware/radeon: sha1 hashes 3142a64061ade6032c95ed948c85b15dd0ae46be CEDAR_me.bin a92856a4fa16926e2451a6335da7e20f01fde210 CEDAR_pfp.bin 644b29756636687ad31a49da4aa3ed85dcedecdb CEDAR_rlc.bin 992d49518d3936986b5ce3ddb0d9bbd75135bb8f CYPRESS_uvd.bin 3e04529600d666ddb2f2f83bb0112d4fab516c04 R600_rlc.bin The system boots without initial ram disk. In dmesg it says: [drm] Initialized drm 1.1.0 20060810 [drm] radeon kernel modesetting enabled. VGA switcheroo: detected switching method \_SB_.PCI0.AGP_.VGA_.ATPX handle [drm] initializing kernel modesetting (RS880 0x1002:0x9712 0x103C:0x1443). [drm] register mmio base: 0xF0400000 [drm] register mmio size: 65536 ATOM BIOS: HP_JoYaHeWi radeon 0000:01:05.0: VRAM: 320M 0x00000000C0000000 - 0x00000000D3FFFFFF (320M used) radeon 0000:01:05.0: GTT: 512M 0x00000000A0000000 - 0x00000000BFFFFFFF [drm] Detected VRAM RAM=320M, BAR=256M [drm] RAM width 32bits DDR [TTM] Zone kernel: Available graphics memory: 3960190 kiB [TTM] Zone dma32: Available graphics memory: 2097152 kiB [TTM] Initializing pool allocator [TTM] Initializing DMA pool allocator [drm] radeon: 320M of VRAM memory ready [drm] radeon: 512M of GTT memory ready. [drm] GART: num cpu pages 131072, num gpu pages 131072 [drm] Loading RS780 Microcode [drm] PCIE GART of 512M enabled (table at 0x00000000C0040000). radeon 0000:01:05.0: WB enabled radeon 0000:01:05.0: fence driver on ring 0 use gpu addr 0x00000000a0000c00 and cpu addr 0xffff880215cb6c00 radeon 0000:01:05.0: fence driver on ring 3 use gpu addr 0x00000000a0000c0c and cpu addr 0xffff880215cb6c0c [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [drm] Driver supports precise vblank timestamp query. [drm] radeon: irq initialized. radeon 0000:01:05.0: setting latency timer to 64 ACPI: Battery Slot [BAT0] (battery present) [drm] ring test on 0 succeeded in 1 usecs [drm] ring test on 3 succeeded in 1 usecs [drm] Enabling audio support [drm] ib test on ring 0 succeeded in 0 usecs [drm] ib test on ring 3 succeeded in 0 usecs [drm] radeon atom DIG backlight initialized [drm] Radeon Display Connectors [drm] Connector 0: [drm] VGA-1 [drm] DDC: 0x7e40 0x7e40 0x7e44 0x7e44 0x7e48 0x7e48 0x7e4c 0x7e4c [drm] Encoders: [drm] CRT1: INTERNAL_KLDSCP_DAC1 [drm] Connector 1: [drm] LVDS-1 [drm] DDC: 0x7e50 0x7e50 0x7e54 0x7e54 0x7e58 0x7e58 0x7e5c 0x7e5c [drm] Encoders: [drm] LCD1: INTERNAL_KLDSCP_LVTMA [drm] radeon: power management initialized tsc: Refined TSC clocksource calibration: 2793.006 MHz Switching to clocksource tsc [drm] fb mappable at 0xD0142000 [drm] vram apper at 0xD0000000 [drm] size 5787648 [drm] fb depth is 24 [drm] pitch is 6400 fbcon: radeondrmfb (fb0) is primary device Console: switching to colour frame buffer device 200x56 radeon 0000:01:05.0: fb0: radeondrmfb frame buffer device radeon 0000:01:05.0: registered panic notifier [drm] Initialized radeon 2.33.0 20080528 for 0000:01:05.0 on minor 0 radeon 0000:02:00.0: enabling device (0000 -> 0003) [drm] initializing kernel modesetting (CEDAR 0x1002:0x68E0 0x103C:0x1443). [drm] register mmio base: 0xF0200000 [drm] register mmio size: 131072 vga_switcheroo: enabled ATPX version 1 ATOM BIOS: HP radeon 0000:02:00.0: VRAM: 512M 0x0000000000000000 - 0x000000001FFFFFFF (512M used) radeon 0000:02:00.0: GTT: 512M 0x0000000020000000 - 0x000000003FFFFFFF [drm] Detected VRAM RAM=512M, BAR=256M [drm] RAM width 64bits DDR [drm] radeon: 512M of VRAM memory ready [drm] radeon: 512M of GTT memory ready. radeon 0000:02:00.0: ffff880215ec6800 unpin not necessary radeon 0000:02:00.0: fence driver on ring 5 use gpu addr 0x000000000005c418 and cpu addr 0xffffc900030ba418 [drm] GART: num cpu pages 131072, num gpu pages 131072 [drm] enabling PCIE gen 2 link speeds, disable with radeon.pcie_gen2=0 [drm] Loading CEDAR Microcode [drm] PCIE GART of 512M enabled (table at 0x0000000000040000). radeon 0000:02:00.0: WB enabled radeon 0000:02:00.0: fence driver on ring 0 use gpu addr 0x0000000020000c00 and cpu addr 0xffff880215b24c00 radeon 0000:02:00.0: fence driver on ring 3 use gpu addr 0x0000000020000c0c and cpu addr 0xffff880215b24c0c radeon 0000:02:00.0: fence driver on ring 5 use gpu addr 0x000000000015e418 and cpu addr 0xffffc9000391c418 [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). [drm] Driver supports precise vblank timestamp query. radeon 0000:02:00.0: irq 43 for MSI/MSI-X radeon 0000:02:00.0: radeon: using MSI. [drm] radeon: irq initialized. [drm] ring test on 0 succeeded in 1 usecs [drm] ring test on 3 succeeded in 1 usecs [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, trying to reset the VCPU!!! [drm:r600_uvd_init] *ERROR* UVD not responding, giving up!!! [drm:evergreen_startup] *ERROR* radeon: error initializing UVD (-1). [drm] Enabling audio support [drm] ib test on ring 0 succeeded in 0 usecs [drm] ib test on ring 3 succeeded in 0 usecs [drm] radeon atom DIG backlight initialized [drm] Radeon Display Connectors [drm] Connector 0: [drm] LVDS-2 [drm] DDC: 0x6560 0x6560 0x6564 0x6564 0x6568 0x6568 0x656c 0x656c [drm] Encoders: [drm] LCD1: INTERNAL_UNIPHY [drm] Connector 1: [drm] HDMI-A-1 [drm] HPD1 [drm] DDC: 0x6430 0x6430 0x6434 0x6434 0x6438 0x6438 0x643c 0x643c [drm] Encoders: [drm] DFP1: INTERNAL_UNIPHY1 [drm] Connector 2: [drm] VGA-2 [drm] DDC: 0x64d8 0x64d8 0x64dc 0x64dc 0x64e0 0x64e0 0x64e4 0x64e4 [drm] Encoders: [drm] CRT1: INTERNAL_KLDSCP_DAC1 [drm] Internal thermal controller without fan control [drm] radeon: power management initialized [drm] fb mappable at 0xE035F000 [drm] vram apper at 0xE0000000 [drm] size 5787648 [drm] fb depth is 24 [drm] pitch is 6400 radeon 0000:02:00.0: fb1: radeondrmfb frame buffer device [drm] Initialized radeon 2.33.0 20080528 for 0000:02:00.0 on minor 1 Please help. -- Regards, Jörg-Volker.

3 8

[PULL] drm-intel-fixes for 3.11
by Daniel Vetter 03 Jul '13

03 Jul '13

Hi Dave, Pile of fixes for 3.11. A bit large in patch count, but that's simply due to two fixes being split up into really small parts. Also I've included a few more vlv patches than I'd have included for other platforms. But since vlv is officially supported for the first time only in 3.11 that shouldn't result in unbearable risks. Highlights: - ghost eDP fixes for hsw from Paulo - fix PCH detection in virtualized enviroments (Rui Guo) - duct-tape dma sg construction when swiotlb is in use (Konrad), dupe with a patch in your drm-fixes branch - fix sdvo hotplug on i965g - tune down a bunch of dmesg ERRORs which can be hit under normal conditions - detect invalid pitches for tiled scanout buffers (Chris) - a pile of vlv fixes from Ville: rps improvements, fixes for the dpll LPF, fixup the sprite mmio offsets - fix context size on hsw (Ben) - locking fixes for the hotplug code, specifically the storm handling - fix get_config on CPT (Xiong Zhang) - Fix the domain tracking when an unlocked seqno wait was interrupt (Chris), this seems to explain tons of little corruption bugs in the ddx. Chris also added a nice igt to exercise this. - work around stack-corrupting vnsprintf in our error state dumper I have 1-2 fixes in flight (like reset improvements on gm45, recently discovered with more paranoid igt tests), but those need a bit more time to settle. So I've figured I'll flush out my current pile of patches. Cheers, Daniel The following changes since commit d482e5fa299c2cfbb4700143dd766273730e2357: Revert "drm: kms_helper: don't lose hotplug event" (2013-06-28 20:31:34 +1000) are available in the git repository at: git://people.freedesktop.org/~danvet/drm-intel tags/drm-intel-fixes-2013-07-03 for you to fetch changes up to 446f8d81ca2d9cefb614e87f2fabcc996a9e4e7e: drm/i915: Don't try to tear down the stolen drm_mm if it's not there (2013-07-02 11:47:19 +0200) ---------------------------------------------------------------- Ben Widawsky (1): drm/i915: Fix context sizes on HSW Chris Wilson (4): drm/i915: Detect invalid scanout pitches drm/i915: Only clear write-domains after a successful wait-seqno drm/i915: Refactor the wait_rendering completion into a common routine drm/i915: Break up the large vsnprintf() in print_error_buffers() Damien Lespiau (1): drm/i915: Introduce an HAS_IPS() macro Daniel Vetter (11): drm/i915: tune down DIDL warning about too many outputs drm/i915: Fix up sdvo hpd pins for i965g/gm drm/i915: don't scream into dmesg when a modeset fails drm/i915: fix locking around ironlake_enable|disable_display_irq drm/i915: close tiny race in the ilk pcu even interrupt setup drm/i915: s/hotplug_irq_storm_detect/intel_hpd_irq_handler/ drm/i915: fold the hpd_irq_setup call into intel_hpd_irq_handler drm/i915: fold the queue_work into intel_hpd_irq_handler drm/i915: fold the no-irq check into intel_hpd_irq_handler drm/i915: fix hpd interrupt register locking drm/i915: Don't try to tear down the stolen drm_mm if it's not there Jani Nikula (1): drm/i915: fix build warning on format specifier mismatch Konrad Rzeszutek Wilk (1): drm/i915: make compact dma scatter lists creation work with SWIOTLB backend. Paulo Zanoni (7): drm/i915: don't check encoder at DP connector destroy() drm/i915: extract intel_edp_init_connector drm/i915: propagate errors from intel_dp_init_connector drm/i915: fix the "ghost eDP" connector unwind path drm/i915: fix the "ghost eDP" encoder unwind path drm/i915: check the return value of intel_dp_i2c_init drm/i915: rename intel_dp_destroy to intel_dp_connector_destroy Rui Guo (1): drm/i915: Fix PCH detect with multiple ISA bridges in VM Ville Syrjälä (11): drm/i915: Remove duplicated WaForceL3Serialization:vlv drm/i915: Clean up VLV rps code a bit drm/i915: Don't wait for Punit after each freq change on VLV drm/i915: Make the rps new_delay comparison more readable drm/i915: GEN6_RP_INTERRUPT_LIMITS doesn't seem to exist on VLV drm/i915: Don't increase the GPU frequency from the delayed VLV rps timer drm/i915: Jump to at least RPe on VLV when increasing the GPU frequency drm/i915: Fix VLV PLL LPF coefficients for DAC drm/i915: s/LFP/LPF in DPIO PLL register names Revert "drm/i915: Don't use the HDMI port color range bit on Valleyview" drm/i915: Fix VLV sprite register offsets Xiong Zhang (1): drm/i915: correct intel_dp_get_config() function for DevCPT drivers/gpu/drm/i915/i915_debugfs.c | 119 ++++++++++++----- drivers/gpu/drm/i915/i915_drv.c | 18 ++- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem.c | 64 +++++---- drivers/gpu/drm/i915/i915_gem_context.c | 2 +- drivers/gpu/drm/i915/i915_gem_stolen.c | 9 +- drivers/gpu/drm/i915/i915_irq.c | 137 +++++++++++--------- drivers/gpu/drm/i915/i915_reg.h | 84 ++++++------ drivers/gpu/drm/i915/intel_ddi.c | 7 +- drivers/gpu/drm/i915/intel_display.c | 38 ++++-- drivers/gpu/drm/i915/intel_dp.c | 215 +++++++++++++++++++------------ drivers/gpu/drm/i915/intel_drv.h | 5 +- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_opregion.c | 8 +- drivers/gpu/drm/i915/intel_pm.c | 110 +++++++++------- 15 files changed, 498 insertions(+), 322 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

1 0

[PATCH] drm/nouveau: bump fence timeout to 150 seconds
by Maarten Lankhorst 03 Jul '13

03 Jul '13

Fixes parallel piglit runs on fermi with boot clock speeds. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)canonical.com> --- diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 1e753b0..460dd00 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fence.c +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c @@ -144,7 +144,7 @@ nouveau_fence_emit(struct nouveau_fence *fence, struct nouveau_channel *chan) int ret; fence->channel = chan; - fence->timeout = jiffies + (3 * DRM_HZ); + fence->timeout = jiffies + (150 * DRM_HZ); fence->sequence = ++fctx->sequence; ret = fctx->emit(fence);

1 0

[patch] drm/nvc0/gr: remove duplicate break statements
by Dan Carpenter 03 Jul '13

03 Jul '13

There are two break statements in a row. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c index 3be7b95..f1c0767 100644 --- a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c +++ b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c @@ -2249,7 +2249,6 @@ nvc0_grctx_generate_tp(struct nvc0_graph_priv *priv) nv_wr32(priv, 0x419f54, 0x00000000); nv_wr32(priv, 0x419f58, 0x00000000); break; - break; default: BUG_ON(1); break; @@ -2321,7 +2320,6 @@ nvc0_grctx_generate(struct nvc0_graph_priv *priv) } } break; - break; case 0xc0: case 0xc3: case 0xc4:

1 0

[PATCH] drm/exynos: fix pages allocation in lowlevel_buffer_allocate
by Seung-Woo Kim 03 Jul '13

03 Jul '13

From: YoungJun Cho <yj44.cho(a)samsung.com> When drm iommu is not supported, buf->pages has to be allocated and assigned to phys_to_page() result, which type is struct page *. So it is sufficient to allocate buf->pages with multiple struct page pointer size. Signed-off-by: YoungJun Cho <yj44.cho(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index 22865ba..3200622 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c @@ -57,7 +57,7 @@ static int lowlevel_buffer_allocate(struct drm_device *dev, dma_addr_t start_addr; unsigned int i = 0; - buf->pages = kzalloc(sizeof(struct page) * nr_pages, + buf->pages = kzalloc(sizeof(struct page *) * nr_pages, GFP_KERNEL); if (!buf->pages) { DRM_ERROR("failed to allocate pages.\n"); -- 1.7.9.5

4 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2013