dri-devel March 2014

dri-devel@lists.freedesktop.org

144 participants
926 discussions

[PATCH] drm/ttm: don't oops if no invalidate_caches()
by Thomas Hellstrom 12 Mar '14

12 Mar '14

From: Rob Clark <rclark(a)redhat.com> A few of the simpler TTM drivers (cirrus, ast, mgag200) do not implement this function. Yet can end up somehow with an evicted bo: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [< (null)>] (null) PGD 16e761067 PUD 16e6cf067 PMD 0 Oops: 0010 [#1] SMP Modules linked in: bnep bluetooth rfkill fuse ip6t_rpfilter ip6t_REJECT ipt_REJECT xt_conntrack ebtable_nat ebtable_broute bridge stp … [View More]llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw iptable_filter ip_tables sg btrfs zlib_deflate raid6_pq xor dm_queue_length iTCO_wdt iTCO_vendor_support coretemp kvm dcdbas dm_service_time microcode serio_raw pcspkr lpc_ich mfd_core i7core_edac edac_core ses enclosure ipmi_si ipmi_msghandler shpchp acpi_power_meter mperf nfsd auth_rpcgss nfs_acl lockd uinput sunrpc dm_multipath xfs libcrc32c ata_generic pata_acpi sr_mod cdrom sd_mod usb_storage mgag200 syscopyarea sysfillrect sysimgblt i2c_algo_bit lpfc drm_kms_helper ttm crc32c_intel ata_piix bfa drm ixgbe libata i2c_core mdio crc_t10dif ptp crct10dif_common pps_core scsi_transport_fc dca scsi_tgt megaraid_sas bnx2 dm_mirror dm_region_hash dm_log dm_mod CPU: 16 PID: 2572 Comm: X Not tainted 3.10.0-86.el7.x86_64 #1 Hardware name: Dell Inc. PowerEdge R810/0H235N, BIOS 0.3.0 11/14/2009 task: ffff8801799dabc0 ti: ffff88016c884000 task.ti: ffff88016c884000 RIP: 0010:[<0000000000000000>] [< (null)>] (null) RSP: 0018:ffff88016c885ad8 EFLAGS: 00010202 RAX: ffffffffa04e94c0 RBX: ffff880178937a20 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000240004 RDI: ffff880178937a00 RBP: ffff88016c885b60 R08: 00000000000171a0 R09: ffff88007cf171a0 R10: ffffea0005842540 R11: ffffffff810487b9 R12: ffff880178937b30 R13: ffff880178937a00 R14: ffff88016c885b78 R15: ffff880179929400 FS: 00007f81ba2ef980(0000) GS:ffff88007cf00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 000000016e763000 CR4: 00000000000007e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Stack: ffffffffa0306fae ffff8801799295c0 0000000000260004 0000000000000001 ffff88016c885b60 ffffffffa0307669 00ff88007cf17738 ffff88017cf17700 ffff880178937a00 ffff880100000000 ffff880100000000 0000000079929400 Call Trace: [<ffffffffa0306fae>] ? ttm_bo_handle_move_mem+0x54e/0x5b0 [ttm] [<ffffffffa0307669>] ? ttm_bo_mem_space+0x169/0x340 [ttm] [<ffffffffa0307bd7>] ttm_bo_move_buffer+0x117/0x130 [ttm] [<ffffffff81130001>] ? perf_event_init_context+0x141/0x220 [<ffffffffa0307cb1>] ttm_bo_validate+0xc1/0x130 [ttm] [<ffffffffa04e7377>] mgag200_bo_pin+0x87/0xc0 [mgag200] [<ffffffffa04e56c4>] mga_crtc_cursor_set+0x474/0xbb0 [mgag200] [<ffffffff811971d2>] ? __mem_cgroup_commit_charge+0x152/0x3b0 [<ffffffff815c4182>] ? mutex_lock+0x12/0x2f [<ffffffffa0201433>] drm_mode_cursor_common+0x123/0x170 [drm] [<ffffffffa0205231>] drm_mode_cursor_ioctl+0x41/0x50 [drm] [<ffffffffa01f5ca2>] drm_ioctl+0x502/0x630 [drm] [<ffffffff815cbab4>] ? __do_page_fault+0x1f4/0x510 [<ffffffff8101cb68>] ? __restore_xstate_sig+0x218/0x4f0 [<ffffffff811b4445>] do_vfs_ioctl+0x2e5/0x4d0 [<ffffffff8124488e>] ? file_has_perm+0x8e/0xa0 [<ffffffff811b46b1>] SyS_ioctl+0x81/0xa0 [<ffffffff815d05d9>] system_call_fastpath+0x16/0x1b Code: Bad RIP value. RIP [< (null)>] (null) RSP <ffff88016c885ad8> CR2: 0000000000000000 Signed-off-by: Rob Clark <rclark(a)redhat.com> Reviewed-by: Jérôme Glisse <jglisse(a)redhat.com> Reviewed-by: Thomas Hellstrom <thellstrom(a)vmware.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/ttm/ttm_bo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index a066513..214b799 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -351,9 +351,11 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, moved: if (bo->evicted) { - ret = bdev->driver->invalidate_caches(bdev, bo->mem.placement); - if (ret) - pr_err("Can not flush read caches\n"); + if (bdev->driver->invalidate_caches) { + ret = bdev->driver->invalidate_caches(bdev, bo->mem.placement); + if (ret) + pr_err("Can not flush read caches\n"); + } bo->evicted = false; } -- 1.7.10.4 [View Less]

1 0

[PATCH] drm/ttm: don't oops if no invalidate_caches()
by Rob Clark 12 Mar '14

12 Mar '14

From: Rob Clark <rclark(a)redhat.com> A few of the simpler TTM drivers (cirrus, ast, mgag200) do not implement this function. Yet can end up somehow with an evicted bo: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [< (null)>] (null) PGD 16e761067 PUD 16e6cf067 PMD 0 Oops: 0010 [#1] SMP Modules linked in: bnep bluetooth rfkill fuse ip6t_rpfilter ip6t_REJECT ipt_REJECT xt_conntrack ebtable_nat ebtable_broute bridge stp … [View More]llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw iptable_filter ip_tables sg btrfs zlib_deflate raid6_pq xor dm_queue_length iTCO_wdt iTCO_vendor_support coretemp kvm dcdbas dm_service_time microcode serio_raw pcspkr lpc_ich mfd_core i7core_edac edac_core ses enclosure ipmi_si ipmi_msghandler shpchp acpi_power_meter mperf nfsd auth_rpcgss nfs_acl lockd uinput sunrpc dm_multipath xfs libcrc32c ata_generic pata_acpi sr_mod cdrom sd_mod usb_storage mgag200 syscopyarea sysfillrect sysimgblt i2c_algo_bit lpfc drm_kms_helper ttm crc32c_intel ata_piix bfa drm ixgbe libata i2c_core mdio crc_t10dif ptp crct10dif_common pps_core scsi_transport_fc dca scsi_tgt megaraid_sas bnx2 dm_mirror dm_region_hash dm_log dm_mod CPU: 16 PID: 2572 Comm: X Not tainted 3.10.0-86.el7.x86_64 #1 Hardware name: Dell Inc. PowerEdge R810/0H235N, BIOS 0.3.0 11/14/2009 task: ffff8801799dabc0 ti: ffff88016c884000 task.ti: ffff88016c884000 RIP: 0010:[<0000000000000000>] [< (null)>] (null) RSP: 0018:ffff88016c885ad8 EFLAGS: 00010202 RAX: ffffffffa04e94c0 RBX: ffff880178937a20 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000240004 RDI: ffff880178937a00 RBP: ffff88016c885b60 R08: 00000000000171a0 R09: ffff88007cf171a0 R10: ffffea0005842540 R11: ffffffff810487b9 R12: ffff880178937b30 R13: ffff880178937a00 R14: ffff88016c885b78 R15: ffff880179929400 FS: 00007f81ba2ef980(0000) GS:ffff88007cf00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 000000016e763000 CR4: 00000000000007e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Stack: ffffffffa0306fae ffff8801799295c0 0000000000260004 0000000000000001 ffff88016c885b60 ffffffffa0307669 00ff88007cf17738 ffff88017cf17700 ffff880178937a00 ffff880100000000 ffff880100000000 0000000079929400 Call Trace: [<ffffffffa0306fae>] ? ttm_bo_handle_move_mem+0x54e/0x5b0 [ttm] [<ffffffffa0307669>] ? ttm_bo_mem_space+0x169/0x340 [ttm] [<ffffffffa0307bd7>] ttm_bo_move_buffer+0x117/0x130 [ttm] [<ffffffff81130001>] ? perf_event_init_context+0x141/0x220 [<ffffffffa0307cb1>] ttm_bo_validate+0xc1/0x130 [ttm] [<ffffffffa04e7377>] mgag200_bo_pin+0x87/0xc0 [mgag200] [<ffffffffa04e56c4>] mga_crtc_cursor_set+0x474/0xbb0 [mgag200] [<ffffffff811971d2>] ? __mem_cgroup_commit_charge+0x152/0x3b0 [<ffffffff815c4182>] ? mutex_lock+0x12/0x2f [<ffffffffa0201433>] drm_mode_cursor_common+0x123/0x170 [drm] [<ffffffffa0205231>] drm_mode_cursor_ioctl+0x41/0x50 [drm] [<ffffffffa01f5ca2>] drm_ioctl+0x502/0x630 [drm] [<ffffffff815cbab4>] ? __do_page_fault+0x1f4/0x510 [<ffffffff8101cb68>] ? __restore_xstate_sig+0x218/0x4f0 [<ffffffff811b4445>] do_vfs_ioctl+0x2e5/0x4d0 [<ffffffff8124488e>] ? file_has_perm+0x8e/0xa0 [<ffffffff811b46b1>] SyS_ioctl+0x81/0xa0 [<ffffffff815d05d9>] system_call_fastpath+0x16/0x1b Code: Bad RIP value. RIP [< (null)>] (null) RSP <ffff88016c885ad8> CR2: 0000000000000000 Signed-off-by: Rob Clark <rclark(a)redhat.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 7298053..acd0fe0 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -351,9 +351,11 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, moved: if (bo->evicted) { - ret = bdev->driver->invalidate_caches(bdev, bo->mem.placement); - if (ret) - pr_err("Can not flush read caches\n"); + if (bdev->driver->invalidate_caches) { + ret = bdev->driver->invalidate_caches(bdev, bo->mem.placement); + if (ret) + pr_err("Can not flush read caches\n"); + } bo->evicted = false; } -- 1.8.5.3 [View Less]

3 2

[PULL] ttm-fixes-3.14
by Thomas Hellstrom 12 Mar '14

12 Mar '14

Dave, A single fix for a performance regression. The following changes since commit 45db98e54242f3ae94bdcfbfe754e743252eb168: Merge branch 'drm-fixes-3.14' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2014-03-07 09:27:22 +1000) are available in the git repository at: git://people.freedesktop.org/~thomash/linux tags/ttm-fixes-3.14-2014-03-12 for you to fetch changes up to 0e6d6ec02f867fe8d1f785312b7343b21052322f: drm/ttm: Work around performance regression with … [View More]

1 1

[Bug 42162] [r600g][kms] Display not enabled on resume (HP DV6)
by bugzilla-daemon＠freedesktop.org 12 Mar '14

12 Mar '14

https://bugs.freedesktop.org/show_bug.cgi?id=42162 --- Comment #27 from Johan Brannlund <freedesktop-bugs(a)nullinfinity.org> --- Taking a tip from https://bugs.freedesktop.org/show_bug.cgi?id=58382, I tried suspending using "pm-suspend --quirk-test --quirk-s3-mode" and this works for me too. Using this, the display *does* get re-enabled on resume. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[RFCv2 00/10] Universal plane support
by Matt Roper 12 Mar '14

12 Mar '14

One of the stepping stones on the way to atomic/nuclear operation is to expose all types of hardware planes to userspace via a consistent interface. Until now, the DRM plane interface has only operated on planes that drivers consider "overlay" or "sprite" planes; primary planes were simply represented by extra state hanging off the CRTC, and cursor planes had no direct representation in userspace, but were manipulated via separate ioctl's. This patch set begins the process of unifying the … [View More]various plane types into a single, consistent interface. With this patchset, userspace clients that set a DRM_CLIENT_CAP_UNIVERSAL_PLANES client capability bit will receive a full list of all hardware planes, including primary planes and cursor planes, not just the overlay/sprite planes that have historically been returned. Userspace should be able to make drmModeSetPlane() calls against any type of plane and have them operate as expected (to the extent supported by the underlying hardware). This benefits of this unified interface will be most evident once driver state is fully property-ized as part of the upcoming atomic modeset / nuclear pageflip work. However there are a few benefits that may be achieved even before then: * Drivers for hardware with scaling-capable primary planes may honor userspace scaling requests for the primary plane made with the drmModeSetPlane() call. Previously there was no interface that allowed userspace to specify desired scaling on primary planes. * Drivers for hardware that may disable primary planes independently from the underlying CRTC may now do so when userspace passes a NULL framebuffer to the drmModeSetPlane() interface. This patchset is organized as follows: - Patch 1 updates the DRM core with the general concept of multiple plane types and prepares for there to be multiple types of planes on the DRM plane list. - Patch 2 adds a set of primary plane helper functions that drivers may use to quickly support plane operations against primary planes. These helpers implement plane update operations by calling into the driver's modeset interface. These helpers are optional; drivers are free to provide their own implementation. - Patches 3 and 4 update loops over the DRM plane list in the exynos and i915 drivers to ignore non-overlay planes. This ensures that the behavior of these loops will not change when new plane types show up on the DRM plane list in future patches. - Patch 5 adds a "plane type" property that allows userspace to identify the types of the planes it receives. Note that we replace the 'priv' parameter to drm_plane_init() with the type that should be used for this property; in doing so, we create the first opportunity for non-overlay planes to appear on the DRM plane list for some drivers ( msm, omap, and imx), although they will not be visible to userspace at this time. - Patch 6 updates all drivers to call drm_primary_helper_create_plane() before CRTC creation and then pass the resulting plane to drm_crtc_init(). This will create a primary plane via the primary plane helper and add it to the DRM plane list. Note that this is the first time that *all* drivers will have non-overlay planes on their plane list (msm, omap, and imx had their previously-private planes show up in the plane list in patch 5). These non-overlay planes still cannot be exposed to userspace. - Patch 7 drops the 'fb' field from drm_crtc and switches everything to using crtc->primary->fb instead. - Patch 8 adds the client capability bit which allows userspace to request the full plane list rather than just the overlay list. This is the first patch that may have a userspace-visible effect. - Patch 9 is a simple function name update in i915 to avoid confusion. - Patch 10 replaces the primary plane helper usage in i915 with a custom implementation of primary planes. On Intel hardware, we can disable the primary plane without disabling the entire CRTC; the custom implementation here allows us to avoid that limitation assumed by the helpers. This patch set is still a work in progress. Specific work that still needs to be done: * Update msm, omap, and imx to properly associate their primary planes with the appropriate CRTC (and stop creating a separate dummy primary plane). At the moment the formerly "private" planes that these drivers use are created as primary planes, but they're never specifically associated with the correct CRTC (i.e., passed at drm_crtc_init()). I think this should be pretty straightforward, but I just haven't had enough time to look through how those drivers are structured yet to make the change. [suggested by Rob Clark] * Add cursor plane implementation. The general infrastructure necessary to support cursors is present, but no default helpers exist yet and no driver actually registers any cursor planes. * Add extra read-only plane properties to inform userspace of what a plane's true limitations and capabilities are. Although the "plane type" property is probably enough to get by with something like a driver-specific DDX in userspace, hardware-independent userspace like Weston will need more information about what can and can't be done with each plane. This is especially important for cursor planes since they can largely be viewed as additional overlay planes that just have some extra limitations attached. * Disallow usage of legacy cursor interfaces by clients that request universal plane support. Make the new, unified interface the only interface for clients that can support it. [suggested by Ville Syrjälä] Matt Roper (10): drm: Add support for multiple plane types drm: Add primary plane helpers drm/exynos: Restrict plane loops to only operate on overlay planes drm/i915: Restrict plane loops to only operate on overlay planes drm: Add plane type property drm: Specify primary plane at CRTC initialization drm: Replace crtc fb with primary plane fb drm: Allow userspace to ask for full plane list (universal planes) drm/i915: Rename similar plane functions to avoid confusion drm/i915: Intel-specific primary plane handling drivers/gpu/drm/armada/armada_crtc.c | 4 +- drivers/gpu/drm/armada/armada_overlay.c | 3 +- drivers/gpu/drm/ast/ast_mode.c | 4 +- drivers/gpu/drm/bochs/bochs_kms.c | 4 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 4 +- drivers/gpu/drm/drm_crtc.c | 447 ++++++++++++++++++++++------ drivers/gpu/drm/drm_crtc_helper.c | 21 +- drivers/gpu/drm/drm_fb_helper.c | 9 +- drivers/gpu/drm/drm_ioctl.c | 5 + drivers/gpu/drm/exynos/exynos_drm_crtc.c | 4 +- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 6 + drivers/gpu/drm/exynos/exynos_drm_plane.c | 4 +- drivers/gpu/drm/gma500/psb_intel_display.c | 4 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 5 +- drivers/gpu/drm/i915/i915_irq.c | 4 +- drivers/gpu/drm/i915/intel_display.c | 238 +++++++++++---- drivers/gpu/drm/i915/intel_dp.c | 5 +- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_overlay.c | 4 +- drivers/gpu/drm/i915/intel_pm.c | 39 +-- drivers/gpu/drm/i915/intel_sprite.c | 2 +- drivers/gpu/drm/mgag200/mgag200_mode.c | 4 +- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 4 +- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 4 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 3 +- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 24 +- drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 4 +- drivers/gpu/drm/nouveau/nouveau_display.c | 8 +- drivers/gpu/drm/nouveau/nv50_display.c | 21 +- drivers/gpu/drm/omapdrm/omap_crtc.c | 4 +- drivers/gpu/drm/omapdrm/omap_plane.c | 4 +- drivers/gpu/drm/qxl/qxl_display.c | 4 +- drivers/gpu/drm/radeon/atombios_crtc.c | 20 +- drivers/gpu/drm/radeon/r100.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 3 +- drivers/gpu/drm/radeon/radeon_display.c | 8 +- drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 16 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 +- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 +- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 3 +- drivers/gpu/drm/shmobile/shmob_drm_plane.c | 2 +- drivers/gpu/drm/tegra/dc.c | 7 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4 +- drivers/gpu/drm/udl/udl_modeset.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 4 +- drivers/staging/imx-drm/imx-drm-core.c | 4 +- drivers/staging/imx-drm/ipuv3-plane.c | 4 +- include/drm/drmP.h | 5 + include/drm/drm_crtc.h | 108 ++++++- include/uapi/drm/drm.h | 8 + 55 files changed, 853 insertions(+), 275 deletions(-) -- 1.8.5.1 [View Less]

3 15

[PATCH] drm/exynos: add hdmi power on/off sequence
by Shirish S 12 Mar '14

12 Mar '14

This patch implements the power on/off sequence (and its dependant functions) of HDMI exynos5250 as provided by the hardware team. Signed-off-by: Shirish S <s.shirish(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 137 +++++++++++++++++++++++++++++----- drivers/gpu/drm/exynos/regs-hdmi.h | 15 ++++ 2 files changed, 133 insertions(+), 19 deletions(-) mode change 100644 => 100755 drivers/gpu/drm/exynos/exynos_hdmi.c mode change 100644 => 100755 drivers/gpu/drm/… [View More]exynos/regs-hdmi.h diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c old mode 100644 new mode 100755 index 12fdf55..ee000f7 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -180,6 +180,7 @@ struct hdmi_context { void __iomem *regs; int irq; + void __iomem *phy_pow_ctrl_reg; struct i2c_client *ddc_port; struct i2c_client *hdmiphy_port; @@ -387,6 +388,33 @@ static inline void hdmi_reg_writemask(struct hdmi_context *hdata, writel(value, hdata->regs + reg_id); } + +static inline void hdmi_phy_pow_ctrl_reg_writemask(struct hdmi_context *hdata, + u32 value, u32 mask) +{ + u32 old = readl(hdata->phy_pow_ctrl_reg); + value = (value & mask) | (old & ~mask); + writel(value, hdata->phy_pow_ctrl_reg); +} + +static int hdmiphy_reg_writeb(struct hdmi_context *hdata, + u32 reg_offset, u8 value) +{ + if (hdata->hdmiphy_port) { + u8 buffer[2]; + int ret; + + buffer[0] = reg_offset; + buffer[1] = value; + + ret = i2c_master_send(hdata->hdmiphy_port, buffer, 2); + if (ret == 2) + return 0; + return ret; + } else + return 0; +} + static void hdmi_v13_regs_dump(struct hdmi_context *hdata, char *prefix) { #define DUMPREG(reg_id) \ @@ -1386,19 +1414,14 @@ static void hdmi_mode_apply(struct hdmi_context *hdata) static void hdmiphy_conf_reset(struct hdmi_context *hdata) { - u8 buffer[2]; u32 reg; clk_disable_unprepare(hdata->res.sclk_hdmi); clk_set_parent(hdata->res.mout_hdmi, hdata->res.sclk_pixel); clk_prepare_enable(hdata->res.sclk_hdmi); - /* operation mode */ - buffer[0] = 0x1f; - buffer[1] = 0x00; - - if (hdata->hdmiphy_port) - i2c_master_send(hdata->hdmiphy_port, buffer, 2); + hdmiphy_reg_writeb(hdata, HDMIPHY_MODE_SET_DONE, + HDMI_PHY_ENABLE_MODE_SET); if (hdata->type == HDMI_TYPE13) reg = HDMI_V13_PHY_RSTOUT; @@ -1414,16 +1437,42 @@ static void hdmiphy_conf_reset(struct hdmi_context *hdata) static void hdmiphy_poweron(struct hdmi_context *hdata) { - if (hdata->type == HDMI_TYPE14) - hdmi_reg_writemask(hdata, HDMI_PHY_CON_0, 0, - HDMI_PHY_POWER_OFF_EN); + if (hdata->type == HDMI_TYPE13) + return; + + DRM_DEBUG_KMS("\n"); + + /* For PHY Mode Setting */ + hdmiphy_reg_writeb(hdata, HDMIPHY_MODE_SET_DONE, + HDMI_PHY_ENABLE_MODE_SET); + /* Phy Power On */ + hdmiphy_reg_writeb(hdata, HDMIPHY_POWER, + HDMI_PHY_POWER_ON); + /* For PHY Mode Setting */ + hdmiphy_reg_writeb(hdata, HDMIPHY_MODE_SET_DONE, + HDMI_PHY_DISABLE_MODE_SET); + /* PHY SW Reset */ + hdmiphy_conf_reset(hdata); } static void hdmiphy_poweroff(struct hdmi_context *hdata) { - if (hdata->type == HDMI_TYPE14) - hdmi_reg_writemask(hdata, HDMI_PHY_CON_0, ~0, - HDMI_PHY_POWER_OFF_EN); + if (hdata->type == HDMI_TYPE13) + return; + + DRM_DEBUG_KMS("\n"); + + /* PHY SW Reset */ + hdmiphy_conf_reset(hdata); + /* For PHY Mode Setting */ + hdmiphy_reg_writeb(hdata, HDMIPHY_MODE_SET_DONE, + HDMI_PHY_ENABLE_MODE_SET); + /* PHY Power Off */ + hdmiphy_reg_writeb(hdata, HDMIPHY_POWER, + HDMI_PHY_POWER_OFF); + /* For PHY Mode Setting */ + hdmiphy_reg_writeb(hdata, HDMIPHY_MODE_SET_DONE, + HDMI_PHY_DISABLE_MODE_SET); } static void hdmiphy_conf_apply(struct hdmi_context *hdata) @@ -1476,6 +1525,14 @@ static void hdmiphy_conf_apply(struct hdmi_context *hdata) DRM_ERROR("failed to read hdmiphy config\n"); return; } + usleep_range(10000, 12000); + + ret = hdmiphy_reg_writeb(hdata, HDMIPHY_MODE_SET_DONE, + HDMI_PHY_DISABLE_MODE_SET); + if (ret < 0) { + DRM_ERROR("failed to enable hdmiphy\n"); + return; + } for (i = 0; i < ret; i++) DRM_DEBUG_KMS("hdmiphy[0x%02x] write[0x%02x] - " @@ -1767,10 +1824,10 @@ static void hdmi_poweron(struct exynos_drm_display *display) if (regulator_bulk_enable(res->regul_count, res->regul_bulk)) DRM_DEBUG_KMS("failed to enable regulator bulk\n"); - clk_prepare_enable(res->hdmiphy); - clk_prepare_enable(res->hdmi); - clk_prepare_enable(res->sclk_hdmi); + hdmi_phy_pow_ctrl_reg_writemask(hdata, PMU_HDMI_PHY_ENABLE, + PMU_HDMI_PHY_CONTROL_MASK); + /* HDMI PHY Enable and Power-On */ hdmiphy_poweron(hdata); hdmi_commit(display); } @@ -1790,11 +1847,16 @@ static void hdmi_poweroff(struct exynos_drm_display *display) * its reset state seems to meet the condition. */ hdmiphy_conf_reset(hdata); + + /* HDMI System Disable */ + hdmi_reg_writemask(hdata, HDMI_CON_0, 0, HDMI_EN); + hdmiphy_poweroff(hdata); - clk_disable_unprepare(res->sclk_hdmi); - clk_disable_unprepare(res->hdmi); - clk_disable_unprepare(res->hdmiphy); + /* HDMI PHY Disable */ + hdmi_phy_pow_ctrl_reg_writemask(hdata, PMU_HDMI_PHY_DISABLE, + PMU_HDMI_PHY_CONTROL_MASK); + regulator_bulk_disable(res->regul_count, res->regul_bulk); pm_runtime_put_sync(hdata->dev); @@ -1947,6 +2009,36 @@ err_data: return NULL; } +static int drm_hdmi_dt_parse_phy_pow_control(struct hdmi_context *hdata) +{ + struct device_node *phy_pow_ctrl_node; + u32 buf[2]; + int ret = 0; + + phy_pow_ctrl_node = of_find_node_by_name(NULL, "phy-power-control"); + if (!phy_pow_ctrl_node) + return 0; + + /* reg property holds two informations: addr of pmu register, size */ + if (of_property_read_u32_array(phy_pow_ctrl_node, "reg", + (u32 *)&buf, 2)) { + DRM_ERROR("faild to get phy power control reg\n"); + ret = -EINVAL; + goto fail; + } + + hdata->phy_pow_ctrl_reg = devm_ioremap(hdata->dev, buf[0], buf[1]); + if (!hdata->phy_pow_ctrl_reg) { + DRM_ERROR("failed to ioremap phy pmu reg\n"); + ret = -ENOMEM; + goto fail; + } + +fail: + of_node_put(phy_pow_ctrl_node); + return ret; +} + static struct of_device_id hdmi_match_types[] = { { .compatible = "samsung,exynos5-hdmi", @@ -2010,6 +2102,13 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data) return ret; } + /* map hdmiphy power control reg */ + ret = drm_hdmi_dt_parse_phy_pow_control(hdata); + if (ret) { + DRM_ERROR("failed to map phy power control registers\n"); + return ret; + } + /* DDC i2c driver */ ddc_node = of_parse_phandle(dev->of_node, "ddc", 0); if (!ddc_node) { diff --git a/drivers/gpu/drm/exynos/regs-hdmi.h b/drivers/gpu/drm/exynos/regs-hdmi.h old mode 100644 new mode 100755 index ef1b3eb..e686fe9 --- a/drivers/gpu/drm/exynos/regs-hdmi.h +++ b/drivers/gpu/drm/exynos/regs-hdmi.h @@ -578,4 +578,19 @@ #define HDMI_TG_VACT_ST4_H HDMI_TG_BASE(0x0074) #define HDMI_TG_3D HDMI_TG_BASE(0x00F0) +/* HDMI PHY Registers Offsets*/ + +#define HDMIPHY_POWER (0x74 >> 2) +#define HDMIPHY_MODE_SET_DONE (0x7C >> 2) + +/* HDMI PHY Values */ +#define HDMI_PHY_POWER_ON 0x80 +#define HDMI_PHY_POWER_OFF 0xFF +#define HDMI_PHY_DISABLE_MODE_SET 0x80 +#define HDMI_PHY_ENABLE_MODE_SET 0x00 + +#define PMU_HDMI_PHY_CONTROL_MASK (1 << 0) +#define PMU_HDMI_PHY_ENABLE (1) +#define PMU_HDMI_PHY_DISABLE (0) + #endif /* SAMSUNG_REGS_HDMI_H */ -- 1.7.10.4 [View Less]

2 1

[PATCH 1/2] drm: Make control nodes master-less
by Thomas Hellstrom 12 Mar '14

12 Mar '14

Like for render-nodes, there is no point in maintaining the master concept for control nodes, so set the struct drm_file::master pointer to NULL. At the same time, make sure DRM_MASTER | DRM_CONTROL_ALLOW ioctls are always allowed when called through the control node. Previously the caller also needed to be master. Signed-off-by: Thomas Hellstrom <thellstrom(a)vmware.com> --- drivers/gpu/drm/drm_drv.c | 5 +++-- drivers/gpu/drm/drm_fops.c | 5 +++-- include/drm/drmP.h | … [View More] 5 +++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 345be03..42af8bd 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -355,8 +355,9 @@ long drm_ioctl(struct file *filp, retcode = -EINVAL; } else if (((ioctl->flags & DRM_ROOT_ONLY) && !capable(CAP_SYS_ADMIN)) || ((ioctl->flags & DRM_AUTH) && !drm_is_render_client(file_priv) && !file_priv->authenticated) || - ((ioctl->flags & DRM_MASTER) && !file_priv->is_master) || - (!(ioctl->flags & DRM_CONTROL_ALLOW) && (file_priv->minor->type == DRM_MINOR_CONTROL)) || + (((ioctl->flags & DRM_MASTER) && !file_priv->is_master) && + !(drm_is_control(file_priv) && (ioctl->flags & DRM_CONTROL_ALLOW))) || + (!(ioctl->flags & DRM_CONTROL_ALLOW) && drm_is_control(file_priv)) || (!(ioctl->flags & DRM_RENDER_ALLOW) && drm_is_render_client(file_priv))) { retcode = -EACCES; } else { diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c index 7f2af9a..08a3196 100644 --- a/drivers/gpu/drm/drm_fops.c +++ b/drivers/gpu/drm/drm_fops.c @@ -259,7 +259,8 @@ static int drm_open_helper(struct inode *inode, struct file *filp, /* if there is no current master make this fd it, but do not create * any master object for render clients */ mutex_lock(&dev->struct_mutex); - if (!priv->minor->master && !drm_is_render_client(priv)) { + if (!priv->minor->master && !drm_is_render_client(priv) && + !drm_is_control(priv)) { /* create a new master */ priv->minor->master = drm_master_create(priv->minor); if (!priv->minor->master) { @@ -297,7 +298,7 @@ static int drm_open_helper(struct inode *inode, struct file *filp, goto out_close; } } - } else if (!drm_is_render_client(priv)) { + } else if (!drm_is_render_client(priv) && !drm_is_control(priv)) { /* get a reference to the master */ priv->master = drm_master_get(priv->minor->master); } diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 04a7f31..ff68e26 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -1246,6 +1246,11 @@ static inline bool drm_is_render_client(struct drm_file *file_priv) return file_priv->minor->type == DRM_MINOR_RENDER; } +static inline bool drm_is_control(struct drm_file *file_priv) +{ + return file_priv->minor->type == DRM_MINOR_CONTROL; +} + /******************************************************************/ /** \name Internal function definitions */ /*@{*/ -- 1.7.10.4 [View Less]

3 10

[PATCH] drm/ttm: Work around performance regression with VM_PFNMAP
by Thomas Hellstrom 12 Mar '14

12 Mar '14

A performance regression was introduced in TTM in linux 3.13 when we started using VM_PFNMAP for shared mappings. In theory this should've been faster due to less page book-keeping but it appears like VM_PFNMAP + x86 PAT + write-combine is a particularly cpu-hungry combination, as seen by largely increased cpu-usage on r200 GL video playback. Until we've sorted out why, revert to always use VM_MIXEDMAP. Reference: freedesktop.org bugzilla bug #75719 Reported-and-tested-by: <smoki00790(a)… [View More]

2 1

Re: [PATCH 1/1] drm/gma500: Code cleanup and adding inline documentation
by Patrik Jakobsson 12 Mar '14

12 Mar '14

Hi Arthur, Please keep the mailing list in CC (It's easily dropped when replying in Gmail). Forgot to tell you, you only need the drm/gma500 tags in the subject line. Not needed in the message itself. On Wed, Mar 12, 2014 at 9:04 AM, Arthur Borsboom <arthurborsboom(a)gmail.com>wrote: > > Split up patch in 3 pieces > > OK > > "static struct drm_driver driver;" needed? > > Yes it became needed, since I moved up the function 'psb_pci_probe' where > it is used, … [View More]before the creation of the struct (to get more in line with the > i915). The same line is also in the i915 driver, I guess for the same > reason. > Ok > > Intel Corporation > > OK > > > PCI device table, why remove the spacing? > > I noticed that in our PCI device table the spaces were inconsistent, so I > decided to make them all equal. The CodingStyleGuide says nothing about > brackets, but they do about parenthesis, were in general you don't put > spaces. I don't mind either of them, so I will add the spaces to the > beginning and the end. OK > > > This breaks the 80 column line rule. See Documentation/CodingStyle > > This is correct; I saw the warning too when running the checkpatch.plscript. A lot of our driver code contains lines which are a little bit > longer than 80 characters. I know the CodeGuide states that the code should > be readable on a 80x25 screen. But honestly, which developer has actually > only 80 columns on his screen? Even with a crappy netbook like mine, with a > 10" screen and a resolution of 1024x600, in a graphical editor, nano or > emacs I still have more than 80 columns (117 in the GUI to be exact). So, > the only moment when you have 80 columns is when your videocard driver is > failing and it falls back to VGA 80x25. So, IMHO, if a line is 85 or 90 > columns long, and it improves readability, I would make an exception. I > believe in this case, it improves readability. Nevertheless, you are making > the call as the responsible person for this driver. So, after my aaawesome > speech, do you want to keep this line longer than 80 char or make me cut it > down to less than 80? > > Some people (including me) keep two files open next to each other. So the 80 col line rule is still applicable. > We don't do internal driver versioning anymore. > > I didn't know that, however, if you are not bothered by it, I like to keep > doing it (at least for me). When I go back in my log files, for example > dmesg, I can see the version number and driver date. This might help me > finding a regression by these log files. If you rather have it not changed, > I will put it back. > The driver version was intended for ABI changes and it's not used anymore. There are better ways to tell userspace what features we expose. For your dmesg case, just look at the kernel version and if needed, name your files appropriately. > > Why bump the patch level? > > IMO, every code change bumps the version number somehow. Since the change > is very very small, major and minor seem to be incorrect, so I believe the > smallest change number is the patchlevel. > > Thanks for the review Patrik! > > In the beginning I guess we will have small talks like this, and after a > while we are on the same line, I guess. ;) > Yes, there is a lot of "process" and it takes a while to get used to it. Documentation/SubmittingPatches is a good read if you haven't already looked at it. > Cheers, > Arthur. > > > On 12 March 2014 01:03, Patrik Jakobsson <patrik.r.jakobsson(a)gmail.com>wrote: > >> On Tue, Mar 11, 2014 at 12:22 PM, Arthur Borsboom >> <arthurborsboom(a)gmail.com> wrote: >> > drm/gma500: Cleanup of code by following i915 constant/variable names >> and ordering >> > drm/gma500: Cleanup of code by following directions from kernel >> documentation: Codingstyle >> > drm/gma500: Cleanup of code by following directions from kernel >> documentation: DRM >> > drm/gma500: Improve readability by adding inline documentation >> > drm/gma500: Removed centralized exiting of function (goto statement), >> since it was the only used in one single location with only a return >> statement. >> > >> > CC: Patrik Jakobsson <patrik.r.jakobsson(a)gmail.com> >> > >> > Signed-off-by: Arthur Borsboom <arthurborsboom(a)gmail.com> >> >> Hi Arthur, >> >> Thanks for the patch. Could you split this up in three patches. >> One for the style fixes, one for documentation and one for the goto fix. >> >> Also, see my comments below. >> >> > --- >> > drivers/gpu/drm/gma500/psb_drv.c | 162 >> +++++++++++++++++++++------------------ >> > drivers/gpu/drm/gma500/psb_drv.h | 58 ++++++-------- >> > 2 files changed, 111 insertions(+), 109 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/gma500/psb_drv.c >> b/drivers/gpu/drm/gma500/psb_drv.c >> > index 1199180..0432136 100644 >> > --- a/drivers/gpu/drm/gma500/psb_drv.c >> > +++ b/drivers/gpu/drm/gma500/psb_drv.c >> > @@ -37,28 +37,42 @@ >> > #include <acpi/video.h> >> > #include <linux/module.h> >> > >> > +static struct drm_driver driver; >> > + >> >> Do we need this? Can't see anything referencing it before we define it. >> >> > static int drm_psb_trap_pagefaults; >> > >> > -static int psb_probe(struct pci_dev *pdev, const struct pci_device_id >> *ent); >> > +static int psb_pci_probe(struct pci_dev *pdev, const struct >> pci_device_id *ent); >> > >> > MODULE_PARM_DESC(trap_pagefaults, "Error and reset on MMU pagefaults"); >> > module_param_named(trap_pagefaults, drm_psb_trap_pagefaults, int, >> 0600); >> > >> > - >> > +/* >> > + * The table below contains a mapping of the PCI vendor ID and the PCI >> Device ID >> > + * to the different groups of PowerVR 5-series chip designs >> > + * >> > + * 0x8086 = Intel Coorperation >> >> s/Coorperation/Corporation >> >> > + * >> > + * PowerVR SGX535 - Poulsbo - Intel GMA 500, Intel Atom Z5xx >> > + * PowerVR SGX535 - Moorestown - Intel GMA 600 >> > + * PowerVR SGX535 - Oaktrail - Intel GMA 600, Intel Atom Z6xx, >> E6xx >> > + * PowerVR SGX540 - Medfield - Intel Atom Z2460 >> > + * PowerVR SGX544MP2 - Medfield - >> > + * PowerVR SGX545 - Cedartrail - Intel GMA 3600, Intel Atom D2500, >> N2600 >> > + * PowerVR SGX545 - Cedartrail - Intel GMA 3650, Intel Atom D2550, >> D2700, N2800 >> > + */ >> > static DEFINE_PCI_DEVICE_TABLE(pciidlist) = { >> > - { 0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &psb_chip_ops }, >> > - { 0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &psb_chip_ops }, >> > + {0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &psb_chip_ops}, >> > + {0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &psb_chip_ops}, >> > #if defined(CONFIG_DRM_GMA600) >> > - { 0x8086, 0x4100, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4101, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4102, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4103, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4104, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4105, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4106, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - { 0x8086, 0x4107, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > - /* Atom E620 */ >> > - { 0x8086, 0x4108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4100, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4101, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4102, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4103, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4104, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4105, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4106, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4107, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> > + {0x8086, 0x4108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &oaktrail_chip_ops}, >> >> Why remove that space? Most drivers have it and also a space at the end. >> Don't think CodingStyle says anything about it anyway. >> >> > #endif >> > #if defined(CONFIG_DRM_MEDFIELD) >> > {0x8086, 0x0130, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &mdfld_chip_ops}, >> > @@ -71,31 +85,30 @@ static DEFINE_PCI_DEVICE_TABLE(pciidlist) = { >> > {0x8086, 0x0137, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &mdfld_chip_ops}, >> > #endif >> > #if defined(CONFIG_DRM_GMA3600) >> > - { 0x8086, 0x0be0, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be3, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be4, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be5, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be6, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be7, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be8, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0be9, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0bea, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0beb, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0bec, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0bed, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0bee, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > - { 0x8086, 0x0bef, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be0, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be3, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be4, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be5, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be6, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be7, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be8, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0be9, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0bea, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0beb, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0bec, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0bed, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0bee, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > + {0x8086, 0x0bef, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (long) >> &cdv_chip_ops}, >> > #endif >> > - { 0, } >> > + {0,} >> > }; >> >> Same here. >> >> > MODULE_DEVICE_TABLE(pci, pciidlist); >> > >> > /* >> > * Standard IOCTLs. >> > */ >> > - >> > #define DRM_IOCTL_GMA_ADB \ >> > DRM_IOWR(DRM_GMA_ADB + DRM_COMMAND_BASE, uint32_t) >> > #define DRM_IOCTL_GMA_MODE_OPERATION \ >> > @@ -147,7 +160,7 @@ static const struct drm_ioctl_desc psb_ioctls[] = { >> > DRM_UNLOCKED | >> DRM_AUTH), >> > }; >> > >> > -static void psb_lastclose(struct drm_device *dev) >> > +static void psb_driver_lastclose(struct drm_device *dev) >> > { >> > int ret; >> > struct drm_psb_private *dev_priv = dev->dev_private; >> > @@ -169,19 +182,14 @@ static int psb_do_init(struct drm_device *dev) >> > >> > uint32_t stolen_gtt; >> > >> > - int ret = -ENOMEM; >> > - >> > if (pg->mmu_gatt_start & 0x0FFFFFFF) { >> > dev_err(dev->dev, "Gatt must be 256M aligned. This is a >> bug.\n"); >> > - ret = -EINVAL; >> > - goto out_err; >> > + return -EINVAL; >> > } >> > >> > - >> > stolen_gtt = (pg->stolen_size >> PAGE_SHIFT) * 4; >> > stolen_gtt = (stolen_gtt + PAGE_SIZE - 1) >> PAGE_SHIFT; >> > - stolen_gtt = >> > - (stolen_gtt < pg->gtt_pages) ? stolen_gtt : pg->gtt_pages; >> > + stolen_gtt = (stolen_gtt < pg->gtt_pages) ? stolen_gtt : >> pg->gtt_pages; >> > >> > dev_priv->gatt_free_offset = pg->mmu_gatt_start + >> > (stolen_gtt << PAGE_SHIFT) * 1024; >> > @@ -192,23 +200,19 @@ static int psb_do_init(struct drm_device *dev) >> > PSB_WSGX32(0x00000000, PSB_CR_BIF_BANK0); >> > PSB_WSGX32(0x00000000, PSB_CR_BIF_BANK1); >> > PSB_RSGX32(PSB_CR_BIF_BANK1); >> > - PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) | _PSB_MMU_ER_MASK, >> > - >> PSB_CR_BIF_CTRL); >> > + PSB_WSGX32(PSB_RSGX32(PSB_CR_BIF_CTRL) | _PSB_MMU_ER_MASK, >> PSB_CR_BIF_CTRL); >> >> This breaks the 80 column line rule. See Documentation/CodingStyle >> >> > psb_spank(dev_priv); >> > >> > /* mmu_gatt ?? */ >> > PSB_WSGX32(pg->gatt_start, PSB_CR_BIF_TWOD_REQ_BASE); >> > return 0; >> > -out_err: >> > - return ret; >> > } >> > >> > static int psb_driver_unload(struct drm_device *dev) >> > { >> > struct drm_psb_private *dev_priv = dev->dev_private; >> > >> > - /* Kill vblank etc here */ >> > - >> > + /* TODO: Kill vblank etc here */ >> > >> > if (dev_priv) { >> > if (dev_priv->backlight_device) >> > @@ -268,7 +272,6 @@ static int psb_driver_unload(struct drm_device *dev) >> > return 0; >> > } >> > >> > - >> > static int psb_driver_load(struct drm_device *dev, unsigned long >> chipset) >> > { >> > struct drm_psb_private *dev_priv; >> > @@ -416,11 +419,11 @@ static int psb_driver_load(struct drm_device >> *dev, unsigned long chipset) >> > return ret; >> > psb_intel_opregion_enable_asle(dev); >> > #if 0 >> > - /*enable runtime pm at last*/ >> > + /* Enable runtime pm at last */ >> > pm_runtime_enable(&dev->pdev->dev); >> > pm_runtime_set_active(&dev->pdev->dev); >> > #endif >> > - /*Intel drm driver load is done, continue doing pvr load*/ >> > + /* Intel drm driver load is done, continue doing pvr load */ >> > return 0; >> > out_err: >> > psb_driver_unload(dev); >> > @@ -561,7 +564,7 @@ static int psb_mode_operation_ioctl(struct >> drm_device *dev, void *data, >> > arg->data = resp; >> > } >> > >> > - /*do some clean up work*/ >> > + /* Do some clean up work */ >> > if (mode) >> > drm_mode_destroy(dev, mode); >> > mode_op_out: >> > @@ -593,7 +596,7 @@ static int psb_driver_open(struct drm_device *dev, >> struct drm_file *priv) >> > return 0; >> > } >> > >> > -static void psb_driver_close(struct drm_device *dev, struct drm_file >> *priv) >> > +static void psb_driver_postclose(struct drm_device *dev, struct >> drm_file *priv) >> > { >> > } >> > >> > @@ -614,15 +617,21 @@ static long psb_unlocked_ioctl(struct file *filp, >> unsigned int cmd, >> > /* FIXME: do we need to wrap the other side of this */ >> > } >> > >> > - >> > -/* When a client dies: >> > +/* >> > + * When a client dies: >> > * - Check for and clean up flipped page state >> > */ >> > static void psb_driver_preclose(struct drm_device *dev, struct >> drm_file *priv) >> > { >> > } >> > >> > -static void psb_remove(struct pci_dev *pdev) >> > +static int psb_pci_probe(struct pci_dev *pdev, const struct >> pci_device_id *ent) >> > +{ >> > + return drm_get_pci_dev(pdev, ent, &driver); >> > +} >> > + >> > + >> > +static void psb_pci_remove(struct pci_dev *pdev) >> > { >> > struct drm_device *dev = pci_get_drvdata(pdev); >> > drm_put_dev(dev); >> > @@ -655,13 +664,23 @@ static const struct file_operations psb_gem_fops >> = { >> > .read = drm_read, >> > }; >> > >> > +/* >> > + * DRM driver structure initialization >> > + * >> > + * The drm_driver structure contains static information that describes >> > + * the driver and features it supports, and pointers to methods that >> DRM >> > + * core will call to implement DRM API. >> > + */ >> > static struct drm_driver driver = { >> > .driver_features = DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED | \ >> > - DRIVER_MODESET | DRIVER_GEM , >> > + DRIVER_MODESET | DRIVER_GEM, >> > .load = psb_driver_load, >> > .unload = psb_driver_unload, >> > + .open = psb_driver_open, >> > + .lastclose = psb_driver_lastclose, >> > + .preclose = psb_driver_preclose, >> > + .postclose = psb_driver_postclose, >> > >> > - .ioctls = psb_ioctls, >> > .num_ioctls = DRM_ARRAY_SIZE(psb_ioctls), >> > .device_is_agp = psb_driver_device_is_agp, >> > .irq_preinstall = psb_irq_preinstall, >> > @@ -671,40 +690,31 @@ static struct drm_driver driver = { >> > .enable_vblank = psb_enable_vblank, >> > .disable_vblank = psb_disable_vblank, >> > .get_vblank_counter = psb_get_vblank_counter, >> > - .lastclose = psb_lastclose, >> > - .open = psb_driver_open, >> > - .preclose = psb_driver_preclose, >> > - .postclose = psb_driver_close, >> > >> > .gem_free_object = psb_gem_free_object, >> > .gem_vm_ops = &psb_gem_vm_ops, >> > + >> > .dumb_create = psb_gem_dumb_create, >> > .dumb_map_offset = psb_gem_dumb_map_gtt, >> > .dumb_destroy = drm_gem_dumb_destroy, >> > + .ioctls = psb_ioctls, >> > .fops = &psb_gem_fops, >> > .name = DRIVER_NAME, >> > .desc = DRIVER_DESC, >> > - .date = PSB_DRM_DRIVER_DATE, >> > - .major = PSB_DRM_DRIVER_MAJOR, >> > - .minor = PSB_DRM_DRIVER_MINOR, >> > - .patchlevel = PSB_DRM_DRIVER_PATCHLEVEL >> > + .date = DRIVER_DATE, >> > + .major = DRIVER_MAJOR, >> > + .minor = DRIVER_MINOR, >> > + .patchlevel = DRIVER_PATCHLEVEL >> > }; >> > >> > static struct pci_driver psb_pci_driver = { >> > .name = DRIVER_NAME, >> > .id_table = pciidlist, >> > - .probe = psb_probe, >> > - .remove = psb_remove, >> > - .driver = { >> > - .pm = &psb_pm_ops, >> > - } >> > + .probe = psb_pci_probe, >> > + .remove = psb_pci_remove, >> > + .driver.pm = &psb_pm_ops, >> > }; >> > >> > -static int psb_probe(struct pci_dev *pdev, const struct pci_device_id >> *ent) >> > -{ >> > - return drm_get_pci_dev(pdev, ent, &driver); >> > -} >> > - >> > static int __init psb_init(void) >> > { >> > return drm_pci_init(&driver, &psb_pci_driver); >> > @@ -718,6 +728,6 @@ static void __exit psb_exit(void) >> > late_initcall(psb_init); >> > module_exit(psb_exit); >> > >> > -MODULE_AUTHOR("Alan Cox <alan(a)linux.intel.com> and others"); >> > +MODULE_AUTHOR(DRIVER_AUTHOR); >> > MODULE_DESCRIPTION(DRIVER_DESC); >> > -MODULE_LICENSE("GPL"); >> > +MODULE_LICENSE(DRIVER_LICENSE); >> > diff --git a/drivers/gpu/drm/gma500/psb_drv.h >> b/drivers/gpu/drm/gma500/psb_drv.h >> > index 5ad6a03..3535640 100644 >> > --- a/drivers/gpu/drm/gma500/psb_drv.h >> > +++ b/drivers/gpu/drm/gma500/psb_drv.h >> > @@ -34,6 +34,25 @@ >> > #include "opregion.h" >> > #include "oaktrail.h" >> > >> > +/* >> > + * Driver definitions >> > + */ >> > +#define DRIVER_AUTHOR "Alan Cox <alan(a)linux.intel.com> and others" >> > +#define DRIVER_LICENSE "GPL" >> > + >> > +#define DRIVER_NAME "gma500" >> > +#define DRIVER_DESC "DRM driver for the Intel GMA500, GMA600, GMA3600, >> GMA3650" >> > +#define DRIVER_DATE "20140311" >> > + >> > +/* >> > + * Driver history >> > + * >> > + * 1.0: Original. Frambuffer only, no 2D/3D acceleration, no video >> acceleration, no power management. >> > + */ >> >> We don't do internal driver versioning anymore. Stuff like this tends to >> get >> forgotten and out-dated anyway. >> >> > +#define DRIVER_MAJOR 1 >> > +#define DRIVER_MINOR 0 >> > +#define DRIVER_PATCHLEVEL 1 >> > + >> >> Why bump the patch level? >> >> > /* Append new drm mode definition here, align with libdrm definition */ >> > #define DRM_MODE_SCALE_NO_SCALE 2 >> > >> > @@ -50,18 +69,6 @@ enum { >> > #define IS_CDV(dev) (((dev)->pdev->device & 0xfff0) == 0x0be0) >> > >> > /* >> > - * Driver definitions >> > - */ >> > - >> > -#define DRIVER_NAME "gma500" >> > -#define DRIVER_DESC "DRM driver for the Intel GMA500" >> > - >> > -#define PSB_DRM_DRIVER_DATE "2011-06-06" >> > -#define PSB_DRM_DRIVER_MAJOR 1 >> > -#define PSB_DRM_DRIVER_MINOR 0 >> > -#define PSB_DRM_DRIVER_PATCHLEVEL 0 >> > - >> > -/* >> > * Hardware offsets >> > */ >> > #define PSB_VDC_OFFSET 0x00000000 >> > @@ -71,6 +78,7 @@ enum { >> > #define PSB_SGX_SIZE 0x8000 >> > #define PSB_SGX_OFFSET 0x00040000 >> > #define MRST_SGX_OFFSET 0x00080000 >> > + >> > /* >> > * PCI resource identifiers >> > */ >> > @@ -78,6 +86,7 @@ enum { >> > #define PSB_AUX_RESOURCE 0 >> > #define PSB_GATT_RESOURCE 2 >> > #define PSB_GTT_RESOURCE 3 >> > + >> > /* >> > * PCI configuration >> > */ >> > @@ -88,26 +97,24 @@ enum { >> > #define _PSB_PGETBL_ENABLED 0x00000001 >> > #define PSB_SGX_2D_SLAVE_PORT 0x4000 >> > >> > -/* To get rid of */ >> > +/* TODO: To get rid of */ >> > #define PSB_TT_PRIV0_LIMIT (256*1024*1024) >> > #define PSB_TT_PRIV0_PLIMIT (PSB_TT_PRIV0_LIMIT >> PAGE_SHIFT) >> > >> > /* >> > - * SGX side MMU definitions (these can probably go) >> > - */ >> > - >> > -/* >> > * Flags for external memory type field. >> > */ >> > #define PSB_MMU_CACHED_MEMORY 0x0001 /* Bind to MMU only */ >> > #define PSB_MMU_RO_MEMORY 0x0002 /* MMU RO memory */ >> > #define PSB_MMU_WO_MEMORY 0x0004 /* MMU WO memory */ >> > + >> > /* >> > * PTE's and PDE's >> > */ >> > #define PSB_PDE_MASK 0x003FFFFF >> > #define PSB_PDE_SHIFT 22 >> > #define PSB_PTE_SHIFT 12 >> > + >> > /* >> > * Cache control >> > */ >> > @@ -286,7 +293,6 @@ struct intel_gmbus { >> > /* >> > * Register offset maps >> > */ >> > - >> > struct psb_offset { >> > u32 fp0; >> > u32 fp1; >> > @@ -485,7 +491,6 @@ struct drm_psb_private { >> > /* >> > * Register base >> > */ >> > - >> > uint8_t __iomem *sgx_reg; >> > uint8_t __iomem *vdc_reg; >> > uint8_t __iomem *aux_reg; /* Auxillary vdc pipe regs */ >> > @@ -494,7 +499,6 @@ struct drm_psb_private { >> > /* >> > * Fencing / irq. >> > */ >> > - >> > uint32_t vdc_irq_mask; >> > uint32_t pipestat[PSB_NUM_PIPE]; >> > >> > @@ -503,7 +507,6 @@ struct drm_psb_private { >> > /* >> > * Power >> > */ >> > - >> > bool suspended; >> > bool display_power; >> > int display_count; >> > @@ -526,7 +529,6 @@ struct drm_psb_private { >> > /* >> > * Sizes info >> > */ >> > - >> > u32 fuse_reg_value; >> > u32 video_device_fuse; >> > >> > @@ -585,7 +587,6 @@ struct drm_psb_private { >> > /* >> > * Register state >> > */ >> > - >> > struct psb_save_area regs; >> > >> > /* MSI reg save */ >> > @@ -595,7 +596,6 @@ struct drm_psb_private { >> > /* >> > * Hotplug handling >> > */ >> > - >> > struct work_struct hotplug_work; >> > >> > /* >> > @@ -609,7 +609,6 @@ struct drm_psb_private { >> > /* >> > * Watchdog >> > */ >> > - >> > uint32_t apm_reg; >> > uint16_t apm_base; >> > >> > @@ -667,7 +666,6 @@ struct drm_psb_private { >> > /* >> > * Operations for each board type >> > */ >> > - >> > struct psb_ops { >> > const char *name; >> > unsigned int accel_2d:1; >> > @@ -726,7 +724,6 @@ static inline struct drm_psb_private >> *psb_priv(struct drm_device *dev) >> > /* >> > * MMU stuff. >> > */ >> > - >> > extern struct psb_mmu_driver *psb_mmu_driver_init(uint8_t __iomem * >> registers, >> > int trap_pagefaults, >> > int invalid_type, >> > @@ -754,8 +751,6 @@ extern int psb_mmu_virtual_to_pfn(struct psb_mmu_pd >> *pd, uint32_t virtual, >> > /* >> > * Enable / disable MMU for different requestors. >> > */ >> > - >> > - >> > extern void psb_mmu_set_pd_context(struct psb_mmu_pd *pd, int >> hw_context); >> > extern int psb_mmu_insert_pages(struct psb_mmu_pd *pd, struct page >> **pages, >> > unsigned long address, uint32_t >> num_pages, >> > @@ -766,9 +761,8 @@ extern void psb_mmu_remove_pages(struct psb_mmu_pd >> *pd, >> > uint32_t desired_tile_stride, >> > uint32_t hw_tile_stride); >> > /* >> > - *psb_irq.c >> > + * psb_irq.c >> > */ >> > - >> > extern irqreturn_t psb_irq_handler(int irq, void *arg); >> > extern int psb_irq_enable_dpst(struct drm_device *dev); >> > extern int psb_irq_disable_dpst(struct drm_device *dev); >> > @@ -808,7 +802,6 @@ extern void psb_spank(struct drm_psb_private >> *dev_priv); >> > /* >> > * psb_reset.c >> > */ >> > - >> > extern void psb_lid_timer_init(struct drm_psb_private *dev_priv); >> > extern void psb_lid_timer_takedown(struct drm_psb_private *dev_priv); >> > extern void psb_print_pagefault(struct drm_psb_private *dev_priv); >> > @@ -888,7 +881,6 @@ extern int drm_idle_check_interval; >> > /* >> > * Utilities >> > */ >> > - >> > static inline u32 MRST_MSG_READ32(uint port, uint offset) >> > { >> > int mcr = (0xD0<<24) | (port << 16) | (offset << 8); >> > -- >> > 1.9.0 >> > >> > > > > -- > Arthur Borsboom > 11 Rue du Manerick > 44740 Batz Sur Mer, France > Mob: +33785927118 > Email: arthurborsboom(a)gmail.com > Skype: Arthur Borsboom, The Hague, The Netherlands > > [image: View Arthur's LinkedIn profile]<http://uk.linkedin.com/in/arthurborsboom> > [View Less]

1 0

[Bug 76046] New: [r600g][RV635][LLVM shader] Chrome aborts GPU acceleration
by bugzilla-daemon＠freedesktop.org 12 Mar '14

12 Mar '14

https://bugs.freedesktop.org/show_bug.cgi?id=76046 Priority: medium Bug ID: 76046 Assignee: dri-devel(a)lists.freedesktop.org Summary: [r600g][RV635][LLVM shader] Chrome aborts GPU acceleration Severity: normal Classification: Unclassified OS: All Reporter: shawn.starr(a)rogers.com Hardware: Other Status: NEW Version: unspecified Component: Drivers/… [View More]Gallium/r600 Product: Mesa Forcing GPU accelration on r600g w/ (now using LLVM R600_LLVM=1 default it seems) causes an assert to be thrown. Components: kernel-3.14.0-0.rc5.git2.2.fc21.x86_64 mesa-dri-drivers-10.1-1.20140305.fc21.x86_64 llvm-libs-3.4-4.fc21.x86_64 libdrm-2.4.52-1.fc21.x86_64 $ google-chrome --ignore-gpu-blacklist & [1] 6174 ATTENTION: default value of option force_s3tc_enable overridden by environment. [6206:6206:0311/190002:ERROR:sandbox_linux.cc(268)] InitializeSandbox() called with multiple threads in process gpu-process /chrome/chrome --type=gpu-process --channel=6174.0.484233088 --user-data-dir=/home/spstarr/.config/google-chrome-beta --disable-breakpad --supports-dual-gpus=false --gpu-driver-bug-workarounds=0,1,28 --gpu-vendor-id=0x1002 --gpu-device-id=0x9591 --gpu-driver-vendor --gpu-driver-version --user-data-dir=/h: sb/sb_bc_parser.cpp:265: int r600_sb::bc_parser::decode_alu_group(r600_sb::cf_node*, unsigned int&, unsigned int&): Assertion `!"alu slot assignment failed"' failed. ATTENTION: default value of option force_s3tc_enable overridden by environment. [6348:6348:0311/190007:ERROR:sandbox_linux.cc(268)] InitializeSandbox() called with multiple threads in process gpu-process /chrome/chrome --type=gpu-process --channel=6174.7.1540935881 --user-data-dir=/home/spstarr/.config/google-chrome-beta --disable-breakpad --supports-dual-gpus=false --gpu-driver-bug-workarounds=0,1,2,28 --gpu-vendor-id=0x1002 --gpu-device-id=0x9591 --gpu-driver-vendor=Mesa --gpu-driver-version=10.1.0 --user-data-dir=/h: sb/sb_bc_parser.cpp:265: int r600_sb::bc_parser::decode_alu_group(r600_sb::cf_node*, unsigned int&, unsigned int&): Assertion `!"alu slot assignment failed"' failed. ATTENTION: default value of option force_s3tc_enable overridden by environment. [6354:6354:0311/190008:ERROR:sandbox_linux.cc(268)] InitializeSandbox() called with multiple threads in process gpu-process /chrome/chrome --type=gpu-process --channel=6174.8.352379127 --user-data-dir=/home/spstarr/.config/google-chrome-beta --disable-breakpad --supports-dual-gpus=false --gpu-driver-bug-workarounds=0,1,2,28 --gpu-vendor-id=0x1002 --gpu-device-id=0x9591 --gpu-driver-vendor=Mesa --gpu-driver-version=10.1.0 --user-data-dir=/h: sb/sb_bc_parser.cpp:265: int r600_sb::bc_parser::decode_alu_group(r600_sb::cf_node*, unsigned int&, unsigned int&): Assertion `!"alu slot assignment failed"' failed. [WARNING:flash/platform/pepper/pep_module.cpp(63)] SANDBOXED -- You are receiving this mail because: You are the assignee for the bug. [View Less]

1 1

← Newer
1
...
80
81
82
83
84
85
86
...
93
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2014