dri-devel May 2014

dri-devel@lists.freedesktop.org

140 participants
970 discussions

[Bug 78537] no anisotropic filtering in a native Half-Life 2
by bugzilla-daemon＠freedesktop.org 12 May '14

12 May '14

1 0

[PATCH] drm/crtc-helper: skip locking checks in panicking path
by Sergei Antonov 11 May '14

11 May '14

Hello! Below is my patch for drm. Here is a photo of kernel output I had: http://s17.postimg.org/k0301hgf3/Untitled.jpg to illustrate what I am writing in the description. --- Subject: [PATCH] drm/crtc-helper: skip locking checks in panicking path Skip locking checks in drm_helper_*_in_use() if they are called in panicking path. See similar code in drm_warn_on_modeset_not_all_locked(). After panic information has been output, these WARN_ONs go off outputing a lot of lines and scrolling the panic information out of the screen. Here is a partial call trace showing how execution reaches them: ? drm_helper_crtc_in_use() ? __drm_helper_disable_unused_functions() ? several *_set_config functions ? drm_fb_helper_restore_fbdev_mode() Cc: Dave Airlie <airlied(a)redhat.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Sergei Antonov <saproj(a)gmail.com> --- drivers/gpu/drm/drm_crtc_helper.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index df281b5..872ba11 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -29,6 +29,7 @@ * Jesse Barnes <jesse.barnes(a)intel.com> */ +#include <linux/kernel.h> #include <linux/export.h> #include <linux/moduleparam.h> @@ -88,7 +89,13 @@ bool drm_helper_encoder_in_use(struct drm_encoder *encoder) struct drm_connector *connector; struct drm_device *dev = encoder->dev; - WARN_ON(!mutex_is_locked(&dev->mode_config.mutex)); + /* + * We can expect this mutex to be locked if we are not panicking. + * Locking is currently fubar in the panic handler. + */ + if (!oops_in_progress) + WARN_ON(!mutex_is_locked(&dev->mode_config.mutex)); + list_for_each_entry(connector, &dev->mode_config.connector_list, head) if (connector->encoder == encoder) return true; @@ -112,7 +119,13 @@ bool drm_helper_crtc_in_use(struct drm_crtc *crtc) struct drm_encoder *encoder; struct drm_device *dev = crtc->dev; - WARN_ON(!mutex_is_locked(&dev->mode_config.mutex)); + /* + * We can expect this mutex to be locked if we are not panicking. + * Locking is currently fubar in the panic handler. + */ + if (!oops_in_progress) + WARN_ON(!mutex_is_locked(&dev->mode_config.mutex)); + list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) if (encoder->crtc == crtc && drm_helper_encoder_in_use(encoder)) return true; -- 1.9.0

1 0

[Bug 76659] Display does not return from DPMS off using ATI drivers
by bugzilla-daemon＠freedesktop.org 11 May '14

11 May '14

https://bugs.freedesktop.org/show_bug.cgi?id=76659 --- Comment #10 from André Wöbbeking <Woebbeking(a)web.de> --- I set the suspend time to two hours now but even after a much shorter time (lets say 10 minutes) the graphic is displayed and when I press any key the screen becomes black. xset q says that the monitor is still on. If I press more keys it takes a while (maybe minutes) til the sreen resumes. I think I had similar problem on another box (with Radeon HD 5570) with Debian Sid x86_64. But it seems not to happen any more for some days now (maybe the update to Linux 3.14). -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 74551] Unable to enable ACPI
by bugzilla-daemon＠bugzilla.kernel.org 11 May '14

11 May '14

https://bugzilla.kernel.org/show_bug.cgi?id=74551 --- Comment #1 from maxis11 <ya.maxis11(a)yandex.ru> --- acer aspire 5560g has problem with gpt, so I convert using gdisk gpt to mbr, and problem seems fixed. But there is another problem, computer freezes during boot with radeon.runpm=1. Should I create another bug report? -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 76659] Display does not return from DPMS off using ATI drivers
by bugzilla-daemon＠freedesktop.org 10 May '14

10 May '14

https://bugs.freedesktop.org/show_bug.cgi?id=76659 --- Comment #9 from André Wöbbeking <Woebbeking(a)web.de> --- Hi, I think that I've the same problem. I've a "ATI Radeon XPRESS 200M 5975 (PCIE)" (ChipID = 0x5975) (from Xorg.0.log). Here already DISPLAY=:0.0 xset dpms force off brings the screen back. I'm running Kubuntu 14.04 32 bit. Cheers, André -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/gk20a/fb: fix NULL dereference
by Alexandre Courbot 09 May '14

09 May '14

gk20a_ram_put() can be called with a NULL nouveau_mem in case of error. Handle that case the way is it done in other RAM drivers. Signed-off-by: Alexandre Courbot <acourbot(a)nvidia.com> --- drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c b/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c index 403c88f07b99..7effd1a63458 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c +++ b/drivers/gpu/drm/nouveau/core/subdev/fb/ramgk20a.c @@ -36,6 +36,8 @@ gk20a_ram_put(struct nouveau_fb *pfb, struct nouveau_mem **pmem) int i; *pmem = NULL; + if (unlikely(mem == NULL)) + return; for (i = 0; i < mem->size; i++) { struct page *page; -- 1.9.2

2 1

Re: OMAPDSS: omap5 SYNC_LOST error with DPI/LCD
by Archit Taneja 09 May '14

09 May '14

Hi Vikas, On Friday 09 May 2014 11:54 AM, Vikas Patil wrote: > Hi, > > Forgot to mention, DPI pins are connected to TDF19988 chip for HDMI > conversion. > I have build the driver for it from > https://gitorious.org/thierryreding/linux/source/e7792ce2da5ded80861db787ac…. > Is this the correct driver for it? Also I am trying to use the > generic-dpi-panel driver for this. it seems I also need to add support > for TDF19988 somewhere in omapdrm or lcd/panel driver by calling > drm_i2c_encoder_init. Could you please give inputs, how should I proceed > further? > > Thanks & Regards, > Vikash > > > > On Thu, May 8, 2014 at 3:37 PM, Vikas Patil <vikasmpatil(a)gmail.com > <mailto:vikasmpatil@gmail.com>> wrote: > > Hi, > > I am working on to enable the second display output for customized > OMAP5 based platform and linux 3.4.25. First display which is > HDMI/tv is working fine. Second display out is coming via DPI > interface. To enable DPI interface I enabled CONFIG_OMAP2_DSS_DPI > and CONFIG_PANEL_GENERIC_DPI and added that in omap_dss_device and > omap_dss_board_info and removed the HDMI device and disabled > CONFIG_OMAP5_DSS_HDMI. With his kernel seems to be booting > correctly, however when I try to run kmscube app and it seems to be > running, noticing following error and till now nothing on display. > > Could you give some inputs to debug this? Is this following error > due to which not getting anything on display? From the logs, one thing which looks like a problem is that the DPI driver isn't using a DSI PLL to generate a pixel clock of 40.5 Mhz for the 1280x480 panel. It's trying to change DSS_FCK to get the desired clock. This won't work well if we start doing scaling. And in genral, it's always good to have DSS_FCK a bit higher than the pixel clocks of all the panels connected to DSS. Could you try to set the value of CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK to 4, and tell what happens? The correct solution would be to figure out why it isn't using the DSI PLL, but we could start with changing the config above. Archit

2 3

[PATCH] drm/exynos: hdmi: remove unnecessary dedicated i2c drivers
by Seung-Woo Kim 09 May '14

09 May '14

The i2c drivers for ddc and hdmiphy are already removed from build and instead, i2c clients registered via devicetree are used. So this patch removes the unnecessary i2c drivers. Signed-off-by: Seung-Woo Kim <sw0312.kim(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_ddc.c | 63 ------------------------------ drivers/gpu/drm/exynos/exynos_hdmiphy.c | 65 ------------------------------- 2 files changed, 0 insertions(+), 128 deletions(-) delete mode 100644 drivers/gpu/drm/exynos/exynos_ddc.c delete mode 100644 drivers/gpu/drm/exynos/exynos_hdmiphy.c diff --git a/drivers/gpu/drm/exynos/exynos_ddc.c b/drivers/gpu/drm/exynos/exynos_ddc.c deleted file mode 100644 index 6a8c84e..0000000 --- a/drivers/gpu/drm/exynos/exynos_ddc.c +++ /dev/null @@ -1,63 +0,0 @@ -/* - * Copyright (C) 2011 Samsung Electronics Co.Ltd - * Authors: - * Seung-Woo Kim <sw0312.kim(a)samsung.com> - * Inki Dae <inki.dae(a)samsung.com> - * - * This program is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License as published by the - * Free Software Foundation; either version 2 of the License, or (at your - * option) any later version. - * - */ - -#include <drm/drmP.h> - -#include <linux/kernel.h> -#include <linux/i2c.h> -#include <linux/of.h> - -#include "exynos_drm_drv.h" -#include "exynos_hdmi.h" - -static int s5p_ddc_probe(struct i2c_client *client, - const struct i2c_device_id *dev_id) -{ - hdmi_attach_ddc_client(client); - - dev_info(&client->adapter->dev, - "attached %s into i2c adapter successfully\n", - client->name); - - return 0; -} - -static int s5p_ddc_remove(struct i2c_client *client) -{ - dev_info(&client->adapter->dev, - "detached %s from i2c adapter successfully\n", - client->name); - - return 0; -} - -static struct of_device_id hdmiddc_match_types[] = { - { - .compatible = "samsung,exynos5-hdmiddc", - }, { - .compatible = "samsung,exynos4210-hdmiddc", - }, { - /* end node */ - } -}; - -struct i2c_driver ddc_driver = { - .driver = { - .name = "exynos-hdmiddc", - .owner = THIS_MODULE, - .of_match_table = hdmiddc_match_types, - }, - .probe = s5p_ddc_probe, - .remove = s5p_ddc_remove, - .command = NULL, -}; diff --git a/drivers/gpu/drm/exynos/exynos_hdmiphy.c b/drivers/gpu/drm/exynos/exynos_hdmiphy.c deleted file mode 100644 index 59abb14..0000000 --- a/drivers/gpu/drm/exynos/exynos_hdmiphy.c +++ /dev/null @@ -1,65 +0,0 @@ -/* - * Copyright (C) 2011 Samsung Electronics Co.Ltd - * Authors: - * Seung-Woo Kim <sw0312.kim(a)samsung.com> - * Inki Dae <inki.dae(a)samsung.com> - * - * This program is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License as published by the - * Free Software Foundation; either version 2 of the License, or (at your - * option) any later version. - * - */ - -#include <drm/drmP.h> - -#include <linux/kernel.h> -#include <linux/i2c.h> -#include <linux/of.h> - -#include "exynos_drm_drv.h" -#include "exynos_hdmi.h" - - -static int hdmiphy_probe(struct i2c_client *client, - const struct i2c_device_id *id) -{ - hdmi_attach_hdmiphy_client(client); - - dev_info(&client->adapter->dev, "attached s5p_hdmiphy " - "into i2c adapter successfully\n"); - - return 0; -} - -static int hdmiphy_remove(struct i2c_client *client) -{ - dev_info(&client->adapter->dev, "detached s5p_hdmiphy " - "from i2c adapter successfully\n"); - - return 0; -} - -static struct of_device_id hdmiphy_match_types[] = { - { - .compatible = "samsung,exynos5-hdmiphy", - }, { - .compatible = "samsung,exynos4210-hdmiphy", - }, { - .compatible = "samsung,exynos4212-hdmiphy", - }, { - /* end node */ - } -}; - -struct i2c_driver hdmiphy_driver = { - .driver = { - .name = "exynos-hdmiphy", - .owner = THIS_MODULE, - .of_match_table = hdmiphy_match_types, - }, - .probe = hdmiphy_probe, - .remove = hdmiphy_remove, - .command = NULL, -}; -EXPORT_SYMBOL(hdmiphy_driver); -- 1.7.4.1

1 0

[PATCH] drm/exynos: hdmi: consider legacy dt binding
by Inki Dae 09 May '14

09 May '14

This patch considers legacy dt binding, and resolves the issue that the use of existing dtb is broken. To resove the dt broken issue, this path tries to get legacy dt nodes from existing dtb directly prior to getting new dt nodes. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Acked-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 6acc1e3..a8bac62 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2240,6 +2240,25 @@ static const struct component_ops hdmi_component_ops = { .unbind = hdmi_unbind, }; +static struct device_node *hdmi_legacy_ddc_dt_binding(struct device *dev) +{ + const char *compatible_str = "samsung,exynos4210-hdmiddc"; + struct device_node *np; + + np = of_find_compatible_node(NULL, NULL, compatible_str); + if (np) + return of_get_next_parent(np); + + return NULL; +} + +static struct device_node *hdmi_legacy_phy_dt_binding(struct device *dev) +{ + const char *compatible_str = "samsung,exynos4212-hdmiphy"; + + return of_find_compatible_node(NULL, NULL, compatible_str); +} + static int hdmi_probe(struct platform_device *pdev) { struct device_node *ddc_node, *phy_node; @@ -2295,18 +2314,28 @@ static int hdmi_probe(struct platform_device *pdev) return ret; } + ddc_node = hdmi_legacy_ddc_dt_binding(dev); + if (ddc_node) + goto out_get_ddc_adpt; + /* DDC i2c driver */ ddc_node = of_parse_phandle(dev->of_node, "ddc", 0); if (!ddc_node) { DRM_ERROR("Failed to find ddc node in device tree\n"); return -ENODEV; } + +out_get_ddc_adpt: hdata->ddc_adpt = of_find_i2c_adapter_by_node(ddc_node); if (!hdata->ddc_adpt) { DRM_ERROR("Failed to get ddc i2c adapter by node\n"); return -ENODEV; } + phy_node = hdmi_legacy_phy_dt_binding(dev); + if (phy_node) + goto out_get_phy_port; + /* hdmiphy i2c driver */ phy_node = of_parse_phandle(dev->of_node, "phy", 0); if (!phy_node) { @@ -2315,6 +2344,7 @@ static int hdmi_probe(struct platform_device *pdev) goto err_ddc; } +out_get_phy_port: if (drv_data->is_apb_phy) { hdata->regs_hdmiphy = of_iomap(phy_node, 0); if (!hdata->regs_hdmiphy) { -- 1.7.9.5

1 0

[PATCH] drm/radeon: handle non-VGA class pci devices with ATRM
by Alex Deucher 09 May '14

09 May '14

Newer PX systems have non-VGA pci class dGPUs. Update the ATRM fetch method to handle those cases. bug: https://bugzilla.kernel.org/show_bug.cgi?id=75401 Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Cc: stable(a)vger.kernel.org --- drivers/gpu/drm/radeon/radeon_bios.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c index b3633d9..9ab3097 100644 --- a/drivers/gpu/drm/radeon/radeon_bios.c +++ b/drivers/gpu/drm/radeon/radeon_bios.c @@ -196,6 +196,20 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev) } } + if (!found) { + while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_OTHER << 8, pdev)) != NULL) { + dhandle = ACPI_HANDLE(&pdev->dev); + if (!dhandle) + continue; + + status = acpi_get_handle(dhandle, "ATRM", &atrm_handle); + if (!ACPI_FAILURE(status)) { + found = true; + break; + } + } + } + if (!found) return false; -- 1.8.3.1

1 0

← Newer
1
...
87
88
89
90
91
92
93
...
97
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2014