dri-devel September 2014

dri-devel@lists.freedesktop.org

173 participants
1045 discussions

[PATCH] drm/nv84+: fix fence context seqno's
by Maarten Lankhorst 25 Sep '14

25 Sep '14

This fixes a regression introduced by "drm/nouveau: rework to new fence interface" (commit 29ba89b2371d466). The fence sequence should not be reset after creation, the old value is used instead. On destruction the final value is written, to prevent another source of accidental wraparound in case of a channel being destroyed after a hang, and unblocking any other channel that may wait on the about-to-be-deleted channel to signal. I'm nothing if not optimistic about any hope of recovery from that. ;-) Reported-by: Ted Percival <ted(a)tedp.id.au> Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)canonical.com> --- diff --git a/drivers/gpu/drm/nouveau/nv84_fence.c b/drivers/gpu/drm/nouveau/nv84_fence.c index 7b372a68aa4e..4138db4d8291 100644 --- a/drivers/gpu/drm/nouveau/nv84_fence.c +++ b/drivers/gpu/drm/nouveau/nv84_fence.c @@ -120,6 +120,7 @@ nv84_fence_context_del(struct nouveau_channel *chan) nouveau_bo_vma_del(bo, &fctx->dispc_vma[i]); } + nouveau_bo_wr32(priv->bo, chan->chid * 16 / 4, fctx->base.sequence); nouveau_bo_vma_del(priv->bo, &fctx->vma_gart); nouveau_bo_vma_del(priv->bo, &fctx->vma); nouveau_fence_context_del(&fctx->base); @@ -159,8 +160,6 @@ nv84_fence_context_new(struct nouveau_channel *chan) ret = nouveau_bo_vma_add(bo, cli->vm, &fctx->dispc_vma[i]); } - nouveau_bo_wr32(priv->bo, chan->chid * 16/4, 0x00000000); - if (ret) nv84_fence_context_del(chan); return ret;

3 4

[PATCH v4 0/5] Add drm driver for Rockchip Socs
by Mark yao 25 Sep '14

25 Sep '14

This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices, eDP. Future patches will add additional encoders/connectors, such as HDMI. The basic "crtc" for rockchip is a "VOP" - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. Changes in v2: - add DRM master device node to list all display nodes that comprise the graphics subsystem. - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master device and each vop device can shared the drm dma mapping. - use drm_crtc_init_with_planes and drm_universal_plane_init. - remove unnecessary middle layers. - add cursor set, move funcs to rockchip drm crtc. - use panel-simple driver for primary display. - add vop and edp reset. Changes in v3: - change "crtc->fb" to "crtc->primary-fb" Adviced by Daniel Vetter - init cursor plane with universal api, remove unnecessary cursor set,move Changes in v4: Adviced by David Herrmann - remove drm_platform_*() usage, use register drm device directly. Adviced by Rob Clark - remove special mmap ioctl, do userspace mmap with normal mmap() or mmap offset Tested on rk3288 pinky board, use eDP encoders/connector, boot and display OK Mark yao (5): drm/rockchip: Add basic drm driver dt-bindings: video: Add for rockchip display subsytem dt-bindings: video: Add documentation for rockchip vop dt-bindings: video: Add documentation for rockchip edp drm/rockchip: Add support for Rockchip Soc EDP .../devicetree/bindings/video/rockchip-drm.txt | 19 + .../devicetree/bindings/video/rockchip-edp.txt | 50 + .../devicetree/bindings/video/rockchip-vop.txt | 58 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/rockchip/Kconfig | 28 + drivers/gpu/drm/rockchip/Makefile | 12 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 524 ++++++++ drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 120 ++ drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 201 +++ drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 28 + drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 231 ++++ drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h | 20 + drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 404 ++++++ drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 72 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1372 ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 187 +++ drivers/gpu/drm/rockchip/rockchip_edp_core.c | 853 ++++++++++++ drivers/gpu/drm/rockchip/rockchip_edp_core.h | 309 +++++ drivers/gpu/drm/rockchip/rockchip_edp_reg.c | 1202 +++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_edp_reg.h | 345 +++++ include/uapi/drm/rockchip_drm.h | 75 ++ 22 files changed, 6113 insertions(+) -- 1.7.9.5

7 25

[GIT PULL] IPUv3 fixes for v3.18
by Philipp Zabel 25 Sep '14

25 Sep '14

Hi Dave, please pull these fixes for the IPUv3 core driver. The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9: Linux 3.17-rc1 (2014-08-16 10:40:26 -0600) are available in the git repository at: git://git.pengutronix.de/git/pza/linux.git tags/ipu-fixes-3.18 for you to fetch changes up to c7750e8321155d39625c1ffb03227af4fa7f9122: gpu: ipu-v3: Kconfig: Remove SOC_IMX6SL from IMX_IPUV3_CORE Kconfig (2014-09-24 23:50:25 +0200) ---------------------------------------------------------------- IPUv3 fixes for v3.18 ---------------------------------------------------------------- Axel Lin (2): gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error gpu: ipu-v3: Return proper error on ipu_add_client_devices error path Fabio Estevam (2): gpu: ipu-v3: ipu-smfc: Do not leave DEBUG defined gpu: ipu-v3: Kconfig: Remove SOC_IMX6SL from IMX_IPUV3_CORE Kconfig drivers/gpu/ipu-v3/Kconfig | 3 ++- drivers/gpu/ipu-v3/ipu-common.c | 4 +++- drivers/gpu/ipu-v3/ipu-smfc.c | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) regards Philipp

1 0

[PATCH v6 0/3] Add drm driver for Rockchip Socs
by Mark yao 25 Sep '14

25 Sep '14

This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic "crtc" for rockchip is a "VOP" - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar Vop devices. Vop devices support iommu mapping, we use dma-mapping API with ARM_DMA_USE_IOMMU. Changes in v2: - add DRM master device node to list all display nodes that comprise the graphics subsystem. - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master device and each vop device can shared the drm dma mapping. - use drm_crtc_init_with_planes and drm_universal_plane_init. - remove unnecessary middle layers. - add cursor set, move funcs to rockchip drm crtc. - add vop reset. Changes in v3: - change "crtc->fb" to "crtc->primary-fb" Adviced by Daniel Vetter - init cursor plane with universal api, remove unnecessary cursor set,move Changes in v4: Adviced by David Herrmann - remove drm_platform_*() usage, use register drm device directly. Adviced by Rob Clark - remove special mmap ioctl, do userspace mmap with normal mmap() or mmap offset Changes in v5: Adviced by Arnd Bergmann - doing DMA start with a 32-bit masks with dma_mask and dma_coherent_mark - fix some incorrect dependencies. Adviced by Boris BREZILLON - fix some mistake and bugs. Adviced by Daniel Vetter - drop all special ioctl and use generic kms ioctl instead. Adviced by Rob Clark - use unlocked api for drm_fb_helper_restore_fbdev_mode. - remove unused rockchip_gem_prime_import_sg_table. Changes in v6: - set gem buffer pitch 64 bytes align, needed by mali gpu. Adviced by Daniel Kurtz - fix some mistake, bugs, remove unused define, more better code style etc. - use clk_prepare()/unprepare() at probe()/remove() and clk_enable()/disable() at runtime instead of clk_prepare_enable(). - provide a help function from vop for encoder to do mode config, instead of using drm_diaplay_mode private method. - change vop mode_set timing to make it more safely. Mark yao (3): drm/rockchip: Add basic drm driver dt-bindings: video: Add for rockchip display subsytem dt-bindings: video: Add documentation for rockchip vop .../devicetree/bindings/video/rockchip-drm.txt | 19 + .../devicetree/bindings/video/rockchip-vop.txt | 58 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/rockchip/Kconfig | 17 + drivers/gpu/drm/rockchip/Makefile | 8 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 516 +++++++ drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 61 + drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 201 +++ drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 28 + drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 230 ++++ drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h | 20 + drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 345 +++++ drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 55 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1418 ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 196 +++ 16 files changed, 3175 insertions(+) -- 1.7.9.5

1 3

[PATCH] drm/exynos/fbdev: set smem_len for fbdev
by Daniel Kurtz 25 Sep '14

25 Sep '14

Commit [0] stopped setting fix.smem_start and fix.smem_len when creating the fbdev. [0] 2f1eab8d8ab59e799f7d51d62410b398607a7bc3 drm/exynos/fbdev: don't set fix.smem/mmio_{start,len} However, smem_len is used by some userland applications to calculate the size for mmap. In particular, it is used by xf86-video-fbdev: http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/fbdevhw/fbdevhw.c?… So, let's restore setting the smem_len to unbreak things for these users. Note: we are still leaving smem_start set to 0. Reported-by: Siarhei Siamashka <siarhei.siamashka(a)gmail.com> Reported-by: Günther Noack <me(a)guenthernoack.de> Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- I am able to compile test this change, but would appreciate help testing it on a system that uses xf86-video-fbdev. Thanks! drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 5a7cd8b..f865736 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -125,6 +125,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, fbi->screen_base = buffer->kvaddr; fbi->screen_size = size; + fbi->fix.smem_len = size; return 0; } -- 2.1.0.rc2.206.gedb03e5

3 4

[PATCH 1/2] drm/nouveau/disp/nv50: Add PFB writes
by Pierre Moreau 25 Sep '14

25 Sep '14

This fix a GPU lockup on 9400M (NVAC) when using acceleration, see #27501. Signed-off-by: Pierre Moreau <pierre.morrow(a)free.fr> --- drivers/gpu/drm/nouveau/core/engine/disp/nv50.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c b/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c index a7efbff..e425604 100644 --- a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c @@ -1137,6 +1137,15 @@ nv50_disp_base_init(struct nouveau_object *object) if (ret) return ret; + if (nv_device(priv)->chipset == 0xac) { + nv_mask(priv, 0x100c18, 0x00000000, 0x000027ff); + nv_mask(priv, 0x100c14, 0x00000000, 0x00000001); + nv_mask(priv, 0x100c1c, 0x00000000, 0x000027fc); + nv_mask(priv, 0x100c14, 0x00000000, 0x00000002); + nv_mask(priv, 0x100c24, 0x00000002, 0x000027fd); + nv_mask(priv, 0x100c14, 0x00000000, 0x00010000); + } + /* The below segments of code copying values from one register to * another appear to inform EVO of the display capabilities or * something similar. NFI what the 0x614004 caps are for.. -- 2.1.0

1 1

nouveau (NV50) regression 3.17-rc1; dpms stopped working
by Jamie Heilman 25 Sep '14

25 Sep '14

With 3.17-rc1 DPMS stopped working. I've bisected this to d55b4af909bc16f7982c2b8b8656f0898158627b testing along the way with xset dpms force off. Controller is: NVIDIA Corporation G86 [Quadro NVS 290] (rev a1) That commit doesn't revert cleanly. I took a look around and found a couple of bugs that made it sound like DPMS issues with DP have been ongoing for a while, but this is a DVI connection in my case (to a single Dell 2405FPW). Then I found bug 82527, which mentioned the problem exactly. My experience with log capture around the xset dpms force off command is exactly the same as Martin's in that bug. No additional output. Prior to d55b4af909bc16f7982c2b8b8656f0898158627b I didn't have any serious problems (the immediate switching back on of the screen after a xset dpms force off the first time not withstanding, I've lived with that for years). -- Jamie Heilman http://audible.transient.net/~jamie/

1 0

[Bug 85021] New: radeon: Allow one to set "mid" to power_dpm_force_performance_level
by bugzilla-daemon＠bugzilla.kernel.org 24 Sep '14

24 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=85021 Bug ID: 85021 Summary: radeon: Allow one to set "mid" to power_dpm_force_performance_level Product: Drivers Version: 2.5 Kernel Version: 3.16.2 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: enhancement Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: higuita(a)gmx.net Regression: No On a radeon module with dpm enable, one can set the power_dpm_force_performance_level to auto, low and high. All fine, but my card have a mid performance setup and is very useful, as the low is too slow when i have some contant graphic usage (usually tvtime running), but auto and high are too fast and hot for that usage, wasting energy and overheating the system without need. If i could setup the mid profile, the performance would be good, but not the card maximum. So the current setup is good for "little"/"a lot" GPU usage, but is missing the mid support for those "moderate" GPU usage where the low is too litle and the high is too much. [ 9.411247] switching to power state: [ 9.411343] ui class: performance [ 9.411480] internal class: ovrdrv [ 9.411664] caps: video [ 9.411848] uvd vclk: 0 dclk: 0 [ 9.411943] power level 0 sclk: 15000 mclk: 42000 vddc: 1000 [ 9.412047] power level 1 sclk: 30000 mclk: 60000 vddc: 1080 [ 9.412144] power level 2 sclk: 80000 mclk: 70000 vddc: 1160 [ 9.412241] status: r -- You are receiving this mail because: You are watching the assignee of the bug.

1 7

[pull] radeon drm-next-3.18
by Alex Deucher 24 Sep '14

24 Sep '14

Hi Dave, Just some fixes for 3.18. These are all pretty non-invasive. - Re-enable some dpm features that were previously disabled due to a bug that was fixed in 3.16 - Make some arrays static - re-arrange some audio code to properly reflect connected status in the audio driver The following changes since commit d743ecf360637d489a3ba81a268f574359149601: drm/doc: Fixup drm_irq kerneldoc includes. (2014-09-24 11:43:47 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-3.18 for you to fetch changes up to 483556f4b3fd3af627bb23b259f23ef427226ca0: drm/radeon/combios: declare legacy_connector_convert as static (2014-09-24 16:46:41 -0400) ---------------------------------------------------------------- Alex Deucher (10): drm/radeon: fix register name to match internal name drm/radeon: consolidate duplicate encode is digital function drm/radeon: consolidate r600_audio.c into r600_hdmi.c drm/radeon: split audio enable between eg and r600 (v2) drm/radeon: disable audio when we disable hdmi (v2) drm/radeon/dpm: drop clk/voltage dependency filters for NI drm/radeon/dpm: drop clk/voltage dependency filters for SI drm/radeon/dpm: drop clk/voltage dependency filters for CI drm/radeon/dpm: drop clk/voltage dependency filters for BTC drm/radeon: drop btc_get_max_clock_from_voltage_dependency_table Michele Curti (2): drm/radeon/atombios: declare connector convert tables as static drm/radeon/combios: declare legacy_connector_convert as static drivers/gpu/drm/radeon/Makefile | 2 +- drivers/gpu/drm/radeon/atombios_encoders.c | 23 ---- drivers/gpu/drm/radeon/btc_dpm.c | 51 ------- drivers/gpu/drm/radeon/btc_dpm.h | 2 - drivers/gpu/drm/radeon/ci_dpm.c | 26 ---- drivers/gpu/drm/radeon/dce3_1_afmt.c | 4 +- drivers/gpu/drm/radeon/dce6_afmt.c | 6 +- drivers/gpu/drm/radeon/evergreen_hdmi.c | 49 ++++++- drivers/gpu/drm/radeon/ni_dpm.c | 24 ---- drivers/gpu/drm/radeon/r600_audio.c | 207 ----------------------------- drivers/gpu/drm/radeon/r600_hdmi.c | 172 +++++++++++++++++++++++- drivers/gpu/drm/radeon/r600d.h | 17 +++ drivers/gpu/drm/radeon/radeon.h | 4 +- drivers/gpu/drm/radeon/radeon_asic.h | 1 - drivers/gpu/drm/radeon/radeon_atombios.c | 6 +- drivers/gpu/drm/radeon/radeon_combios.c | 2 +- drivers/gpu/drm/radeon/radeon_encoders.c | 21 +++ drivers/gpu/drm/radeon/radeon_mode.h | 1 + drivers/gpu/drm/radeon/si_dpm.c | 24 ---- drivers/gpu/drm/radeon/sid.h | 2 +- 20 files changed, 267 insertions(+), 377 deletions(-) delete mode 100644 drivers/gpu/drm/radeon/r600_audio.c

1 0

[git pull] drm fixes
by Dave Airlie 24 Sep '14

24 Sep '14

Hi Linus, Some final radeon and i915 fixes, black screens mostly Dave. The following changes since commit 0f33be009b89d2268e94194dc4fd01a7851b6d51: Linux 3.17-rc6 (2014-09-21 15:43:02 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes for you to fetch changes up to 67f33f30fc3cb7896cbdbd25c70395d38bfa9520: Merge branch 'drm-fixes-3.17' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2014-09-25 06:49:26 +1000) ---------------------------------------------------------------- Alex Deucher (4): drm/radeon: add a module parameter for backlight control (v2) drm/radeon: add a backlight quirk for Amilo Xi 2550 drm/radeon: add PX quirk for asus K53TK drm/radeon/cik: use a separate counter for CP init timeout Brad Volkin (1): drm/i915: Don't leak command parser tables on suspend/resume Dave Airlie (2): Merge tag 'drm-intel-fixes-2014-09-24' of git://anongit.freedesktop.org/drm-intel into drm-fixes Merge branch 'drm-fixes-3.17' of git://people.freedesktop.org/~agd5f/linux into drm-fixes Jani Nikula (1): drm/i915/hdmi: fix hdmi audio state readout Michel Dänzer (3): drm/radeon: Clear RB_OVERFLOW bit earlier drm/radeon: Make IH ring overflow debugging output more useful drm/radeon: Update IH_RB_RPTR register after each processed interrupt drivers/gpu/drm/i915/i915_cmd_parser.c | 12 +++++---- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/radeon/cik.c | 12 ++++----- drivers/gpu/drm/radeon/evergreen.c | 8 +++--- drivers/gpu/drm/radeon/r600.c | 8 +++--- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_device.c | 4 +++ drivers/gpu/drm/radeon/radeon_drv.c | 4 +++ drivers/gpu/drm/radeon/radeon_encoders.c | 44 ++++++++++++++++++++++++++------ drivers/gpu/drm/radeon/si.c | 8 +++--- 10 files changed, 71 insertions(+), 32 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2014