dri-devel September 2014

dri-devel@lists.freedesktop.org

173 participants
1045 discussions

[PULL] topic/core-stuff
by Daniel Vetter 24 Sep '14

24 Sep '14

Hi Dave, Just noticed that you've picked up the header rework stuff already, so I've rebased that out again. Otherwise just two stragglers from the vblank rework and the universal cursor planes locking fix. Plus sprinkling container_of all over fbdev emulation from Fabian. Aside: I only have just 1 fix for drm-next atm for i915 and not terribly serious. So will probably only send you a pull for it when the merge window opens or something more serious shows up. Cheers, Daniel The following changes since commit d743ecf360637d489a3ba81a268f574359149601: drm/doc: Fixup drm_irq kerneldoc includes. (2014-09-24 11:43:47 +1000) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/topic/core-stuff-2014-09-24 for you to fetch changes up to ee0d68ab5f0997a500fdf90924a58e787b216292: drm/udl: use container_of to resolve udl_fbdev from drm_fb_helper (2014-09-24 12:09:28 +0200) ---------------------------------------------------------------- Daniel Vetter (2): drm: Fixup locking for universal cursor planes drm: Improve debug output for drm_wait_one_vblank Fabian Frederick (9): drm/cirrus: use container_of to resolve cirrus_fbdev from drm_fb_helper drm/mgag200: use container_of to resolve mga_fbdev from drm_fb_helper drm/radeon: use container_of to resolve radeon_fbdev from drm_fb_helper drm/nouveau: use container_of to resolve nouveau_fbdev from drm_fb_helper drm/nouveau: use container_of to resolve nouveau_plane from drm_plane drm/qxl: use container_of to resolve qxl_fbdev from drm_fb_helper drm/gma500: use container_of to resolve psb_fbdev from drm_fb_helper drm/ast: use container_of to resolve ast_fbdev from drm_fb_helper drm/udl: use container_of to resolve udl_fbdev from drm_fb_helper Mario Kleiner (1): drm: Don't update vblank timestamp when the counter didn't change drivers/gpu/drm/ast/ast_fb.c | 3 +- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 3 +- drivers/gpu/drm/drm_crtc.c | 51 ++++++++++++++++++++---------- drivers/gpu/drm/drm_irq.c | 7 ++-- drivers/gpu/drm/gma500/framebuffer.c | 3 +- drivers/gpu/drm/mgag200/mgag200_fb.c | 3 +- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 15 ++++++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 +- drivers/gpu/drm/qxl/qxl_fb.c | 3 +- drivers/gpu/drm/radeon/radeon_fb.c | 3 +- drivers/gpu/drm/udl/udl_fb.c | 3 +- 11 files changed, 65 insertions(+), 32 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

4 4

[pull] radeon drm-fixes-3.17
by Alex Deucher 24 Sep '14

24 Sep '14

Hi Dave, Some radeon fixes for 3.17: - fix a backlight regression resulting in dark screen - add a PX quirk to avoid a hang with runtime pm - fix an init issue on the CIK compute rings - fix IH ring buffer overflows gracefully The following changes since commit fe3d9c4b87bb98222a502cc585844a0b950786fb: drm/nouveau: ltc/gf100-: fix cbc issues on certain boards (2014-09-20 17:42:25 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-3.17 for you to fetch changes up to 370ce45b5986118fa496dddbcd7039e1aa1a418f: drm/radeon/cik: use a separate counter for CP init timeout (2014-09-23 10:20:13 -0400) ---------------------------------------------------------------- Alex Deucher (4): drm/radeon: add a module parameter for backlight control (v2) drm/radeon: add a backlight quirk for Amilo Xi 2550 drm/radeon: add PX quirk for asus K53TK drm/radeon/cik: use a separate counter for CP init timeout Michel Dänzer (3): drm/radeon: Clear RB_OVERFLOW bit earlier drm/radeon: Make IH ring overflow debugging output more useful drm/radeon: Update IH_RB_RPTR register after each processed interrupt drivers/gpu/drm/radeon/cik.c | 12 ++++----- drivers/gpu/drm/radeon/evergreen.c | 8 +++--- drivers/gpu/drm/radeon/r600.c | 8 +++--- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_device.c | 4 +++ drivers/gpu/drm/radeon/radeon_drv.c | 4 +++ drivers/gpu/drm/radeon/radeon_encoders.c | 44 ++++++++++++++++++++++++++------ drivers/gpu/drm/radeon/si.c | 8 +++--- 8 files changed, 63 insertions(+), 26 deletions(-)

1 0

[PATCH] drm: Drop grab fpriv->fbs_lock in drm_fb_release
by Daniel Vetter 24 Sep '14

24 Sep '14

Paulo Zanoni reported a lockdep splat with a locking inversion between fpriv->fbs_lock and the modeset locks. This issue was introduced in commit f2b50c1161590c3bcdbf3455fe4c575f1c1bd293 Author: Daniel Vetter <daniel.vetter(a)ffwll.ch> Date: Fri Sep 12 17:07:32 2014 +0200 drm: Fixup locking for universal cursor planes This here is actually one of the rare cases where lockdep hits a false positive: The deadlock only happens in drm_fb_release, which cleans up the file private structure when all the references are gone. So the locking is the very last one and no one else can deadlock. It also doesn't protect anything at all, since all ioctls are guaranteed to have returned at this point - otherwise they'd still hold a reference on the file. So let's just drop it and replace it with a big comment. Cc: David Herrmann <dh.herrmann(a)gmail.com> Cc: Matt Roper <matthew.d.roper(a)intel.com> Cc: Paulo Zanoni <przanoni(a)gmail.com> Reported-by: Paulo Zanoni <przanoni(a)gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_crtc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index b7021069b078..e79c8d3700d8 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -3400,7 +3400,16 @@ void drm_fb_release(struct drm_file *priv) struct drm_device *dev = priv->minor->dev; struct drm_framebuffer *fb, *tfb; - mutex_lock(&priv->fbs_lock); + /* + * When the file gets released that means no one else can access the fb + * list any more, so no need to grab fpriv->fbs_lock. And we need to to + * avoid upsetting lockdep since the universal cursor code adds a + * framebuffer while holding mutex locks. + * + * Note that a real deadlock between fpriv->fbs_lock and the modeset + * locks is impossible here since no one else but this function can get + * at it any more. + */ list_for_each_entry_safe(fb, tfb, &priv->fbs, filp_head) { mutex_lock(&dev->mode_config.fb_lock); @@ -3413,7 +3422,6 @@ void drm_fb_release(struct drm_file *priv) /* This will also drop the fpriv->fbs reference. */ drm_framebuffer_remove(fb); } - mutex_unlock(&priv->fbs_lock); } /** -- 2.1.0

2 1

[Bug 82441] [gma500] Dell Inspiron Mini 1010 black screen after boot
by bugzilla-daemon＠freedesktop.org 24 Sep '14

24 Sep '14

1 0

[Bug 78562] [gma500] wrong pixel clock on LVDS (half the correct frequency)
by bugzilla-daemon＠freedesktop.org 24 Sep '14

24 Sep '14

1 0

[PULL] drm-intel-fixes
by Jani Nikula 24 Sep '14

24 Sep '14

Hi Dave, a couple of small fixes for 3.17 still. BR, Jani. The following changes since commit 0f33be009b89d2268e94194dc4fd01a7851b6d51: Linux 3.17-rc6 (2014-09-21 15:43:02 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fixes-2014-09-24 for you to fetch changes up to c84db77010877da6c5da119868ed54c43d59e726: drm/i915/hdmi: fix hdmi audio state readout (2014-09-23 16:36:12 +0300) ---------------------------------------------------------------- Brad Volkin (1): drm/i915: Don't leak command parser tables on suspend/resume Jani Nikula (1): drm/i915/hdmi: fix hdmi audio state readout drivers/gpu/drm/i915/i915_cmd_parser.c | 12 +++++++----- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) -- Jani Nikula, Intel Open Source Technology Center

1 0

re: drm/radeon: fix AGP userptr handling
by Dan Carpenter 24 Sep '14

24 Sep '14

Hello Christian König, This is a semi-automatic email about new static checker warnings. The patch 3840a656f61f: "drm/radeon: fix AGP userptr handling" from Sep 17, 2014, leads to the following Smatch complaint: drivers/gpu/drm/radeon/radeon_ttm.c:708 radeon_ttm_tt_populate() error: we previously assumed 'gtt' could be null (see line 696) drivers/gpu/drm/radeon/radeon_ttm.c 695 696 if (gtt && gtt->userptr) { ^^^ New check. 697 ttm->sg = kcalloc(1, sizeof(struct sg_table), GFP_KERNEL); 698 if (!ttm->sg) 699 return -ENOMEM; 700 701 ttm->page_flags |= TTM_PAGE_FLAG_SG; 702 ttm->state = tt_unbound; 703 return 0; 704 } 705 706 if (slave && ttm->sg) { 707 drm_prime_sg_to_page_addr_arrays(ttm->sg, ttm->pages, 708 gtt->ttm.dma_address, ttm->num_pages); ^^^^^^^^ Old unchecked dereference. 709 ttm->state = tt_unbound; 710 return 0; drivers/gpu/drm/radeon/radeon_ttm.c 754 755 if (gtt && gtt->userptr) { ^^^ 756 kfree(ttm->sg); 757 ttm->page_flags &= ~TTM_PAGE_FLAG_SG; 758 return; 759 } 760 761 if (slave) 762 return; 763 764 rdev = radeon_get_rdev(ttm->bdev); 765 #if __OS_HAS_AGP 766 if (rdev->flags & RADEON_IS_AGP) { 767 ttm_agp_tt_unpopulate(ttm); 768 return; 769 } 770 #endif 771 772 #ifdef CONFIG_SWIOTLB 773 if (swiotlb_nr_tbl()) { 774 ttm_dma_unpopulate(&gtt->ttm, rdev->dev); 775 return; 776 } 777 #endif 778 779 for (i = 0; i < ttm->num_pages; i++) { 780 if (gtt->ttm.dma_address[i]) { ^^^^^^^^ 781 pci_unmap_page(rdev->pdev, gtt->ttm.dma_address[i], 782 PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); regards, dan carpenter

1 0

[PATCH 0/9] drm/omap: misc fixes
by Tomi Valkeinen 24 Sep '14

24 Sep '14

Hi, This is a modified version of the series I sent earlier (http://comments.gmane.org/gmane.comp.video.dri.devel/113812). I haven't had time to work on the locking issues, so I've dropped the patches related to that so that the rest could get merged. I have also added three new small patches (the three last ones). Tomi Tomi Valkeinen (9): drm/omap: fix encoder-crtc mapping drm/omap: page_flip: return -EBUSY if flip pending drm/omap: fix race issue with vsync irq and apply drm/omap: clear omap_obj->paddr in omap_gem_put_paddr() drm/omap: add pin refcounting to omap_framebuffer drm/omap: add a comment why locking is missing drm/omap: fix operation without fbdev drm/omap: fix error handling in omap_framebuffer_create() drm/omap: handle mismatching color format and buffer width drivers/gpu/drm/omapdrm/omap_crtc.c | 19 ++++++++++++++++--- drivers/gpu/drm/omapdrm/omap_drv.c | 18 ++++++++++-------- drivers/gpu/drm/omapdrm/omap_fb.c | 26 +++++++++++++++++++++++--- drivers/gpu/drm/omapdrm/omap_gem.c | 1 + drivers/gpu/drm/omapdrm/omap_plane.c | 4 ++++ 5 files changed, 54 insertions(+), 14 deletions(-) -- 1.9.1

1 10

[Bug 83861] radeon power management cause audio skips and glitch
by bugzilla-daemon＠bugzilla.kernel.org 24 Sep '14

24 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=83861 --- Comment #5 from Francesco <markurujapan(a)gmail.com> --- please,. we need an answer if is possible, a solution!5 months with this bug , the bug is present on kernel 3.16 and on 3.17, we neeed a solutioN :'( -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 83861] radeon power management cause audio skips and glitch
by bugzilla-daemon＠bugzilla.kernel.org 24 Sep '14

24 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=83861 --- Comment #4 from Yomi <abyomi0(a)gmail.com> --- Created attachment 151761 --> https://bugzilla.kernel.org/attachment.cgi?id=151761&action=edit Xorg.log -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2014