dri-devel September 2014

dri-devel@lists.freedesktop.org

173 participants
1045 discussions

[PATCH] drm/exynos: use a new anon file for exynos gem mmaper
by Inki Dae 11 Sep '14

11 Sep '14

This patch resolves potential deadlock issue that can be incurred by changing file->f_op and filp->private_data to exynos specific mapper ops and gem object temporarily. To resolve this issue, this patch creates a new anon file dedicated to exynos specific mmaper, and making it used instead of existing one. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 +++++++++ drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 + drivers/gpu/drm/exynos/exynos_drm_gem.c | 74 ++++++------------------------- drivers/gpu/drm/exynos/exynos_drm_gem.h | 3 ++ 4 files changed, 38 insertions(+), 61 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 22b8f5e..b5e5957 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -14,6 +14,8 @@ #include <drm/drmP.h> #include <drm/drm_crtc_helper.h> +#include <linux/anon_inodes.h> + #include <drm/exynos_drm.h> #include "exynos_drm_drv.h" @@ -150,9 +152,14 @@ static int exynos_drm_unload(struct drm_device *dev) return 0; } +static const struct file_operations exynos_drm_gem_fops = { + .mmap = exynos_drm_gem_mmap_buffer, +}; + static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) { struct drm_exynos_file_private *file_priv; + struct file *anon_filp; int ret; file_priv = kzalloc(sizeof(*file_priv), GFP_KERNEL); @@ -167,6 +174,16 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) file->driver_priv = NULL; } + anon_filp = anon_inode_getfile("exynos_gem", &exynos_drm_gem_fops, + NULL, 0); + if (IS_ERR(anon_filp)) { + kfree(file_priv); + return PTR_ERR(anon_filp); + } + + anon_filp->f_mode = FMODE_READ | FMODE_WRITE; + file_priv->anon_filp = anon_filp; + return ret; } @@ -179,6 +196,7 @@ static void exynos_drm_preclose(struct drm_device *dev, static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file) { struct exynos_drm_private *private = dev->dev_private; + struct drm_exynos_file_private *file_priv; struct drm_pending_vblank_event *v, *vt; struct drm_pending_event *e, *et; unsigned long flags; @@ -204,6 +222,9 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file) } spin_unlock_irqrestore(&dev->event_lock, flags); + file_priv = file->driver_priv; + if (file_priv->anon_filp) + fput(file_priv->anon_filp); kfree(file->driver_priv); file->driver_priv = NULL; diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index eaa1966..0eaf5a2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -226,6 +226,7 @@ struct exynos_drm_ipp_private { struct drm_exynos_file_private { struct exynos_drm_g2d_private *g2d_priv; struct exynos_drm_ipp_private *ipp_priv; + struct file *anon_filp; }; /* diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index 1ade191..49b8c9b 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -338,46 +338,22 @@ int exynos_drm_gem_map_offset_ioctl(struct drm_device *dev, void *data, &args->offset); } -static struct drm_file *exynos_drm_find_drm_file(struct drm_device *drm_dev, - struct file *filp) -{ - struct drm_file *file_priv; - - /* find current process's drm_file from filelist. */ - list_for_each_entry(file_priv, &drm_dev->filelist, lhead) - if (file_priv->filp == filp) - return file_priv; - - WARN_ON(1); - - return ERR_PTR(-EFAULT); -} - -static int exynos_drm_gem_mmap_buffer(struct file *filp, +int exynos_drm_gem_mmap_buffer(struct file *filp, struct vm_area_struct *vma) { struct drm_gem_object *obj = filp->private_data; struct exynos_drm_gem_obj *exynos_gem_obj = to_exynos_gem_obj(obj); struct drm_device *drm_dev = obj->dev; struct exynos_drm_gem_buf *buffer; - struct drm_file *file_priv; unsigned long vm_size; int ret; + WARN_ON(!mutex_is_locked(&obj->dev->struct_mutex)); + vma->vm_flags |= VM_IO | VM_DONTEXPAND | VM_DONTDUMP; vma->vm_private_data = obj; vma->vm_ops = drm_dev->driver->gem_vm_ops; - /* restore it to driver's fops. */ - filp->f_op = fops_get(drm_dev->driver->fops); - - file_priv = exynos_drm_find_drm_file(drm_dev, filp); - if (IS_ERR(file_priv)) - return PTR_ERR(file_priv); - - /* restore it to drm_file. */ - filp->private_data = file_priv; - update_vm_cache_attr(exynos_gem_obj, vma); vm_size = vma->vm_end - vma->vm_start; @@ -411,15 +387,13 @@ static int exynos_drm_gem_mmap_buffer(struct file *filp, return 0; } -static const struct file_operations exynos_drm_gem_fops = { - .mmap = exynos_drm_gem_mmap_buffer, -}; - int exynos_drm_gem_mmap_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { + struct drm_exynos_file_private *exynos_file_priv; struct drm_exynos_gem_mmap *args = data; struct drm_gem_object *obj; + struct file *anon_filp; unsigned long addr; if (!(dev->driver->driver_features & DRIVER_GEM)) { @@ -427,47 +401,25 @@ int exynos_drm_gem_mmap_ioctl(struct drm_device *dev, void *data, return -ENODEV; } + mutex_lock(&dev->struct_mutex); + obj = drm_gem_object_lookup(dev, file_priv, args->handle); if (!obj) { DRM_ERROR("failed to lookup gem object.\n"); + mutex_unlock(&dev->struct_mutex); return -EINVAL; } - /* - * We have to use gem object and its fops for specific mmaper, - * but vm_mmap() can deliver only filp. So we have to change - * filp->f_op and filp->private_data temporarily, then restore - * again. So it is important to keep lock until restoration the - * settings to prevent others from misuse of filp->f_op or - * filp->private_data. - */ - mutex_lock(&dev->struct_mutex); - - /* - * Set specific mmper's fops. And it will be restored by - * exynos_drm_gem_mmap_buffer to dev->driver->fops. - * This is used to call specific mapper temporarily. - */ - file_priv->filp->f_op = &exynos_drm_gem_fops; - - /* - * Set gem object to private_data so that specific mmaper - * can get the gem object. And it will be restored by - * exynos_drm_gem_mmap_buffer to drm_file. - */ - file_priv->filp->private_data = obj; + exynos_file_priv = file_priv->driver_priv; + anon_filp = exynos_file_priv->anon_filp; + anon_filp->private_data = obj; - addr = vm_mmap(file_priv->filp, 0, args->size, - PROT_READ | PROT_WRITE, MAP_SHARED, 0); + addr = vm_mmap(anon_filp, 0, args->size, PROT_READ | PROT_WRITE, + MAP_SHARED, 0); drm_gem_object_unreference(obj); if (IS_ERR_VALUE(addr)) { - /* check filp->f_op, filp->private_data are restored */ - if (file_priv->filp->f_op == &exynos_drm_gem_fops) { - file_priv->filp->f_op = fops_get(dev->driver->fops); - file_priv->filp->private_data = file_priv; - } mutex_unlock(&dev->struct_mutex); return (int)addr; } diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h index 702ec3a..fde860c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h @@ -122,6 +122,9 @@ int exynos_drm_gem_map_offset_ioctl(struct drm_device *dev, void *data, int exynos_drm_gem_mmap_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv); +int exynos_drm_gem_mmap_buffer(struct file *filp, + struct vm_area_struct *vma); + /* map user space allocated by malloc to pages. */ int exynos_drm_gem_userptr_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv); -- 1.7.9.5

3 7

Re: [PATCH RFC 4/4] drm: link connectors to backlight devices
by Matthew Garrett 11 Sep '14

11 Sep '14

One extreme case - apple_gmux needs to be mapped to both the internal and discrete gpu. The same may be true for some other platform drivers on multi-gpu systems. Matthew Garrett | matthew.garrett(a)nebula.com

1 0

[PATCH 00/15] put drmP.h on diet
by Daniel Vetter 11 Sep '14

11 Sep '14

Hi all, Motivated by some irc discussions and a quick patch from Dave I've decided to clean up drmP.h. This series creates two new header files: - "drm_internal.h" for stuff private to drm.ko - <drm/drm_legacy.h> for declaratations which are only used by non-kms legacy drivers. Result is a net reduction of drmP.h by almost 300 lines. It now resembles a sane-ish header a lot more. This is on top of the drm_irq module option patche I've submitted already. And I like Dave's patch for ati_pcigart stuff better, so will rebase the series and drop mine once it has landed in drm-next. To squeeze this into 3.18 I'll send a pull request later this week (since -rc5 will happen likely this w/e). Comments highly welcome. Thanks, Daniel Daniel Vetter (15): drm: Move dma functions into drm_legacy.h drm: Move sg functions into drm_legacy.h drm: Move drm_legacy_vma_flush into drm_legacy.h drm: Create drm legacy driver header drm: Move ati pci gart into <drm/drm_legacy.h> drm: Move __drm_pci_free to drm_legacy.c drm: Drop drm_sysfs_class from drmP.h drm: Move piles of functions from drmP.h to drm_internal.h drm: unexport drm_global_mutex drm: Purge ioctl forward declarations from drmP.h drm: Move drm_memory.c map support declarations to <drm/drm_legacy.h> drm: Move legacy buffer structures to <drm/drm_legacy.h> drm: Move LOCK_TEST_WITH_RETURN to <drm/drm_legacy.h> drm: Move drm_class to drm_internal.h drm: Move DRM_MAGIC_HASH_ORDER into drm_drv.c drivers/gpu/drm/ati_pcigart.c | 1 + drivers/gpu/drm/drm_auth.c | 1 + drivers/gpu/drm/drm_bufs.c | 4 +- drivers/gpu/drm/drm_crtc.c | 1 + drivers/gpu/drm/drm_debugfs.c | 1 + drivers/gpu/drm/drm_dma.c | 11 +- drivers/gpu/drm/drm_drv.c | 3 + drivers/gpu/drm/drm_fops.c | 4 +- drivers/gpu/drm/drm_gem.c | 1 + drivers/gpu/drm/drm_info.c | 1 + drivers/gpu/drm/drm_internal.h | 71 ++++++++ drivers/gpu/drm/drm_ioctl.c | 230 +++++++++++++------------- drivers/gpu/drm/drm_legacy.h | 18 ++ drivers/gpu/drm/drm_lock.c | 1 + drivers/gpu/drm/drm_memory.c | 12 +- drivers/gpu/drm/drm_pci.c | 5 +- drivers/gpu/drm/drm_prime.c | 1 + drivers/gpu/drm/drm_scatter.c | 9 +- drivers/gpu/drm/drm_sysfs.c | 1 + drivers/gpu/drm/drm_vm.c | 2 +- drivers/gpu/drm/i810/i810_dma.c | 8 +- drivers/gpu/drm/i810/i810_drv.h | 2 + drivers/gpu/drm/i915/i915_dma.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 9 +- drivers/gpu/drm/mga/mga_dma.c | 28 ++-- drivers/gpu/drm/mga/mga_drv.h | 2 + drivers/gpu/drm/mgag200/mgag200_drv.h | 2 - drivers/gpu/drm/r128/r128_cce.c | 22 +-- drivers/gpu/drm/r128/r128_drv.h | 2 + drivers/gpu/drm/radeon/r600_cp.c | 24 +-- drivers/gpu/drm/radeon/radeon_cp.c | 24 +-- drivers/gpu/drm/radeon/radeon_drv.h | 1 + drivers/gpu/drm/savage/savage_bci.c | 16 +- drivers/gpu/drm/savage/savage_drv.h | 2 + drivers/gpu/drm/sis/sis_drv.h | 2 + drivers/gpu/drm/via/via_dma.c | 4 +- drivers/gpu/drm/via/via_drv.h | 2 + drivers/gpu/drm/via/via_map.c | 4 +- drivers/gpu/drm/via/via_verifier.c | 1 + include/drm/drmP.h | 299 +--------------------------------- include/drm/drm_legacy.h | 226 +++++++++++++++++++++++++ 41 files changed, 561 insertions(+), 498 deletions(-) create mode 100644 include/drm/drm_legacy.h -- 1.9.3

3 22

[Bug 35457] [rs690m] Graphics corruption with ati x1200
by bugzilla-daemon＠freedesktop.org 11 Sep '14

11 Sep '14

https://bugs.freedesktop.org/show_bug.cgi?id=35457 Appin Technology Lab <appintechnologylab.pdy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dri-devel(a)lists.freedesktop |atl.puducherry(a)gmail.com |.org | -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 82551] monitor resolution wrongly set when using kernels > 3.13
by bugzilla-daemon＠bugzilla.kernel.org 11 Sep '14

11 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=82551 --- Comment #10 from Javier Fernandez <elhoir(a)gmail.com> --- the kernel i am using now and on which open source driver is working is 3.16.0-14-lowlatency -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 82551] monitor resolution wrongly set when using kernels > 3.13
by bugzilla-daemon＠bugzilla.kernel.org 11 Sep '14

11 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=82551 --- Comment #9 from Javier Fernandez <elhoir(a)gmail.com> --- well, actually i havent tested upstream versions of 3.16 kernels, only Ubuntu kernels (which are patched) thats why i ask about installing upstream ones... what do u think? Also, i can remember earlier releases of 3.16 kernels on which radeon open source driver didnt work ( 3.16.0-8) 3.13 -> works 3.14 -> doesn't work 3.15 -> doesn't work 3.16 -> works seems so, yes -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 82551] monitor resolution wrongly set when using kernels > 3.13
by bugzilla-daemon＠bugzilla.kernel.org 10 Sep '14

10 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=82551 --- Comment #8 from Alex Deucher <alexdeucher(a)gmail.com> --- to be clear, are you saying that it's working again with 3.16? E.g., 3.13 -> works 3.14 -> doesn't work 3.16 -> works -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Bug 82551] monitor resolution wrongly set when using kernels > 3.13
by bugzilla-daemon＠bugzilla.kernel.org 10 Sep '14

10 Sep '14

https://bugzilla.kernel.org/show_bug.cgi?id=82551 --- Comment #7 from Javier Fernandez <elhoir(a)gmail.com> --- Hello again, i have been able to boot correctly with the open source driver using the Ubuntu specific kernel 3.16.0-14-lowlatency should i try with upstream 3.16.2 ? -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

ccf vs iommu vs drm locking fun
by Rob Clark 10 Sep '14

10 Sep '14

So, I was looking at the below lockdep splat, and discussing it a bit w/ sboyd on IRC, and came to a slightly disturbing realization.. The interaction between prepare_lock and debugfs bits is a little bit worrying. In particular, it is probably not a good idea to assume that anyone who needs to grab prepare_lock does not already hold mmap_sem. Not holding mmap_sem or locks that interact w/ mmap_sem is going to be pretty hard to avoid, at least for gpu drivers that are using iommus that are using CCF ;-) BR, -R ---------- [15928.894558] [15928.894609] ====================================================== [15928.895145] [ INFO: possible circular locking dependency detected ] [15928.901141] 3.17.0-rc1-00050-g07a489b #802 Tainted: G W [15928.907335] ------------------------------------------------------- [15928.907348] Xorg.bin/5413 is trying to acquire lock: [15928.907417] (prepare_lock){+.+.+.}, at: [<c0781280>] clk_prepare_lock+0x88/0xfc [15928.907424] [15928.907424] but task is already holding lock: [15928.907508] (qcom_iommu_lock){+.+...}, at: [<c079f664>] qcom_iommu_unmap+0x1c/0x1f0 [15928.907519] [15928.907519] which lock already depends on the new lock. [15928.907519] [15928.907532] [15928.907532] the existing dependency chain (in reverse order) is: [15928.907575] [15928.907575] -> #4 (qcom_iommu_lock){+.+...}: [15928.907611] [<c079f860>] qcom_iommu_map+0x28/0x450 [15928.907634] [<c079eb50>] iommu_map+0xc8/0x12c [15928.907662] [<c056c1fc>] msm_iommu_map+0xb4/0x130 [15928.907681] [<c05697bc>] msm_gem_get_iova_locked+0x9c/0xe8 [15928.907714] [<c0569854>] msm_gem_get_iova+0x4c/0x64 [15928.907765] [<c0562208>] mdp4_kms_init+0x4c4/0x6c0 [15928.907813] [<c056881c>] msm_load+0x2ac/0x34c [15928.907846] [<c0545724>] drm_dev_register+0xac/0x108 [15928.907868] [<c0547510>] drm_platform_init+0x50/0xf0 [15928.907892] [<c0578a60>] try_to_bring_up_master.part.3+0xc8/0x108 [15928.907913] [<c0578b48>] component_master_add_with_match+0xa8/0x104 [15928.907934] [<c0568294>] msm_pdev_probe+0x64/0x70 [15928.907955] [<c057e704>] platform_drv_probe+0x2c/0x60 [15928.907983] [<c057cff8>] driver_probe_device+0x108/0x234 [15928.908003] [<c057b65c>] bus_for_each_drv+0x64/0x98 [15928.908040] [<c057cec0>] device_attach+0x78/0x8c [15928.908082] [<c057c590>] bus_probe_device+0x88/0xac [15928.908126] [<c057c9b8>] deferred_probe_work_func+0x68/0x9c [15928.908182] [<c0259db4>] process_one_work+0x1a0/0x40c [15928.908214] [<c025a710>] worker_thread+0x44/0x4d8 [15928.908237] [<c025ec54>] kthread+0xd8/0xec [15928.908262] [<c020e9a8>] ret_from_fork+0x14/0x2c [15928.908291] [15928.908291] -> #3 (&dev->struct_mutex){+.+.+.}: [15928.908311] [<c0541188>] drm_gem_mmap+0x38/0xd0 [15928.908329] [<c05695b8>] msm_gem_mmap+0xc/0x5c [15928.908358] [<c02f0b6c>] mmap_region+0x35c/0x6c8 [15928.908377] [<c02f11ec>] do_mmap_pgoff+0x314/0x398 [15928.908398] [<c02de1e0>] vm_mmap_pgoff+0x84/0xb4 [15928.908416] [<c02ef83c>] SyS_mmap_pgoff+0x94/0xbc [15928.908436] [<c020e8e0>] ret_fast_syscall+0x0/0x48 [15928.908463] [15928.908463] -> #2 (&mm->mmap_sem){++++++}: [15928.908512] [<c0321138>] filldir64+0x68/0x180 [15928.908558] [<c0333fe0>] dcache_readdir+0x188/0x22c [15928.908593] [<c0320ed0>] iterate_dir+0x9c/0x11c [15928.908616] [<c03213b0>] SyS_getdents64+0x78/0xe8 [15928.908640] [<c020e8e0>] ret_fast_syscall+0x0/0x48 [15928.908671] [15928.908671] -> #1 (&sb->s_type->i_mutex_key#3){+.+.+.}: [15928.908706] [<c03fc544>] __create_file+0x58/0x1dc [15928.908728] [<c03fc70c>] debugfs_create_dir+0x1c/0x24 [15928.908761] [<c0781c7c>] clk_debug_create_subtree+0x20/0x170 [15928.908790] [<c0be2af8>] clk_debug_init+0xec/0x14c [15928.908816] [<c0208c70>] do_one_initcall+0x8c/0x1c8 [15928.908846] [<c0b9cce4>] kernel_init_freeable+0x13c/0x1dc [15928.908873] [<c0877bc4>] kernel_init+0x8/0xe8 [15928.908898] [<c020e9a8>] ret_from_fork+0x14/0x2c [15928.908925] [15928.908925] -> #0 (prepare_lock){+.+.+.}: [15928.908948] [<c087c408>] mutex_lock_nested+0x70/0x3e8 [15928.908970] [<c0781280>] clk_prepare_lock+0x88/0xfc [15928.909001] [<c0782c50>] clk_prepare+0xc/0x24 [15928.909022] [<c079f474>] __enable_clocks.isra.4+0x18/0xa4 [15928.909041] [<c079f614>] __flush_iotlb_va+0xe0/0x114 [15928.909071] [<c079f6f4>] qcom_iommu_unmap+0xac/0x1f0 [15928.909093] [<c079ea3c>] iommu_unmap+0x9c/0xe8 [15928.909112] [<c056c2fc>] msm_iommu_unmap+0x64/0x84 [15928.909130] [<c0569da4>] msm_gem_free_object+0x11c/0x338 [15928.909149] [<c05413ec>] drm_gem_object_handle_unreference_unlocked+0xfc/0x130 [15928.909166] [<c0541604>] drm_gem_object_release_handle+0x50/0x68 [15928.909199] [<c0447a98>] idr_for_each+0xa8/0xdc [15928.909225] [<c0541c10>] drm_gem_release+0x1c/0x28 [15928.909258] [<c0540b3c>] drm_release+0x370/0x428 [15928.909302] [<c031105c>] __fput+0x98/0x1e8 [15928.909339] [<c025d73c>] task_work_run+0xb0/0xfc [15928.909386] [<c02477ec>] do_exit+0x2ec/0x948 [15928.909415] [<c0247ec0>] do_group_exit+0x4c/0xb8 [15928.909455] [<c025180c>] get_signal+0x28c/0x6ac [15928.909507] [<c0211204>] do_signal+0xc4/0x3e4 [15928.909548] [<c02116cc>] do_work_pending+0xb4/0xc4 [15928.909584] [<c020e938>] work_pending+0xc/0x20 [15928.909595] [15928.909595] other info that might help us debug this: [15928.909595] [15928.909665] Chain exists of: [15928.909665] prepare_lock --> &dev->struct_mutex --> qcom_iommu_lock [15928.909665] [15928.909675] Possible unsafe locking scenario: [15928.909675] [15928.909685] CPU0 CPU1 [15928.909696] ---- ---- [15928.909724] lock(qcom_iommu_lock); [15928.909753] lock(&dev->struct_mutex); [15928.909769] lock(qcom_iommu_lock); [15928.909786] lock(prepare_lock); [15928.909795] [15928.909795] *** DEADLOCK *** [15928.909795] [15928.909818] 3 locks held by Xorg.bin/5413: [15928.909905] #0: (drm_global_mutex){+.+.+.}, at: [<c0540800>] drm_release+0x34/0x428 [15928.909954] #1: (&dev->struct_mutex){+.+.+.}, at: [<c05413bc>] drm_gem_object_handle_unreference_unlocked+0xcc/0x130 [15928.910029] #2: (qcom_iommu_lock){+.+...}, at: [<c079f664>] qcom_iommu_unmap+0x1c/0x1f0 [15928.910042] [15928.910042] stack backtrace: [15928.910073] CPU: 1 PID: 5413 Comm: Xorg.bin Tainted: G W 3.17.0-rc1-00050-g07a489b #802 [15928.910141] [<c0216290>] (unwind_backtrace) from [<c0211d8c>] (show_stack+0x10/0x14) [15928.910181] [<c0211d8c>] (show_stack) from [<c087a078>] (dump_stack+0x98/0xb8) [15928.910210] [<c087a078>] (dump_stack) from [<c027f024>] (print_circular_bug+0x218/0x340) [15928.910250] [<c027f024>] (print_circular_bug) from [<c0283e08>] (__lock_acquire+0x1d24/0x20b8) [15928.910293] [<c0283e08>] (__lock_acquire) from [<c0284774>] (lock_acquire+0x9c/0xbc) [15928.910332] [<c0284774>] (lock_acquire) from [<c087c408>] (mutex_lock_nested+0x70/0x3e8) [15928.910380] [<c087c408>] (mutex_lock_nested) from [<c0781280>] (clk_prepare_lock+0x88/0xfc) [15928.910436] [<c0781280>] (clk_prepare_lock) from [<c0782c50>] (clk_prepare+0xc/0x24) [15928.910478] [<c0782c50>] (clk_prepare) from [<c079f474>] (__enable_clocks.isra.4+0x18/0xa4) [15928.910517] [<c079f474>] (__enable_clocks.isra.4) from [<c079f614>] (__flush_iotlb_va+0xe0/0x114) [15928.910561] [<c079f614>] (__flush_iotlb_va) from [<c079f6f4>] (qcom_iommu_unmap+0xac/0x1f0) [15928.910602] [<c079f6f4>] (qcom_iommu_unmap) from [<c079ea3c>] (iommu_unmap+0x9c/0xe8) [15928.910635] [<c079ea3c>] (iommu_unmap) from [<c056c2fc>] (msm_iommu_unmap+0x64/0x84) [15928.910669] [<c056c2fc>] (msm_iommu_unmap) from [<c0569da4>] (msm_gem_free_object+0x11c/0x338) [15928.910692] [<c0569da4>] (msm_gem_free_object) from [<c05413ec>] (drm_gem_object_handle_unreference_unlocked+0xfc/0x130) [15928.910715] [<c05413ec>] (drm_gem_object_handle_unreference_unlocked) from [<c0541604>] (drm_gem_object_release_handle+0x50/0x68) [15928.910737] [<c0541604>] (drm_gem_object_release_handle) from [<c0447a98>] (idr_for_each+0xa8/0xdc) [15928.910759] [<c0447a98>] (idr_for_each) from [<c0541c10>] (drm_gem_release+0x1c/0x28) [15928.910786] [<c0541c10>] (drm_gem_release) from [<c0540b3c>] (drm_release+0x370/0x428) [15928.910818] [<c0540b3c>] (drm_release) from [<c031105c>] (__fput+0x98/0x1e8) [15928.910846] [<c031105c>] (__fput) from [<c025d73c>] (task_work_run+0xb0/0xfc) [15928.910870] [<c025d73c>] (task_work_run) from [<c02477ec>] (do_exit+0x2ec/0x948) [15928.910897] [<c02477ec>] (do_exit) from [<c0247ec0>] (do_group_exit+0x4c/0xb8) [15928.910920] [<c0247ec0>] (do_group_exit) from [<c025180c>] (get_signal+0x28c/0x6ac) [15928.910966] [<c025180c>] (get_signal) from [<c0211204>] (do_signal+0xc4/0x3e4) [15928.911019] [<c0211204>] (do_signal) from [<c02116cc>] (do_work_pending+0xb4/0xc4) [15928.911054] [<c02116cc>] (do_work_pending) from [<c020e938>] (work_pending+0xc/0x20)

3 7

[pull] radeon drm-next-3.18
by Alex Deucher 10 Sep '14

10 Sep '14

Hi Dave, A few more radeon patches for 3.18. This patch set gives us more flexibility with respect to buffer placement in vram with respect to CPU access. E.g., if you know you will not need CPU access, we can now pin outside of the CPU window, reducing contention for the CPU window space. We also have an additional patch set from Christian to enable concurrent buffer reads. It uses the new fence code to avoid unnecessary serialization of command streams when a buffer is read by multiple engines at the same time. It would be nice to get some additional comments on it since it requires some minor changes to ttm. I've sent you another email about it. The following changes since commit fdcaa1dbb7c6ed419b10fb8cdb5001ab0a00538f: Merge tag 'ipu-3.18' of git://git.pengutronix.de/git/pza/linux into drm-next (2014-09-10 19:43:29 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-3.18 for you to fetch changes up to f266f04d33e5265e2f61ffc9d2b2f97214804995: drm/radeon: add RADEON_GEM_NO_CPU_ACCESS BO creation flag (v4) (2014-09-10 11:29:46 -0400) ---------------------------------------------------------------- Alex Deucher (1): drm/radeon: add RADEON_GEM_NO_CPU_ACCESS BO creation flag (v4) Michel Dänzer (2): drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag drm/radeon: Clean up assignment of TTM placement lpfn member for pinning drivers/gpu/drm/radeon/radeon_object.c | 26 +++++++++++++++----------- include/uapi/drm/radeon_drm.h | 4 ++++ 2 files changed, 19 insertions(+), 11 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2014