dri-devel April 2015

dri-devel@lists.freedesktop.org

175 participants
1044 discussions

[PATCH] xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic
by Daniel Kurtz 05 Apr '15

05 Apr '15

Unfortunately, there are some users of libdrm installed headers that like to be built with -std=c89 -pedantic, which does not like "inline". However, __inline works. Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> --- xf86drmMode.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xf86drmMode.h b/xf86drmMode.h index 856a6bb..2d30184 100644 --- a/xf86drmMode.h +++ b/xf86drmMode.h @@ -240,7 +240,7 @@ typedef struct _drmModeProperty { uint32_t *blob_ids; /* store the blob IDs */ } drmModePropertyRes, *drmModePropertyPtr; -static inline int drm_property_type_is(drmModePropertyPtr property, +static __inline int drm_property_type_is(drmModePropertyPtr property, uint32_t type) { /* instanceof for props.. handles extended type vs original types: */ -- 2.2.0.rc0.207.ga3a616c

3 6

[PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable
by Connor Behan 05 Apr '15

05 Apr '15

This one is a bit harder to notice. Signed-off-by: Connor Behan <connor.behan(a)gmail.com> --- xf86drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xf86drm.c b/xf86drm.c index e73cddd..ffc53b8 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -1719,7 +1719,7 @@ int drmAgpEnable(int fd, unsigned long mode) { drm_agp_mode_t m; - memclear(mode); + memclear(m); m.mode = mode; if (drmIoctl(fd, DRM_IOCTL_AGP_ENABLE, &m)) return -errno; -- 2.3.3

3 4

[PATCH 0/16] fix error return code
by Julia Lawall 05 Apr '15

05 Apr '15

The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ... when != ret = e return ret; | if (ret < 0) { ... return ret; } ) ... when any } @r exists@ identifier ret,ok.f,fn; expression e1,e2,e3,e4,e5,e6,x; statement S,S1; position p1,p2,p3; @@ // identify a case where the return variable is set to a non-negative value // and then returned in error-handling code f(...) { ... when any ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != \(ret = e1\|ret++\|ret--\|ret+=e1\|ret-=e1\) when != &ret when any ( if (<+... ret = e5 ...+>) S1 | if (<+... &ret ...+>) S1 | if@p2(<+...x = fn(...)...+>) { ... when != ret = e6 when forall return@p3 ret; } | break; | x = fn(...) ... when != \(ret = e4\|ret++\|ret--\|ret+=e4\|ret-=e4\) when != &ret ( if (<+... ret = e3 ...+>) S | if (<+... &ret ...+>) S | if@p2(<+...\(x != 0\|x < 0\|x == NULL\|IS_ERR(x)\)...+>) { ... when != ret = e2 when forall return@p3 ret; } ) ) ... when any } @printer depends on r@ position p; identifier ok.f,pr; constant char [] c; @@ f(...) { <...pr@p(...,c,...)...> } @bad0 exists@ identifier r.ret,ok.f,g != {ERR_PTR,IS_ERR}; position p != printer.p; @@ f(...) { ... when any g@p(...,ret,...) ... when any } @bad depends on !bad0 exists@ position r.p1,r.p2; statement S1,S2; identifier r.ret; expression e1; @@ // ignore the above if there is some path where the variable is set to // something else ( if@p1 (\(ret < 0\|ret != 0\)) S1 | ret@p1 = 0 ) ... when any \(ret = e1\|ret++\|ret--\|ret+=e1\|ret-=e1\|&ret\) ... when any if@p2(...) S2 @bad1 depends on !bad0 && !bad exists@ position r.p2; statement S2; identifier r.ret; expression e1; constant c; @@ ret = -c ... when != \(ret = e1\|ret++\|ret--\|ret+=e1\|ret-=e1\) when != &ret when any if@p2(...) S2 @bad2 depends on !bad0 && !bad && !bad1 exists@ position r.p1,r.p2; identifier r.ret; expression e1; statement S2; constant c; @@ // likewise ignore it if there has been an intervening return ret@p1 = 0 ... when != if (...) { ... ret = e1 ... return ret; } when != if (...) { ... return -c; } when any if@p2(...) S2 @script:python depends on !bad0 && !bad && !bad1 && !bad2@ p1 << r.p1; p2 << r.p2; p3 << r.p3; @@ cocci.print_main("",p1) cocci.print_secs("",p2) cocci.print_secs("",p3) // </smpl>

1 1

[PATCH] drm/msm: fix build warning - missing prototype
by Nicholas Mc Guire 05 Apr '15

05 Apr '15

fix build warning when building edp/edp_aux.o due to missing prototype for edp_aux_transfer. Signed-off-by: Nicholas Mc Guire <hofrat(a)osadl.org> --- building drivers/gpu/drm/msm/msm.ko gives the following warning: drivers/gpu/drm/msm/edp/edp_aux.c:118:9: warning: no previous prototype for 'edp_aux_transfer' [-Wmissing-prototypes] ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg) ^ the fix is to simply add the missing prototype to drivers/gpu/drm/msm/edp/edp.h This was compile tested with qcom_defconfig + CONFIG_DRM=m (implies CONFIG_DRM_MSM=m) Patch is against 4.0-rc6 (localversion-next is -next-20150402) drivers/gpu/drm/msm/edp/edp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/edp/edp.h b/drivers/gpu/drm/msm/edp/edp.h index ba5bedd..93d819c 100644 --- a/drivers/gpu/drm/msm/edp/edp.h +++ b/drivers/gpu/drm/msm/edp/edp.h @@ -58,6 +58,8 @@ void *msm_edp_aux_init(struct device *dev, void __iomem *regbase, void msm_edp_aux_destroy(struct device *dev, struct edp_aux *aux); irqreturn_t msm_edp_aux_irq(struct edp_aux *aux, u32 isr); void msm_edp_aux_ctrl(struct edp_aux *aux, int enable); +ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, + struct drm_dp_aux_msg *msg); /* Phy */ bool msm_edp_phy_ready(struct edp_phy *phy); -- 1.7.10.4

3 2

[PATCH 1/3] drm/msm: fixup wait_for_completion_timeout handling
by Nicholas Mc Guire 04 Apr '15

04 Apr '15

wait_for_completion_timeout return >= 0 but never negative so the check logic looks inconsistent. Further the return value of wait_for_completion_timeout was being passed up the call chain but the x call sites as drm_dp_i2c_do_msg()/drm_dp_dpcd_access() check for < 0 thus timeout was being treated as success case. <snip> drivers/gpu/drm/drm_dp_helper.c:drm_dp_i2c_do_msg() mutex_lock(&aux->hw_mutex); ret = aux->transfer(aux, msg); mutex_unlock(&aux->hw_mutex); if (ret < 0) { <snip> logic in edp_aux_transfer() seems incorrect as it could return 0 (timeout) but checks of <= 0 to indicate error so the return probably should be -ETIMEDOUT in case wait_for_completion_timeout returns 0 (timeout occurred). Signed-off-by: Nicholas Mc Guire <hofrat(a)osadl.org> --- This was compile tested with qcom_defconfig + CONFIG_DRM=m (implies CONFIG_DRM_MSM=m) Patch is against 4.0-rc6 (localversion-next is -next-20150402) drivers/gpu/drm/msm/edp/edp_aux.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/edp/edp_aux.c b/drivers/gpu/drm/msm/edp/edp_aux.c index 5f5a84f..1d2ccdf 100644 --- a/drivers/gpu/drm/msm/edp/edp_aux.c +++ b/drivers/gpu/drm/msm/edp/edp_aux.c @@ -119,6 +119,7 @@ ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg) { struct edp_aux *aux = to_edp_aux(drm_aux); ssize_t ret; + unsigned long time_left; bool native = msg->request & (DP_AUX_NATIVE_WRITE & DP_AUX_NATIVE_READ); bool read = msg->request & (DP_AUX_I2C_READ & DP_AUX_NATIVE_READ); @@ -147,15 +148,16 @@ ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg) goto unlock_exit; DBG("wait_for_completion"); - ret = wait_for_completion_timeout(&aux->msg_comp, 300); - if (ret <= 0) { + time_left = wait_for_completion_timeout(&aux->msg_comp, 300); + if (!time_left) { /* * Clear GO and reset AUX channel * to cancel the current transaction. */ edp_write(aux->base + REG_EDP_AUX_TRANS_CTRL, 0); msm_edp_aux_ctrl(aux, 1); - pr_err("%s: aux timeout, %d\n", __func__, ret); + pr_err("%s: aux timeout, %lu\n", __func__, time_left); + ret = -ETIMEDOUT; goto unlock_exit; } DBG("completion"); -- 1.7.10.4

1 2

[PATCH 00/10] drm/exynos: Add atomic modesetting support
by Gustavo Padovan 03 Apr '15

03 Apr '15

From: Gustavo Padovan <gustavo.padovan(a)collabora.co.uk> Hi, Here goes the full support for atomic modesetting on exynos. I've split the patches in the various phases of atomic support. These patches sits on top of the clean up patches I've sent yesterday to this mailing list[1]. Gustavo [1] http://lists.freedesktop.org/archives/dri-devel/2015-March/080074.html Gustavo Padovan (10): drm/exynos: atomic phase 1: use drm_plane_helper_update() drm/exynos: atomic phase 1: use drm_plane_helper_disable() drm/exynos: atomic phase 1: add .mode_set_nofb() callback drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() drm/exynos: atomic phase 2: keep track of framebuffer pointer drm/exynos: atomic phase 3: atomic updates of planes drm/exynos: atomic phase 3: use atomic .set_config helper drm/exynos: atomic phase 3: convert page flips drm/exynos: remove exported functions from exynos_drm_plane drm/exynos: atomic dpms support drivers/gpu/drm/bridge/ptn3460.c | 4 + drivers/gpu/drm/exynos/exynos_dp_core.c | 6 +- drivers/gpu/drm/exynos/exynos_drm_connector.c | 6 +- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 226 ++++++++------------------ drivers/gpu/drm/exynos/exynos_drm_dpi.c | 6 +- drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 + drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 +- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 6 +- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 27 +-- drivers/gpu/drm/exynos/exynos_drm_fb.c | 12 +- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 3 - drivers/gpu/drm/exynos/exynos_drm_plane.c | 113 +++++++------ drivers/gpu/drm/exynos/exynos_drm_plane.h | 11 -- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 6 +- drivers/gpu/drm/exynos/exynos_hdmi.c | 6 +- 15 files changed, 185 insertions(+), 253 deletions(-) -- 2.1.0

2 15

[PATCH v3 0/8] Add drivers for Exynos5433 display
by Hyungwon Hwang 03 Apr '15

03 Apr '15

This patchset is based on the git(branch name: exynos-drm-next) which is maintained by Inki Dae. https://kernel.googlesource.com/pub/scm/linux/kernel/git/... This patchset adds 2 new device drivers, decon and mic, and adds support for Exynos5433 mipi dsi. To enable display in a Exynos5433 board, decon(display controller), MIC(Mobile image compressor), mipi dsi, and panel have to be turned on. This patchset contains support for 3 drivers for SoC level devices. Changes for v2: - change config, file, and variable names of decon to represnt exynos5433 instead of exynos to distinguish them from exynos7 decon - change the initialization order of decon to make it initialized in order like FIMD or exynos7 decon - make mic driver to be registered by exynos drm driver instead as a module driver - change the description of mic driver in documentation - add module author at the top of the source file removing MODULE_OWNER, MODULE_DESCRIPTION, MODULE_LICENSE - change the author of "drm/exynos: dsi: add support for Exynos5433 SoC" to Hyungwon Hwang by the previous author's will Changes for v3: < Decon > - fail fast when the proper image format is not set - remove unnecessary checking code - add and modify the function to make DPMS work well < MIC > - move if statement out of function, so that the function is not called unnecessarily - Make it use syscon framework for controlling system register < DSI > - separate the previous one patch to three - renaming patch: rename pll clock to sclk clock - generalizing patch: generalize the way to getting address and values - Exynos5433 patch: adds support for Exynos5433 dsi - use defines for more readable code - fix typos Hyungwon Hwang (7): of: add helper for getting endpoint node of specific identifiers drm/exynos: mic: add MIC driver drm/exynos: dsi: rename pll_clk to sclk_clk drm/exynos: dsi: generalize register setting and clock control drm/exynos: dsi: add support for Exynos5433 drm/exynos: dsi: add support for MIC driver as a bridge drm/exynos: dsi: do not set TE GPIO direction by input Joonyoung Shim (1): drm/exynos: add Exynos5433 decon driver .../devicetree/bindings/video/exynos-mic.txt | 51 ++ .../devicetree/bindings/video/exynos5433-decon.txt | 65 ++ .../devicetree/bindings/video/exynos_dsim.txt | 30 +- drivers/gpu/drm/exynos/Kconfig | 14 +- drivers/gpu/drm/exynos/Makefile | 2 + drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 665 +++++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 + drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 + drivers/gpu/drm/exynos/exynos_drm_dsi.c | 453 +++++++++----- drivers/gpu/drm/exynos/exynos_drm_mic.c | 490 +++++++++++++++ drivers/of/base.c | 33 + include/linux/of_graph.h | 8 + include/video/exynos5433_decon.h | 163 +++++ 13 files changed, 1832 insertions(+), 150 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/exynos-mic.txt create mode 100644 Documentation/devicetree/bindings/video/exynos5433-decon.txt create mode 100644 drivers/gpu/drm/exynos/exynos5433_drm_decon.c create mode 100644 drivers/gpu/drm/exynos/exynos_drm_mic.c create mode 100644 include/video/exynos5433_decon.h -- 1.9.1

2 9

[PATCH v4 0/4] drm/layerscape: Add Freescale DCU DRM driver
by Jianwei Wang 03 Apr '15

03 Apr '15

@Daniel, Do you have any other comments for this driver? @Stefan, Please help test this driver on vybrid if possible, I have test it on vybrid twr board. If anyone has any objections, please let me know. Changed in V4: -This version doesn't have functionality changed. Just a minor adjustment. Changed in V3: - Test driver on Vybrid board and add compatible string - Remove unused functions - set default crtc for encoder - replace legacy functions with atomic help functions - Set the unique name of the DRM device - Implement irq handle function for vblank interrupt Changed in v2: - Add atomic support - Modify bindings file - Rename node for compatibility - Move platform related code out for compatibility Added in v1: - Add support for DCU display controller on the Freescale LS102x SoCs. - Create a primary plane, a fb created for fbdev, a crtc, a connector for TFT LCD panel, an encoder. .../devicetree/bindings/drm/fsl/fsl,dcu.txt | 50 ++++ drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/fsl/Kconfig | 17 ++ drivers/gpu/drm/fsl/Makefile | 7 + drivers/gpu/drm/fsl/fsl_dcu_drm_connector.c | 194 ++++++++++++ drivers/gpu/drm/fsl/fsl_dcu_drm_connector.h | 30 ++ drivers/gpu/drm/fsl/fsl_dcu_drm_crtc.c | 165 +++++++++++ drivers/gpu/drm/fsl/fsl_dcu_drm_crtc.h | 26 ++ drivers/gpu/drm/fsl/fsl_dcu_drm_drv.c | 329 +++++++++++++++++++++ drivers/gpu/drm/fsl/fsl_dcu_drm_drv.h | 210 +++++++++++++ drivers/gpu/drm/fsl/fsl_dcu_drm_fbdev.c | 26 ++ drivers/gpu/drm/fsl/fsl_dcu_drm_kms.c | 42 +++ drivers/gpu/drm/fsl/fsl_dcu_drm_kms.h | 17 ++ drivers/gpu/drm/fsl/fsl_dcu_drm_plane.c | 192 ++++++++++++ drivers/gpu/drm/fsl/fsl_dcu_drm_plane.h | 23 ++ 16 files changed, 1331 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/fsl/fsl,dcu.txt create mode 100644 drivers/gpu/drm/fsl/Kconfig create mode 100644 drivers/gpu/drm/fsl/Makefile create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_connector.c create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_connector.h create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_crtc.c create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_crtc.h create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_drv.c create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_drv.h create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_fbdev.c create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_kms.c create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_kms.h create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_plane.c create mode 100644 drivers/gpu/drm/fsl/fsl_dcu_drm_plane.h

1 4

[GIT PULL] drm/rockchip: fixes
by Mark yao 03 Apr '15

03 Apr '15

Hi Dave These are based on drm-next branch, fix some drm/rockchip problem. Please pull them. Mark The following changes since commit 502e95c6678505474f1056480310cd9382bacbac: drm/vgem: implement virtual GEM (2015-04-02 09:21:48 +1000) are available in the git repository at: https://github.com/markyzq/kernel-drm-rockchip.git drm-next0401 for you to fetch changes up to 5d82d1a785155fe4ff65628a88b677cfacea863b: drm/rockchip: vop: add vop power domain support (2015-04-03 14:23:36 +0800) ---------------------------------------------------------------- Caesar Wang (1): drm: rockchip: Turn off VT switching on suspend Daniel Kurtz (1): drm/rockchip: register all connectors after bind Heiko Stuebner (1): drm/rockchip: fix clk enable disable mismatch in vop_crtc_mode_set Mark Yao (1): drm/rockchip: vop: add vop power domain support drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 19 +++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 3 +++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 25 +++++++++++++++++-------- 3 files changed, 39 insertions(+), 8 deletions(-)-- Ｍark

1 0

[Bug 89876] radeon: mmap failed, errno: 12
by bugzilla-daemon＠freedesktop.org 03 Apr '15

03 Apr '15

https://bugs.freedesktop.org/show_bug.cgi?id=89876 Bug ID: 89876 Summary: radeon: mmap failed, errno: 12 Product: Mesa Version: 10.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: minor Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: jdami534(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org package : libgl1-mesa-dri version: 10.3.2-0ubuntu0.1 a random, one time crash that so far has been unreproducible error log: radeon: mmap failed, errno: 12 # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007fea9055a0c3, pid=15637, tid=140647298373376 # # JRE version: Java(TM) SE Runtime Environment (8.0_31-b13) (build 1.8.0_31-b13) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.31-b07 mixed mode linux-amd64 compressed oops) # Problematic frame: # C [r600_dri.so+0x1b20c3] # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # An error report file with more information is saved as: # /home/jason/ftbinstal/FTBInfinity/minecraft/hs_err_pid15637.log # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # attached hs_err file personal note: it might be possible it was a simple out of memory issue, as i did notice that ram useage was creeping up, but not sure. dmesg indicates nothing at all. -- You are receiving this mail because: You are the assignee for the bug.

1 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2015