dri-devel May 2015

dri-devel@lists.freedesktop.org

191 participants
1132 discussions

linux-next: build warning after merge of the drm-intel tree
by Stephen Rothwell 07 May '15

07 May '15

Hi all, After merging the drm-intel tree, today's linux-next build (i386 defconfig) produced this warning: drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen8_ppgtt_init': drivers/gpu/drm/i915/i915_gem_gtt.c:954:22: warning: large integer implicitly truncated to unsigned type [-Woverflow] ppgtt->base.total = 1ULL << 32; ^ Introduced by commit 5c5f645773b6 ("drm/i915: Unify aliasing ppgtt handling"). "total" is a size_t, so unsigned 32 bit on i386. -- … [View More]

1 0

[PATCH] qxl: rewrite framebuffer support
by Gerd Hoffmann 07 May '15

07 May '15

Completely different approach: Instead of encoding each and every framebuffer update as spice operation simply update the shadow framebuffer and maintain a dirty rectangle. Also schedule a worker to push an update for the dirty rectangle as spice operation. Usually a bunch of dirty rectangle updates are collected before the worker actually runs. What changes: Updates get batched now. Instead of sending tons of small updates a few large ones are sent. When the same region is updated … [View More]multiple times within a short timeframe (scrolling multiple lines for example) we send a single update only. Spice server has an easier job now: The dependency tree for display operations which spice server maintains for lazy rendering is alot smaller now. Spice server's image compression probably works better too with the larger image blits. Net effect: framebuffer console @ qxldrmfb is an order of magnitude faster now. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- drivers/gpu/drm/qxl/qxl_fb.c | 275 +++++++++---------------------------------- 1 file changed, 57 insertions(+), 218 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c index f778c0e..6b6e57e 100644 --- a/drivers/gpu/drm/qxl/qxl_fb.c +++ b/drivers/gpu/drm/qxl/qxl_fb.c @@ -37,21 +37,6 @@ #define QXL_DIRTY_DELAY (HZ / 30) -#define QXL_FB_OP_FILLRECT 1 -#define QXL_FB_OP_COPYAREA 2 -#define QXL_FB_OP_IMAGEBLIT 3 - -struct qxl_fb_op { - struct list_head head; - int op_type; - union { - struct fb_fillrect fr; - struct fb_copyarea ca; - struct fb_image ib; - } op; - void *img_data; -}; - struct qxl_fbdev { struct drm_fb_helper helper; struct qxl_framebuffer qfb; @@ -66,7 +51,6 @@ struct qxl_fbdev { /* dirty memory logging */ struct { spinlock_t lock; - bool active; unsigned x1; unsigned y1; unsigned x2; @@ -105,23 +89,33 @@ static void qxl_fb_dirty_flush(struct fb_info *info) struct qxl_device *qdev = qfbdev->qdev; struct qxl_fb_image qxl_fb_image; struct fb_image *image = &qxl_fb_image.fb_image; + unsigned long flags; u32 x1, x2, y1, y2; /* TODO: hard coding 32 bpp */ int stride = qfbdev->qfb.base.pitches[0]; + spin_lock_irqsave(&qfbdev->dirty.lock, flags); + x1 = qfbdev->dirty.x1; x2 = qfbdev->dirty.x2; y1 = qfbdev->dirty.y1; y2 = qfbdev->dirty.y2; + qfbdev->dirty.x1 = 0; + qfbdev->dirty.x2 = 0; + qfbdev->dirty.y1 = 0; + qfbdev->dirty.y2 = 0; + + spin_unlock_irqrestore(&qfbdev->dirty.lock, flags); + /* * we are using a shadow draw buffer, at qdev->surface0_shadow */ qxl_io_log(qdev, "dirty x[%d, %d], y[%d, %d]", x1, x2, y1, y2); image->dx = x1; image->dy = y1; - image->width = x2 - x1; - image->height = y2 - y1; + image->width = x2 - x1 + 1; + image->height = y2 - y1 + 1; image->fg_color = 0xffffffff; /* unused, just to avoid uninitialized warnings */ image->bg_color = 0; @@ -136,10 +130,37 @@ static void qxl_fb_dirty_flush(struct fb_info *info) qxl_fb_image_init(&qxl_fb_image, qdev, info, NULL); qxl_draw_opaque_fb(&qxl_fb_image, stride); - qfbdev->dirty.x1 = 0; - qfbdev->dirty.x2 = 0; - qfbdev->dirty.y1 = 0; - qfbdev->dirty.y2 = 0; +} + +static void qxl_dirty_update(struct qxl_fbdev *qfbdev, + int x, int y, int width, int height) +{ + struct qxl_device *qdev = qfbdev->qdev; + unsigned long flags; + int x2, y2; + + x2 = x + width - 1; + y2 = y + height - 1; + + spin_lock_irqsave(&qfbdev->dirty.lock, flags); + + if (qfbdev->dirty.y1 < y) + y = qfbdev->dirty.y1; + if (qfbdev->dirty.y2 > y2) + y2 = qfbdev->dirty.y2; + if (qfbdev->dirty.x1 < x) + x = qfbdev->dirty.x1; + if (qfbdev->dirty.x2 > x2) + x2 = qfbdev->dirty.x2; + + qfbdev->dirty.x1 = x; + qfbdev->dirty.x2 = x2; + qfbdev->dirty.y1 = y; + qfbdev->dirty.y2 = y2; + + spin_unlock_irqrestore(&qfbdev->dirty.lock, flags); + + schedule_work(&qdev->fb_work); } static void qxl_deferred_io(struct fb_info *info, @@ -162,234 +183,51 @@ static void qxl_deferred_io(struct fb_info *info, if (min < max) { y1 = min / info->fix.line_length; y2 = (max / info->fix.line_length) + 1; - - /* TODO: add spin lock? */ - /* spin_lock_irqsave(&qfbdev->dirty.lock, flags); */ - qfbdev->dirty.x1 = 0; - qfbdev->dirty.y1 = y1; - qfbdev->dirty.x2 = info->var.xres; - qfbdev->dirty.y2 = y2; - /* spin_unlock_irqrestore(&qfbdev->dirty.lock, flags); */ + qxl_dirty_update(qfbdev, 0, y1, info->var.xres, y2 - y1); } - - qxl_fb_dirty_flush(info); }; - static struct fb_deferred_io qxl_defio = { .delay = QXL_DIRTY_DELAY, .deferred_io = qxl_deferred_io, }; -static void qxl_fb_delayed_fillrect(struct qxl_fbdev *qfbdev, - const struct fb_fillrect *fb_rect) -{ - struct qxl_fb_op *op; - unsigned long flags; - - op = kmalloc(sizeof(struct qxl_fb_op), GFP_ATOMIC | __GFP_NOWARN); - if (!op) - return; - - op->op.fr = *fb_rect; - op->img_data = NULL; - op->op_type = QXL_FB_OP_FILLRECT; - - spin_lock_irqsave(&qfbdev->delayed_ops_lock, flags); - list_add_tail(&op->head, &qfbdev->delayed_ops); - spin_unlock_irqrestore(&qfbdev->delayed_ops_lock, flags); -} - -static void qxl_fb_delayed_copyarea(struct qxl_fbdev *qfbdev, - const struct fb_copyarea *fb_copy) -{ - struct qxl_fb_op *op; - unsigned long flags; - - op = kmalloc(sizeof(struct qxl_fb_op), GFP_ATOMIC | __GFP_NOWARN); - if (!op) - return; - - op->op.ca = *fb_copy; - op->img_data = NULL; - op->op_type = QXL_FB_OP_COPYAREA; - - spin_lock_irqsave(&qfbdev->delayed_ops_lock, flags); - list_add_tail(&op->head, &qfbdev->delayed_ops); - spin_unlock_irqrestore(&qfbdev->delayed_ops_lock, flags); -} - -static void qxl_fb_delayed_imageblit(struct qxl_fbdev *qfbdev, - const struct fb_image *fb_image) -{ - struct qxl_fb_op *op; - unsigned long flags; - uint32_t size = fb_image->width * fb_image->height * (fb_image->depth >= 8 ? fb_image->depth / 8 : 1); - - op = kmalloc(sizeof(struct qxl_fb_op) + size, GFP_ATOMIC | __GFP_NOWARN); - if (!op) - return; - - op->op.ib = *fb_image; - op->img_data = (void *)(op + 1); - op->op_type = QXL_FB_OP_IMAGEBLIT; - - memcpy(op->img_data, fb_image->data, size); - - op->op.ib.data = op->img_data; - spin_lock_irqsave(&qfbdev->delayed_ops_lock, flags); - list_add_tail(&op->head, &qfbdev->delayed_ops); - spin_unlock_irqrestore(&qfbdev->delayed_ops_lock, flags); -} - -static void qxl_fb_fillrect_internal(struct fb_info *info, - const struct fb_fillrect *fb_rect) -{ - struct qxl_fbdev *qfbdev = info->par; - struct qxl_device *qdev = qfbdev->qdev; - struct qxl_rect rect; - uint32_t color; - int x = fb_rect->dx; - int y = fb_rect->dy; - int width = fb_rect->width; - int height = fb_rect->height; - uint16_t rop; - struct qxl_draw_fill qxl_draw_fill_rec; - - if (info->fix.visual == FB_VISUAL_TRUECOLOR || - info->fix.visual == FB_VISUAL_DIRECTCOLOR) - color = ((u32 *) (info->pseudo_palette))[fb_rect->color]; - else - color = fb_rect->color; - rect.left = x; - rect.right = x + width; - rect.top = y; - rect.bottom = y + height; - switch (fb_rect->rop) { - case ROP_XOR: - rop = SPICE_ROPD_OP_XOR; - break; - case ROP_COPY: - rop = SPICE_ROPD_OP_PUT; - break; - default: - pr_err("qxl_fb_fillrect(): unknown rop, " - "defaulting to SPICE_ROPD_OP_PUT\n"); - rop = SPICE_ROPD_OP_PUT; - } - qxl_draw_fill_rec.qdev = qdev; - qxl_draw_fill_rec.rect = rect; - qxl_draw_fill_rec.color = color; - qxl_draw_fill_rec.rop = rop; - - qxl_draw_fill(&qxl_draw_fill_rec); -} - static void qxl_fb_fillrect(struct fb_info *info, - const struct fb_fillrect *fb_rect) + const struct fb_fillrect *rect) { struct qxl_fbdev *qfbdev = info->par; - struct qxl_device *qdev = qfbdev->qdev; - if (!drm_can_sleep()) { - qxl_fb_delayed_fillrect(qfbdev, fb_rect); - schedule_work(&qdev->fb_work); - return; - } - /* make sure any previous work is done */ - flush_work(&qdev->fb_work); - qxl_fb_fillrect_internal(info, fb_rect); -} - -static void qxl_fb_copyarea_internal(struct fb_info *info, - const struct fb_copyarea *region) -{ - struct qxl_fbdev *qfbdev = info->par; - - qxl_draw_copyarea(qfbdev->qdev, - region->width, region->height, - region->sx, region->sy, - region->dx, region->dy); + sys_fillrect(info, rect); + qxl_dirty_update(qfbdev, rect->dx, rect->dy, rect->width, + rect->height); } static void qxl_fb_copyarea(struct fb_info *info, - const struct fb_copyarea *region) + const struct fb_copyarea *area) { struct qxl_fbdev *qfbdev = info->par; - struct qxl_device *qdev = qfbdev->qdev; - if (!drm_can_sleep()) { - qxl_fb_delayed_copyarea(qfbdev, region); - schedule_work(&qdev->fb_work); - return; - } - /* make sure any previous work is done */ - flush_work(&qdev->fb_work); - qxl_fb_copyarea_internal(info, region); -} - -static void qxl_fb_imageblit_safe(struct qxl_fb_image *qxl_fb_image) -{ - qxl_draw_opaque_fb(qxl_fb_image, 0); -} - -static void qxl_fb_imageblit_internal(struct fb_info *info, - const struct fb_image *image) -{ - struct qxl_fbdev *qfbdev = info->par; - struct qxl_fb_image qxl_fb_image; - - /* ensure proper order rendering operations - TODO: must do this - * for everything. */ - qxl_fb_image_init(&qxl_fb_image, qfbdev->qdev, info, image); - qxl_fb_imageblit_safe(&qxl_fb_image); + sys_copyarea(info, area); + qxl_dirty_update(qfbdev, area->dx, area->dy, area->width, + area->height); } static void qxl_fb_imageblit(struct fb_info *info, const struct fb_image *image) { struct qxl_fbdev *qfbdev = info->par; - struct qxl_device *qdev = qfbdev->qdev; - if (!drm_can_sleep()) { - qxl_fb_delayed_imageblit(qfbdev, image); - schedule_work(&qdev->fb_work); - return; - } - /* make sure any previous work is done */ - flush_work(&qdev->fb_work); - qxl_fb_imageblit_internal(info, image); + sys_imageblit(info, image); + qxl_dirty_update(qfbdev, image->dx, image->dy, image->width, + image->height); } static void qxl_fb_work(struct work_struct *work) { struct qxl_device *qdev = container_of(work, struct qxl_device, fb_work); - unsigned long flags; - struct qxl_fb_op *entry, *tmp; struct qxl_fbdev *qfbdev = qdev->mode_info.qfbdev; - /* since the irq context just adds entries to the end of the - list dropping the lock should be fine, as entry isn't modified - in the operation code */ - spin_lock_irqsave(&qfbdev->delayed_ops_lock, flags); - list_for_each_entry_safe(entry, tmp, &qfbdev->delayed_ops, head) { - spin_unlock_irqrestore(&qfbdev->delayed_ops_lock, flags); - switch (entry->op_type) { - case QXL_FB_OP_FILLRECT: - qxl_fb_fillrect_internal(qfbdev->helper.fbdev, &entry->op.fr); - break; - case QXL_FB_OP_COPYAREA: - qxl_fb_copyarea_internal(qfbdev->helper.fbdev, &entry->op.ca); - break; - case QXL_FB_OP_IMAGEBLIT: - qxl_fb_imageblit_internal(qfbdev->helper.fbdev, &entry->op.ib); - break; - } - spin_lock_irqsave(&qfbdev->delayed_ops_lock, flags); - list_del(&entry->head); - kfree(entry); - } - spin_unlock_irqrestore(&qfbdev->delayed_ops_lock, flags); + qxl_fb_dirty_flush(qfbdev->helper.fbdev); } int qxl_fb_init(struct qxl_device *qdev) @@ -678,6 +516,7 @@ int qxl_fbdev_init(struct qxl_device *qdev) qfbdev->qdev = qdev; qdev->mode_info.qfbdev = qfbdev; spin_lock_init(&qfbdev->delayed_ops_lock); + spin_lock_init(&qfbdev->dirty.lock); INIT_LIST_HEAD(&qfbdev->delayed_ops); drm_fb_helper_prepare(qdev->ddev, &qfbdev->helper, -- 1.8.3.1 [View Less]

2 1

[Bug 89203] Mesa 10.4.3 and up causes stuttering and frame drops in a particular game
by bugzilla-daemon＠freedesktop.org 07 May '15

07 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=89203 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Michel Dänzer <michel(a)daenzer.net> --- Glad to hear it's working better now! -- You are receiving this mail because: … [View More]

1 0

[ANNOUNCE] libdrm 2.4.61
by Dave Airlie 07 May '15

07 May '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Release to fix regression in nouveau in 2.4.60, but brings lots of android changes and other fixes. Ben Skeggs (2): nouveau: restore check that avoids multiple user bos per kernel bo configure.ac: bump version to 2.4.61 for release Chih-Wei Huang (3): android: simplify the including rule of subdirs android: get rid of LIBDRM_TOP android: remove unnecessary TARGET_OUT_HEADERS variable Chris Wilson (2): mode: … [View More]Retrieve only the current information for a Connector intel: Delay testing for userptr until first use Connor Behan (1): xf86drm: Fix ioctl struct clearing in drmAgpEnable Damien Lespiau (3): RELEASING: Fix releasing instructions to match the latest release.sh RELEASING: Fix the step numbering RELEASING: Fix annouce typo Daniel Kurtz (3): proptest: install it with --enable-install-test-programs tests: add rockchip to modetest, kmstest, vbltest and proptest xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic Emil Velikov (39): android: correcly set LOCAL_EXPORT_C_INCLUDE_DIRS android: simplify LOCAL_C_INCLUDES android: remove ${srcdir} from the includes android: remove LOCAL_COPY_HEADERS* variables android: add the missing tag "optional" to libkms autotools: remove ${srcdir} from the includes android: remove explicit include to libpciaccess tests/hash: extract test out of xf86drmHash.c tests/hash: misc compilation fixes tests/hash: style fixes tests/hash: return non-zero on failure tests/random: extract test out of xf86drmRandom.c tests/random: return non-zero on test failure drm: replace HASH_DEBUG with DEBUG drm: use correct printf modifiers configure.ac: split -fvisibility and __attribute__((visibility)) checks radeon: move bof.[ch] out of libdrm_radeon radeon: add symbols test freedreno: annotate the private symbols freedreno: add symbols test intel: remove the drm_mm* symbol workarounds intel: remove unused mmFindBlock intel: annotate the private symbols intel: add symbols test nouveau: annotate the private symbols nouveau: add symbols test libkms: annotate private symbols libkms: add symbols test exynos: add symbols test omap: add symbols test tegra: add symbols test drm: rename libdrm{,_macros}.h drm: remove no longer needed VISIBILITY_CFLAGS drm: remove drm_public macro configure: request/set the compiler in C99 mode drm: use c99 __func__ over __FUNCTION__ man: rework the Makefile.am android: set the HAVE_VISIBILITY define freedreno: link against CLOCK_LIB Greg Hackmann (1): Add missing <strings.h> includes Jan Vesely (5): Fix unused function warnings Remove drmSetDebugMsgFunction and related infrastructure tests/exynos: Fix missing static keyword drmSL: Fix neighbor lookup tests/drmsl: Extract tests out of xf86drmSL.c Joonyoung Shim (6): modetest: fix Segmentation fault modetest: make use of drmModeRmFB modetest: fix the error path handling modetest: clear buffer and framebuffer for planes modetest: destroy the cursor bo modetest: fix the arguments of the MAKE_RGB_INFO define Neil Roberts (1): intel: Merge latest i915_drm.h Rob Clark (2): modeprint: add missing encoder/connector type names modetest: fix allocation for yuv420/yvu420 Tobias Jakobi (1): modetest: initialize handles/pitches in set_plane() Tvrtko Ursulin (1): intel: Leak the userptr test bo git tag: libdrm-2.4.61 http://dri.freedesktop.org/libdrm/libdrm-2.4.61.tar.bz2 MD5: c3d31138d63e0edde3f5b93cd88fb93a libdrm-2.4.61.tar.bz2 SHA1: fce70371540af0490541b05d96c6b6b43f1fab80 libdrm-2.4.61.tar.bz2 SHA256: 8b549092c8961a393a7e1d9a1bccddcea8e2af67c0d7d7c67babb9fc3b47699c libdrm-2.4.61.tar.bz2 PGP: http://dri.freedesktop.org/libdrm/libdrm-2.4.61.tar.bz2.sig http://dri.freedesktop.org/libdrm/libdrm-2.4.61.tar.gz MD5: a77a37370f6f8e17f5c4fe40b1b98782 libdrm-2.4.61.tar.gz SHA1: 25b2225197c714549f95fdde6ba24406645549bd libdrm-2.4.61.tar.gz SHA256: cfc768c22bd2bf6a8ee20c97ae3f85733e6cad6bc28c023f163312604204fcd6 libdrm-2.4.61.tar.gz PGP: http://dri.freedesktop.org/libdrm/libdrm-2.4.61.tar.gz.sig -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVSsKcAAoJEMUGCSafkIbkbbIP/3a8bREUNcgRD0nI2HM0G8dZ 7KYnVV4cXUCQGnIoD3GA47PIsBOlXGwC5y7e1fRJby9fI5em3RYa+j+dqWm7CsHW Fl7Kk300miJ45tkHH8sVGzrGqnJ1Dj4sm8YXmwQ6Dzo8f504DIMjwGBqxrBldNpr UO/lXA0lK9gg764Me17W3vb5R5vfNiCQmzl3OOUhZb8aMwXXt8nv0EivZ3QJGhn8 FrdF1zgRH6A/h901AkHKAEglVGNY5AaHee3f0H9i0usedt0LOAp+2ilu0VhIjbin s3bov2ThCUBgz3HBgmN9/qjZJ00SsPYOqnrPt1sfaqS3gPBVsz4mJYhNM27ZHXfn kLBv9DWIa2sQO5r+Cl5OGJX9yXqQUlOP4C+k9VYTO8S5PFqnvoIsQ9caa61Dfzdm WYaGrODR36JehSo5WQYGSs6P5xlNjZtxL5sBt8kIH8b8yehZV8dTVibD7utO0cVZ GueOdUwWpI5/0GyYll1qePdXOdUeZxToNhQYI21VkaP/jkjvZhKvJaUT+MoibtO2 AZq1BXdN4OisqHyBx/MbnThFlxoNIsxxGRChrk0VbD8OH02BG6Lhvf8VQ627RFm1 yrqPBPd8wAhX8PWUA0SpGivaaEu8+N7ankgbZAGBmvNpLbW7myNBV6PwCgAQ5NVX V8XNITbmyzF/Vq5qqfi3 =TxEZ -----END PGP SIGNATURE----- [View Less]

1 0

[Bug 89203] Mesa 10.4.3 and up causes stuttering and frame drops in a particular game
by bugzilla-daemon＠freedesktop.org 06 May '15

06 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=89203 --- Comment #9 from andre35822(a)yahoo.com --- The issue seems to no longer occur on Mesa 10.5.4, I am also on kernel 4.0 (I dont remember if it did not occur on Mesa 10.5.4 with kernel 3.19) I guess this is solved? I don't know what was done to solve it but the stuttering no longer occurs and FPS has increased by 10-20FPS. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 97561] New: Regression: Issue with ATI HD 6570 (possibly others) HDMI output Purple Line
by bugzilla-daemon＠bugzilla.kernel.org 06 May '15

06 May '15

https://bugzilla.kernel.org/show_bug.cgi?id=97561 Bug ID: 97561 Summary: Regression: Issue with ATI HD 6570 (possibly others) HDMI output Purple Line Product: Drivers Version: 2.5 Kernel Version: 4.0 and above Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: … [View More]

1 9

[Bug 25898] glEvalPoint causes glEnd to throw GL_INVALID_OPERATION
by bugzilla-daemon＠freedesktop.org 06 May '15

06 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=25898 marius predut <marius.predut(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dri-devel(a)lists.freedesktop |marius.predut(a)intel.com |.org | -- You are receiving this mail because: You are the assignee for the bug.

1 0

component_unbind_all() splat..
by Rob Clark 06 May '15

06 May '15

Hey Russell, I just noticed a splat triggered by component_unbind_all() called from ->bind().. any opinions about whether component stuff should handle that case, or whether I should rearrange my error cleanup path to not component_unbind_all() in this case? [ 2.329829] msm 1a00000.qcom,mdss_mdp: failed to allocate VRAM [ 2.334027] ------------[ cut here ]------------ [ 2.339754] WARNING: CPU: 1 PID: 1 at ../drivers/base/component.c:356 component_unbind.isra.2+0x5c/0x68() [ 2.… [View More]344536] Modules linked in: [ 2.356918] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.0.0-dirty #5 [ 2.356996] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) [ 2.363420] Call trace: [ 2.370110] [<ffffffc000089c78>] dump_backtrace+0x0/0x118 [ 2.372276] [<ffffffc000089da0>] show_stack+0x10/0x20 [ 2.377840] [<ffffffc0006686bc>] dump_stack+0x84/0xc4 [ 2.382865] [<ffffffc0000b1afc>] warn_slowpath_common+0x94/0xd0 [ 2.387910] [<ffffffc0000b1bdc>] warn_slowpath_null+0x14/0x20 [ 2.393631] [<ffffffc00042a450>] component_unbind.isra.2+0x58/0x68 [ 2.399543] [<ffffffc00042a4e4>] component_unbind_all+0x84/0xc0 [ 2.405619] [<ffffffc000419c70>] msm_unload+0x118/0x1a0 [ 2.411425] [<ffffffc00041a2f8>] msm_load+0xe0/0x3b8 [ 2.416643] [<ffffffc0003e6a00>] drm_dev_register+0xb8/0x110 [ 2.421843] [<ffffffc0003e8c5c>] drm_platform_init+0x44/0xe0 [ 2.427493] [<ffffffc000419490>] msm_drm_bind+0x18/0x28 [ 2.433125] [<ffffffc00042a160>] try_to_bring_up_master.part.1+0xc0/0x108 [ 2.438087] [<ffffffc00042a258>] component_master_add_with_match+0xb0/0x138 [ 2.445031] [<ffffffc000419eb4>] msm_pdev_probe+0x64/0x78 [ 2.451791] [<ffffffc000430c68>] platform_drv_probe+0x48/0xb8 [ 2.457355] [<ffffffc00042f0ec>] driver_probe_device+0x8c/0x248 [ 2.463074] [<ffffffc00042f398>] __driver_attach+0x98/0xa0 [ 2.468811] [<ffffffc00042d52c>] bus_for_each_dev+0x5c/0xa0 [ 2.474366] [<ffffffc00042ec04>] driver_attach+0x1c/0x28 [ 2.479826] [<ffffffc00042e864>] bus_add_driver+0x14c/0x208 [ 2.485390] [<ffffffc00042fa2c>] driver_register+0x5c/0x120 [ 2.490679] [<ffffffc000430b98>] __platform_driver_register+0x58/0x68 [ 2.496246] [<ffffffc000a4b268>] msm_drm_register+0x48/0x54 [ 2.502831] [<ffffffc0000828e0>] do_one_initcall+0x88/0x1a8 [ 2.508223] [<ffffffc000a2dac4>] kernel_init_freeable+0x144/0x1ec [ 2.513769] [<ffffffc0006663ac>] kernel_init+0xc/0xe0 [ 2.520034] ---[ end trace 7e1590a270796f2f ]--- [ 2.525063] Unable to handle kernel NULL pointer dereference at virtual address 00000028 [View Less]

2 3

[PATCH 1/2 linux-next] drm/msm: use IS_ERR() to check msm_ioremap() return
by Fabian Frederick 06 May '15

06 May '15

msm_ioremap() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick <fabf(a)skynet.be> --- drivers/gpu/drm/msm/dsi/dsi_phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_phy.c b/drivers/gpu/drm/msm/dsi/dsi_phy.c index f0cea89..61af193 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/dsi_phy.c @@ -300,12 +300,12 @@ struct msm_dsi_phy *msm_dsi_phy_init(struct … [View More]

1 2

[PATCH v4 00/10] HDMI CEC framework
by Kamil Debski 06 May '15

06 May '15

Hi, This is the fourth version of the HDMI CEC framework. I would like to thank for all the comments and suggestions to the previous versions of this patch. I believe that the code has matured enough to be tagged as PATCH and not RFC as in previous version. This patchset is base on the linux-next tree. I believe that there will be some comments to it and there will be some things to fix, hence I am sending this version now. The next version with appropriate fixes will be based on the next RC (… [View More]which I guess will be released soon). The promiscuous mode included in the previous version caused some discussion and I decided to drop it. In my opinion it can be useful for debugging, but on the other hand I believe it can be easily added at a later time, if appropriate. Best wishes, Kamil Debski Changes since v3 ================ - remove the promiscuous mode - rewrite the devicetree patches - fixes, expansion and partial rewrite of the documentation - reorder of API structures and addition of reserved fields - use own struct to report time (32/64 bit safe) - fix of handling events - add cec.h to include/uapi/linux/Kbuild - fixes in the adv76xx driver (add missing methods, change adv7604 to adv76xx) - cleanup of debug messages in s5p-cec driver - remove non necessary claiming of a gpio in the s5p-cec driver - cleanup headers of the s5p-cec driver Changes since v2 ===============- - added promiscuous mode - added new key codes to the input framework - add vendor ID reporting - add the possibility to clear assigned logical addresses - cleanup of the rc cec map Changes since v1 ================ - documentation edited and moved to the Documentation folder - added key up/down message handling - add missing CEC commands to the cec.h file Original cover letter ===================== Hi, The work on a common CEC framework was started over three years ago by Hans Verkuil. Unfortunately the work has stalled. As I have received the task of creating a driver for the CEC interface module present on the Exynos range of SoCs, I got in touch with Hans. He replied that the work stalled due to his lack of time. The driver was done in the most part and there were only minor fixes that needed to be implemented. I would like to bring back the discussion on a common CEC interface framework. There are a few things that were still left as TODO, I think they might need some discussion - for instance the way how the remote controls should be handled. Best wishes, Kamil Debski Original RFC by Hans Verkuil/Martin Bugge ========================================= https://www.mail-archive.com/linux-media@vger.kernel.org/msg28735.html Hans Verkuil (4): cec: add HDMI CEC framework v4l2-subdev: add HDMI CEC ops cec: adv7604: add cec support. cec: adv7511: add cec support. Kamil Debski (6): dts: exynos4*: add HDMI CEC pin definition to pinctrl dts: exynos4: add node for the HDMI CEC device dts: exynos4412-odroid*: enable the HDMI CEC device HID: add HDMI CEC specific keycodes rc: Add HDMI CEC protoctol handling cec: s5p-cec: Add s5p-cec driver Documentation/cec.txt | 396 +++++++ .../devicetree/bindings/media/s5p-cec.txt | 33 + arch/arm/boot/dts/exynos4.dtsi | 12 + arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 + arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 7 + drivers/media/Kconfig | 6 + drivers/media/Makefile | 2 + drivers/media/cec.c | 1161 ++++++++++++++++++++ drivers/media/i2c/adv7511.c | 347 +++++- drivers/media/i2c/adv7604.c | 207 +++- drivers/media/platform/Kconfig | 10 + drivers/media/platform/Makefile | 1 + drivers/media/platform/s5p-cec/Makefile | 4 + drivers/media/platform/s5p-cec/exynos_hdmi_cec.h | 37 + .../media/platform/s5p-cec/exynos_hdmi_cecctrl.c | 208 ++++ drivers/media/platform/s5p-cec/regs-cec.h | 96 ++ drivers/media/platform/s5p-cec/s5p_cec.c | 283 +++++ drivers/media/platform/s5p-cec/s5p_cec.h | 76 ++ drivers/media/rc/keymaps/Makefile | 1 + drivers/media/rc/keymaps/rc-cec.c | 144 +++ drivers/media/rc/rc-main.c | 1 + include/media/adv7511.h | 6 +- include/media/cec.h | 140 +++ include/media/rc-core.h | 1 + include/media/rc-map.h | 5 +- include/media/v4l2-subdev.h | 8 + include/uapi/linux/Kbuild | 1 + include/uapi/linux/cec.h | 303 +++++ include/uapi/linux/input.h | 12 + 30 files changed, 3507 insertions(+), 12 deletions(-) create mode 100644 Documentation/cec.txt create mode 100644 Documentation/devicetree/bindings/media/s5p-cec.txt create mode 100644 drivers/media/cec.c create mode 100644 drivers/media/platform/s5p-cec/Makefile create mode 100644 drivers/media/platform/s5p-cec/exynos_hdmi_cec.h create mode 100644 drivers/media/platform/s5p-cec/exynos_hdmi_cecctrl.c create mode 100644 drivers/media/platform/s5p-cec/regs-cec.h create mode 100644 drivers/media/platform/s5p-cec/s5p_cec.c create mode 100644 drivers/media/platform/s5p-cec/s5p_cec.h create mode 100644 drivers/media/rc/keymaps/rc-cec.c create mode 100644 include/media/cec.h create mode 100644 include/uapi/linux/cec.h -- 1.7.9.5 [View Less]

4 26

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2015