dri-devel May 2015

dri-devel@lists.freedesktop.org

191 participants
1132 discussions

[PATCH 1/3] drm/edid: Fix up DMT modes
by ville.syrjala＠linux.intel.com 06 May '15

06 May '15

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Liu Lei noticed that our 1856x1392@75Hz DMT mode doesn't match the spec. Fix that up, and also fix up a few other inconsistencies I discovered by parsing the spec (DMT version 1.0, revision 13) and comparing the results to our current DMT mode table. Also clean up the indentation mess for the 1024x768i mode. Cc: "liu,lei" <lei.a.liu(a)intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/gpu/drm/drm_edid.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 53bc7a6..567c7ed 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -160,7 +160,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 640x480@60Hz */ { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 25175, 640, 656, - 752, 800, 0, 480, 489, 492, 525, 0, + 752, 800, 0, 480, 490, 492, 525, 0, DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) }, /* 640x480@72Hz */ { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 31500, 640, 664, @@ -206,7 +206,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { { DRM_MODE("1024x768i", DRM_MODE_TYPE_DRIVER, 44900, 1024, 1032, 1208, 1264, 0, 768, 768, 772, 817, 0, DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC | - DRM_MODE_FLAG_INTERLACE) }, + DRM_MODE_FLAG_INTERLACE) }, /* 1024x768@60Hz */ { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 65000, 1024, 1048, 1184, 1344, 0, 768, 771, 777, 806, 0, @@ -242,7 +242,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { /* 1280x768@75Hz */ { DRM_MODE("1280x768", DRM_MODE_TYPE_DRIVER, 102250, 1280, 1360, 1488, 1696, 0, 768, 771, 778, 805, 0, - DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) }, + DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1280x768@85Hz */ { DRM_MODE("1280x768", DRM_MODE_TYPE_DRIVER, 117500, 1280, 1360, 1496, 1712, 0, 768, 771, 778, 809, 0, @@ -258,7 +258,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { /* 1280x800@60Hz */ { DRM_MODE("1280x800", DRM_MODE_TYPE_DRIVER, 83500, 1280, 1352, 1480, 1680, 0, 800, 803, 809, 831, 0, - DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) }, + DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1280x800@75Hz */ { DRM_MODE("1280x800", DRM_MODE_TYPE_DRIVER, 106500, 1280, 1360, 1488, 1696, 0, 800, 803, 809, 838, 0, @@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1856x1392@75Hz */ { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984, - 2208, 2560, 0, 1392, 1395, 1399, 1500, 0, + 2208, 2560, 0, 1392, 1393, 1396, 1500, 0, DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1856x1392@120Hz RB */ { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904, -- 2.0.5

4 5

[Bug 15006] translate & rotate the line cause Aliasing
by bugzilla-daemon＠freedesktop.org 06 May '15

06 May '15

https://bugs.freedesktop.org/show_bug.cgi?id=15006 marius predut <marius.predut(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nanhai.zou(a)intel.com |marius.predut(a)intel.com --- Comment #5 from marius predut <marius.predut(a)intel.com> --- The patch series that fix this bug are upstream -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[PATCH v2] modetest: only select plane with matching format
by Tobias Jakobi 06 May '15

06 May '15

Don't assume that a plane supports any kind of pixelformat but do a check first. v2: Simplify the format check. Signed-off-by: Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> --- tests/modetest/modetest.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 7f0c1cc..29d4c34 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -969,6 +969,18 @@ page_flip_handler(int fd, unsigned int frame, } } +static bool format_support(const drmModePlanePtr ovr, uint32_t fmt) +{ + unsigned int i; + + for (i = 0; i < ovr->count_formats; ++i) { + if (ovr->formats[i] == fmt) + return true; + } + + return false; +} + static int set_plane(struct device *dev, struct plane_arg *p) { drmModePlane *ovr; @@ -999,7 +1011,7 @@ static int set_plane(struct device *dev, struct plane_arg *p) for (i = 0; i < dev->resources->plane_res->count_planes && !plane_id; i++) { ovr = dev->resources->planes[i].plane; - if (!ovr) + if (!ovr || !format_support(ovr, p->fourcc)) continue; if ((ovr->possible_crtcs & (1 << pipe)) && !ovr->crtc_id) -- 2.0.5

1 0

Re: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface
by Emil Velikov 06 May '15

06 May '15

Hi Kamil, It seems that you've only incorporated the libgencec.pc suggestion. Did you change your mind about the others, found out something funny with them (if so can you let me know what) or simply forgot about them ? On 30 April 2015 at 11:25, Kamil Debski <k.debski(a)samsung.com> wrote: > Hi Emil, > > From: linux-media-owner(a)vger.kernel.org [mailto:linux-media- > owner(a)vger.kernel.org] On Behalf Of Emil Velikov > Sent: Wednesday, April 29, 2015 5:00 PM >> >> Hi Kamil, >> >> Allow me to put a few suggestions: >> >> On 29 April 2015 at 11:02, Kamil Debski <k.debski(a)samsung.com> wrote: >> > diff --git a/m4/.gitkeep b/m4/.gitkeep new file mode 100644 index >> > 0000000..e69de29 >> Haven't seen any projects doing this. Curious what the benefits of >> keeping and empty folder might be ? > > When I run autoreconf -i it complained about missing m4 folder, hence I added > this filler file such that the folder is created. Any suggestion on how to do > this better? > Ahh yes - that lovely message. It turns out that older versions of automake will even error out [1], rather than just printing out a warning. A handy workaround would be to add a .gitignore (and a second one in the top folder) list. Plus it will slim down the untracked files list and let you clearly see when git add was missed :-) Cheers Emil [1] https://bugzilla.redhat.com/show_bug.cgi?id=901333

2 1

[PATCH 1/2] modetest: make middle SMPTE colors transparent
by Tobias Jakobi 06 May '15

06 May '15

This enables us to check for overlay planes which are located 'below' the primary plane. Since the alpha value only has an effect when creating surfaces with an alpha-pixelformat this doesn't affect the regular XRGB8888 primary surface. Signed-off-by: Tobias Jakobi <tjakobi(a)math.uni-bielefeld.de> --- tests/modetest/buffers.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tests/modetest/buffers.c b/tests/modetest/buffers.c index 7e214e8..30ac033 100644 --- a/tests/modetest/buffers.c +++ b/tests/modetest/buffers.c @@ -423,13 +423,13 @@ fill_smpte_rgb16(const struct rgb_info *rgb, unsigned char *mem, MAKE_RGBA(rgb, 0, 0, 192, 255), /* blue */ }; const uint16_t colors_middle[] = { - MAKE_RGBA(rgb, 0, 0, 192, 255), /* blue */ - MAKE_RGBA(rgb, 19, 19, 19, 255), /* black */ - MAKE_RGBA(rgb, 192, 0, 192, 255), /* magenta */ - MAKE_RGBA(rgb, 19, 19, 19, 255), /* black */ - MAKE_RGBA(rgb, 0, 192, 192, 255), /* cyan */ - MAKE_RGBA(rgb, 19, 19, 19, 255), /* black */ - MAKE_RGBA(rgb, 192, 192, 192, 255), /* grey */ + MAKE_RGBA(rgb, 0, 0, 192, 127), /* blue */ + MAKE_RGBA(rgb, 19, 19, 19, 127), /* black */ + MAKE_RGBA(rgb, 192, 0, 192, 127), /* magenta */ + MAKE_RGBA(rgb, 19, 19, 19, 127), /* black */ + MAKE_RGBA(rgb, 0, 192, 192, 127), /* cyan */ + MAKE_RGBA(rgb, 19, 19, 19, 127), /* black */ + MAKE_RGBA(rgb, 192, 192, 192, 127), /* grey */ }; const uint16_t colors_bottom[] = { MAKE_RGBA(rgb, 0, 33, 76, 255), /* in-phase */ @@ -547,13 +547,13 @@ fill_smpte_rgb32(const struct rgb_info *rgb, unsigned char *mem, MAKE_RGBA(rgb, 0, 0, 192, 255), /* blue */ }; const uint32_t colors_middle[] = { - MAKE_RGBA(rgb, 0, 0, 192, 255), /* blue */ - MAKE_RGBA(rgb, 19, 19, 19, 255), /* black */ - MAKE_RGBA(rgb, 192, 0, 192, 255), /* magenta */ - MAKE_RGBA(rgb, 19, 19, 19, 255), /* black */ - MAKE_RGBA(rgb, 0, 192, 192, 255), /* cyan */ - MAKE_RGBA(rgb, 19, 19, 19, 255), /* black */ - MAKE_RGBA(rgb, 192, 192, 192, 255), /* grey */ + MAKE_RGBA(rgb, 0, 0, 192, 127), /* blue */ + MAKE_RGBA(rgb, 19, 19, 19, 127), /* black */ + MAKE_RGBA(rgb, 192, 0, 192, 127), /* magenta */ + MAKE_RGBA(rgb, 19, 19, 19, 127), /* black */ + MAKE_RGBA(rgb, 0, 192, 192, 127), /* cyan */ + MAKE_RGBA(rgb, 19, 19, 19, 127), /* black */ + MAKE_RGBA(rgb, 192, 192, 192, 127), /* grey */ }; const uint32_t colors_bottom[] = { MAKE_RGBA(rgb, 0, 33, 76, 255), /* in-phase */ -- 2.0.5

1 1

No HDMI Audio with Radeon HD7750 on Acube Sam460ex AMCC powerpc 460ex board
by Julian Margetson 06 May '15

06 May '15

With Kernel 3.19 HDMI audio works ok with Radeon HD 6670 but not Radeon HD 7750 on Acube Sam460ex AMCC powerpc 460ex board.Also a problem with direct firmware loading or the radeon firmware which loads ok for the Radeon HD 6670 . [ 2.561952] Linux agpgart interface v0.103 [ 2.566290] [drm] Initialized drm 1.1.0 20060810 [ 2.571164] [drm] radeon kernel modesetting enabled. [ 2.577230] [drm] initializing kernel modesetting (VERDE 0x1002:0x683F 0x1545:0x7750). [ 2.585379] [drm] register mmio base: 0xe90000000 [ 2.590143] [drm] register mmio size: 262144 [ 2.925520] ATOM BIOS: C44501 [ 2.928803] radeon 0001:81:00.0: VRAM: 1024M 0x0000000000000000 - 0x000000003FFFFFFF (1024M used) [ 2.937725] radeon 0001:81:00.0: GTT: 1024M 0x0000000040000000 - 0x000000007FFFFFFF [ 2.945401] [drm] Detected VRAM RAM=1024M, BAR=256M [ 2.950294] [drm] RAM width 128bits DDR [ 2.954331] [TTM] Zone kernel: Available graphics memory: 379212 kiB [ 2.960822] [TTM] Zone highmem: Available graphics memory: 1034572 kiB [ 2.967373] [TTM] Initializing pool allocator [ 2.971766] [TTM] Initializing DMA pool allocator [ 2.976604] [drm] radeon: 1024M of VRAM memory ready [ 2.981610] [drm] radeon: 1024M of GTT memory ready. [ 2.986651] [drm] Loading verde Microcode [ 2.990757] radeon 0001:81:00.0: Direct firmware load for radeon/verde_pfp.bin failed with error -2 [ 2.999908] radeon 0001:81:00.0: Direct firmware load for radeon/verde_me.bin failed with error -2 [ 3.008995] radeon 0001:81:00.0: Direct firmware load for radeon/verde_ce.bin failed with error -2 [ 3.018041] radeon 0001:81:00.0: Direct firmware load for radeon/verde_rlc.bin failed with error -2 [ 3.027184] radeon 0001:81:00.0: Direct firmware load for radeon/verde_mc.bin failed with error -2 [ 3.036203] [drm] radeon/VERDE_mc2.bin: 31500 bytes [ 3.041171] radeon 0001:81:00.0: Direct firmware load for radeon/verde_smc.bin failed with error -2 [ 3.050278] [drm] Internal thermal controller with fan control [ 3.056448] [drm] probing gen 2 caps for device aaa1:bed1 = 18cc41/0 [ 3.110566] [drm] radeon: dpm initialized [ 3.114788] [drm] GART: num cpu pages 262144, num gpu pages 262144 [ 3.126445] [drm] probing gen 2 caps for device aaa1:bed1 = 18cc41/0 [ 3.171357] [drm] PCIE GART of 1024M enabled (table at 0x0000000000277000). [ 3.178681] radeon 0001:81:00.0: WB enabled [ 3.182925] radeon 0001:81:00.0: fence driver on ring 0 use gpu addr 0x0000000040000c00 and cpu addr 0xffc01c00 [ 3.193045] radeon 0001:81:00.0: fence driver on ring 1 use gpu addr 0x0000000040000c04 and cpu addr 0xffc01c04 [ 3.203167] radeon 0001:81:00.0: fence driver on ring 2 use gpu addr 0x0000000040000c08 and cpu addr 0xffc01c08 [ 3.213287] radeon 0001:81:00.0: fence driver on ring 3 use gpu addr 0x0000000040000c0c and cpu addr 0xffc01c0c [ 3.223409] radeon 0001:81:00.0: fence driver on ring 4 use gpu addr 0x0000000040000c10 and cpu addr 0xffc01c10 [ 3.255059] radeon 0001:81:00.0: fence driver on ring 5 use gpu addr 0x0000000000075a18 and cpu addr 0xf90b5a18 [ 3.265199] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 3.271837] [drm] Driver supports precise vblank timestamp query. [ 3.277957] radeon 0001:81:00.0: radeon: MSI limited to 32-bit [ 3.283833] ppc4xx_setup_msi_irqs: fail allocating msi interrupt [ 3.289927] [drm] radeon: irq initialized. [ 4.047989] [drm:r600_ring_test] *ERROR* radeon: ring 0 test failed (scratch(0x850C)=0xCAFEDEAD) [ 4.056845] radeon 0001:81:00.0: disabling GPU acceleration [ 4.261053] [drm] Radeon Display Connectors [ 4.265626] [drm] Connector 0: [ 4.268744] [drm] HDMI-A-1 [ 4.271735] [drm] HPD4 [ 4.274313] [drm] DDC: 0x6570 0x6570 0x6574 0x6574 0x6578 0x6578 0x657c 0x657c [ 4.281755] [drm] Encoders: [ 4.284768] [drm] DFP1: INTERNAL_UNIPHY2 [ 4.289060] [drm] Connector 1: [ 4.292125] [drm] DVI-I-1 [ 4.294929] [drm] HPD2 [ 4.297476] [drm] DDC: 0x6560 0x6560 0x6564 0x6564 0x6568 0x6568 0x656c 0x656c [ 4.304894] [drm] Encoders: [ 4.307872] [drm] DFP2: INTERNAL_UNIPHY [ 4.312064] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [ 4.465445] [drm] fb mappable at 0x80478000 [ 4.469662] [drm] vram apper at 0x80000000 [ 4.473775] [drm] size 8294400 [ 4.476840] [drm] fb depth is 24 [ 4.480084] [drm] pitch is 7680 [ 4.759376] Console: switching to colour frame buffer device 240x67 [ 4.838736] radeon 0001:81:00.0: fb0: radeondrmfb frame buffer device [ 4.845560] radeon 0001:81:00.0: registered panic notifier [ 4.856007] [drm] Initialized radeon 2.40.0 20080528 for 0001:81:00.0 on minor 0 [ 31.335598] [drm:dce6_audio_get_pin] *ERROR* No connected audio pins found!

3 7

i915 dma_map_sg return value
by Volker Vogelhuber 06 May '15

06 May '15

The documentation of the DMA-API writes the following about dma_map_sg: "The implementation is free to merge several consecutive sglist entries into one (e.g. if DMA mapping is done with PAGE_SIZE granularity, any consecutive sglist entries can be merged into one provided the first one ends and the second one starts on a page boundary - in fact this is a huge advantage for cards which either cannot do scatter-gather or have very limited number of scatter-gather entries) and returns the actual number of sg entries it mapped them to." I wonder why the return value of dma_map_sg is not returned in any way from i915_gem_map_dma_buf. It only uses the return value for error checking. Can one be sure that in case of the i915 the nents value of the scatter gather table is always equal to the value returned by dma_map_sg? I'm asking because I want to use the sg table returned by i915_gem_map_dma_buf in my own kernel module and iterate over it using for_each_sg. And the example in the documentation of the DMA-API uses the return value of dma_map_sg when calling for_each_sg and not nents and it explicitly mentions: "Then you should loop count times (note: this can be less than nents times)" Regards, Volker

3 4

[PULL] topic/drm-misc
by Daniel Vetter 06 May '15

06 May '15

Hi Dave, rc2 is out, time to open drm-next. Bunch of drm_irq.c patches from Mario&me, magic/auth removal from David and a few other oddball things. Cheers, Daniel The following changes since commit 2b1193d5287004edfbf89407149a3159656f47f1: drm: fix trivial typo mistake (2015-04-14 12:41:03 +0200) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/topic/drm-misc-2015-05-06 for you to fetch changes up to 4a324d33bfe95a279d4c7370d84087d3e773e799: drm: simplify master cleanup (2015-05-05 09:46:38 +0200) ---------------------------------------------------------------- Daniel Vetter (3): drm/atomic-helper: Don't call atomic_update_plane when it stays off drm/vblank: Fixup and document timestamp update/read barriers drm/atomic-helper: Really recover pre-atomic plane/cursor behavior David Herrmann (3): drm: drop unused 'magicfree' list drm: simplify authentication management drm: simplify master cleanup Josef Holzmayr (1): DRM: Don't re-poll connector for disconnect Mario Kleiner (3): drm: Prevent invalid use of vblank_disable_immediate. (v2) drm: Zero out invalid vblank timestamp in drm_update_vblank_count. (v2) drm/qxl: Fix qxl_noop_get_vblank_counter() Oleg Drokin (1): drm: fix a memleak on mutex failure path Todd Previte (2): drm: Fix the 'native defer' message in drm_dp_i2c_do_msg() drm: Fix for DP CTS test 4.2.2.5 - I2C DEFER handling drivers/gpu/drm/drm_atomic_helper.c | 9 +- drivers/gpu/drm/drm_auth.c | 178 ++++++------------------------ drivers/gpu/drm/drm_dp_helper.c | 12 +- drivers/gpu/drm/drm_drv.c | 20 +--- drivers/gpu/drm/drm_fops.c | 7 +- drivers/gpu/drm/drm_internal.h | 1 - drivers/gpu/drm/drm_irq.c | 103 +++++++++-------- drivers/gpu/drm/drm_modeset_lock.c | 8 +- drivers/gpu/drm/drm_probe_helper.c | 4 +- drivers/gpu/drm/i915/intel_atomic_plane.c | 4 - drivers/gpu/drm/qxl/qxl_drv.c | 2 +- include/drm/drmP.h | 14 ++- 12 files changed, 132 insertions(+), 230 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

1 0

[Bug 67681] Asus G75VW F keys Not Working For WiFi & Brightness
by bugzilla-daemon＠bugzilla.kernel.org 06 May '15

06 May '15

https://bugzilla.kernel.org/show_bug.cgi?id=67681 --- Comment #40 from KernelBug <3fdd1e5d(a)opayq.com> --- I just noticed in the kernel under; Graphics support > Frame buffer Devices > CONFIG_FB_NVIDIA_BACKLIGHT: This is the description; Say Y here if you want to control the backlight of your display. If this is what I'm looking at and reading, for the backlight of the monitor to control the brightness, WHY is this under the Frame Buffer section, and not placed under, 'Backlight & LCD device support'? I'm really confused by this and just don't understand... Can someone PLEASE explain this? Because I have been waiting since Dec. 2013, hoping that the Kernel Dev team will add in more backlight support, only to find under the Framebuffer, which trying to make Nvidia Framebuffer work is a pain in the ass... -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[PATCH] drm/amdkfd: allow unregister process with queues
by Oded Gabbay 05 May '15

05 May '15

Sometimes we might unregister process that have queues, because we couldn't preempt the queues. Until now we blocked it with BUG_ON but instead just print it as debug. Reviewed-by: Ben Goz <ben.goz(a)amd.com> Signed-off-by: Oded Gabbay <oded.gabbay(a)gmail.com> --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c index 69af73f..7b1d510 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c @@ -430,9 +430,10 @@ static int unregister_process_nocpsch(struct device_queue_manager *dqm, BUG_ON(!dqm || !qpd); - BUG_ON(!list_empty(&qpd->queues_list)); + pr_debug("In func %s\n", __func__); - pr_debug("kfd: In func %s\n", __func__); + pr_debug("qpd->queues_list is %s\n", + list_empty(&qpd->queues_list) ? "empty" : "not empty"); retval = 0; mutex_lock(&dqm->lock); -- 1.9.1

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2015