dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[Bug 108561] New: nouveau: external monitor can not be enabled with hindsight
by bugzilla-daemon＠bugzilla.kernel.org 27 Jan '16

27 Jan '16

https://bugzilla.kernel.org/show_bug.cgi?id=108561 Bug ID: 108561 Summary: nouveau: external monitor can not be enabled with hindsight Product: Drivers Version: 2.5 Kernel Version: 4.2.5-1-ARCH #1 SMP PREEMPT Tue Oct 27 08:13:28 CET 2015 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: estellnb(a)elstel.org Regression: No Whenever I boot without an external monitor enabled then I get problems trying to enable my u2868pqu monitor with hindsight. Xorg will recognize and it will let me configure the external monitor. However the external monitor will stay black and without a signal in spite of being configured well. If I just reboot the X-server with the monitor cable unplugged then there will be no problem in enabling my u2868pqu monitor. Consequently I would assume this to be a kernel / nouveau module bug since it depends on boot time not on the time when I start the X-server. Is there any way to post the external monitor if I have booted without it? What would you believe is going wrong here with nouveau and the HDMI port? -- You are receiving this mail because: You are watching the assignee of the bug.

1 11

[PATCH libdrm] Synchronize drm/drm_fourcc.h with Linux’ version
by Emmanuel Gil Peyrot 27 Jan '16

27 Jan '16

This adds R8, RG88 and GR88, as well as the non-subsampled NV24/NV42 formats. Signed-off-by: Emmanuel Gil Peyrot <emmanuel.peyrot(a)collabora.com> --- include/drm/drm_fourcc.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index e741b09..59fc54d 100644 --- a/include/drm/drm_fourcc.h +++ b/include/drm/drm_fourcc.h @@ -34,6 +34,13 @@ /* color index */ #define DRM_FORMAT_C8 fourcc_code('C', '8', ' ', ' ') /* [7:0] C */ +/* 8 bpp Red */ +#define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ + +/* 16 bpp RG */ +#define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */ +#define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */ + /* 8 bpp RGB */ #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */ #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */ @@ -106,6 +113,8 @@ #define DRM_FORMAT_NV21 fourcc_code('N', 'V', '2', '1') /* 2x2 subsampled Cb:Cr plane */ #define DRM_FORMAT_NV16 fourcc_code('N', 'V', '1', '6') /* 2x1 subsampled Cr:Cb plane */ #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */ +#define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */ +#define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ /* * 3 plane YCbCr -- 2.7.0

4 7

Trying nouveau reclocking
by Boszormenyi Zoltan 27 Jan '16

27 Jan '16

Hi, I was trying to use re-clocking with nouveau in 4.5.0-rc1 with: # echo "0f" >/sys/kernel/debug/dri/0/pstate while Chromium with a WebGL app already running. (www.playmapscube.com) The video chip in question is: 03:00.0 VGA compatible controller: NVIDIA Corporation GT218 [ION] (rev a2) or in numbers: 03:00.0 0300: 10de:0a64 (rev a2) It is an integrated chip on the mainboard. The result was: [ 77.531009] ------------[ cut here ]------------ [ 77.531009] WARNING: CPU: 3 PID: 405 at drivers/gpu/drm/nouveau/nvkm/subdev/mc/base.c:51 nvkm_mc_intr+0x102/0x110 [nouveau]() [ 77.531009] Modules linked in: tun ums_realtek uas usb_storage joydev input_leds hid_generic usbhid hid cdc_acm snd_hda_codec_hdmi nouveau arc4 mxm_wmi wmi ath9k i2c_algo_bit iTCO_wdt drm_kms_helper iTCO_vendor_support gpio_ich ath9k_common snd_hda_codec_realtek ttm snd_hda_codec_generic ath9k_hw drm snd_hda_intel ath snd_hda_codec mac80211 snd_hwdep syscopyarea lpc_ich snd_hda_core sysfillrect mfd_core sysimgblt fb_sys_fops coretemp snd_pcm serio_raw i2c_i801 xhci_pci pcspkr xhci_hcd cfg80211 r8169 snd_timer i2c_core snd mii ehci_pci uhci_hcd rfkill ehci_hcd soundcore acpi_cpufreq xt_limit xt_multiport xt_recent ip6table_filter xt_conntrack ip6table_nat iptable_nat nf_conntrack_ipv6 nf_nat_ipv4 nf_defrag_ipv6 nf_conntrack_ipv4 nf_nat_ipv6 nf_defrag_ipv4 nf_nat xt_connmark nf_conntrack ip6_tables [ 77.531009] iptable_mangle [ 77.531009] CPU: 3 PID: 405 Comm: Xorg.bin Not tainted 4.5.0-rc1 #1 [ 77.531009] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./To Be Filled By O.E.M., BIOS 080016 05/05/2011 [ 77.531009] ffffffffa053b6f0 ffff88007fd83cd8 ffffffff80761604 0000000000000000 [ 77.531009] ffff88007fd83d10 ffffffff8048e7a2 ffff88007c0ef480 ffff880037838840 [ 77.531009] ffff88007a4b3800 0000000000000000 ffffffffa04fa9a0 ffff88007fd83d20 [ 77.531009] Call Trace: [ 77.531009] <IRQ> [<ffffffff80761604>] dump_stack+0x44/0x60 [ 77.531009] [<ffffffff8048e7a2>] warn_slowpath_common+0x82/0xc0 [ 77.531009] [<ffffffff8048e89a>] warn_slowpath_null+0x1a/0x20 [ 77.531009] [<ffffffffa046ee02>] nvkm_mc_intr+0x102/0x110 [nouveau] [ 77.531009] [<ffffffffa0473284>] nvkm_pci_intr+0x44/0x70 [nouveau] [ 77.531009] [<ffffffff804dbb35>] handle_irq_event_percpu+0x75/0x180 [ 77.531009] [<ffffffff804dbc7b>] handle_irq_event+0x3b/0x60 [ 77.531009] [<ffffffff804ded74>] handle_edge_irq+0x74/0x130 [ 77.531009] [<ffffffff80417dca>] handle_irq+0x1a/0x30 [ 77.531009] [<ffffffff804176eb>] do_IRQ+0x4b/0xd0 [ 77.531009] [<ffffffff80ac7d42>] common_interrupt+0x82/0x82 [ 77.531009] [<ffffffff80492cbb>] ? __do_softirq+0x7b/0x260 [ 77.531009] [<ffffffff80493031>] irq_exit+0xb1/0xc0 [ 77.531009] [<ffffffff8044e312>] smp_apic_timer_interrupt+0x42/0x50 [ 77.531009] [<ffffffff80ac7fe2>] apic_timer_interrupt+0x82/0x90 [ 77.531009] <EOI> [<ffffffffa04dad41>] ? nouveau_fence_emit+0xf1/0x1a0 [nouveau] [ 77.531009] [<ffffffffa04dad8f>] ? nouveau_fence_emit+0x13f/0x1a0 [nouveau] [ 77.531009] [<ffffffffa04db329>] nouveau_fence_new+0x59/0xa0 [nouveau] [ 77.531009] [<ffffffffa04c9aa5>] nouveau_gem_ioctl_pushbuf+0xeb5/0x1730 [nouveau] [ 77.531009] [<ffffffffa03226a2>] drm_ioctl+0x152/0x540 [drm] [ 77.531009] [<ffffffffa04c8bf0>] ? nouveau_gem_ioctl_new+0x1c0/0x1c0 [nouveau] [ 77.531009] [<ffffffff80420175>] ? fpu__activate_curr+0x15/0x20 [ 77.531009] [<ffffffffa04c1908>] nouveau_drm_ioctl+0x68/0xc0 [nouveau] [ 77.531009] [<ffffffff805f8562>] do_vfs_ioctl+0x92/0x580 [ 77.531009] [<ffffffff806eb883>] ? security_file_ioctl+0x43/0x60 [ 77.531009] [<ffffffff805f8ac9>] SyS_ioctl+0x79/0x90 [ 77.531009] [<ffffffff80ac7276>] entry_SYSCALL_64_fastpath+0x16/0x75 [ 77.531009] ---[ end trace 4a0b55289f0a358e ]--- [ 78.561529] nouveau 0000:03:00.0: timeout at drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c:332/gt215_clk_pre()! [ 90.693743] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 90.693743] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 90.693743] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 90.693743] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 90.693743] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 93.001694] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 93.001694] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 93.001694] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 93.001694] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 93.001694] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 95.137647] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 95.137647] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 95.137647] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 95.137647] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 95.137647] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 98.022424] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 98.022424] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 98.022424] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 98.022424] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 98.022424] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 99.702023] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 99.702023] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 99.702023] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 99.702023] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 99.702023] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 105.561027] nouveau 0000:03:00.0: chrome[1926]: failed to idle channel 6 [chrome[1926]] [ 107.562517] nouveau 0000:03:00.0: timeout at drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:111/g84_fifo_chan_engine_fini()! [ 107.562527] nouveau 0000:03:00.0: fifo: channel 6 [chrome[1926]] unload timeout [ 122.562029] nouveau 0000:03:00.0: chrome[1926]: failed to idle channel 6 [chrome[1926]] [ 145.491031] nouveau 0000:03:00.0: Xorg.bin[405]: failed to idle channel 5 [Xorg.bin[405]] [ 147.492503] nouveau 0000:03:00.0: timeout at drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:111/g84_fifo_chan_engine_fini()! [ 147.492514] nouveau 0000:03:00.0: fifo: channel 5 [Xorg.bin[405]] unload timeout [ 148.312163] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 148.312163] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 148.312163] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 148.312163] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 148.312163] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 164.494032] nouveau 0000:03:00.0: Xorg.bin[405]: failed to idle channel 5 [Xorg.bin[405]] [ 165.629394] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 165.629394] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 165.629394] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 165.629394] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 165.629394] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 168.408605] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 168.408605] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 168.408605] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 168.408605] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 168.408605] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 170.209599] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 170.209599] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 170.209599] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 170.209599] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 170.209599] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 172.189493] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 172.189493] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 172.189493] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 172.189493] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 172.189493] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 172.527022] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 172.527022] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 172.527022] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 172.527022] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 172.527022] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] [ 189.528029] nouveau 0000:03:00.0: Xorg.bin[405]: failed to idle channel 4 [Xorg.bin[405]] [ 191.529426] nouveau 0000:03:00.0: timeout at drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c:111/g84_fifo_chan_engine_fini()! [ 191.529436] nouveau 0000:03:00.0: fifo: channel 4 [Xorg.bin[405]] unload timeout [ 191.733932] nouveau 0000:03:00.0: gr: PGRAPH TLB flush idle timeout fail [ 191.733932] nouveau 0000:03:00.0: gr: PGRAPH_STATUS 01dffe03 [BUSY DISPATCH VFETCH CCACHE_PREGEOM STRMOUT_VATTR_POSTGEOM VCLIP RATTR_APLANE TRAST CLIPID ZCULL ENG2D RMASK TPC_RAST TPC_PROP ] [ 191.733932] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS0: 00145b49 [VFETCH CCACHE] [ 191.733932] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS1: 00001a2d [TPC_MP] [ 191.733932] nouveau 0000:03:00.0: gr: PGRAPH_VSTATUS2: 0034db43 [ENG2D ROP] I guess this is possibly a race condition. Best regards, Zoltán Böszörményi

2 2

Re: Problem with component helpers and probe deferral in 4.5-rc1
by Russell King - ARM Linux 27 Jan '16

27 Jan '16

On Tue, Jan 26, 2016 at 05:59:13PM +0000, Jon Medhurst (Tixy) wrote: > I believe I've found a problem with the component helpers and/or how > drivers use them. I discovered this whilst trying to get ARM's HDLCD > driver [1] working on 4.5-rc1, however I believe that code is following > a pattern used by drivers already in 4.5 and the problem isn't specific > to it. This is what I have observed... Hmm, it all looks plausible, and I'm again left wondering how the code passed testing over the last year (I've been running this code for ages both on iMX6 and Dove, where deferred probing does happen.) Your patch looks like the right thing to do, so I'll add it to the component tree shortly - it should end up in linux-next in a few days time. Thanks. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.

2 2

[Bug 108221] New: amdgpu: mouse cursor flickers + black boxes
by bugzilla-daemon＠bugzilla.kernel.org 27 Jan '16

27 Jan '16

https://bugzilla.kernel.org/show_bug.cgi?id=108221 Bug ID: 108221 Summary: amdgpu: mouse cursor flickers + black boxes Product: Drivers Version: 2.5 Kernel Version: 4.3.0-7 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: frederic.santos(a)u-bordeaux.fr Regression: No For kernel >= 4.3.0-3: Mouse cursor constantly flickers and disappears. A black box stays on screen when clicking on some elements of the GNOME desktop. More generally, there are problems with screen refresh. The problem is present only since an update to the kernel 4.3.0-3, the first versions of 4.3.x were OK for me. Recent updates of the kernel and amdgpu did not help. Details about hardware: #/sbin/lspci -nnv | grep 'VGA' -A2 Flags: bus master, VGA palette snoop, 66MHz, medium devsel, latency 64 Bus: primary=00, secondary=03, subordinate=03, sec-latency=64 -- 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Tonga PRO [Radeon R9 285/380] [1002:6939] (rev f1) (prog-if 00 [VGA controller]) Subsystem: XFX Pine Group Inc. Device [1682:9380] Flags: bus master, fast devsel, latency 0, IRQ 38 # glxinfo name of display: :0 display: :0 screen: 0 direct rendering: Yes [...] OpenGL vendor string: X.Org OpenGL renderer string: Gallium 0.4 on AMD TONGA (DRM 3.1.0, LLVM 3.7.0) OpenGL core profile version string: 4.1 (Core Profile) Mesa 11.0.2 OpenGL core profile shading language version string: 4.10 OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile -- You are receiving this mail because: You are watching the assignee of the bug.

1 15

[PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed
by Dan Williams 27 Jan '16

27 Jan '16

pfn_t_to_page() honors the flags in the pfn_t value to determine if a pfn is backed by a page. However, vm_insert_mixed() was originally written to use pfn_valid() to make this determination. To restore the old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() case and fallback to trusting pfn_valid(). Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t") Cc: Dave Hansen <dave(a)sr71.net> Cc: David Airlie <airlied(a)linux.ie> Reported-by: Julian Margetson <runaway(a)candw.ms> Reported-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Signed-off-by: Dan Williams <dan.j.williams(a)intel.com> --- mm/memory.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 30991f83d0bf..93ce37989471 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1591,10 +1591,15 @@ int vm_insert_mixed(struct vm_area_struct *vma, unsigned long addr, * than insert_pfn). If a zero_pfn were inserted into a VM_MIXEDMAP * without pte special, it would there be refcounted as a normal page. */ - if (!HAVE_PTE_SPECIAL && pfn_t_valid(pfn)) { + if (!HAVE_PTE_SPECIAL && !pfn_t_devmap(pfn) && pfn_t_valid(pfn)) { struct page *page; - page = pfn_t_to_page(pfn); + /* + * At this point we are committed to insert_page() + * regardless of whether the caller specified flags that + * result in pfn_t_has_page() == false. + */ + page = pfn_to_page(pfn_t_to_pfn(pfn)); return insert_page(vma, addr, page, vma->vm_page_prot); } return insert_pfn(vma, addr, pfn, vma->vm_page_prot);

3 4

[Bug 93764] [PATCH] Fix building on musl-libc
by bugzilla-daemon＠freedesktop.org 26 Jan '16

26 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=93764 Bug ID: 93764 Summary: [PATCH] Fix building on musl-libc Product: DRI Version: DRI git Hardware: All OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: libdrm Assignee: dri-devel(a)lists.freedesktop.org Reporter: somasis(a)exherbo.org Created attachment 121121 --> https://bugs.freedesktop.org/attachment.cgi?id=121121&action=edit 0001-Fix-building-on-musl-libc.patch libdrm git master fails to compile due to undefined functions/constants on musl libc. The attached patch fixes it. -- You are receiving this mail because: You are the assignee for the bug.

1 3

[PATCH] Fix building on musl-libc
by Kylie McClain 26 Jan '16

26 Jan '16

libdrm git master fails to compile due to undefined functions/constants on musl libc. The attached patches fix it. (I've attached them rather than included them in the message since gmail is really bad about ruining patch formatting.) I originally posted these to https://bugs.freedesktop.org/show_bug.cgi?id=93764 in a different form, and have modified them to Emil's comments on the bugzilla entry. commit 6ec5d220184e46135109923d252ae619068b7eb2 Author: Kylie McClain <somasis(a)exherbo.org> Date: Tue Jan 19 22:27:28 2016 -0500 tests: Include poll.h rather than sys/poll.h sys/poll.h is a non-standard location of the poll.h header, and is incorrect on non-glibc libcs. poll.h, however, is defined in SUS (v2) and is more portable. http://pubs.opengroup.org/onlinepubs/007908799/xsh/poll.h.html commit 6e7f12f1977bd13d10d99bc7826c54b692284c38 Author: Kylie McClain <somasis(a)exherbo.org> Date: Tue Jan 19 22:24:15 2016 -0500 kms-steal-crtc: Make use of sys/select.h if available On systems using musl libc, FD_ZERO, FD_SET, select, etc. are defined in sys/select.h. This behavior is defined in IEEE Std 1003.1, 2000, http://pubs.opengroup.org/onlinepubs/009696899/basedefs/sys/select.h.html and fixes building kms-steal-crtc on musl libc systems.

2 2

[PATCH V2] tests: Include sys/select.h
by Khem Raj 26 Jan '16

26 Jan '16

Used in compliance with POSIX 2001/2008 Fixes errors e.g. error: implicit declaration of function 'select' and helps with missing definitions of FD_* defines Signed-off-by: Khem Raj <raj.khem(a)gmail.com> Reviewed-by: Thierry Reding <thierry.reding(a)gmail.com> --- configure.ac | 2 +- tests/kms/kms-steal-crtc.c | 3 +++ tests/kms/kms-universal-planes.c | 3 +++ tests/modetest/modetest.c | 3 +++ tests/vbltest/vbltest.c | 3 +++ 5 files changed, 13 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 057a846..258e2f6 100644 --- a/configure.ac +++ b/configure.ac @@ -53,7 +53,7 @@ AC_USE_SYSTEM_EXTENSIONS AC_SYS_LARGEFILE AC_FUNC_ALLOCA -AC_CHECK_HEADERS([sys/mkdev.h sys/sysctl.h]) +AC_CHECK_HEADERS([sys/mkdev.h sys/sysctl.h sys/select.h]) # Initialize libtool LT_PREREQ([2.2]) diff --git a/tests/kms/kms-steal-crtc.c b/tests/kms/kms-steal-crtc.c index 2f7f327..497772e 100644 --- a/tests/kms/kms-steal-crtc.c +++ b/tests/kms/kms-steal-crtc.c @@ -31,6 +31,9 @@ #include <stdio.h> #include <string.h> #include <unistd.h> +#ifdef HAVE_SYS_SELECT_H +#include <sys/select.h> +#endif #include <drm_fourcc.h> diff --git a/tests/kms/kms-universal-planes.c b/tests/kms/kms-universal-planes.c index 9151231..d8e5fc4 100644 --- a/tests/kms/kms-universal-planes.c +++ b/tests/kms/kms-universal-planes.c @@ -32,6 +32,9 @@ #include <stdio.h> #include <string.h> #include <unistd.h> +#ifdef HAVE_SYS_SELECT_H +#include <sys/select.h> +#endif #include <drm_fourcc.h> #include "xf86drm.h" diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 22e3e81..d5a4062 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -55,6 +55,9 @@ #include <errno.h> #include <sys/poll.h> #include <sys/time.h> +#ifdef HAVE_SYS_SELECT_H +#include <sys/select.h> +#endif #include "xf86drm.h" #include "xf86drmMode.h" diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c index 1833321..086407e 100644 --- a/tests/vbltest/vbltest.c +++ b/tests/vbltest/vbltest.c @@ -37,6 +37,9 @@ #include <errno.h> #include <sys/poll.h> #include <sys/time.h> +#ifdef HAVE_SYS_SELECT_H +#include <sys/select.h> +#endif #include "xf86drm.h" #include "xf86drmMode.h" -- 2.7.0

2 1

[PATCH libdrm] tests: util: Fixup util_open() parameter order
by Thierry Reding 26 Jan '16

26 Jan '16

From: Thierry Reding <treding(a)nvidia.com> util_open() takes a device parameter, followed by a module parameter. The existing tests used the drmOpen() function, which uses a different ordering of the parameters, and the old ordering was accidentally kept during the conversion. Signed-off-by: Thierry Reding <treding(a)nvidia.com> --- Evidently I didn't properly test this. Things do work in most cases with the current code because of the auto-detection, but there will be cases where it fails. tests/modetest/modetest.c | 2 +- tests/proptest/proptest.c | 2 +- tests/vbltest/vbltest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 22e3e81bd3cc..f665240a53c5 100644 --- a/tests/modetest/modetest.c +++ b/tests/modetest/modetest.c @@ -1603,7 +1603,7 @@ int main(int argc, char **argv) if (!args) encoders = connectors = crtcs = planes = framebuffers = 1; - dev.fd = util_open(module, device); + dev.fd = util_open(device, module); if (dev.fd < 0) return -1; diff --git a/tests/proptest/proptest.c b/tests/proptest/proptest.c index 24c634569f2f..4bd08665461c 100644 --- a/tests/proptest/proptest.c +++ b/tests/proptest/proptest.c @@ -295,7 +295,7 @@ int main(int argc, char *argv[]) args = argc - optind; - fd = util_open(module, device); + fd = util_open(device, module); if (fd < 0) return 1; diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c index 183332122978..4475b49b7b9a 100644 --- a/tests/vbltest/vbltest.c +++ b/tests/vbltest/vbltest.c @@ -120,7 +120,7 @@ int main(int argc, char **argv) } } - fd = util_open(module, device); + fd = util_open(device, module); if (fd < 0) return 1; -- 2.5.0

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016