dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[PATCH] GPU-host1x: Use a signed return type for do_relocs()
by SF Markus Elfring 25 Jan '16

25 Jan '16

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 19 Dec 2015 12:48:31 +0100 The return type "unsigned int" was used by the do_relocs() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the type qualifier then. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/host1x/job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 63bd63f..1919aab 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -225,7 +225,7 @@ unpin: return 0; } -static unsigned int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) +static int do_relocs(struct host1x_job *job, struct host1x_bo *cmdbuf) { int i = 0; u32 last_page = ~0; -- 2.6.3

2 1

[PATCH] gpu: host1x: bus: Add missing of_node_put
by Amitoj Kaur Chawla 25 Jan '16

25 Jan '16

for_each_child_of_node performs an of_node_get on each iteration, so to break out of the loop an of_node_put is required. Found using Coccinelle. The semantic patch used for this is as follows: // <smpl> @@ expression e; local idexpression n; @@ for_each_child_of_node(..., n) { ... when != of_node_put(n) when != e = n ( return n; | + of_node_put(n); ? return ...; ) ... } // </smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606(a)gmail.com> --- drivers/gpu/host1x/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index 4a99c64..c1795a2 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -82,8 +82,10 @@ static int host1x_device_parse_dt(struct host1x_device *device, if (of_match_node(driver->subdevs, np) && of_device_is_available(np)) { err = host1x_subdev_add(device, np); - if (err < 0) + if (err < 0) { + of_node_put(np); return err; + } } } -- 1.9.1

2 1

[PATCH] drm/etnaviv: fix memory leak in IOMMU init path
by Lucas Stach 25 Jan '16

25 Jan '16

Plug in error handling to free any allocated ressources in the IOMMU init path. Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index 92e80c0c5b55..d212319a173d 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -588,12 +588,10 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) goto fail; } - /* TODO: we will leak here memory - fix it! */ - gpu->mmu = etnaviv_iommu_new(gpu, iommu, version); if (!gpu->mmu) { ret = -ENOMEM; - goto fail; + goto free_domain; } /* Create buffer: */ @@ -601,7 +599,7 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) if (!gpu->buffer) { ret = -ENOMEM; dev_err(gpu->dev, "could not create command buffer\n"); - goto fail; + goto destroy_iommu; } if (gpu->buffer->paddr - gpu->memory_base > 0x80000000) { ret = -EINVAL; @@ -631,6 +629,11 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) free_buffer: etnaviv_gpu_cmdbuf_free(gpu->buffer); gpu->buffer = NULL; +destroy_iommu: + etnaviv_iommu_destroy(gpu->mmu); + gpu->mmu = NULL; +free_domain: + iommu_domain_free(iommu); fail: pm_runtime_mark_last_busy(gpu->dev); pm_runtime_put_autosuspend(gpu->dev); -- 2.7.0.rc3

1 0

[PATCH 0/2] drm/rockchip: cleanup unnecessary modules and symbol
by Mark Yao 25 Jan '16

25 Jan '16

Since a67719d (drm/rockchip: vop: spilt register related into rockchip_reg_vop.c), rockchip_drm_vop's module_init moved to rockchip_vop_reg.c, then no need to build rockchip_drm_vop.ko After build rockchip_drm_vop.c into rockchipdrm.ko, following export symbol is also no needed: rockchip_drm_dma_attach_device rockchip_drm_dma_detach_device rockchip_drm_dma_attach_device rockchip_drm_dma_detach_device rockchip_register_crtc_funcs rockchip_unregister_crtc_funcs rockchip_fb_get_gem_obj Mark Yao (2): drm/rockchip: Don't build rockchip_drm_vop as modules drm/rockchip: cleanup unnecessary export symbol drivers/gpu/drm/rockchip/Makefile | 5 ++--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ---- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) -- 1.7.9.5

3 4

[PATCH 0/5] Etnaviv updates
by Russell King - ARM Linux 25 Jan '16

25 Jan '16

Here's some updates to etnaviv, which augment the features and GPU specifications which we export to userspace. This will allow us to fix the (currently incorrect) number of varyings that GPUs such as GC880 and GC2000 supposedly have. While making this change, I'm also increasing the number of feature words we export up to the largest number known from the current Vivante galcore code. drivers/gpu/drm/etnaviv/common.xml.h | 59 ++++++++++-- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 161 ++++++++++++++++++++++----------- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 9 ++ drivers/gpu/drm/etnaviv/state_hi.xml.h | 26 +++++- include/uapi/drm/etnaviv_drm.h | 3 + 5 files changed, 196 insertions(+), 62 deletions(-) -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.

3 7

[PATCH] drm/i915: refine qemu south bridge detection
by Gerd Hoffmann 25 Jan '16

25 Jan '16

The test for the qemu q35 south bridge added by commit "39bfcd52 drm/i915: more virtual south bridge detection" also matches on real hardware. Having the check for virtual systems last in the list is not enough to avoid that ... Refine the check by additionally verifying the pci subsystem id to see whenever it *really* is qemu. Reported-by: Bjørn Mork <bjorn(a)mork.no> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- drivers/gpu/drm/i915/i915_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 3ac616d..9668162 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -501,7 +501,9 @@ void intel_detect_pch(struct drm_device *dev) WARN_ON(!IS_SKYLAKE(dev) && !IS_KABYLAKE(dev)); } else if ((id == INTEL_PCH_P2X_DEVICE_ID_TYPE) || - (id == INTEL_PCH_QEMU_DEVICE_ID_TYPE)) { + ((id == INTEL_PCH_QEMU_DEVICE_ID_TYPE) && + pch->subsystem_vendor == 0x1a4f && + pch->subsystem_device == 0x1100)) { dev_priv->pch_type = intel_virt_detect_pch(dev); } else continue; -- 1.8.3.1

3 3

[PATCH 1/5] drm/imx: ipuv3 plane: Introduce ipu_plane_cleanup()
by Liu Ying 25 Jan '16

25 Jan '16

This patch adds a helper ipu_plane_cleanup() to cleanup a IPU plane. It can be used in the bailout path of ipu_crtc_init(), for instance. Signed-off-by: Liu Ying <Ying.Liu(a)freescale.com> --- This patch applies to the imx-drm/fixes branch of Philipp Zabel's open git. drivers/gpu/drm/imx/ipuv3-plane.c | 6 ++++++ drivers/gpu/drm/imx/ipuv3-plane.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index e2ff410..e60b382 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -410,3 +410,9 @@ struct ipu_plane *ipu_plane_init(struct drm_device *dev, struct ipu_soc *ipu, return ipu_plane; } + +void ipu_plane_cleanup(struct ipu_plane *ipu_plane) +{ + drm_plane_cleanup(&ipu_plane->base); + kfree(ipu_plane); +} diff --git a/drivers/gpu/drm/imx/ipuv3-plane.h b/drivers/gpu/drm/imx/ipuv3-plane.h index 3a443b4..dd2239c 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.h +++ b/drivers/gpu/drm/imx/ipuv3-plane.h @@ -36,6 +36,8 @@ struct ipu_plane *ipu_plane_init(struct drm_device *dev, struct ipu_soc *ipu, int dma, int dp, unsigned int possible_crtcs, enum drm_plane_type type); +void ipu_plane_cleanup(struct ipu_plane *ipu_plane); + /* Init IDMAC, DMFC, DP */ int ipu_plane_mode_set(struct ipu_plane *plane, struct drm_crtc *crtc, struct drm_display_mode *mode, -- 2.5.0

3 14

[RFC libdrm] intel: Softpin support
by Michał Winiarski 25 Jan '16

25 Jan '16

The goal of this series is to start a discussion whether the interface and implementation of softpin support proposed for libdrm is acceptable by all interested parties. The i915 patches are added so that it's easy to apply the series on latest drm-intel-nightly and libdrm master and start using softpin. Michał Winiarski (1): drm/i915/gtt: Allow adventurous users to select enable_ppgtt=3 is not strictly necessary for softpin itself, but it is needed for SVM usecase. Chris Wilson (1): drm/i915: Add soft-pinning API for execbuffer is just v5 from Thomas Daniel rebased on top of current nightly.

9 18

Re: Build regressions/improvements in v4.5-rc1
by Geert Uytterhoeven 25 Jan '16

25 Jan '16

On Mon, Jan 25, 2016 at 9:18 AM, Geert Uytterhoeven <geert(a)linux-m68k.org> wrote: > Below is the list of build error/warning regressions/improvements in > v4.5-rc1[1] compared to v4.4[2]. > > Summarized: > - build errors: +15/-23 > [1] http://kisskb.ellerman.id.au/kisskb/head/9841/ (all 261 configs) > [2] http://kisskb.ellerman.id.au/kisskb/head/9774/ (259 out of 261 configs) > > > *** ERRORS *** > > 15 error regressions: > + /home/kisskb/slave/src/arch/sh/drivers/dma/dma-sh.c: error: 'DMTE6_IRQ' undeclared (first use in this function): => 58:21 sh-randconfig > + /home/kisskb/slave/src/drivers/gpu/drm/vc4/vc4_v3d.c: error: called object '0u' is not a function: => 157:29, 159:27 cris-allmodconfig cris-allyesconfig m32r/m32700ut.smp_defconfig m68k-allmodconfig parisc-allmodconfig sh-randconfig xtensa-allmodconfig > + /home/kisskb/slave/src/sound/core/compress_offload.c: error: case label does not reduce to an integer constant: => 804:2 ppc64le/allmodconfig+ppc64le > + /tmp/ccDC0dZh.s: Error: can't resolve `_start' {*UND* section} - `L0 ' {.text section}: => 378, 49 > + /tmp/ccGniXga.s: Error: can't resolve `_start' {*UND* section} - `L0 ' {.text section}: => 43 > + /tmp/ccci5ABy.s: Error: can't resolve `_start' {*UND* section} - `L0 ' {.text section}: => 366, 49 > + /tmp/cccq2wZf.s: Error: can't resolve `_start' {*UND* section} - `L0 ' {.text section}: => 43 > + /tmp/cchnfEGb.s: Error: can't resolve `_start' {*UND* section} - `L0 ' {.text section}: => 43 (reported before) mips-allnoconfig mips-defconfig ip27_defconfig > + error: No rule to make target include/config/auto.conf: => N/A arm-randconfig (reported before) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

1 0

[PATCH 00/13] drm/msm/hdmi: HDMI support on MSM8996
by Archit Taneja 25 Jan '16

25 Jan '16

HDMI on MSM8996 has a tx block that is compatible with the older versions apart from some minor changes. The HDMI PHY and PLL on msm8996 are new. The series refactors the code such that there is a separate hdmi phy driver, similar to what we already have for dsi. This makes it easier to integrate new PHYs like the one in msm8996. Archit Taneja (13): drm/msm/dsi: Create separate Makefile/Kconfig drm/msm/hdmi: Create separate Makefile/Kconfig drm/msm/edp: Create separate Makefile/Kconfig drm/msm/hdmi: Clean up connector gpio usage drm/msm/hdmi: Fix connector detect when there is no hpd gpio drm/msm/hdmi: Update generated headers to split PHY/PLL offsets drm/msm/hdmi: Create a separate hdmi phy driver drm/msm/hdmi: Make hdmi core get its phy drm/msm/hdmi: Manage hdmi PLL through phy driver drm/msm/hdmi: Convert phy files according to new design drm/msm/hdmi: Update generated headers for hdmi 8996 phy drm/msm/hdmi: HDMI 8996 PHY/PLL support dt/bindings: drm/msm/hdmi: Add hdmi phy bindings .../devicetree/bindings/display/msm/hdmi.txt | 39 +- drivers/gpu/drm/msm/Kconfig | 42 +- drivers/gpu/drm/msm/Makefile | 39 +- drivers/gpu/drm/msm/dsi/Kconfig | 40 ++ drivers/gpu/drm/msm/dsi/Makefile | 13 + drivers/gpu/drm/msm/edp/Kconfig | 7 + drivers/gpu/drm/msm/edp/Makefile | 3 + drivers/gpu/drm/msm/hdmi/Kconfig | 7 + drivers/gpu/drm/msm/hdmi/Makefile | 6 + drivers/gpu/drm/msm/hdmi/hdmi.c | 98 ++- drivers/gpu/drm/msm/hdmi/hdmi.h | 78 ++- drivers/gpu/drm/msm/hdmi/hdmi.xml.h | 657 +++++++++++++++--- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 8 +- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 139 ++-- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 228 ++++++ drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 503 +------------- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 767 +++++++++++++++++++++ drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 196 ++---- drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c | 94 +-- drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 462 +++++++++++++ drivers/gpu/drm/msm/msm_drv.h | 31 + 21 files changed, 2495 insertions(+), 962 deletions(-) create mode 100644 drivers/gpu/drm/msm/dsi/Kconfig create mode 100644 drivers/gpu/drm/msm/dsi/Makefile create mode 100644 drivers/gpu/drm/msm/edp/Kconfig create mode 100644 drivers/gpu/drm/msm/edp/Makefile create mode 100644 drivers/gpu/drm/msm/hdmi/Kconfig create mode 100644 drivers/gpu/drm/msm/hdmi/Makefile create mode 100644 drivers/gpu/drm/msm/hdmi/hdmi_phy.c create mode 100644 drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c create mode 100644 drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation

2 15

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016