dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[PATCH] drm/fbdev-helper: Explain how to debug console_lock fun
by Daniel Vetter 25 Jan '16

25 Jan '16

Every new KMS driver writer seems to run into this and wonder how exactly drm_fb_helper_initial_config can die doing nothing at all. Set up some big warnings signs around this newbie trap to avoid future frustration and wasting everyone's time. Cc: Carlos Palminha <CARLOS.PALMINHA(a)synopsys.com> Cc: Xinliang Liu <xinliang.liu(a)linaro.org> Cc: laurent.pinchart(a)ideasonboard.com Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_fb_helper.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 1e103c4c6ee0..9bf84b227613 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -2091,6 +2091,28 @@ out: * drm_fb_helper_fill_fix() are provided as helpers to setup simple default * values for the fbdev info structure. * + * HANG DEBUGGING: + * + * When you have fbcon support built-in or already loaded, this function will do + * a full modeset to setup the fbdev console. And due to locking misdesign in + * the VT/fbdev subsystem that entire modeset sequence has to be done while + * holding console_lock. And until console_unlock is called no dmesg lines will + * be sent out to consoles, not even serial console. Which means when your + * driver crashes, you will see absolutely nothing else but a system stuck in + * this function, with no further output. And any kind of printk() you place + * within your own driver or in the drm core modeset code will also never show + * up. + * + * Standard debug practice is to run the fbcon setup without taking the + * console_lock as a hack, to be able to see backtraces and crashes on the + * serial line. This can be done by setting the fb.lockless_register_fb=1 kernel + * cmdline option. + * + * The other option is to just disable fbdev emulation since very likely the + * first modest from userspace will crash in the same way, and is even easier to + * debug. This can be done by setting the drm_kms_helper.fbdev_emulation=0 + * kernel cmdline option. + * * RETURNS: * Zero if everything went ok, nonzero otherwise. */ -- 2.7.0.rc3

4 4

[Bug 105041] System constantly freezes up when waking from suspend2ram
by bugzilla-daemon＠bugzilla.kernel.org 25 Jan '16

25 Jan '16

https://bugzilla.kernel.org/show_bug.cgi?id=105041 Aaron Lu <aaron.lu(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Component|Hibernation/Suspend |Video(DRI - non Intel) Assignee|rjw(a)rjwysocki.net |drivers_video-dri@kernel-bu | |gs.osdl.org Product|Power Management |Drivers --- Comment #13 from Aaron Lu <aaron.lu(a)intel.com> --- Then I'm moving this bug to Drivers/DRM-non-intel for nouveau people to take a look. -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[PATCH v3 0/2] Introduce Innosilicon HDMI driver on Rockchip platforms
by Yakir Yang 25 Jan '16

25 Jan '16

Here are a brief introduction to Innosilicon HDMI IP: - Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter - Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec - Digital video interface supports a pixel size of 24, 30, 36, 48bits color depth in RGB - S/PDIF output supports PCM, Dolby Digital, DTS digital audio transmission (32-192kHz Fs) using IEC60958 and IEC 61937 - The EDID and CEC function are also supported by Innosilicon HDMI Transmitter Controlle This series is based on Mark's RK3036 VOP series, I have created an test branch that collected his changes: [https://github.com/rockchip-linux/kernel/tree/kylin-develop4.4-test] Best regards, - Yakir Changes in v3: - Use encoder enable/disable function, and remove the encoder DPMS function - Keep HDMI PLL power on in standby mode Changes in v2: - Using DRM atomic helper functions for connector init (Mark) - Remove "hdmi->connector.encoder = encoder;" (Mark) - Correct the misspell "rk3036-dw-hdmi" (Heiko) Yakir Yang (2): FORMLIST: drm: rockchip/hdmi: add Innosilicon HDMI support dt-bindings: add document for Innosilicon HDMI on Rockchip platform .../display/rockchip/inno_hdmi-rockchip.txt | 50 ++ drivers/gpu/drm/rockchip/Kconfig | 8 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/inno_hdmi.c | 999 +++++++++++++++++++++ drivers/gpu/drm/rockchip/inno_hdmi.h | 364 ++++++++ 5 files changed, 1422 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/rockchip/inno_hdmi-rockchip.txt create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.c create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h -- 1.9.1

3 6

[PATCH] drm/etnaviv: move runtime PM balance into retire worker
by Lucas Stach 24 Jan '16

24 Jan '16

The retire worker is kicked for each fence, either the normal way by signaling the fence from the event completion interrupt or by the recover worker if the GPU got stuck. Moving the RPM put into the retire worker allows us to have it in a single place for both cases. This also shaves off quite a bit of the CPU time spent in hardirq context, as arming the autosuspend timer when the RPM refcount drops to 0 is a relatively costly operation. Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index 056a72e6ed26..ca949ae19933 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -806,11 +806,6 @@ static void recover_worker(struct work_struct *work) gpu->event[i].fence = NULL; gpu->event[i].used = false; complete(&gpu->event_free); - /* - * Decrement the PM count for each stuck event. This is safe - * even in atomic context as we use ASYNC RPM here. - */ - pm_runtime_put_autosuspend(gpu->dev); } spin_unlock_irqrestore(&gpu->event_spinlock, flags); gpu->completed_fence = gpu->active_fence; @@ -1093,6 +1088,14 @@ static void retire_worker(struct work_struct *work) } etnaviv_gpu_cmdbuf_free(cmdbuf); + /* + * We need to balance the runtime PM count caused by + * each submission. Upon submission, we increment + * the runtime PM counter, and allocate one event. + * So here, we put the runtime PM count for each + * completed event. + */ + pm_runtime_put_autosuspend(gpu->dev); } gpu->retired_fence = fence; @@ -1313,15 +1316,6 @@ static irqreturn_t irq_handler(int irq, void *data) gpu->completed_fence = fence->seqno; event_free(gpu, event); - - /* - * We need to balance the runtime PM count caused by - * each submission. Upon submission, we increment - * the runtime PM counter, and allocate one event. - * So here, we put the runtime PM count for each - * completed event. - */ - pm_runtime_put_autosuspend(gpu->dev); } /* Retire the buffer objects in a work */ -- 2.7.0.rc3

2 1

[PATCH] drm: etnaviv: fix failure path if model is zero
by Russell King 24 Jan '16

24 Jan '16

Fix the failure path to call pm_runtime_mark_last_busy() when failing due to the model field being zero. Acked-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> Signed-off-by: Russell King <rmk+kernel(a)arm.linux.org.uk> --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index d39093dc37e6..e758e897e15e 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -508,8 +508,8 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) if (gpu->identity.model == 0) { dev_err(gpu->dev, "Unknown GPU model\n"); - pm_runtime_put_autosuspend(gpu->dev); - return -ENXIO; + ret = -ENXIO; + goto fail; } ret = etnaviv_hw_reset(gpu); -- 2.1.0

1 0

[pull] radeon and amdgpu drm-fixes-4.5
by Alex Deucher 22 Jan '16

22 Jan '16

Hi Dave, A few misc radeon and amdgpu fixes for 4.5. Nothing too major. The following changes since commit e9c5e7402dad6f4f04c2430db6f283512bcd4392: drm/amdgpu: add missing irq.h include (2016-01-14 08:07:55 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-4.5 for you to fetch changes up to 41f2d9905646b1cd4be5852b273c06b6a6d23a80: drm/amdgpu: fix next_rptr handling for debugfs (2016-01-22 14:44:08 -0500) ---------------------------------------------------------------- Alex Deucher (4): drm/amdgpu: fix tonga smu resume drm/amdgpu: Add some tweaks to gfx 8 soft reset drm/amdgpu: add a message to indicate when powerplay is enabled (v2) drm/radeon: properly byte swap vce firmware setup Christian König (2): drm/amdgpu: fix amdgpu_bo_pin_restricted VRAM placing v2 drm/amdgpu: fix next_rptr handling for debugfs Eric Huang (1): drm/amd/amdgpu: Improve amdgpu_dpm* macros to avoid unexpected result (v2) Jordan Lazare (1): drm/amdgpu: Allow the driver to load if amdgpu.powerplay=1 on asics without powerplay support Michel Dänzer (1): drm/amdgpu: Use drm_calloc_large for VM page_tables array drivers/gpu/drm/amd/amdgpu/amdgpu.h | 44 +++++++++++++-------------- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c | 25 ++++++++++----- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 23 +++++++++++++- drivers/gpu/drm/amd/amdgpu/tonga_dpm.c | 17 ++--------- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 5 +++ drivers/gpu/drm/radeon/vce_v1_0.c | 12 ++++---- 9 files changed, 81 insertions(+), 57 deletions(-)

1 0

[PATCH] configure.ac: disable annoying warning -Wmissing-field-initializers
by Marek Olšák 22 Jan '16

22 Jan '16

From: Marek Olšák <marek.olsak(a)amd.com> It warns for all "{}" initializers. Well, I want us to use {}. --- configure.ac | 3 ++- intel/intel_decode.c | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index c8c4ace..057a846 100644 --- a/configure.ac +++ b/configure.ac @@ -174,7 +174,8 @@ MAYBE_WARN="-Wall -Wextra \ -Wstrict-aliasing=2 -Winit-self \ -Wdeclaration-after-statement -Wold-style-definition \ -Wno-unused-parameter \ --Wno-attributes -Wno-long-long -Winline -Wshadow" +-Wno-attributes -Wno-long-long -Winline -Wshadow \ +-Wno-missing-field-initializers" # invalidate cached value if MAYBE_WARN has changed if test "x$libdrm_cv_warn_maybe" != "x$MAYBE_WARN"; then diff --git a/intel/intel_decode.c b/intel/intel_decode.c index e7aef74..287c342 100644 --- a/intel/intel_decode.c +++ b/intel/intel_decode.c @@ -38,8 +38,6 @@ #include "intel_chipset.h" #include "intel_bufmgr.h" -/* The compiler throws ~90 warnings. Do not spam the build, until we fix them. */ -#pragma GCC diagnostic ignored "-Wmissing-field-initializers" /* Struct for tracking drm_intel_decode state. */ struct drm_intel_decode { -- 2.1.4

8 26

[PATCH] drm/vc4: Remove broken attempt at GPU reset using genpd.
by Eric Anholt 22 Jan '16

22 Jan '16

I've tested and confirmed that it doesn't actually work. We'll need to sort out how to do this properly later, but for now just remove it since it also caused build breakage due to using CONFIG_PM_SLEEP functions without our Kconfig depending on PM_SLEEP. Signed-off-by: Eric Anholt <eric(a)anholt.net> --- drivers/gpu/drm/vc4/vc4_v3d.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 424d515..314ff71 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -144,19 +144,16 @@ int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused) } #endif /* CONFIG_DEBUG_FS */ -/* - * Asks the firmware to turn on power to the V3D engine. - * - * This may be doable with just the clocks interface, though this - * packet does some other register setup from the firmware, too. - */ int vc4_v3d_set_power(struct vc4_dev *vc4, bool on) { - if (on) - return pm_generic_poweroff(&vc4->v3d->pdev->dev); - else - return pm_generic_resume(&vc4->v3d->pdev->dev); + /* XXX: This interface is needed for GPU reset, and the way to + * do it is to turn our power domain off and back on. We + * can't just reset from within the driver, because the reset + * bits are in the power domain's register area, and get set + * during the poweron process. + */ + return 0; } static void vc4_v3d_init_hw(struct drm_device *dev) -- 2.6.2

3 5

[PATCH libdrm] xf86drm: Bound strstr() to the allocated data
by Damien Lespiau 22 Jan '16

22 Jan '16

We are reading at most sizeof(data) bytes, but then data may not contain a terminating '\0', at least in theory, so strstr() may overflow the stack allocated array. Make sure that data always contains at least one '\0'. Signed-off-by: Damien Lespiau <damien.lespiau(a)intel.com> --- xf86drm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xf86drm.c b/xf86drm.c index 7e28b4f..5f587d9 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -2863,7 +2863,7 @@ static int drmParsePciBusInfo(int maj, int min, drmPciBusInfoPtr info) { #ifdef __linux__ char path[PATH_MAX + 1]; - char data[128]; + char data[128 + 1]; char *str; int domain, bus, dev, func; int fd, ret; @@ -2874,6 +2874,7 @@ static int drmParsePciBusInfo(int maj, int min, drmPciBusInfoPtr info) return -errno; ret = read(fd, data, sizeof(data)); + data[128] = '\0'; close(fd); if (ret < 0) return -errno; -- 2.4.3

2 2

[PATCH] drm/etnaviv: hold object lock while getting pages for coredump
by Lucas Stach 22 Jan '16

22 Jan '16

While all objects that get coredumped have an active IOVA and thus pages already populated, etnaviv_gem_get_pages() still requires the object lock to be held. Signed-off-by: Lucas Stach <l.stach(a)pengutronix.de> --- drivers/gpu/drm/etnaviv/etnaviv_dump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c index bf8fa859e8be..fd7d3e989e79 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c @@ -201,7 +201,9 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) obj = vram->object; + mutex_lock(&obj->lock); pages = etnaviv_gem_get_pages(obj); + mutex_unlock(&obj->lock); if (pages) { int j; -- 2.7.0.rc3

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016