dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[PATCH] drm/rockchip: fix wrong pitch/size using on gem
by Mark Yao 21 Jan '16

21 Jan '16

args->pitch and args->size may not be set by userspace, sometimes userspace only malloc args and not memset args to zero, then args->pitch and args->size is random, it is very danger to use pitch/size on gem. pitch's type is u32, and min_pitch's type is int, example, pitch is 0xffffffff, then pitch < min_pitch return true, then gem will alloc very very big bufffer, it would eat all the memory and cause kernel crash. Stop using pitch/size from args, calc them from other args. … [View More]

1 0

[RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed
by John Keeping 21 Jan '16

21 Jan '16

As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies on cursor ioctls being unsynced. Converting the rockchip driver to atomic has significantly impacted cursor performance by making every cursor update wait for vblank. By skipping the vblank sync when the framebuffer has not changed (as is done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the common case of moving the cursor and only need to delay the cursor ioctl when the cursor icon changes. I … [View More]originally inserted a check on legacy_cursor_update as well, but that caused a storm of iommu page faults. I didn't investigate the cause of those since this change gives enough of a performance improvement for my use case. This is RFC because of that and because the framebuffer_changed() function is copied from drm_atomic_helper.c as a quick way to test the result. Signed-off-by: John Keeping <john(a)metanate.com> --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c index f784488..8fd9821 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c @@ -177,8 +177,28 @@ static void rockchip_crtc_wait_for_update(struct drm_crtc *crtc) crtc_funcs->wait_for_update(crtc); } +static bool framebuffer_changed(struct drm_device *dev, + struct drm_atomic_state *old_state, + struct drm_crtc *crtc) +{ + struct drm_plane *plane; + struct drm_plane_state *old_plane_state; + int i; + + for_each_plane_in_state(old_state, plane, old_plane_state, i) { + if (plane->state->crtc != crtc && + old_plane_state->crtc != crtc) + continue; + + if (plane->state->fb != old_plane_state->fb) + return true; + } + + return false; +} + static void -rockchip_atomic_wait_for_complete(struct drm_atomic_state *old_state) +rockchip_atomic_wait_for_complete(struct drm_device *dev, struct drm_atomic_state *old_state) { struct drm_crtc_state *old_crtc_state; struct drm_crtc *crtc; @@ -194,6 +214,9 @@ rockchip_atomic_wait_for_complete(struct drm_atomic_state *old_state) if (!crtc->state->active) continue; + if (!framebuffer_changed(dev, old_state, crtc)) + continue; + ret = drm_crtc_vblank_get(crtc); if (ret != 0) continue; @@ -241,7 +264,7 @@ rockchip_atomic_commit_complete(struct rockchip_atomic_commit *commit) drm_atomic_helper_commit_planes(dev, state, true); - rockchip_atomic_wait_for_complete(state); + rockchip_atomic_wait_for_complete(dev, state); drm_atomic_helper_cleanup_planes(dev, state); -- 2.7.0.rc3.140.g520a093 [View Less]

5 27

[patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
by Dan Carpenter 20 Jan '16

20 Jan '16

"bpp" needs to be signed for the error handling to work. Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI') Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) static int … [View More]

2 1

[Bug 88861] [efi, i915, vgaswitcheroo, black screen, nouveau] Screen goes black when switching from dedicated nvidia graphics card (nouveau) to integrated
by bugzilla-daemon＠bugzilla.kernel.org 20 Jan '16

20 Jan '16

https://bugzilla.kernel.org/show_bug.cgi?id=88861 --- Comment #10 from Paul Hordiienko <pvt.gord(a)gmail.com> --- Hi Lukas and Jani, I have tested v5 and confirm that it works on my MBP 6,2 2010 without any issues. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[patch] drm/amd/powerplay: indent a couple if statements
by Dan Carpenter 20 Jan '16

20 Jan '16

We recently redid the indenting, but missed these two if statements. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h b/drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h index b7429a5..b10df32 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h @@ -293,7 +293,7 @@ fInt GetScaledFraction(int X, int factor) } if (factor == 1) - return (ConvertToFraction(… [View More]

2 1

[Bug 72877] Wrong colors with Mesa 9.2, 10.0, and 11.0.2 on PPC Linux systems
by bugzilla-daemon＠freedesktop.org 20 Jan '16

20 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=72877 Alex Perez <aperez(a)alexperez.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong colors with Mesa 9.2 |Wrong colors with Mesa 9.2, |and Mesa 10.0 on PPC Linux |10.0, and 11.0.2 on PPC |systems |Linux systems -- You are receiving this mail because: You are … [View More]

1 0

[Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems
by bugzilla-daemon＠freedesktop.org 20 Jan '16

20 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #20 from Alex Perez <aperez(a)alexperez.com> --- Last night, I confirmed that the colors are *correct* with r300g on Big Endian (tested with an RV515), but still incorrect with r600g, as of Mesa 11.0.2. Therefore, I have changed the component for this bug from mesa core to r600. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems
by bugzilla-daemon＠freedesktop.org 20 Jan '16

20 Jan '16

1 0

[PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
by Colin King 20 Jan '16

20 Jan '16

From: Colin Ian King <colin.king(a)canonical.com> Duplicated const, only one is required. Also reformat line to ensure it is less than 80 columns wide. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index c895b6f..bb88e3d 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/… [View More]

3 2

[PATCH] drm: exynos: make PM functions as __maybe_unused
by Arnd Bergmann 20 Jan '16

20 Jan '16

The newly added runtime-pm support for exynos-drm encloses the pm functions in an #ifdef, but not the functions that are called from them and nowhere else, which produces warnings: drm/exynos/exynos_drm_dsi.c:733:13: warning: 'exynos_dsi_disable_clock' defined but not used [-Wunused-function] static void exynos_dsi_disable_clock(struct exynos_dsi *dsi) ^ drm/exynos/exynos_drm_dsi.c:1291:13: warning: 'exynos_dsi_disable_irq' defined but not used [-Wunused-function] static void … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016